Changeset 96276 in webkit


Ignore:
Timestamp:
Sep 28, 2011 5:29:11 PM (13 years ago)
Author:
commit-queue@webkit.org
Message:

Don't clamp cubic-bezier timing functions between 0 and 1
​https://bugs.webkit.org/show_bug.cgi?id=45761

Source/WebCore:

Remove the limitation of clamping the cubic-bezier timing function
values between 0 and 1, following the specification change made on
April 5 of this year.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.

Tests: transitions/cubic-bezier-overflow-color.html

transitions/cubic-bezier-overflow-length.html
transitions/cubic-bezier-overflow-shadow.html
transitions/cubic-bezier-overflow-svg-length.html
transitions/cubic-bezier-overflow-transform.html

  • css/CSSParser.cpp:

(WebCore::CSSParser::parseCubicBezierTimingFunctionValue):

LayoutTests:

Test overflow behavior of colors, lengths, svg lengths,
shadows and transforms (through rotations). Update the
timing function test to check for now valid values.

Patch by Peter Beverloo <​peter@chromium.org> on 2011-09-28
Reviewed by Dean Jackson.

  • fast/css/transition-timing-function-expected.txt:
  • fast/css/transition-timing-function.html:
  • transitions/cubic-bezier-overflow-color-expected.txt: Added.
  • transitions/cubic-bezier-overflow-color.html: Added.
  • transitions/cubic-bezier-overflow-length-expected.txt: Added.
  • transitions/cubic-bezier-overflow-length.html: Added.
  • transitions/cubic-bezier-overflow-shadow-expected.txt: Added.
  • transitions/cubic-bezier-overflow-shadow.html: Added.
  • transitions/cubic-bezier-overflow-svg-length-expected.txt: Added.
  • transitions/cubic-bezier-overflow-svg-length.html: Added.
  • transitions/cubic-bezier-overflow-transform-expected.txt: Added.
  • transitions/cubic-bezier-overflow-transform.html: Added.
Location:
trunk
Files:
10 added
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r96275 r96276  
     12011-09-28  Peter Beverloo  <peter@chromium.org>
     2
     3        Don't clamp cubic-bezier timing functions between 0 and 1
     4        https://bugs.webkit.org/show_bug.cgi?id=45761
     5
     6        Test overflow behavior of colors, lengths, svg lengths,
     7        shadows and transforms (through rotations). Update the
     8        timing function test to check for now valid values.
     9
     10        Reviewed by Dean Jackson.
     11
     12        * fast/css/transition-timing-function-expected.txt:
     13        * fast/css/transition-timing-function.html:
     14        * transitions/cubic-bezier-overflow-color-expected.txt: Added.
     15        * transitions/cubic-bezier-overflow-color.html: Added.
     16        * transitions/cubic-bezier-overflow-length-expected.txt: Added.
     17        * transitions/cubic-bezier-overflow-length.html: Added.
     18        * transitions/cubic-bezier-overflow-shadow-expected.txt: Added.
     19        * transitions/cubic-bezier-overflow-shadow.html: Added.
     20        * transitions/cubic-bezier-overflow-svg-length-expected.txt: Added.
     21        * transitions/cubic-bezier-overflow-svg-length.html: Added.
     22        * transitions/cubic-bezier-overflow-transform-expected.txt: Added.
     23        * transitions/cubic-bezier-overflow-transform.html: Added.
     24
    1252011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
    226

  • trunk/LayoutTests/fast/css/transition-timing-function-expected.txt

    r30635 r96276  
    66PASS: 'cubic-bezier(0, 0, 0, 1)' parsed and serialized successfully.
    77PASS: 'cubic-bezier(0.1, 0.52, 0.11101, 0.9)' parsed and serialized successfully.
     8PASS: 'cubic-bezier(1.5, 55, 12.3456, 1000)' parsed and serialized successfully.
     9PASS: 'cubic-bezier(-1.5, -55, -12.3456, -1000)' parsed and serialized successfully.
    810

  • trunk/LayoutTests/fast/css/transition-timing-function.html

    r28707 r96276  
    2929    roundTripTransitionTimingFunctionValue("cubic-bezier(0, 0, 0, 1)");
    3030    roundTripTransitionTimingFunctionValue("cubic-bezier(0.1, 0.52, 0.11101, 0.9)");
     31    roundTripTransitionTimingFunctionValue("cubic-bezier(1.5, 55, 12.3456, 1000)");
     32    roundTripTransitionTimingFunctionValue("cubic-bezier(-1.5, -55, -12.3456, -1000)");
    3133</script>

  • trunk/Source/WebCore/ChangeLog

    r96270 r96276  
     12011-09-28  Peter Beverloo  <peter@chromium.org>
     2
     3        Don't clamp cubic-bezier timing functions between 0 and 1
     4        https://bugs.webkit.org/show_bug.cgi?id=45761
     5
     6        Remove the limitation of clamping the cubic-bezier timing function
     7        values between 0 and 1, following the specification change made on
     8        April 5 of this year.
     9
     10        Reviewed by Dean Jackson.
     11
     12        Tests: transitions/cubic-bezier-overflow-color.html
     13               transitions/cubic-bezier-overflow-length.html
     14               transitions/cubic-bezier-overflow-shadow.html
     15               transitions/cubic-bezier-overflow-svg-length.html
     16               transitions/cubic-bezier-overflow-transform.html
     17
     18        * css/CSSParser.cpp:
     19        (WebCore::CSSParser::parseCubicBezierTimingFunctionValue):
     20
    1212011-09-28  Chris Rogers  <crogers@google.com>
    222

  • trunk/Source/WebCore/css/CSSParser.cpp

    r95911 r96276  
    32703270        return false;
    32713271    result = v->fValue;
    3272     if (result < 0 || result > 1.0)
    3273         return false;
    32743272    v = args->next();
    32753273    if (!v)
Note: See TracChangeset for help on using the changeset viewer.