Changeset 96290 in webkit

Timestamp:

Sep 28, 2011 7:49:45 PM (13 years ago)

Author:

tkent@chromium.org

Message:

REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 2^{31
​https://bugs.webkit.org/show_bug.cgi?id=68981}

Reviewed by Darin Adler.

Source/WebCore:

• html/parser/HTMLParserIdioms.cpp:

(WebCore::parseHTMLInteger):
Check the failure of charactersToIntStrict().
(WebCore::parseHTMLNonNegativeInteger):
Check the failure of charactersToUIntStrict().

LayoutTests:

• fast/forms/input-text-paste-maxlength-expected.txt:
• fast/forms/input-text-paste-maxlength.html:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/input-text-paste-maxlength-expected.txt (modified) (1 diff)
• LayoutTests/fast/forms/input-text-paste-maxlength.html (modified) (3 diffs)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/html/parser/HTMLParserIdioms.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-09-28  Kent Tamura  <tkent@chromium.org>
+
+        REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 2^31
+        https://bugs.webkit.org/show_bug.cgi?id=68981
+
+        Reviewed by Darin Adler.
+
+        * fast/forms/input-text-paste-maxlength-expected.txt:
+        * fast/forms/input-text-paste-maxlength.html:
+
 2011-09-28  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/LayoutTests/fast/forms/input-text-paste-maxlength-expected.txt

@@ -35 +35 @@
 PASS domValueOf('n') is '12' + fancyX + '45'
 PASS visibleValueOf('n') is '12' + fancyX + '45'
+PASS domValueOf('huge') is '12' + fancyX + '45'
+PASS visibleValueOf('huge') is '12' + fancyX + '45'
 PASS successfullyParsed is true
 
 TEST COMPLETE
-           
+

trunk/LayoutTests/fast/forms/input-text-paste-maxlength.html

@@ -9 +9 @@
 <div id="console"></div>
 
+<div id=container>
 <input type="text" id="f" size="5" maxlength="4">
 <input type="text" id="e" size="5" maxlength="4">
@@ -21 +22 @@
 <input type="text" id="m" size="5" maxlength="">
 <input type="text" id="n" size="5" maxlength="invalid">
+<input type="text" id="huge" size="5" maxlength="9999999999">
+</div>
 
 <script>
@@ -114 +117 @@
 shouldBe("domValueOf('n')", "'12' + fancyX + '45'");
 shouldBe("visibleValueOf('n')", "'12' + fancyX + '45'");
+document.getElementById("huge").focus();
+document.execCommand("InsertHTML", false, "12x&#x305;&#x332;45");
+shouldBe("domValueOf('huge')", "'12' + fancyX + '45'");
+shouldBe("visibleValueOf('huge')", "'12' + fancyX + '45'");
 
+document.getElementById('container').innerHTML = '';
 var successfullyParsed = true;
 </script>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-28  Kent Tamura  <tkent@chromium.org>
+
+        REGRESSION(r93858): Can't type anything into input elements when maxlength is greater than 2^31
+        https://bugs.webkit.org/show_bug.cgi?id=68981
+
+        Reviewed by Darin Adler.
+
+        * html/parser/HTMLParserIdioms.cpp:
+        (WebCore::parseHTMLInteger):
+        Check the failure of charactersToIntStrict().
+        (WebCore::parseHTMLNonNegativeInteger):
+        Check the failure of charactersToUIntStrict().
+
 2011-09-28  Antoine Labour  <piman@chromium.org>
 

trunk/Source/WebCore/html/parser/HTMLParserIdioms.cpp

@@ -216 +216 @@
 
     // Step 9
-    value = sign * charactersToIntStrict(digits.characters(), digits.length());
-    return true;
+    bool ok;
+    value = sign * charactersToIntStrict(digits.characters(), digits.length(), &ok);
+    return ok;
 }
 
@@ -262 +263 @@
 
     // Step 9
-    value = charactersToUIntStrict(digits.characters(), digits.length());
-    return true;
-}
-
-}
+    bool ok;
+    value = charactersToUIntStrict(digits.characters(), digits.length(), &ok);
+    return ok;
+}
+
+}