Changeset 96301 in webkit

Timestamp:

Sep 28, 2011 11:07:17 PM (13 years ago)

Author:

haraken@chromium.org

Message:

"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
​https://bugs.webkit.org/show_bug.cgi?id=68984

Reviewed by Darin Adler.

Just a follow-up fix for the bug 68345. For performance,
"ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&".

Tests: fast/events/constructors/pop-state-event-constructor.html

fast/events/fire-popstate-event.html

• dom/PopStateEvent.cpp:

(WebCore::PopStateEvent::PopStateEvent):
(WebCore::PopStateEvent::create):
(WebCore::PopStateEvent::initPopStateEvent):

• dom/PopStateEvent.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/PopStateEvent.cpp (modified) (3 diffs)
• dom/PopStateEvent.h (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-28  Kentaro Hara  <haraken@chromium.org>
+
+        "ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&"
+        https://bugs.webkit.org/show_bug.cgi?id=68984
+
+        Reviewed by Darin Adler.
+
+        Just a follow-up fix for the bug 68345. For performance,
+        "ScriptValue" arguments of PopStateEvent methods should be "const ScriptValue&".
+
+        Tests: fast/events/constructors/pop-state-event-constructor.html
+               fast/events/fire-popstate-event.html
+
+        * dom/PopStateEvent.cpp:
+        (WebCore::PopStateEvent::PopStateEvent):
+        (WebCore::PopStateEvent::create):
+        (WebCore::PopStateEvent::initPopStateEvent):
+        * dom/PopStateEvent.h:
+
 2011-09-28  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebCore/dom/PopStateEvent.cpp

@@ -49 +49 @@
 }
 
-PopStateEvent::PopStateEvent(ScriptValue state)
+PopStateEvent::PopStateEvent(const ScriptValue& state)
     : Event(eventNames().popstateEvent, false, true)
     , m_state(state)
@@ -71 +71 @@
 }
 
-PassRefPtr<PopStateEvent> PopStateEvent::create(ScriptValue state)
+PassRefPtr<PopStateEvent> PopStateEvent::create(const ScriptValue& state)
 {
     return adoptRef(new PopStateEvent(state));
@@ -86 +86 @@
 }
 
-void PopStateEvent::initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, ScriptValue state)
+void PopStateEvent::initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue& state)
 {
     if (dispatched())

trunk/Source/WebCore/dom/PopStateEvent.h

@@ -44 +44 @@
     virtual ~PopStateEvent();
     static PassRefPtr<PopStateEvent> create();
-    static PassRefPtr<PopStateEvent> create(ScriptValue);
+    static PassRefPtr<PopStateEvent> create(const ScriptValue&);
     static PassRefPtr<PopStateEvent> create(PassRefPtr<SerializedScriptValue>);
     static PassRefPtr<PopStateEvent> create(const AtomicString&, const PopStateEventInit&);
-    void initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, ScriptValue);
+    void initPopStateEvent(const AtomicString& type, bool canBubble, bool cancelable, const ScriptValue&);
     bool isPopStateEvent() const { return true; }
 
@@ -56 +56 @@
     PopStateEvent();
     PopStateEvent(const AtomicString&, const PopStateEventInit&);
-    explicit PopStateEvent(ScriptValue);
+    explicit PopStateEvent(const ScriptValue&);
     explicit PopStateEvent(PassRefPtr<SerializedScriptValue>);