Changeset 96317 in webkit

Timestamp:

Sep 29, 2011 4:00:04 AM (13 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Explicitly call destructors for objects initialized with placement new syntax
​https://bugs.webkit.org/show_bug.cgi?id=69079

Reviewed by Xan Lopez.

• UIProcess/API/gtk/WebKitWebContext.cpp:

(webkitWebContextFinalize): Call ~WebKitWebContextPrivate().

• UIProcess/API/gtk/WebKitWebLoaderClient.cpp:

(webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
(webkit_web_loader_client_class_init):

• UIProcess/API/gtk/WebKitWebView.cpp:

(webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
(webkit_web_view_class_init):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebContext.cpp (modified) (1 diff)
• UIProcess/API/gtk/WebKitWebLoaderClient.cpp (modified) (2 diffs)
• UIProcess/API/gtk/WebKitWebView.cpp (modified) (2 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-09-29  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Explicitly call destructors for objects initialized with placement new syntax
+        https://bugs.webkit.org/show_bug.cgi?id=69079
+
+        Reviewed by Xan Lopez.
+
+        * UIProcess/API/gtk/WebKitWebContext.cpp:
+        (webkitWebContextFinalize): Call ~WebKitWebContextPrivate().
+        * UIProcess/API/gtk/WebKitWebLoaderClient.cpp:
+        (webkitWebLoaderClientFinalize): Call ~WebKitWebLoaderClient().
+        (webkit_web_loader_client_class_init):
+        * UIProcess/API/gtk/WebKitWebView.cpp:
+        (webkitWebViewFinalize): Call ~WebKitWebViewPrivate().
+        (webkit_web_view_class_init):
+
 2011-09-28  Martin Robinson  <mrobinson@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebContext.cpp

@@ -37 +37 @@
     WKRelease(context->priv->context);
     context->priv->context = 0;
+
+    context->priv->~WebKitWebContextPrivate();
+
+    G_OBJECT_CLASS(webkit_web_context_parent_class)->finalize(object);
 }
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebLoaderClient.cpp

@@ -183 +183 @@
 }
 
+static void webkitWebLoaderClientFinalize(GObject* object)
+{
+    WEBKIT_WEB_LOADER_CLIENT(object)->priv->~WebKitWebLoaderClientPrivate();
+    G_OBJECT_CLASS(webkit_web_loader_client_parent_class)->finalize(object);
+}
+
 static void webkit_web_loader_client_init(WebKitWebLoaderClient* client)
 {
@@ -197 +203 @@
     objectClass->get_property = webkitWebLoaderClientGetProperty;
     objectClass->constructed = webkitWebLoaderClientConstructed;
+    objectClass->finalize = webkitWebLoaderClientFinalize;
 
     /**

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp

@@ -84 +84 @@
 }
 
+static void webkitWebViewFinalize(GObject* object)
+{
+    WEBKIT_WEB_VIEW(object)->priv->~WebKitWebViewPrivate();
+    G_OBJECT_CLASS(webkit_web_view_parent_class)->finalize(object);
+}
+
 static void webkit_web_view_init(WebKitWebView* webView)
 {
@@ -98 +104 @@
     gObjectClass->set_property = webkitWebViewSetProperty;
     gObjectClass->get_property = webkitWebViewGetProperty;
+    gObjectClass->finalize = webkitWebViewFinalize;
 
     g_type_class_add_private(webViewClass, sizeof(WebKitWebViewPrivate));