Changeset 96321 in webkit

Timestamp:

Sep 29, 2011 4:59:27 AM (13 years ago)

Author:

loislo@chromium.org

Message:

Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
​https://bugs.webkit.org/show_bug.cgi?id=69081

There is a test with 30 requests.
For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.

Reviewed by Pavel Feldman.

Test: inspector/performance/resources/network-append-30-requests.html

• inspector/front-end/NetworkPanel.js:

(WebInspector.NetworkLogView):
(WebInspector.NetworkLogView.prototype._invalidateAllItems):
(WebInspector.NetworkLogView.prototype.refresh):
(WebInspector.NetworkLogView.prototype._reset):
(WebInspector.NetworkLogView.prototype._refreshResource):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/front-end/NetworkPanel.js (modified) (7 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-09-29  Ilya Tikhonovsky  <loislo@chromium.org>
+
+        Web Inspector: speed-up Network panel. Change _staleResources type from array to object.
+        https://bugs.webkit.org/show_bug.cgi?id=69081
+
+        There is a test with 30 requests.
+        For the each stage of loading a resource we have an entry in _staleResources array. There are at least 4 stages per request.
+        NetworkLogView._refresh function is creating/updating the resource row for the each such entry.
+        This array can be replaced with a hash map just because the resource associated with the entry is the same for all the entries with the same request id.
+
+        Reviewed by Pavel Feldman.
+
+        Test: inspector/performance/resources/network-append-30-requests.html
+
+        * inspector/front-end/NetworkPanel.js:
+        (WebInspector.NetworkLogView):
+        (WebInspector.NetworkLogView.prototype._invalidateAllItems):
+        (WebInspector.NetworkLogView.prototype.refresh):
+        (WebInspector.NetworkLogView.prototype._reset):
+        (WebInspector.NetworkLogView.prototype._refreshResource):
+
 2011-09-28  Pavel Feldman  <pfeldman@google.com>
 

trunk/Source/WebCore/inspector/front-end/NetworkPanel.js

@@ -43 +43 @@
     this._resourcesById = {};
     this._resourcesByURL = {};
-    this._staleResources = [];
+    this._staleResources = {};
     this._resourceGridNodes = {};
     this._lastResourceGridNodeId = 0;
@@ -579 +579 @@
     _invalidateAllItems: function()
     {
-        this._staleResources = this._resources.slice();
+        for (var i = 0; i < this._resources.length; ++i) {
+            var resource = this._resources[i];
+            this._staleResources[resource.requestId] = resource;
+        }
     },
 
@@ -661 +664 @@
         this._removeAllNodeHighlights();
         var wasScrolledToLastRow = this._dataGrid.isScrolledToLastRow();
-        var staleItemsLength = this._staleResources.length;
         var boundariesChanged = false;
         if (this.calculator.updateBoundariesForEventTime) {
@@ -668 +670 @@
         }
 
-        for (var i = 0; i < staleItemsLength; ++i) {
-            var resource = this._staleResources[i];
+        for (var resourceId in this._staleResources) {
+            var resource = this._staleResources[resourceId];
             var node = this._resourceGridNode(resource);
             if (!node) {
@@ -688 +690 @@
             // The boundaries changed, so all item graphs are stale.
             this._invalidateAllItems();
-            staleItemsLength = this._staleResources.length;
-        }
-
-        for (var i = 0; i < staleItemsLength; ++i)
-            this._resourceGridNode(this._staleResources[i]).refreshGraph(this.calculator);
-
-        this._staleResources = [];
+        }
+
+        for (var resourceId in this._staleResources)
+            this._resourceGridNode(this._staleResources[resourceId]).refreshGraph(this.calculator);
+
+        this._staleResources = {};
         this._sortItems();
         this._updateSummaryBar();
@@ -722 +723 @@
         this._resourcesById = {};
         this._resourcesByURL = {};
-        this._staleResources = [];
+        this._staleResources = {};
         this._resourceGridNodes = {};
 
@@ -783 +784 @@
     _refreshResource: function(resource)
     {
-        this._staleResources.push(resource);
+        this._staleResources[resource.requestId] = resource;
         this._scheduleRefresh();
     },