Changeset 96414 in webkit

Timestamp:

Sep 30, 2011 12:34:33 PM (13 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Only save the current viewport in PixelDumpSupportEfl.
​https://bugs.webkit.org/show_bug.cgi?id=68450

Patch by Raphael Kubo da Costa <​kubo@profusion.mobi> on 2011-09-30
Reviewed by Antonio Gomes.

The previous implementation saved the whole page contents in the final
PNG, however the baselines and expectations in the tree only want the
current viewport (with a scrollbar, if needed), so we now only save the
currently visible contents.

• DumpRenderTree/efl/PixelDumpSupportEfl.cpp:

(createBitmapContextFromWebView): Use
ewk_frame_visible_content_geometry_get instead of
ewk_frame_contents_size_get.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• DumpRenderTree/efl/PixelDumpSupportEfl.cpp (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
+
+        [EFL] Only save the current viewport in PixelDumpSupportEfl.
+        https://bugs.webkit.org/show_bug.cgi?id=68450
+
+        Reviewed by Antonio Gomes.
+
+        The previous implementation saved the whole page contents in the final
+        PNG, however the baselines and expectations in the tree only want the
+        current viewport (with a scrollbar, if needed), so we now only save the
+        currently visible contents.
+
+        * DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
+        (createBitmapContextFromWebView): Use
+        ewk_frame_visible_content_geometry_get instead of
+        ewk_frame_contents_size_get.
+
 2011-09-30  Raphael Kubo da Costa  <kubo@profusion.mobi>
 

trunk/Tools/DumpRenderTree/efl/PixelDumpSupportEfl.cpp

@@ -42 +42 @@
     Ewk_View_Private_Data* privateData = static_cast<Ewk_View_Private_Data*>(smartData->_priv);
 
-    int width, height;
-    if (!ewk_frame_contents_size_get(mainFrame, &width, &height))
+    int x, y, width, height;
+    if (!ewk_frame_visible_content_geometry_get(mainFrame, EINA_TRUE, &x, &y, &width, &height))
         return 0;
 
@@ -49 +49 @@
     RefPtr<cairo_t> context = adoptRef(cairo_create(surface.get()));
 
-    const Eina_Rectangle rect = { 0, 0, width, height };
-    if (!ewk_view_paint_contents(privateData, context.get(), &rect))
+    const Eina_Rectangle rect = { x, y, width, height };
+    if (!ewk_view_paint(privateData, context.get(), &rect))
         return 0;