Changeset 96496 in webkit

Timestamp:

Oct 3, 2011 7:16:46 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

Shrink HTMLLIElement.
​https://bugs.webkit.org/show_bug.cgi?id=69250

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-03
Reviewed by Antti Koivisto.

Don't cache the explicit "value" attribute on the HTMLLIElement,
but fetch it with fastGetAttribute when needed.
This shrinks HTMLLIElement by one CPU word.

• html/HTMLLIElement.cpp:

(WebCore::HTMLLIElement::HTMLLIElement):
(WebCore::HTMLLIElement::parseMappedAttribute):
(WebCore::HTMLLIElement::attach):

• html/HTMLLIElement.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLLIElement.cpp (modified) (3 diffs)
• html/HTMLLIElement.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-03  Andreas Kling  <kling@webkit.org>
+
+        Shrink HTMLLIElement.
+        https://bugs.webkit.org/show_bug.cgi?id=69250
+
+        Reviewed by Antti Koivisto.
+
+        Don't cache the explicit "value" attribute on the HTMLLIElement,
+        but fetch it with fastGetAttribute when needed.
+        This shrinks HTMLLIElement by one CPU word.
+
+        * html/HTMLLIElement.cpp:
+        (WebCore::HTMLLIElement::HTMLLIElement):
+        (WebCore::HTMLLIElement::parseMappedAttribute):
+        (WebCore::HTMLLIElement::attach):
+        * html/HTMLLIElement.h:
+
 2011-10-03  Vsevolod Vlasov  <vsevik@chromium.org>
 

trunk/Source/WebCore/html/HTMLLIElement.cpp

@@ -36 +36 @@
 HTMLLIElement::HTMLLIElement(const QualifiedName& tagName, Document* document)
     : HTMLElement(tagName, document)
-    , m_requestedValue(0)
 {
     ASSERT(hasTagName(liTag));
@@ -64 +63 @@
 {
     if (attr->name() == valueAttr) {
-        m_requestedValue = attr->value().toInt();
         if (renderer() && renderer()->isListItem()) {
-            if (m_requestedValue > 0)
-                toRenderListItem(renderer())->setExplicitValue(m_requestedValue);
+            int requestedValue = attr->value().toInt();
+            if (requestedValue > 0)
+                toRenderListItem(renderer())->setExplicitValue(requestedValue);
             else
                 toRenderListItem(renderer())->clearExplicitValue();
@@ -110 +109 @@
             render->setNotInList(true);
 
-        if (m_requestedValue > 0)
-            render->setExplicitValue(m_requestedValue);
-        else
+        const AtomicString& requestedValueString = fastGetAttribute(valueAttr);
+        if (requestedValueString.isNull())
             render->clearExplicitValue();
+        else {
+            int requestedValue = requestedValueString.toInt();
+            if (requestedValue > 0)
+                render->setExplicitValue(requestedValue);
+            else
+                render->clearExplicitValue();
+        }
     }
 }

trunk/Source/WebCore/html/HTMLLIElement.h

@@ -40 +40 @@
 
     virtual void attach();
-
-    int m_requestedValue;
 };