Changeset 96512 in webkit

Timestamp:

Oct 3, 2011 9:50:53 AM (13 years ago)

Author:

commit-queue@webkit.org

Message:

FontFallbackList: Glyph pages waste a lot of memory.
​https://bugs.webkit.org/show_bug.cgi?id=69260

Patch by Andreas Kling <​kling@webkit.org> on 2011-10-03
Reviewed by Dan Bernstein.

Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
glyph pages. This reduces memory consumption by ~900 kB when loading the
full HTML5 spec.

The cost is two additional rehash()es of FontFallbackList::m_pages when
adding the 32nd and 64th pages to the hash map.

• platform/graphics/FontFallbackList.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/FontFallbackList.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-10-03  Andreas Kling  <kling@webkit.org>
+
+        FontFallbackList: Glyph pages waste a lot of memory.
+        https://bugs.webkit.org/show_bug.cgi?id=69260
+
+        Reviewed by Dan Bernstein.
+
+        Use a minimum hash table size of 16 (down from 64) for FontFallbackList's
+        glyph pages. This reduces memory consumption by ~900 kB when loading the
+        full HTML5 spec.
+
+        The cost is two additional rehash()es of FontFallbackList::m_pages when
+        adding the 32nd and 64th pages to the hash map.
+
+        * platform/graphics/FontFallbackList.h:
+
 2011-10-03  Konstantin Scheglov  <scheglov@google.com>
 

trunk/Source/WebCore/platform/graphics/FontFallbackList.h

@@ -54 +54 @@
     unsigned generation() const { return m_generation; }
 
-    typedef HashMap<int, GlyphPageTreeNode*> GlyphPages;
+    struct GlyphPagesHashTraits : HashTraits<int> {
+        static const int minimumTableSize = 16;
+    };
+    typedef HashMap<int, GlyphPageTreeNode*, DefaultHash<int>::Hash, GlyphPagesHashTraits> GlyphPages;
     GlyphPageTreeNode* glyphPageZero() const { return m_pageZero; }
     const GlyphPages& glyphPages() const { return m_pages; }