Changeset 96552 in webkit


Ignore:
Timestamp:
Oct 3, 2011 4:02:51 PM (12 years ago)
Author:
rniwa@webkit.org
Message:

REGRESSION(r94274): cloned text input loses value
https://bugs.webkit.org/show_bug.cgi?id=69095

Reviewed by Darin Adler.

Source/WebCore:

The bug was caused by copyNonAttributeProperties not updating inner element text after copying
m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.

Test: fast/forms/clone-input-with-dirty-value.html

  • html/HTMLInputElement.cpp:

(WebCore::HTMLInputElement::copyNonAttributeProperties):

LayoutTests:

Added a regression test that clones an input element with a dirty value.
The cloned input element should have the edited value.

  • fast/forms/clone-input-with-dirty-value-expected.txt: Added.
  • fast/forms/clone-input-with-dirty-value.html: Added.
Location:
trunk
Files:
2 added
3 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r96548 r96552  
     12011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        REGRESSION(r94274): cloned text input loses value
     4        https://bugs.webkit.org/show_bug.cgi?id=69095
     5
     6        Reviewed by Darin Adler.
     7
     8        Added a regression test that clones an input element with a dirty value.
     9        The cloned input element should have the edited value.
     10
     11        * fast/forms/clone-input-with-dirty-value-expected.txt: Added.
     12        * fast/forms/clone-input-with-dirty-value.html: Added.
     13
    1142011-10-03  Adam Barth  <abarth@webkit.org>
    215
  • trunk/Source/WebCore/ChangeLog

    r96551 r96552  
     12011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
     2
     3        REGRESSION(r94274): cloned text input loses value
     4        https://bugs.webkit.org/show_bug.cgi?id=69095
     5
     6        Reviewed by Darin Adler.
     7
     8        The bug was caused by copyNonAttributeProperties not updating inner element text after copying
     9        m_valueIfDirty. Fixed the bug by calling updateInnerTextValue.
     10
     11        Test: fast/forms/clone-input-with-dirty-value.html
     12
     13        * html/HTMLInputElement.cpp:
     14        (WebCore::HTMLInputElement::copyNonAttributeProperties):
     15
    1162011-10-03  Ryosuke Niwa  <rniwa@webkit.org>
    217
  • trunk/Source/WebCore/html/HTMLInputElement.cpp

    r96224 r96552  
    10281028
    10291029    HTMLTextFormControlElement::copyNonAttributeProperties(source);
     1030
     1031    setFormControlValueMatchesRenderer(false);
     1032    updateInnerTextValue();
    10301033}
    10311034
Note: See TracChangeset for help on using the changeset viewer.