Changeset 96619 in webkit

Timestamp:

Oct 4, 2011 11:15:42 AM (13 years ago)

Author:

jeffm@apple.com

Message:

WKPreferences should allow control of application chrome mode
​https://bugs.webkit.org/show_bug.cgi?id=69344

Reviewed by Dan Bernstein.

• Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().

• UIProcess/API/C/WKPreferences.cpp:

(WKPreferencesSetApplicationChromeModeEnabled): Added.
(WKPreferencesGetApplicationChromeModeEnabled): Added.

• UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().

• WebProcess/WebPage/WebPage.cpp:

(WebKit::WebPage::updatePreferences): Set application chrome mode setting.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• Shared/WebPreferencesStore.h (modified) (1 diff)
• UIProcess/API/C/WKPreferences.cpp (modified) (1 diff)
• UIProcess/API/C/WKPreferencesPrivate.h (modified) (1 diff)
• WebProcess/WebPage/WebPage.cpp (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2011-10-04  Jeff Miller  <jeffm@apple.com>
+
+        WKPreferences should allow control of application chrome mode
+        https://bugs.webkit.org/show_bug.cgi?id=69344
+
+        Reviewed by Dan Bernstein.
+
+        * Shared/WebPreferencesStore.h: Add application chrome mode setting to FOR_EACH_WEBKIT_BOOL_PREFERENCE().
+
+        * UIProcess/API/C/WKPreferences.cpp:
+        (WKPreferencesSetApplicationChromeModeEnabled): Added.
+        (WKPreferencesGetApplicationChromeModeEnabled): Added.
+
+        * UIProcess/API/C/WKPreferencesPrivate.h: Added WKPreferencesSetApplicationChromeModeEnabled() and WKPreferencesGetApplicationChromeModeEnabled().
+
+        * WebProcess/WebPage/WebPage.cpp:
+        (WebKit::WebPage::updatePreferences): Set application chrome mode setting.
+
 2011-10-04  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/Shared/WebPreferencesStore.h

@@ -95 +95 @@
     macro(MockScrollbarsEnabled, mockScrollbarsEnabled, Bool, bool, false) \
     macro(WebAudioEnabled, webAudioEnabled, Bool, bool, false) \
+    macro(ApplicationChromeModeEnabled, applicationChromeMode, Bool, bool, false) \
     \
 

trunk/Source/WebKit2/UIProcess/API/C/WKPreferences.cpp

@@ -632 +632 @@
     return toImpl(preferencesRef)->webAudioEnabled();
 }
+
+void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef, bool enabled)
+{
+    toImpl(preferencesRef)->setApplicationChromeModeEnabled(enabled);
+}
+
+bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef)
+{
+    return toImpl(preferencesRef)->applicationChromeMode();
+}

trunk/Source/WebKit2/UIProcess/API/C/WKPreferencesPrivate.h

@@ -148 +148 @@
 WK_EXPORT void WKPreferencesSetMockScrollbarsEnabled(WKPreferencesRef preferencesRef, bool flag);
 WK_EXPORT bool WKPreferencesGetMockScrollbarsEnabled(WKPreferencesRef preferencesRef);
+    
+// Defaults to false.
+WK_EXPORT void WKPreferencesSetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef, bool enabled);
+WK_EXPORT bool WKPreferencesGetApplicationChromeModeEnabled(WKPreferencesRef preferencesRef);
 
 #ifdef __cplusplus

trunk/Source/WebKit2/WebProcess/WebPage/WebPage.cpp

@@ -1683 +1683 @@
 #endif
 
+    settings->setApplicationChromeMode(store.getBoolValueForKey(WebPreferencesKey::applicationChromeModeKey()));
+    
     platformPreferencesDidChange(store);
 }