Changeset 96637 in webkit


Ignore:
Timestamp:
Oct 4, 2011 1:37:58 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Unreviewed, rolling out r96630.
http://trac.webkit.org/changeset/96630
https://bugs.webkit.org/show_bug.cgi?id=69368

Caused assertion failures in validateCell (Requested by
mhahnenberg on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2011-10-04

Source/JavaScriptCore:

  • runtime/BooleanConstructor.cpp:
  • runtime/BooleanConstructor.h:
  • runtime/Error.cpp:

(JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
(JSC::StrictModeTypeErrorFunction::getCallData):

  • runtime/ErrorConstructor.cpp:
  • runtime/ErrorConstructor.h:
  • runtime/FunctionConstructor.cpp:
  • runtime/FunctionConstructor.h:
  • runtime/FunctionPrototype.cpp:
  • runtime/FunctionPrototype.h:

Source/WebCore:

  • bridge/qt/qt_runtime.cpp:
  • bridge/qt/qt_runtime.h:
Location:
trunk/Source
Files:
13 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/JavaScriptCore/ChangeLog

    r96630 r96637  
     12011-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r96630.
     4        http://trac.webkit.org/changeset/96630
     5        https://bugs.webkit.org/show_bug.cgi?id=69368
     6
     7        Caused assertion failures in validateCell (Requested by
     8        mhahnenberg on #webkit).
     9
     10        * runtime/BooleanConstructor.cpp:
     11        * runtime/BooleanConstructor.h:
     12        * runtime/Error.cpp:
     13        (JSC::StrictModeTypeErrorFunction::getCallDataVirtual):
     14        (JSC::StrictModeTypeErrorFunction::getCallData):
     15        * runtime/ErrorConstructor.cpp:
     16        * runtime/ErrorConstructor.h:
     17        * runtime/FunctionConstructor.cpp:
     18        * runtime/FunctionConstructor.h:
     19        * runtime/FunctionPrototype.cpp:
     20        * runtime/FunctionPrototype.h:
     21
    1222011-10-04  Mark Hahnenberg  <mhahnenberg@apple.com>
    223
  • trunk/Source/JavaScriptCore/runtime/BooleanConstructor.cpp

    r96630 r96637  
    2828
    2929ASSERT_CLASS_FITS_IN_CELL(BooleanConstructor);
    30 
    31 const ClassInfo BooleanConstructor::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(BooleanConstructor) };
    3230
    3331BooleanConstructor::BooleanConstructor(JSGlobalObject* globalObject, Structure* structure)
  • trunk/Source/JavaScriptCore/runtime/BooleanConstructor.h

    r96630 r96637  
    3939        }
    4040
    41         static const ClassInfo s_info;
    42 
    4341    protected:
    4442        void finishCreation(ExecState*, BooleanPrototype*);
  • trunk/Source/JavaScriptCore/runtime/Error.cpp

    r96630 r96637  
    202202    }
    203203
    204     virtual CallType getCallDataVirtual(CallData& callData)
     204    CallType getCallDataVirtual(CallData& callData)
    205205    {
    206206        return getCallData(this, callData);
    207207    }
    208208
    209     static CallType getCallData(JSCell*, CallData& callData)
     209    CallType getCallData(JSCell*, CallData& callData)
    210210    {
    211211        callData.native.function = callThrowTypeError;
    212212        return CallTypeHost;
    213213    }
    214 
    215     static const ClassInfo s_info;
    216214
    217215private:
     
    221219ASSERT_CLASS_FITS_IN_CELL(StrictModeTypeErrorFunction);
    222220
    223 const ClassInfo StrictModeTypeErrorFunction::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(StrictModeTypeErrorFunction) };
    224 
    225221JSValue createTypeErrorFunction(ExecState* exec, const UString& message)
    226222{
  • trunk/Source/JavaScriptCore/runtime/ErrorConstructor.cpp

    r96630 r96637  
    2929
    3030ASSERT_CLASS_FITS_IN_CELL(ErrorConstructor);
    31 
    32 const ClassInfo ErrorConstructor::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(ErrorConstructor) };
    3331
    3432ErrorConstructor::ErrorConstructor(JSGlobalObject* globalObject, Structure* structure)
  • trunk/Source/JavaScriptCore/runtime/ErrorConstructor.h

    r96630 r96637  
    4040        }
    4141
    42         static const ClassInfo s_info;
    43 
    4442    protected:
    4543        void finishCreation(ExecState*, ErrorPrototype*);
  • trunk/Source/JavaScriptCore/runtime/FunctionConstructor.cpp

    r96630 r96637  
    3737
    3838ASSERT_CLASS_FITS_IN_CELL(FunctionConstructor);
    39 
    40 const ClassInfo FunctionConstructor::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(FunctionConstructor) };
    4139
    4240FunctionConstructor::FunctionConstructor(JSGlobalObject* globalObject, Structure* structure)
  • trunk/Source/JavaScriptCore/runtime/FunctionConstructor.h

    r96630 r96637  
    3939        }
    4040
    41         static const ClassInfo s_info;
    42 
    4341    private:
    4442        FunctionConstructor(JSGlobalObject*, Structure*);
  • trunk/Source/JavaScriptCore/runtime/FunctionPrototype.cpp

    r96630 r96637  
    3939static EncodedJSValue JSC_HOST_CALL functionProtoFuncCall(ExecState*);
    4040static EncodedJSValue JSC_HOST_CALL functionProtoFuncBind(ExecState*);
    41 
    42 const ClassInfo FunctionPrototype::s_info = { "Function", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(FunctionPrototype) };
    4341
    4442FunctionPrototype::FunctionPrototype(JSGlobalObject* globalObject, Structure* structure)
  • trunk/Source/JavaScriptCore/runtime/FunctionPrototype.h

    r96630 r96637  
    4444        }
    4545
    46         static const ClassInfo s_info;
    47 
    4846    protected:
    4947        void finishCreation(ExecState*, const Identifier& name);
  • trunk/Source/WebCore/ChangeLog

    r96635 r96637  
     12011-10-04  Sheriff Bot  <webkit.review.bot@gmail.com>
     2
     3        Unreviewed, rolling out r96630.
     4        http://trac.webkit.org/changeset/96630
     5        https://bugs.webkit.org/show_bug.cgi?id=69368
     6
     7        Caused assertion failures in validateCell (Requested by
     8        mhahnenberg on #webkit).
     9
     10        * bridge/qt/qt_runtime.cpp:
     11        * bridge/qt/qt_runtime.h:
     12
    1132011-10-04  Cary Clark  <caryclark@google.com>
    214
  • trunk/Source/WebCore/bridge/qt/qt_runtime.cpp

    r96630 r96637  
    14261426}
    14271427
    1428 const ClassInfo QtRuntimeMetaMethod::s_info = { "QtRuntimeMethod", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(QtRuntimeMetaMethod) };
    1429 
    14301428QtRuntimeMetaMethod::QtRuntimeMetaMethod(ExecState* exec, Structure* structure, const Identifier& identifier)
    14311429    : QtRuntimeMethod (new QtRuntimeMetaMethodData(), exec, structure, identifier)
     
    15821580
    15831581QMultiMap<QObject*, QtConnectionObject*> QtRuntimeConnectionMethod::connections;
    1584 
    1585 const ClassInfo QtRuntimeConnectionMethod::s_info = { "QtRuntimeMethod", &Base::s_info, 0, 0, CREATE_METHOD_TABLE(QtRuntimeConnectionMethod) };
    15861582
    15871583QtRuntimeConnectionMethod::QtRuntimeConnectionMethod(ExecState* exec, Structure* structure, const Identifier& identifier)
  • trunk/Source/WebCore/bridge/qt/qt_runtime.h

    r96630 r96637  
    171171    static void visitChildren(JSCell*, SlotVisitor&);
    172172
    173     static const ClassInfo s_info;
    174 
    175173protected:
    176174    QtRuntimeMetaMethodData* d_func() const {return reinterpret_cast<QtRuntimeMetaMethodData*>(d_ptr);}
     
    204202    virtual bool getOwnPropertyDescriptor(ExecState*, const Identifier&, PropertyDescriptor&);
    205203    virtual void getOwnPropertyNames(ExecState*, PropertyNameArray&, EnumerationMode mode = ExcludeDontEnumProperties);
    206  
    207     static const ClassInfo s_info;
    208204
    209205protected:
Note: See TracChangeset for help on using the changeset viewer.