Changeset 96679 in webkit
- Timestamp:
- Oct 4, 2011 11:07:51 PM (12 years ago)
- Location:
- trunk/Source/WebCore
- Files:
-
- 10 edited
Legend:
- Unmodified
- Added
- Removed
-
trunk/Source/WebCore/ChangeLog
r96678 r96679 1 2011-10-04 Kent Tamura <tkent@chromium.org> 2 3 Remove Node::willBlur() 4 https://bugs.webkit.org/show_bug.cgi?id=69395 5 6 Reviewed by Ryosuke Niwa. 7 8 Revert the WebCore part of r87371 because 9 FrameSelection::textWillBeReplaced() doesn't set focus anymore. 10 No new tests. Covered by fast/forms/input-number-blur-twice.html. 11 12 * dom/Document.cpp: 13 (WebCore::Document::setFocusedNode): Revert r87371. 14 * dom/Node.cpp: ditto. 15 * dom/Node.h: ditto. 16 * html/HTMLInputElement.cpp: 17 (WebCore::HTMLInputElement::handleBlurEvent): ditto. 18 * html/HTMLInputElement.h: ditto. 19 * html/InputType.cpp: 20 (WebCore::InputType::handleBlurEvent): ditto. 21 * html/InputType.h: ditto. 22 * html/NumberInputType.cpp: 23 (WebCore::NumberInputType::handleBlurEvent): ditto. 24 * html/NumberInputType.h: ditto. 25 1 26 2011-10-04 Kent Tamura <tkent@chromium.org> 2 27 -
trunk/Source/WebCore/dom/Document.cpp
r96667 r96679 3169 3169 bool focusChangeBlocked = false; 3170 3170 RefPtr<Node> oldFocusedNode = m_focusedNode; 3171 m_focusedNode = 0; 3171 3172 3172 3173 // Remove focus from the existing focus node (if any) 3173 3174 if (oldFocusedNode && !oldFocusedNode->inDetach()) { 3174 // willBlur() should be called before any status changes.3175 oldFocusedNode->willBlur();3176 m_focusedNode = 0;3177 3175 if (oldFocusedNode->active()) 3178 3176 oldFocusedNode->setActive(false); … … 3219 3217 view()->setFocus(false); 3220 3218 } 3221 } else 3222 m_focusedNode = 0; 3219 } 3223 3220 3224 3221 if (newFocusedNode) { -
trunk/Source/WebCore/dom/Node.cpp
r96353 r96679 2743 2743 } 2744 2744 2745 void Node::willBlur()2746 {2747 }2748 2749 2745 void Node::dispatchBlurEvent(PassRefPtr<Node> newFocusedNode) 2750 2746 { -
trunk/Source/WebCore/dom/Node.h
r96353 r96679 564 564 565 565 virtual void dispatchFocusEvent(PassRefPtr<Node> oldFocusedNode); 566 virtual void willBlur();567 566 virtual void dispatchBlurEvent(PassRefPtr<Node> newFocusedNode); 568 567 virtual void dispatchChangeEvent(); -
trunk/Source/WebCore/html/HTMLInputElement.cpp
r96552 r96679 514 514 } 515 515 516 void HTMLInputElement::willBlur()517 {518 m_inputType->willBlur();519 HTMLTextFormControlElement::willBlur();520 }521 522 516 void HTMLInputElement::handleBlurEvent() 523 517 { 518 m_inputType->handleBlurEvent(); 524 519 if (!isTextField()) 525 520 return; -
trunk/Source/WebCore/html/HTMLInputElement.h
r95911 r96679 308 308 virtual bool isEmptySuggestedValue() const { return suggestedValue().isEmpty(); } 309 309 virtual void handleFocusEvent(); 310 virtual void willBlur();311 310 virtual void handleBlurEvent(); 312 311 -
trunk/Source/WebCore/html/InputType.cpp
r96678 r96679 437 437 } 438 438 439 void InputType:: willBlur()439 void InputType::handleBlurEvent() 440 440 { 441 441 } -
trunk/Source/WebCore/html/InputType.h
r95901 r96679 183 183 virtual bool isKeyboardFocusable() const; 184 184 virtual bool shouldUseInputMethod() const; 185 virtual void willBlur();185 virtual void handleBlurEvent(); 186 186 virtual void accessKeyAction(bool sendToAnyElement); 187 187 virtual bool canBeSuccessfulSubmitButton(); -
trunk/Source/WebCore/html/NumberInputType.cpp
r95901 r96679 274 274 } 275 275 276 void NumberInputType:: willBlur()276 void NumberInputType::handleBlurEvent() 277 277 { 278 278 // Reset the renderer value, which might be unmatched with the element value. -
trunk/Source/WebCore/html/NumberInputType.h
r95901 r96679 65 65 virtual String serialize(double) const; 66 66 virtual double acceptableError(double) const; 67 virtual void willBlur();67 virtual void handleBlurEvent() OVERRIDE; 68 68 virtual String visibleValue() const; 69 69 virtual String convertFromVisibleValue(const String&) const;
Note: See TracChangeset
for help on using the changeset viewer.