Changeset 96794 in webkit

Timestamp:

Oct 6, 2011 2:08:25 AM (13 years ago)

Author:

fpizlo@apple.com

Message:

SpeculativeJIT::isKnownString() is wrong
​https://bugs.webkit.org/show_bug.cgi?id=69501

Reviewed by Oliver Hunt.

Removed the wrong case (GetLocal predicted String) and added a case that
works (StrCat).

• dfg/DFGSpeculativeJIT.h:

(JSC::DFG::SpeculativeJIT::isKnownString):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGSpeculativeJIT.h (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2011-10-05  Filip Pizlo  <fpizlo@apple.com>
+
+        SpeculativeJIT::isKnownString() is wrong
+        https://bugs.webkit.org/show_bug.cgi?id=69501
+
+        Reviewed by Oliver Hunt.
+        
+        Removed the wrong case (GetLocal predicted String) and added a case that
+        works (StrCat).
+
+        * dfg/DFGSpeculativeJIT.h:
+        (JSC::DFG::SpeculativeJIT::isKnownString):
+
 2011-10-05  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Source/JavaScriptCore/dfg/DFGSpeculativeJIT.h

@@ -593 +593 @@
     bool isKnownString(NodeIndex op1)
     {
-        Node& node = m_jit.graph()[op1];
-        switch (node.op) {
-        case GetLocal:
-            return isStringPrediction(node.variableAccessData()->prediction());
-
+        switch (m_jit.graph()[op1].op) {
+        case StrCat:
+            return true;
+            
         default:
             return false;