Changeset 97419 in webkit


Ignore:
Timestamp:
Oct 13, 2011 4:16:09 PM (13 years ago)
Author:
haraken@chromium.org
Message:

Implement a BeforeLoadEvent constructor for V8
​https://bugs.webkit.org/show_bug.cgi?id=69980

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/before-load-event-constructor.html

  • bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
  • dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.

  • platform/chromium/test_expectations.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r97418 r97419  
     12011-10-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        Implement a BeforeLoadEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=69980
     5
     6        Reviewed by Adam Barth.
     7
     8        Enabled before-load-event-constructor.html, since now V8 has the BeforeLoadEvent constructor.
     9
     10        * platform/chromium/test_expectations.txt:
     11
    1122011-10-13  Dimitri Glazkov  <dglazkov@chromium.org>
    213

  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r97418 r97419  
    9292BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
    9393BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
    94 
    95 // This will soon be fixed after implementing a BeforeLoadEvent constructor for V8.
    96 BUGWK69893 : fast/events/constructors/before-load-event-constructor.html = FAIL
    9794
    9895// This will soon be fixed after implementing an OverflowEvent constructor for V8.

  • trunk/Source/WebCore/ChangeLog

    r97417 r97419  
     12011-10-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        Implement a BeforeLoadEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=69980
     5
     6        Reviewed by Adam Barth.
     7
     8        Test: fast/events/constructors/before-load-event-constructor.html
     9
     10        * bindings/v8/custom/V8EventConstructors.cpp: Added a BeforeLoadEvent constructor.
     11        * dom/BeforeLoadEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
     12
    1132011-10-13  Joshua Bell  <jsbell@chromium.org>
    214

  • trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp

    r97326 r97419  
    3232#include "EventConstructors.h"
    3333
     34#include "BeforeLoadEvent.h"
    3435#include "CloseEvent.h"
    3536#include "CustomEvent.h"
    … …  
    4647
    4748#include "OptionsObject.h"
     49#include "V8BeforeLoadEvent.h"
    4850#include "V8Binding.h"
    4951#include "V8BindingMacros.h"
    … …  
    124126INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_POP_STATE_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    125127INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
     128INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_BEFORE_LOAD_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    126129
    127130

  • trunk/Source/WebCore/dom/BeforeLoadEvent.idl

    r97324 r97419  
    2929    interface [
    3030        CanBeConstructed,
    31         JSCustomConstructor
     31        CustomConstructor
    3232    ] BeforeLoadEvent : Event {
    3333        void initBeforeLoadEvent(in [Optional=CallWithDefaultValue] DOMString type,
Note: See TracChangeset for help on using the changeset viewer.