Changeset 97424 in webkit


Ignore:
Timestamp:
Oct 13, 2011 4:45:43 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
https://bugs.webkit.org/show_bug.cgi?id=69801

As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.

Reviewed by Adam Barth.

No new tests, since no change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.

(GenerateConstructorCallback):

  • bindings/scripts/test/TestInterface.idl: Ditto.
  • fileapi/FileReader.idl: Ditto.
  • p2p/PeerConnection.idl: Ditto.
  • page/EventSource.idl: Ditto.
  • workers/Worker.idl: Ditto.
Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed
  • trunk/Source/WebCore/ChangeLog

    r97423 r97424  
     12011-10-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        Regarding constructor, replace [ConstructorWith=...] IDL with [CallWith=...] IDL
     4        https://bugs.webkit.org/show_bug.cgi?id=69801
     5
     6        As for constructors, [ConstructorWith=...] has the same meaning as [CallWith=...].
     7        We should deprecate [ConstructorWith=...]. This is a clean-up bug for the bug 65839.
     8
     9        Reviewed by Adam Barth.
     10
     11        No new tests, since no change in behavior.
     12
     13        * bindings/scripts/CodeGeneratorV8.pm: Replaced [ConstructorWith=...] IDL with [CallWith=...] IDL.
     14        (GenerateConstructorCallback):
     15        * bindings/scripts/test/TestInterface.idl: Ditto.
     16        * fileapi/FileReader.idl: Ditto.
     17        * p2p/PeerConnection.idl: Ditto.
     18        * page/EventSource.idl: Ditto.
     19        * workers/Worker.idl: Ditto.
     20
    1212011-10-13  Kentaro Hara  <haraken@chromium.org>
    222
  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r97423 r97424  
    15491549
    15501550    my @contextArgument;
    1551     if ($dataNode->extendedAttributes->{"ConstructorWith"} && $dataNode->extendedAttributes->{"ConstructorWith"} eq "ScriptExecutionContext") {
     1551    if ($dataNode->extendedAttributes->{"CallWith"} && $dataNode->extendedAttributes->{"CallWith"} eq "ScriptExecutionContext") {
    15521552        push(@contextArgument, "context");
    15531553        push(@implContent, <<END);
  • trunk/Source/WebCore/bindings/scripts/test/TestInterface.idl

    r94156 r97424  
    3535        CallWith=ScriptExecutionContext,
    3636        Constructor(in DOMString str1, in [Optional=CallWithDefaultValue] DOMString str2),
    37         ConstructorWith=ScriptExecutionContext,
    3837        V8ConstructorSetsActiveDOMWrapper,
    3938        ConstructorRaisesException
  • trunk/Source/WebCore/fileapi/FileReader.idl

    r94375 r97424  
    3939        NoStaticTables,
    4040        Constructor,
    41         ConstructorWith=ScriptExecutionContext,
    4241        V8ConstructorSetsActiveDOMWrapper
    4342    ] FileReader {
  • trunk/Source/WebCore/p2p/PeerConnection.idl

    r97305 r97424  
    3131        ConstructorParameters=2,
    3232        Constructor(in DOMString serverConfiguration, in [Callback=FunctionOnly] SignalingCallback signalingCallback),
    33         ConstructorWith=ScriptExecutionContext,
     33        CallWith=ScriptExecutionContext,
    3434        JSCustomConstructor,
    3535        V8ConstructorSetsActiveDOMWrapper,
  • trunk/Source/WebCore/page/EventSource.idl

    r96788 r97424  
    3838        ConstructorParameters=1,
    3939        Constructor(in DOMString scriptUrl),
    40         ConstructorWith=ScriptExecutionContext,
     40        CallWith=ScriptExecutionContext,
    4141        ConstructorRaisesException,
    4242        V8ConstructorSetsActiveDOMWrapper,
  • trunk/Source/WebCore/workers/Worker.idl

    r96788 r97424  
    3535        ConstructorParameters=1,
    3636        Constructor(in DOMString scriptUrl),
    37         ConstructorWith=ScriptExecutionContext,
     37        CallWith=ScriptExecutionContext,
    3838        ConstructorRaisesException,
    3939        V8ConstructorSetsActiveDOMWrapper,
Note: See TracChangeset for help on using the changeset viewer.