Changeset 97431 in webkit


Ignore:
Timestamp:
Oct 13, 2011 5:57:31 PM (12 years ago)
Author:
haraken@chromium.org
Message:

Implement an OverflowEvent constructor for V8
https://bugs.webkit.org/show_bug.cgi?id=70017

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/events/constructors/overflow-event-constructor.html

  • bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
  • dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.

LayoutTests:

Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.

  • platform/chromium/test_expectations.txt:
Location:
trunk
Files:
5 edited

Legend:

Unmodified
Added
Removed
  • trunk/LayoutTests/ChangeLog

    r97419 r97431  
     12011-10-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        Implement an OverflowEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=70017
     5
     6        Reviewed by Adam Barth.
     7
     8        Enabled overflow-event-constructor.html, since now V8 has the OverflowEvent constructor.
     9
     10        * platform/chromium/test_expectations.txt:
     11
    1122011-10-13  Kentaro Hara  <haraken@chromium.org>
    213
  • trunk/LayoutTests/platform/chromium/test_expectations.txt

    r97419 r97431  
    9292BUGCR10395 SKIP : svg/custom/image-with-prefix-in-webarchive.svg = PASS FAIL
    9393BUGCR10395 SKIP : http/tests/webarchive = PASS FAIL
    94 
    95 // This will soon be fixed after implementing an OverflowEvent constructor for V8.
    96 BUGWK69907 : fast/events/constructors/overflow-event-constructor.html = FAIL
    9794
    9895// According to the Chromium bug, we need to write some sort of workaround for
  • trunk/Source/WebCore/ChangeLog

    r97429 r97431  
     12011-10-13  Kentaro Hara  <haraken@chromium.org>
     2
     3        Implement an OverflowEvent constructor for V8
     4        https://bugs.webkit.org/show_bug.cgi?id=70017
     5
     6        Reviewed by Adam Barth.
     7
     8        Test: fast/events/constructors/overflow-event-constructor.html
     9
     10        * bindings/v8/custom/V8EventConstructors.cpp: Added an OverflowEvent constructor.
     11        * dom/OverflowEvent.idl: Replaced 'JSCustomConstructor' with 'CustomConstructor'.
     12
    1132011-10-13  Anantanarayanan G Iyengar  <ananta@chromium.org>
    214
  • trunk/Source/WebCore/bindings/v8/custom/V8EventConstructors.cpp

    r97419 r97431  
    4040#include "HashChangeEvent.h"
    4141#include "Node.h"
     42#include "OverflowEvent.h"
    4243#include "PageTransitionEvent.h"
    4344#include "PopStateEvent.h"
     
    5758#include "V8HashChangeEvent.h"
    5859#include "V8Node.h"
     60#include "V8OverflowEvent.h"
    5961#include "V8PageTransitionEvent.h"
    6062#include "V8PopStateEvent.h"
     
    127129INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_WEBKIT_TRANSITION_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    128130INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_BEFORE_LOAD_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
     131INSTANTIATE_INITIALIZING_CONSTRUCTOR_FOR_OVERFLOW_EVENT(DICTIONARY_START, DICTIONARY_END, FILL_PARENT_PROPERTIES, FILL_PROPERTY)
    129132
    130133
  • trunk/Source/WebCore/dom/OverflowEvent.idl

    r97356 r97431  
    2828    interface [
    2929        CanBeConstructed,
    30         JSCustomConstructor
     30        CustomConstructor
    3131    ] OverflowEvent : Event {
    3232        const unsigned short HORIZONTAL = 0;
Note: See TracChangeset for help on using the changeset viewer.