Changeset 98985 in webkit


Ignore:
Timestamp:
Nov 1, 2011 11:39:34 AM (12 years ago)
Author:
arv@chromium.org
Message:

Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
​https://bugs.webkit.org/show_bug.cgi?id=64628

Reviewed by Adam Barth.

Covered by existing tests.

  • html/canvas/CanvasRenderingContext2D.idl:
Location:
trunk/Source/WebCore
Files:
2 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r98980 r98985  
     12011-11-01  Erik Arvidsson  <arv@chromium.org>
     2
     3        Remove LegacyDefaultOptionalArguments flag from CanvasRenderingContext2d
     4        https://bugs.webkit.org/show_bug.cgi?id=64628
     5
     6        Reviewed by Adam Barth.
     7
     8        Covered by existing tests.
     9
     10        * html/canvas/CanvasRenderingContext2D.idl:
     11
    1122011-11-01  Julien Chaffraix  <jchaffraix@webkit.org>
    213

  • trunk/Source/WebCore/html/canvas/CanvasRenderingContext2D.idl

    r98617 r98985  
    2727
    2828    interface [
    29         LegacyDefaultOptionalArguments,
    3029        InterfaceUUID=98fb48ae-7216-489c-862b-8e1217fc4443,
    3130        ImplementationUUID=ab4f0781-152f-450e-9546-5b3987491a54
    3231    ] CanvasRenderingContext2D : CanvasRenderingContext {
    3332
    34         // Web Applications 1.0 draft
    35 
    3633        void save();
    3734        void restore();
    3835
    39         void scale(in float sx, in float sy);
    40         void rotate(in float angle);
    41         void translate(in float tx, in float ty);
    42         void transform(in float m11, in float m12, in float m21, in float m22, in float dx, in float dy);
    43         void setTransform(in float m11, in float m12, in float m21, in float m22, in float dx, in float dy);
     36        void scale(in [Optional=CallWithDefaultValue] float sx,
     37                   in [Optional=CallWithDefaultValue] float sy);
     38        void rotate(in [Optional=CallWithDefaultValue] float angle);
     39        void translate(in [Optional=CallWithDefaultValue] float tx,
     40                       in [Optional=CallWithDefaultValue] float ty);
     41        void transform(in [Optional=CallWithDefaultValue] float m11,
     42                       in [Optional=CallWithDefaultValue] float m12,
     43                       in [Optional=CallWithDefaultValue] float m21,
     44                       in [Optional=CallWithDefaultValue] float m22,
     45                       in [Optional=CallWithDefaultValue] float dx,
     46                       in [Optional=CallWithDefaultValue] float dy);
     47        void setTransform(in [Optional=CallWithDefaultValue] float m11,
     48                          in [Optional=CallWithDefaultValue] float m12,
     49                          in [Optional=CallWithDefaultValue] float m21,
     50                          in [Optional=CallWithDefaultValue] float m22,
     51                          in [Optional=CallWithDefaultValue] float dx,
     52                          in [Optional=CallWithDefaultValue] float dy);
    4453
    4554        attribute float globalAlpha;
    4655        attribute [ConvertNullToNullString] DOMString globalCompositeOperation;
    4756
    48         CanvasGradient createLinearGradient(in float x0, in float y0, in float x1, in float y1)
    49             raises (DOMException);
    50         CanvasGradient createRadialGradient(in float x0, in float y0, in float r0, in float x1, in float y1, in float r1)
     57        CanvasGradient createLinearGradient(in [Optional=CallWithDefaultValue] float x0,
     58                                            in [Optional=CallWithDefaultValue] float y0,
     59                                            in [Optional=CallWithDefaultValue] float x1,
     60                                            in [Optional=CallWithDefaultValue] float y1)
     61            raises (DOMException);
     62        CanvasGradient createRadialGradient(in [Optional=CallWithDefaultValue] float x0,
     63                                            in [Optional=CallWithDefaultValue] float y0,
     64                                            in [Optional=CallWithDefaultValue] float r0,
     65                                            in [Optional=CallWithDefaultValue] float x1,
     66                                            in [Optional=CallWithDefaultValue] float y1,
     67                                            in [Optional=CallWithDefaultValue] float r1)
    5168            raises (DOMException);
    5269
    … …  
    6784#endif
    6885
    69         void clearRect(in float x, in float y, in float width, in float height);
    70         void fillRect(in float x, in float y, in float width, in float height);
     86        void clearRect(in [Optional=CallWithDefaultValue] float x,
     87                       in [Optional=CallWithDefaultValue] float y,
     88                       in [Optional=CallWithDefaultValue] float width,
     89                       in [Optional=CallWithDefaultValue] float height);
     90        void fillRect(in [Optional=CallWithDefaultValue] float x,
     91                      in [Optional=CallWithDefaultValue] float y,
     92                      in [Optional=CallWithDefaultValue] float width,
     93                      in [Optional=CallWithDefaultValue] float height);
    7194
    7295        void beginPath();
    7396        void closePath();
    74         void moveTo(in float x, in float y);
    75         void lineTo(in float x, in float y);
    76         void quadraticCurveTo(in float cpx, in float cpy, in float x, in float y);
    77         void bezierCurveTo(in float cp1x, in float cp1y, in float cp2x, in float cp2y, in float x, in float y);
    78         void arcTo(in float x1, in float y1, in float x2, in float y2, in float radius)
    79             raises (DOMException);
    80         void rect(in float x, in float y, in float width, in float height);
    81         void arc(in float x, in float y, in float radius, in float startAngle, in float endAngle, in boolean anticlockwise)
     97        void moveTo(in [Optional=CallWithDefaultValue] float x,
     98                    in [Optional=CallWithDefaultValue] float y);
     99        void lineTo(in [Optional=CallWithDefaultValue] float x,
     100                    in [Optional=CallWithDefaultValue] float y);
     101        void quadraticCurveTo(in [Optional=CallWithDefaultValue] float cpx,
     102                              in [Optional=CallWithDefaultValue] float cpy,
     103                              in [Optional=CallWithDefaultValue] float x,
     104                              in [Optional=CallWithDefaultValue] float y);
     105        void bezierCurveTo(in [Optional=CallWithDefaultValue] float cp1x,
     106                           in [Optional=CallWithDefaultValue] float cp1y,
     107                           in [Optional=CallWithDefaultValue] float cp2x,
     108                           in [Optional=CallWithDefaultValue] float cp2y,
     109                           in [Optional=CallWithDefaultValue] float x,
     110                           in [Optional=CallWithDefaultValue] float y);
     111        void arcTo(in [Optional=CallWithDefaultValue] float x1,
     112                   in [Optional=CallWithDefaultValue] float y1,
     113                   in [Optional=CallWithDefaultValue] float x2,
     114                   in [Optional=CallWithDefaultValue] float y2,
     115                   in [Optional=CallWithDefaultValue] float radius)
     116            raises (DOMException);
     117        void rect(in [Optional=CallWithDefaultValue] float x,
     118                  in [Optional=CallWithDefaultValue] float y,
     119                  in [Optional=CallWithDefaultValue] float width,
     120                  in [Optional=CallWithDefaultValue] float height);
     121        void arc(in [Optional=CallWithDefaultValue] float x,
     122                 in [Optional=CallWithDefaultValue] float y,
     123                 in [Optional=CallWithDefaultValue] float radius,
     124                 in [Optional=CallWithDefaultValue] float startAngle,
     125                 in [Optional=CallWithDefaultValue] float endAngle,
     126                 in [Optional=CallWithDefaultValue] boolean anticlockwise)
    82127            raises (DOMException);
    83128        void fill();
    84129        void stroke();
    85130        void clip();
    86         boolean isPointInPath(in float x, in float y);
     131        boolean isPointInPath(in [Optional=CallWithDefaultValue] float x,
     132                              in [Optional=CallWithDefaultValue] float y);
    87133
    88134        // text
    … …  
    91137        attribute DOMString textBaseline;
    92138
    93         TextMetrics measureText(in DOMString text);
     139        TextMetrics measureText(in [Optional=CallWithDefaultValue] DOMString text);
    94140
    95141        // other
    96142
    97         void setAlpha(in float alpha);
    98         void setCompositeOperation(in DOMString compositeOperation);
     143        void setAlpha(in [Optional=CallWithDefaultValue] float alpha);
     144        void setCompositeOperation(in [Optional=CallWithDefaultValue] DOMString compositeOperation);
    99145
    100146#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
    101         void setLineWidth(in float width);
    102         void setLineCap(in DOMString cap);
    103         void setLineJoin(in DOMString join);
    104         void setMiterLimit(in float limit);
     147        void setLineWidth(in [Optional=CallWithDefaultValue] float width);
     148        void setLineCap(in [Optional=CallWithDefaultValue] DOMString cap);
     149        void setLineJoin(in [Optional=CallWithDefaultValue] DOMString join);
     150        void setMiterLimit(in [Optional=CallWithDefaultValue] float limit);
    105151#endif
    106152
    107153        void clearShadow();
    108154
    109         [RequiresAllArguments=Raise] void fillText(in DOMString text, in float x, in float y, in [Optional] float maxWidth);
    110         [RequiresAllArguments=Raise] void strokeText(in DOMString text, in float x, in float y, in [Optional] float maxWidth);
     155        void fillText(in DOMString text, in float x, in float y, in [Optional] float maxWidth);
     156        void strokeText(in DOMString text, in float x, in float y, in [Optional] float maxWidth);
    111157
    112158        void setStrokeColor(in DOMString color, in [Optional] float alpha);
    … …  
    120166        void setFillColor(in float c, in float m, in float y, in float k, in float a);
    121167
    122         void strokeRect(in float x, in float y, in float width, in float height, in [Optional] float lineWidth);
    123 
    124         [RequiresAllArguments=Raise] void drawImage(in HTMLImageElement image, in float x, in float y)
    125             raises (DOMException);
    126         [RequiresAllArguments=Raise] void drawImage(in HTMLImageElement image, in float x, in float y, in float width, in float height)
    127             raises (DOMException);
    128         [RequiresAllArguments=Raise] void drawImage(in HTMLImageElement image, in float sx, in float sy, in float sw, in float sh, in float dx, in float dy, in float dw, in float dh)
    129             raises (DOMException);
    130         [RequiresAllArguments=Raise] void drawImage(in HTMLCanvasElement canvas, in float x, in float y)
    131             raises (DOMException);
    132         [RequiresAllArguments=Raise] void drawImage(in HTMLCanvasElement canvas, in float x, in float y, in float width, in float height)
    133             raises (DOMException);
    134         [RequiresAllArguments=Raise] void drawImage(in HTMLCanvasElement canvas, in float sx, in float sy, in float sw, in float sh, in float dx, in float dy, in float dw, in float dh)
     168        void strokeRect(in [Optional=CallWithDefaultValue] float x,
     169                        in [Optional=CallWithDefaultValue] float y,
     170                        in [Optional=CallWithDefaultValue] float width,
     171                        in [Optional=CallWithDefaultValue] float height,
     172                        in [Optional] float lineWidth);
     173
     174        void drawImage(in HTMLImageElement image, in float x, in float y)
     175            raises (DOMException);
     176        void drawImage(in HTMLImageElement image, in float x, in float y, in float width, in float height)
     177            raises (DOMException);
     178        void drawImage(in HTMLImageElement image, in float sx, in float sy, in float sw, in float sh, in float dx, in float dy, in float dw, in float dh)
     179            raises (DOMException);
     180        void drawImage(in HTMLCanvasElement canvas, in float x, in float y)
     181            raises (DOMException);
     182        void drawImage(in HTMLCanvasElement canvas, in float x, in float y, in float width, in float height)
     183            raises (DOMException);
     184        void drawImage(in HTMLCanvasElement canvas, in float sx, in float sy, in float sw, in float sh, in float dx, in float dy, in float dw, in float dh)
    135185            raises (DOMException);
    136186#if defined(ENABLE_VIDEO) && ENABLE_VIDEO
    137         [RequiresAllArguments=Raise] void drawImage(in HTMLVideoElement video, in float x, in float y)
    138             raises (DOMException);
    139         [RequiresAllArguments=Raise] void drawImage(in HTMLVideoElement video, in float x, in float y, in float width, in float height)
    140             raises (DOMException);
    141         [RequiresAllArguments=Raise] void drawImage(in HTMLVideoElement video, in float sx, in float sy, in float sw, in float sh, in float dx, in float dy, in float dw, in float dh)
     187        void drawImage(in HTMLVideoElement video, in float x, in float y)
     188            raises (DOMException);
     189        void drawImage(in HTMLVideoElement video, in float x, in float y, in float width, in float height)
     190            raises (DOMException);
     191        void drawImage(in HTMLVideoElement video, in float sx, in float sy, in float sw, in float sh, in float dx, in float dy, in float dw, in float dh)
    142192            raises (DOMException);
    143193#endif
    144194
    145         [RequiresAllArguments=Raise] void drawImageFromRect(in HTMLImageElement image,
    146                                                             in [Optional] float sx, in [Optional] float sy, in [Optional] float sw, in [Optional] float sh,
    147                                                             in [Optional] float dx, in [Optional] float dy, in [Optional] float dw, in [Optional] float dh,
    148                                                             in [Optional] DOMString compositeOperation);
     195        void drawImageFromRect(in HTMLImageElement image,
     196                               in [Optional] float sx, in [Optional] float sy, in [Optional] float sw, in [Optional] float sh,
     197                               in [Optional] float dx, in [Optional] float dy, in [Optional] float dw, in [Optional] float dh,
     198                               in [Optional] DOMString compositeOperation);
    149199
    150200        void setShadow(in float width, in float height, in float blur, in [Optional] DOMString color, in [Optional] float alpha);
    … …  
    177227
    178228        // pixel manipulation
    179         ImageData getImageData(in float sx, in float sy, in float sw, in float sh)
     229        ImageData getImageData(in [Optional=CallWithDefaultValue] float sx, in [Optional=CallWithDefaultValue] float sy,
     230                               in [Optional=CallWithDefaultValue] float sw, in [Optional=CallWithDefaultValue] float sh)
    180231            raises(DOMException);
    181232    };
Note: See TracChangeset for help on using the changeset viewer.