Changeset 99155 in webkit

Timestamp:

Nov 3, 2011 2:56:33 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[EFL] Enable the Page Visibility API.
​https://bugs.webkit.org/show_bug.cgi?id=69127

Patch by Dongwoo Im <​dw.im@samsung.com> on 2011-11-03
Reviewed by Adam Barth.

.:

Build system changes to support ENABLE(PAGE_VISIBILITY_API) on EFL port.

• Source/cmake/OptionsEfl.cmake: Add enabled ENABLE_PAGE_VISIBILITY_API definition.
• Source/cmakeconfig.h.cmake: ditto.

Source/WebKit/efl:

Implement methods to enable the Page Visibility API on EFL port.
(​http://www.w3.org/TR/page-visibility)

When the visibility status of the page is changed, browser could
inform the status to WebKit using the APIs below.

• ewk/ewk_view.cpp: Add setter/getter functions to query/set page visibility state.

(ewk_view_visibility_state_set): Sets the page visibility status.
(ewk_view_visibility_state_get): Gets the page visibility status.

• ewk/ewk_view.h: Add public prototypes.

LayoutTests:

• platform/efl/Skipped: Unskip all of the test cases of page visibility.

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/efl/Skipped (modified) (1 diff)
• Source/WebKit/efl/ChangeLog (modified) (1 diff)
• Source/WebKit/efl/ewk/ewk_view.cpp (modified) (1 diff)
• Source/WebKit/efl/ewk/ewk_view.h (modified) (1 diff)
• Source/cmake/OptionsEfl.cmake (modified) (1 diff)
• Source/cmakeconfig.h.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2011-11-03  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the Page Visibility API.
+        https://bugs.webkit.org/show_bug.cgi?id=69127
+
+        Reviewed by Adam Barth.
+
+        Build system changes to support ENABLE(PAGE_VISIBILITY_API) on EFL port.
+
+        * Source/cmake/OptionsEfl.cmake: Add enabled ENABLE_PAGE_VISIBILITY_API definition.
+        * Source/cmakeconfig.h.cmake: ditto.
+
 2011-10-28  Adam Barth  <abarth@webkit.org>
 

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-03  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the Page Visibility API.
+        https://bugs.webkit.org/show_bug.cgi?id=69127
+
+        Reviewed by Adam Barth.
+
+        * platform/efl/Skipped: Unskip all of the test cases of page visibility.
+
 2011-11-03  Andrey Kosyakov  <caseq@chromium.org>
 

trunk/LayoutTests/platform/efl/Skipped

@@ -1081 +1081 @@
 webarchive
 
-# The EFL port has no support for the Page Visibility API
-fast/events/page-visibility-iframe-delete-test.html
-fast/events/page-visibility-iframe-move-test.html
-fast/events/page-visibility-iframe-propagation-test.html
-fast/events/page-visibility-transition-test.html
-
 # The EFL port has no support for webtiming
 fast/dom/Window/window-properties-performance.html

trunk/Source/WebKit/efl/ChangeLog

@@ +1 @@
+2011-11-03  Dongwoo Im  <dw.im@samsung.com>
+
+        [EFL] Enable the Page Visibility API.
+        https://bugs.webkit.org/show_bug.cgi?id=69127
+
+        Reviewed by Adam Barth.
+
+        Implement methods to enable the Page Visibility API on EFL port.
+        (http://www.w3.org/TR/page-visibility)
+
+        When the visibility status of the page is changed, browser could
+        inform the status to WebKit using the APIs below.
+
+        * ewk/ewk_view.cpp: Add setter/getter functions to query/set page visibility state.
+        (ewk_view_visibility_state_set): Sets the page visibility status.
+        (ewk_view_visibility_state_get): Gets the page visibility status.
+        * ewk/ewk_view.h: Add public prototypes.
+
 2011-11-02  Tom Sepez  <tsepez@chromium.org>
 

trunk/Source/WebKit/efl/ewk/ewk_view.cpp

@@ -3875 +3875 @@
 }
 
+Eina_Bool ewk_view_visibility_state_set(Evas_Object* ewkView, Ewk_Page_Visibility_State pageVisibleState, Eina_Bool initialState)
+{
+#if ENABLE(PAGE_VISIBILITY_API)
+    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EINA_FALSE);
+    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EINA_FALSE);
+
+    switch (pageVisibleState) {
+    case EWK_PAGE_VISIBILITY_STATE_VISIBLE:
+        priv->page->setVisibilityState(WebCore::PageVisibilityStateVisible, initialState);
+        break;
+    case EWK_PAGE_VISIBILITY_STATE_HIDDEN:
+        priv->page->setVisibilityState(WebCore::PageVisibilityStateHidden, initialState);
+        break;
+    case EWK_PAGE_VISIBILITY_STATE_PRERENDER:
+        priv->page->setVisibilityState(WebCore::PageVisibilityStatePrerender, initialState);
+        break;
+    default:
+        return EINA_FALSE;
+    }
+
+    return EINA_TRUE;
+#else
+    DBG("PAGE_VISIBILITY_API is disabled.");
+    return EINA_FALSE;
+#endif
+}
+
+Ewk_Page_Visibility_State ewk_view_visibility_state_get(const Evas_Object* ewkView)
+{
+#if ENABLE(PAGE_VISIBILITY_API)
+    EWK_VIEW_SD_GET_OR_RETURN(ewkView, smartData, EWK_PAGE_VISIBILITY_STATE_VISIBLE);
+    EWK_VIEW_PRIV_GET_OR_RETURN(smartData, priv, EWK_PAGE_VISIBILITY_STATE_VISIBLE);
+
+    switch (priv->page->visibilityState()) {
+    case WebCore::PageVisibilityStateVisible:
+        return EWK_PAGE_VISIBILITY_STATE_VISIBLE;
+    case WebCore::PageVisibilityStateHidden:
+        return EWK_PAGE_VISIBILITY_STATE_HIDDEN;
+    case WebCore::PageVisibilityStatePrerender:
+        return EWK_PAGE_VISIBILITY_STATE_PRERENDER;
+    default:
+        return EWK_PAGE_VISIBILITY_STATE_VISIBLE;
+    }
+#else
+    DBG("PAGE_VISIBILITY_API is disabled.");
+    return EWK_PAGE_VISIBILITY_STATE_VISIBLE;
+#endif
+}
+
 namespace EWKPrivate {
 

trunk/Source/WebKit/efl/ewk/ewk_view.h

@@ -2219 +2219 @@
 EAPI Eina_Bool ewk_view_protocol_handler_unset(Evas_Object* o);
 
+/// Defines the page visibility status.
+enum _Ewk_Page_Visibility_State {
+    EWK_PAGE_VISIBILITY_STATE_VISIBLE,
+    EWK_PAGE_VISIBILITY_STATE_HIDDEN,
+    EWK_PAGE_VISIBILITY_STATE_PRERENDER
+};
+/// Creates a type name for @a _Ewk_Page_Visibility_State.
+typedef enum _Ewk_Page_Visibility_State Ewk_Page_Visibility_State;
+
+/**
+ * Sets the visibility state of the page.
+ *
+ * This function let WebKit knows the visibility status of the page.
+ * WebKit will save the current status, and fire a "visibilitychange"
+ * event which web application can listen. Web application could slow
+ * down or stop itself when it gets a "visibilitychange" event and its
+ * visibility state is hidden. If its visibility state is visible, then
+ * the web application could use more resources.
+ *
+ * This feature makes that web application could use the resources efficiently,
+ * such as power, CPU, and etc.
+ *
+ * If more detailed description is needed, please see the specification.
+ * (http://www.w3.org/TR/page-visibility)
+ *
+ * @param o view object to set the visibility state.
+ * @param page_visible_state the visible state of the page to set.
+ * @param initial_state @c EINA_TRUE if this function is called at page initialization time,
+ *                      @c EINA_FALSE otherwise.
+ *
+ * @return @c EINA_TRUE on success or @c EINA_FALSE on failure.
+ */
+EAPI Eina_Bool ewk_view_visibility_state_set(Evas_Object* o, Ewk_Page_Visibility_State page_visible_state, Eina_Bool initial_state);
+
+/**
+ * Gets the visibility state of the page.
+ *
+ * @param o view object
+ *
+ * @return enum value of @a Ewk_Page_Visibility_State that indicates current visibility status of the page.
+ *
+ * @see ewk_view_visibility_state_set()
+ */
+EAPI Ewk_Page_Visibility_State ewk_view_visibility_state_get(const Evas_Object *o);
+
 #ifdef __cplusplus
 }

trunk/Source/cmake/OptionsEfl.cmake

@@ -84 +84 @@
 WEBKIT_FEATURE(ENABLE_NOTIFICATIONS "Enable notifications" DEFAULT OFF)
 WEBKIT_FEATURE(ENABLE_ORIENTATION_EVENTS "Enable orientation events" DEFAULT OFF)
+WEBKIT_FEATURE(ENABLE_PAGE_VISIBILITY_API "Enable Page Visibility API" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_PROGRESS_TAG "Enable progress tag" DEFAULT ON)
 WEBKIT_FEATURE(ENABLE_SHARED_WORKERS "Enable shared workers" DEFAULT ON)

trunk/Source/cmakeconfig.h.cmake

@@ -31 +31 @@
 #cmakedefine01 ENABLE_NOTIFICATIONS
 #cmakedefine01 ENABLE_ORIENTATION_EVENTS
+#cmakedefine01 ENABLE_PAGE_VISIBILITY_API
 #cmakedefine01 ENABLE_PROGRESS_TAG
 #cmakedefine01 ENABLE_SHARED_WORKERS