Changeset 99207 in webkit

Timestamp:

Nov 3, 2011 10:06:51 AM (13 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] Show url of history items in a status bar in MiniBrowser
​https://bugs.webkit.org/show_bug.cgi?id=71474

Reviewed by Martin Robinson.

• MiniBrowser/gtk/BrowserWindow.c:

(browserWindowSetStatusText): Set status text and show/hide the
status label.
(resetStatusText): Reset status text when history menu is hidden.
(browserWindowHistoryItemSelected): Show url of currently selected
history item.
(browserWindowCreateBackForwardMenu): Connect to hide signal of
menu to reset the status text.
(browserWindowConstructed): Use GtkOverlay if available to show
status text.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• MiniBrowser/gtk/BrowserWindow.c (modified) (6 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] Show url of history items in a status bar in MiniBrowser
+        https://bugs.webkit.org/show_bug.cgi?id=71474
+
+        Reviewed by Martin Robinson.
+
+        * MiniBrowser/gtk/BrowserWindow.c:
+        (browserWindowSetStatusText): Set status text and show/hide the
+        status label.
+        (resetStatusText): Reset status text when history menu is hidden.
+        (browserWindowHistoryItemSelected): Show url of currently selected
+        history item.
+        (browserWindowCreateBackForwardMenu): Connect to hide signal of
+        menu to reset the status text.
+        (browserWindowConstructed): Use GtkOverlay if available to show
+        status text.
+
 2011-11-03  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/MiniBrowser/gtk/BrowserWindow.c

@@ -41 +41 @@
     GtkWidget *backItem;
     GtkWidget *forwardItem;
+    GtkWidget *statusLabel;
     WebKitWebView *webView;
 
@@ -52 +53 @@
 
 G_DEFINE_TYPE(BrowserWindow, browser_window, GTK_TYPE_WINDOW)
+
+static void browserWindowSetStatusText(BrowserWindow *window, const char *text)
+{
+#if GTK_CHECK_VERSION(3, 2, 0)
+    gtk_label_set_text(GTK_LABEL(window->statusLabel), text);
+    gtk_widget_set_visible(window->statusLabel, !!text);
+#endif
+}
+
+static void resetStatusText(GtkWidget *widget, BrowserWindow *window)
+{
+    browserWindowSetStatusText(window, NULL);
+}
 
 static void activateUriEntryCallback(BrowserWindow *window)
@@ -85 +99 @@
     if (progress == 1.0)
         g_timeout_add(500, (GSourceFunc)resetEntryProgress, window->uriEntry);
+}
+
+static void browserWindowHistoryItemSelected(BrowserWindow *window, GtkMenuItem *item)
+{
+    GtkAction *action = gtk_activatable_get_related_action(GTK_ACTIVATABLE(item));
+    browserWindowSetStatusText(window, action ? gtk_action_get_name(action) : NULL);
 }
 
@@ -113 +133 @@
 
         GtkWidget *menuItem = gtk_action_create_menu_item(action);
+        g_signal_connect_swapped(menuItem, "select", G_CALLBACK(browserWindowHistoryItemSelected), window);
         g_object_unref(action);
 
@@ -118 +139 @@
         gtk_widget_show(menuItem);
     }
+
+    /* FIXME: This shoulnd't be necessary when didMouseMoveOverElement
+     * is implemented in WebKit2 GTK+ API.
+     */
+    g_signal_connect(menu, "hide", G_CALLBACK(resetStatusText), window);
 
     return menu;
@@ -235 +261 @@
     g_signal_connect(backForwadlist, "changed", G_CALLBACK(backForwadlistChanged), window);
 
+#if GTK_CHECK_VERSION(3, 2, 0)
+    GtkWidget *overlay = gtk_overlay_new();
+    gtk_box_pack_start(GTK_BOX(window->mainBox), overlay, TRUE, TRUE, 0);
+    gtk_widget_show(overlay);
+
+    window->statusLabel = gtk_label_new(NULL);
+    gtk_widget_set_halign(window->statusLabel, GTK_ALIGN_START);
+    gtk_widget_set_valign(window->statusLabel, GTK_ALIGN_END);
+    gtk_widget_set_margin_left(window->statusLabel, 1);
+    gtk_widget_set_margin_right(window->statusLabel, 1);
+    gtk_widget_set_margin_top(window->statusLabel, 1);
+    gtk_widget_set_margin_bottom(window->statusLabel, 1);
+    gtk_overlay_add_overlay(GTK_OVERLAY(overlay), window->statusLabel);
+
+    gtk_container_add(GTK_CONTAINER(overlay), GTK_WIDGET(window->webView));
+#else
     gtk_box_pack_start(GTK_BOX(window->mainBox), GTK_WIDGET(window->webView), TRUE, TRUE, 0);
+#endif
     gtk_widget_show(GTK_WIDGET(window->webView));
 }