Changeset 99310 in webkit


Ignore:
Timestamp:
Nov 4, 2011 12:53:21 PM (12 years ago)
Author:
commit-queue@webkit.org
Message:

Send the submissions character encoding in hidden _charset_ field.
​https://bugs.webkit.org/show_bug.cgi?id=19079

Patch by Vineet Chaudhary <​vineet.chaudhary@motorola.com> on 2011-11-04
Reviewed by Darin Adler.

Source/WebCore:

Spec reference ​http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.

Tests: http/tests/misc/char-encoding-in-hidden-charset-field-default.html

http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html
http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html
http/tests/misc/char-encoding-in-text-charset-field-with-value.html
http/tests/misc/char-encoding-without-charset-field.html

  • html/HiddenInputType.cpp:

(WebCore::HiddenInputType::isHiddenType):
(WebCore::HiddenInputType::appendFormData): For _charset_ send value as respective encodingType.

  • html/HiddenInputType.h: Override appendFormData for hidden control types.

LayoutTests:

Spec reference ​http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
If _charset_ used as the name of a hidden control it should send character encoding
as value while submissions.
Added test cases to check this behavior.

  • http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-default.html: Added. For Default Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html: Added. For Big5 Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html: Added. For EUC-JP Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html: Added. For ISO-2022-JP Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html: Added. For Shift_JIS Encoding.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html: Added. For two input fields.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html: Added. For GET method.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field-expected.txt: Added.
  • http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html: Added. For one input fields.
  • http/tests/misc/char-encoding-in-text-charset-field-with-value-expected.txt: Added.
  • http/tests/misc/char-encoding-in-text-charset-field-with-value.html: Added. If input type is text.
  • http/tests/misc/char-encoding-without-charset-field-expected.txt: Added.
  • http/tests/misc/char-encoding-without-charset-field.html: Added. If no hidden input field.
  • http/tests/misc/resources/char-encoding-in-hidden-charset-field.php: Added. Server side script for test.
Location:
trunk
Files:
21 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r99309 r99310  
     12011-11-04  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        Send the submissions character encoding in hidden _charset_ field.
     4        https://bugs.webkit.org/show_bug.cgi?id=19079
     5
     6        Reviewed by Darin Adler.
     7
     8        Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
     9        If _charset_ used as the name of a hidden control it should send character encoding
     10        as value while submissions.
     11        Added test cases to check this behavior.
     12
     13        * http/tests/misc/char-encoding-in-hidden-charset-field-default-expected.txt: Added.
     14        * http/tests/misc/char-encoding-in-hidden-charset-field-default.html: Added. For Default Encoding.
     15        * http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5-expected.txt: Added.
     16        * http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html: Added. For Big5 Encoding.
     17        * http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP-expected.txt: Added.
     18        * http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html: Added. For EUC-JP Encoding.
     19        * http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP-expected.txt: Added.
     20        * http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html: Added. For ISO-2022-JP Encoding.
     21        * http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS-expected.txt: Added.
     22        * http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html: Added. For Shift_JIS Encoding.
     23        * http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset-expected.txt: Added.
     24        * http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html: Added. For two input fields.
     25        * http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method-expected.txt: Added.
     26        * http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html: Added. For GET method.
     27        * http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field-expected.txt: Added.
     28        * http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html: Added. For one input fields.
     29        * http/tests/misc/char-encoding-in-text-charset-field-with-value-expected.txt: Added.
     30        * http/tests/misc/char-encoding-in-text-charset-field-with-value.html: Added. If input type is text.
     31        * http/tests/misc/char-encoding-without-charset-field-expected.txt: Added.
     32        * http/tests/misc/char-encoding-without-charset-field.html: Added. If no hidden input field.
     33        * http/tests/misc/resources/char-encoding-in-hidden-charset-field.php: Added. Server side script for test.
     34
    1352011-11-04  Pavel Feldman  <pfeldman@chromium.org>
    236

  • trunk/Source/WebCore/ChangeLog

    r99308 r99310  
     12011-11-04  Vineet Chaudhary  <vineet.chaudhary@motorola.com>
     2
     3        Send the submissions character encoding in hidden _charset_ field.
     4        https://bugs.webkit.org/show_bug.cgi?id=19079
     5
     6        Reviewed by Darin Adler.
     7
     8        Spec reference http://dev.w3.org/html5/spec/Overview.html#attr-fe-name-charset
     9        If _charset_ used as the name of a hidden control it should send character encoding
     10        as value while submissions.
     11
     12        Tests: http/tests/misc/char-encoding-in-hidden-charset-field-default.html
     13               http/tests/misc/char-encoding-in-hidden-charset-field-with-Big5.html
     14               http/tests/misc/char-encoding-in-hidden-charset-field-with-EUC-JP.html
     15               http/tests/misc/char-encoding-in-hidden-charset-field-with-ISO-2022-JP.html
     16               http/tests/misc/char-encoding-in-hidden-charset-field-with-Shift_JIS.html
     17               http/tests/misc/char-encoding-in-hidden-charset-field-with-accept-charset.html
     18               http/tests/misc/char-encoding-in-hidden-charset-field-with-get-method.html
     19               http/tests/misc/char-encoding-in-hidden-charset-field-with-one-field.html
     20               http/tests/misc/char-encoding-in-text-charset-field-with-value.html
     21               http/tests/misc/char-encoding-without-charset-field.html
     22
     23        * html/HiddenInputType.cpp:
     24        (WebCore::HiddenInputType::isHiddenType):
     25        (WebCore::HiddenInputType::appendFormData): For _charset_ send value as respective encodingType.
     26        * html/HiddenInputType.h: Override appendFormData for hidden control types.
     27
    1282011-11-04  Robert Sesek  <rsesek@chromium.org>
    229

  • trunk/Source/WebCore/html/HiddenInputType.cpp

    r95901 r99310  
    3333#include "HiddenInputType.h"
    3434
     35#include "FormDataList.h"
    3536#include "HTMLInputElement.h"
    3637#include "HTMLNames.h"
    … …  
    8586}
    8687
     88bool HiddenInputType::appendFormData(FormDataList& encoding, bool isMultipartForm) const
     89{
     90    if (equalIgnoringCase(element()->name(), "_charset_")) {
     91        encoding.appendData(element()->name(), String(encoding.encoding().name()));
     92        return true;
     93    }
     94    return InputType::appendFormData(encoding, isMultipartForm);
     95}
     96
    8797bool HiddenInputType::shouldRespectHeightAndWidthAttributes()
    8898{

  • trunk/Source/WebCore/html/HiddenInputType.h

    r95901 r99310  
    5151    virtual bool shouldRespectHeightAndWidthAttributes();
    5252    virtual void setValue(const String&, bool, bool);
     53    virtual bool appendFormData(FormDataList&, bool) const;
    5354};
    5455
Note: See TracChangeset for help on using the changeset viewer.