Changeset 99384 in webkit

Timestamp:

Nov 6, 2011 2:27:34 PM (13 years ago)

Author:

Darin Adler

Message:

Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
​https://bugs.webkit.org/show_bug.cgi?id=71260

Reviewed by Mark Rowe.

Memory leak fix covered by existing tests.

• rendering/RenderFlowThread.cpp:

(WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
Instead of calling remove, call take and then delete, since the
values of the map are owned and need to be deleted when removed.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderFlowThread.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-06  Darin Adler  <darin@apple.com>
+
+        Leaks seen in RenderFlowThread::setRegionRangeForBox on Leaks bot
+        https://bugs.webkit.org/show_bug.cgi?id=71260
+
+        Reviewed by Mark Rowe.
+
+        Memory leak fix covered by existing tests.
+
+        * rendering/RenderFlowThread.cpp:
+        (WebCore::RenderFlowThread::removeRenderBoxRegionInfo):
+        Instead of calling remove, call take and then delete, since the
+        values of the map are owned and need to be deleted when removed.
+
 2011-11-06  Adam Barth  <abarth@webkit.org>
 

trunk/Source/WebCore/rendering/RenderFlowThread.cpp

@@ -635 +635 @@
     }
     
-    m_regionRangeMap.remove(box);
+    delete m_regionRangeMap.take(box);
 }