Changeset 99667 in webkit

Timestamp:

Nov 9, 2011 12:56:36 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Select multiple options with mouse drag in Select element.
​https://bugs.webkit.org/show_bug.cgi?id=71128

Patch by Rakesh KN <​rakesh.kn@motorola.com> on 2011-11-09
Reviewed by Ryosuke Niwa.

Multiple selection of option elements in select element with an mouse drag.
Other browsers(IE, Firefox, Opera) support this feature.

Source/WebCore:

Test: fast/forms/select-multiple-elements-with-mouse-drag.html

• page/EventHandler.cpp:

(WebCore::EventHandler::handleMouseDraggedEvent):
Allow auto scroll to be fired if current node(option) under mouse does not have renderer
but its container node(select) can autoscroll and has renderer for specific case of ListBox

LayoutTests:

• fast/forms/select-multiple-elements-with-mouse-drag-expected.txt: Added.
• fast/forms/select-multiple-elements-with-mouse-drag.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag-expected.txt (added)
• LayoutTests/fast/forms/select-multiple-elements-with-mouse-drag.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/page/EventHandler.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2011-11-09  Rakesh KN  <rakesh.kn@motorola.com>
+
+        Select multiple options with mouse drag in Select element.
+        https://bugs.webkit.org/show_bug.cgi?id=71128
+
+        Reviewed by Ryosuke Niwa.
+
+        Multiple selection of option elements in select element with an mouse drag.
+        Other browsers(IE, Firefox, Opera) support this feature.
+
+        * fast/forms/select-multiple-elements-with-mouse-drag-expected.txt: Added.
+        * fast/forms/select-multiple-elements-with-mouse-drag.html: Added.
+
 2011-11-08  Yuta Kitamura  <yutak@chromium.org>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2011-11-09  Rakesh KN  <rakesh.kn@motorola.com>
+
+        Select multiple options with mouse drag in Select element.
+        https://bugs.webkit.org/show_bug.cgi?id=71128
+
+        Reviewed by Ryosuke Niwa.
+
+        Multiple selection of option elements in select element with an mouse drag.
+        Other browsers(IE, Firefox, Opera) support this feature.
+
+        Test: fast/forms/select-multiple-elements-with-mouse-drag.html
+
+        * page/EventHandler.cpp:
+        (WebCore::EventHandler::handleMouseDraggedEvent):
+        Allow auto scroll to be fired if current node(option) under mouse does not have renderer
+        but its container node(select) can autoscroll and has renderer for specific case of ListBox
+
 2011-11-09  Simon Hausmann  <simon.hausmann@nokia.com>
 

trunk/Source/WebCore/page/EventHandler.cpp

@@ -558 +558 @@
 
     Node* targetNode = EventHandler::targetNode(event);
-    if (event.event().button() != LeftButton || !targetNode || !targetNode->renderer())
-        return false;
+    if (event.event().button() != LeftButton || !targetNode)
+        return false;
+
+    RenderObject* renderer = targetNode->renderer();
+    if (!renderer) {
+        renderer = targetNode->parentNode() ? targetNode->parentNode()->renderer() : 0;
+        if (!renderer || !renderer->isListBox())
+            return false;
+    }
 
 #if PLATFORM(MAC) // FIXME: Why does this assertion fire on other platforms?
@@ -569 +576 @@
     if (m_mouseDownMayStartAutoscroll && !m_panScrollInProgress) {            
         // Find a renderer that can autoscroll.
-        RenderObject* renderer = targetNode->renderer();
         while (renderer && !canAutoscroll(renderer)) {
             if (!renderer->parent() && renderer->node() == renderer->document() && renderer->document()->ownerElement())