Changeset 99732 in webkit


Ignore:
Timestamp:
Nov 9, 2011 10:07:12 AM (13 years ago)
Author:
haraken@chromium.org
Message:

Remove redundant [CanBeConstructed] IDLs
​https://bugs.webkit.org/show_bug.cgi?id=71868

Reviewed by Adam Barth.

If a class has [Constructor] or [CustomConstructor],
then [CanBeConstructed] is not necessary.
This patch just removes [CanBeConstructed] from all the classes
that already have [Constructor] or [CustomConstructor].

No tests. No change in behavior.

  • bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch.
  • bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result.

(WebCore::ConfigureV8TestObjTemplate):

  • css/WebKitCSSMatrix.idl:
  • dom/BeforeLoadEvent.idl:
  • dom/CustomEvent.idl:
  • dom/ErrorEvent.idl:
  • dom/Event.idl:
  • dom/HashChangeEvent.idl:
  • dom/MessageChannel.idl:
  • dom/MessageEvent.idl:
  • dom/OverflowEvent.idl:
  • dom/PageTransitionEvent.idl:
  • dom/PopStateEvent.idl:
  • dom/ProgressEvent.idl:
  • dom/WebKitAnimationEvent.idl:
  • dom/WebKitMutationObserver.idl:
  • dom/WebKitTransitionEvent.idl:
  • fileapi/FileReader.idl:
  • html/DOMFormData.idl:
  • html/TextTrackCue.idl:
  • html/canvas/ArrayBuffer.idl:
  • html/canvas/DataView.idl:
  • html/canvas/Float32Array.idl:
  • html/canvas/Float64Array.idl:
  • html/canvas/Int16Array.idl:
  • html/canvas/Int32Array.idl:
  • html/canvas/Int8Array.idl:
  • html/canvas/Uint16Array.idl:
  • html/canvas/Uint32Array.idl:
  • html/canvas/Uint8Array.idl:
  • html/track/TrackEvent.idl:
  • mediastream/PeerConnection.idl:
  • page/EventSource.idl:
  • page/WebKitPoint.idl:
  • webaudio/AudioContext.idl:
  • websockets/CloseEvent.idl:
  • websockets/WebSocket.idl:
  • workers/SharedWorker.idl:
  • workers/Worker.idl:
  • xml/XMLHttpRequest.idl:
  • xml/XSLTProcessor.idl:
Location:
trunk/Source/WebCore
Files:
42 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r99731 r99732  
     12011-11-09  Kentaro Hara  <haraken@chromium.org>
     2
     3        Remove redundant [CanBeConstructed] IDLs
     4        https://bugs.webkit.org/show_bug.cgi?id=71868
     5
     6        Reviewed by Adam Barth.
     7
     8        If a class has [Constructor] or [CustomConstructor],
     9        then [CanBeConstructed] is not necessary.
     10        This patch just removes [CanBeConstructed] from all the classes
     11        that already have [Constructor] or [CustomConstructor].
     12
     13        No tests. No change in behavior.
     14
     15        * bindings/scripts/CodeGeneratorV8.pm: Corrected typo. This correction is required for this patch.
     16        * bindings/scripts/test/V8/V8TestObj.cpp: Updated a run-bindings-tests result.
     17        (WebCore::ConfigureV8TestObjTemplate):
     18        * css/WebKitCSSMatrix.idl:
     19        * dom/BeforeLoadEvent.idl:
     20        * dom/CustomEvent.idl:
     21        * dom/ErrorEvent.idl:
     22        * dom/Event.idl:
     23        * dom/HashChangeEvent.idl:
     24        * dom/MessageChannel.idl:
     25        * dom/MessageEvent.idl:
     26        * dom/OverflowEvent.idl:
     27        * dom/PageTransitionEvent.idl:
     28        * dom/PopStateEvent.idl:
     29        * dom/ProgressEvent.idl:
     30        * dom/WebKitAnimationEvent.idl:
     31        * dom/WebKitMutationObserver.idl:
     32        * dom/WebKitTransitionEvent.idl:
     33        * fileapi/FileReader.idl:
     34        * html/DOMFormData.idl:
     35        * html/TextTrackCue.idl:
     36        * html/canvas/ArrayBuffer.idl:
     37        * html/canvas/DataView.idl:
     38        * html/canvas/Float32Array.idl:
     39        * html/canvas/Float64Array.idl:
     40        * html/canvas/Int16Array.idl:
     41        * html/canvas/Int32Array.idl:
     42        * html/canvas/Int8Array.idl:
     43        * html/canvas/Uint16Array.idl:
     44        * html/canvas/Uint32Array.idl:
     45        * html/canvas/Uint8Array.idl:
     46        * html/track/TrackEvent.idl:
     47        * mediastream/PeerConnection.idl:
     48        * page/EventSource.idl:
     49        * page/WebKitPoint.idl:
     50        * webaudio/AudioContext.idl:
     51        * websockets/CloseEvent.idl:
     52        * websockets/WebSocket.idl:
     53        * workers/SharedWorker.idl:
     54        * workers/Worker.idl:
     55        * xml/XMLHttpRequest.idl:
     56        * xml/XSLTProcessor.idl:
     57
    1582011-11-09  Ken Buchanan  <kenrb@chromium.org>
    259

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorV8.pm

    r99673 r99732  
    23802380END
    23812381
    2382     if ($dataNode->extendedAttributes->{"CanBeConstructed"} || $dataNode->extendedAttributes->{"CustomConstructor"} || $dataNode->extendedAttributes->{"V8CustomConstructor"} || $dataNode->extendedAttributes->{"Constructer"}) {
     2382    if ($dataNode->extendedAttributes->{"CanBeConstructed"} || $dataNode->extendedAttributes->{"CustomConstructor"} || $dataNode->extendedAttributes->{"V8CustomConstructor"} || $dataNode->extendedAttributes->{"Constructor"}) {
    23832383        push(@implContent, <<END);
    23842384    desc->SetCallHandler(V8${interfaceName}::constructorCallback);

  • trunk/Source/WebCore/bindings/scripts/test/V8/V8TestObj.cpp

    r99673 r99732  
    15171517        TestObjCallbacks, WTF_ARRAY_LENGTH(TestObjCallbacks));
    15181518    UNUSED_PARAM(defaultSignature); // In some cases, it will not be used.
     1519    desc->SetCallHandler(V8TestObj::constructorCallback);
    15191520    v8::Local<v8::ObjectTemplate> instance = desc->InstanceTemplate();
    15201521    v8::Local<v8::ObjectTemplate> proto = desc->PrototypeTemplate();

  • trunk/Source/WebCore/css/WebKitCSSMatrix.idl

    r98679 r99732  
    2828    // Introduced in DOM Level ?:
    2929    interface [
    30         CanBeConstructed,
    3130        ConstructorParameters=1,
    3231        Constructor(in [Optional=CallWithNullValue] DOMString cssValue),

  • trunk/Source/WebCore/dom/BeforeLoadEvent.idl

    r99389 r99732  
    2828
    2929    interface [
    30         CanBeConstructed,
    3130        CustomConstructor
    3231    ] BeforeLoadEvent : Event {

  • trunk/Source/WebCore/dom/CustomEvent.idl

    r96788 r99732  
    2929    // Introduced in DOM Level 3:
    3030    interface [
    31         CanBeConstructed,
    3231        CustomConstructor
    3332    ] CustomEvent : Event {

  • trunk/Source/WebCore/dom/ErrorEvent.idl

    r99021 r99732  
    3333    interface [
    3434        NoStaticTables,
    35         CanBeConstructed,
    3635        CustomConstructor
    3736    ] ErrorEvent : Event {

  • trunk/Source/WebCore/dom/Event.idl

    r98146 r99732  
    2424    interface [
    2525        CustomToJS,
    26         CanBeConstructed,
    2726        CustomConstructor,
    2827        NoStaticTables,

  • trunk/Source/WebCore/dom/HashChangeEvent.idl

    r96788 r99732  
    2222    // Introduced in http://www.whatwg.org/specs/web-apps/current-work/multipage/history.html#event-hashchange
    2323    interface [
    24         CanBeConstructed,
    2524        CustomConstructor
    2625    ] HashChangeEvent : Event {

  • trunk/Source/WebCore/dom/MessageChannel.idl

    r97586 r99732  
    2828
    2929    interface [
    30         CanBeConstructed,
    3130        Constructor,
    3231        CallWith=ScriptExecutionContext,

  • trunk/Source/WebCore/dom/MessageEvent.idl

    r97955 r99732  
    3030    interface [
    3131        NoStaticTables,
    32         CanBeConstructed,
    3332        CustomConstructor
    3433    ] MessageEvent : Event {

  • trunk/Source/WebCore/dom/OverflowEvent.idl

    r99435 r99732  
    2727
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor
    3130    ] OverflowEvent : Event {

  • trunk/Source/WebCore/dom/PageTransitionEvent.idl

    r99431 r99732  
    2727
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor
    3130    ] PageTransitionEvent : Event {

  • trunk/Source/WebCore/dom/PopStateEvent.idl

    r99471 r99732  
    2929#if !defined(LANGUAGE_CPP) || !LANGUAGE_CPP
    3030    interface [
    31         CanBeConstructed,
    32         CustomConstructor,
     31        CustomConstructor
    3332    ] PopStateEvent : Event {
    3433        readonly attribute [CustomGetter] DOMObject state;

  • trunk/Source/WebCore/dom/ProgressEvent.idl

    r96788 r99732  
    2727
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor
    3130    ] ProgressEvent : Event {

  • trunk/Source/WebCore/dom/WebKitAnimationEvent.idl

    r96788 r99732  
    2727
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor
    3130    ] WebKitAnimationEvent : Event {

  • trunk/Source/WebCore/dom/WebKitMutationObserver.idl

    r99611 r99732  
    3232    interface [
    3333        Conditional=MUTATION_OBSERVERS,
    34         CanBeConstructed,
    3534        CustomConstructor
    3635    ] WebKitMutationObserver {

  • trunk/Source/WebCore/dom/WebKitTransitionEvent.idl

    r97326 r99732  
    2727
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor
    3130    ] WebKitTransitionEvent : Event {

  • trunk/Source/WebCore/fileapi/FileReader.idl

    r98695 r99732  
    3434        Conditional=BLOB,
    3535        ActiveDOMObject,
    36         CanBeConstructed,
     36        Constructor,
    3737        CallWith=ScriptExecutionContext,
    3838        EventTarget,
    39         NoStaticTables,
    40         Constructor
     39        NoStaticTables
    4140    ] FileReader {
    4241        // ready states

  • trunk/Source/WebCore/html/DOMFormData.idl

    r97274 r99732  
    3232
    3333    interface [
    34         CanBeConstructed,
    3534        CustomConstructor,
    3635        GenerateNativeConverter,

  • trunk/Source/WebCore/html/TextTrackCue.idl

    r97926 r99732  
    2929        Conditional=VIDEO_TRACK,
    3030        EnabledAtRuntime=webkitVideoTrack,
    31         CanBeConstructed,
    3231        GenerateNativeConverter,
    3332        Constructor(in DOMString id, in double startTime, in double endTime, in DOMString text, in [Optional=CallWithDefaultValue] DOMString settings, in [Optional=CallWithDefaultValue] boolean pauseOnExit),

  • trunk/Source/WebCore/html/canvas/ArrayBuffer.idl

    r97893 r99732  
    2828    interface [
    2929        GenerateIsReachable=Impl,
    30         CanBeConstructed,
    3130        CustomConstructor,
    3231        NoStaticTables

  • trunk/Source/WebCore/html/canvas/DataView.idl

    r96788 r99732  
    2727
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        CustomToJS,
    32         NoStaticTables,
     31        NoStaticTables
    3332    ] DataView : ArrayBufferView {
    3433        // All these methods raise an exception if they would read or write beyond the end of the view.

  • trunk/Source/WebCore/html/canvas/Float32Array.idl

    r96788 r99732  
    2727module html {
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/canvas/Float64Array.idl

    r96788 r99732  
    2727module html {
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/canvas/Int16Array.idl

    r96788 r99732  
    2626module html {
    2727    interface [
    28         CanBeConstructed,
    2928        CustomConstructor,
    3029        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/canvas/Int32Array.idl

    r96788 r99732  
    2727module html {
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/canvas/Int8Array.idl

    r96788 r99732  
    2727module html {
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/canvas/Uint16Array.idl

    r96788 r99732  
    2727module html {
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/canvas/Uint32Array.idl

    r96788 r99732  
    2727module html {
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/canvas/Uint8Array.idl

    r96788 r99732  
    2727module html {
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    3130        HasNumericIndexGetter,

  • trunk/Source/WebCore/html/track/TrackEvent.idl

    r99261 r99732  
    2929        Conditional=VIDEO_TRACK,
    3030        EnabledAtRuntime=webkitVideoTrack,
    31         CanBeConstructed,
    32         CustomConstructor,
     31        CustomConstructor
    3332    ] TrackEvent : Event {
    3433

  • trunk/Source/WebCore/mediastream/PeerConnection.idl

    r98695 r99732  
    2828        Conditional=MEDIA_STREAM,
    2929        ActiveDOMObject,
    30         CanBeConstructed,
    3130        ConstructorParameters=2,
    3231        Constructor(in DOMString serverConfiguration, in [Callback=FunctionOnly] SignalingCallback signalingCallback),

  • trunk/Source/WebCore/page/EventSource.idl

    r98695 r99732  
    3434    interface [
    3535        ActiveDOMObject,
    36         CanBeConstructed,
    3736        ConstructorParameters=1,
    3837        Constructor(in DOMString scriptUrl),

  • trunk/Source/WebCore/page/WebKitPoint.idl

    r96788 r99732  
    2727
    2828    interface [
    29         CanBeConstructed,
    3029        CustomConstructor,
    31         ConstructorParameters=2,
     30        ConstructorParameters=2
    3231    ] WebKitPoint {
    3332        attribute float x;

  • trunk/Source/WebCore/webaudio/AudioContext.idl

    r96788 r99732  
    2828        Conditional=WEB_AUDIO,
    2929        ActiveDOMObject,
    30         CanBeConstructed,
    3130        CustomConstructor,
    3231        CustomMarkFunction,

  • trunk/Source/WebCore/websockets/CloseEvent.idl

    r99438 r99732  
    3333    interface [
    3434        NoStaticTables,
    35         CanBeConstructed,
    3635        CustomConstructor
    3736    ] CloseEvent : Event {

  • trunk/Source/WebCore/websockets/WebSocket.idl

    r96788 r99732  
    3535        Conditional=WEB_SOCKETS,
    3636        ActiveDOMObject,
    37         CanBeConstructed,
    3837        CustomConstructor,
    3938        ConstructorParameters=1,

  • trunk/Source/WebCore/workers/SharedWorker.idl

    r98695 r99732  
    3535        Conditional=SHARED_WORKERS,
    3636        ActiveDOMObject,
    37         CanBeConstructed,
    3837        JSCustomConstructor,
    3938        ConstructorParameters=2,

  • trunk/Source/WebCore/workers/Worker.idl

    r98695 r99732  
    3131        Conditional=WORKERS,
    3232        ActiveDOMObject,
    33         CanBeConstructed,
    3433        JSCustomConstructor,
    3534        ConstructorParameters=1,

  • trunk/Source/WebCore/xml/XMLHttpRequest.idl

    r98893 r99732  
    3131    interface [
    3232        ActiveDOMObject,
    33         CanBeConstructed,
    3433        Constructor,
    3534        CallWith=ScriptExecutionContext,

  • trunk/Source/WebCore/xml/XSLTProcessor.idl

    r97580 r99732  
    3535    interface [
    3636        Conditional=XSLT,
    37         CanBeConstructed,
    3837        Constructor
    3938    ] XSLTProcessor {
Note: See TracChangeset for help on using the changeset viewer.