Timeline

May 9, 2002:

8:18 PM Changeset in webkit [1125] by rjw

• 5 edits in trunk/WebCore

i Added new method to avoid creation of NSString.

8:18 PM Changeset in webkit [1124] by rjw

• 6 edits in trunk/WebKit

Tuned implementation more. Cleaned up and factored code.

6:35 PM Changeset in webkit [1123] by sullivan

• 6 edits in trunk/WebKit

• Bookmarks.subproj/IFBookmarkGroup.h:
• Bookmarks.subproj/IFBookmarkGroup.m: (-[IFBookmarkGroup addNewBookmarkToBookmark:withTitle:image:URLString:isLeaf:]): (-[IFBookmarkGroup insertNewBookmarkAtIndex:ofBookmark:withTitle:image:URLString:isLeaf:]): Gave these two methods return values of the new bookmark created, to make callers' lives easier.

More work on bookmarks; you can now create new ones and new folders
from the Bookmarks window. You still can't reorder them by dragging.
There are many details wrong still, including some obvious ones.

Fixed these radar bugs along the way:
2921389 -- No way to create a folder in Bookmarks window
2923495 -- Shouldn't be able to create bookmarks with no title and/or URL string

Also improved what Activity Viewer shows for errors that had no description
(was "(null)", now is "error").

• AppController.m: (-[AppController _insertBookmark:intoMenu:atIndex:]): Made this method handle non-leaf bookmarks (i.e., folders)

• BookmarksController.m: (-[BookmarksController _collapseSelectionToSingleRow]): New helper routine that always ends up with a single row selected (unless outline view is empty).

(-[BookmarksController _removeSelectedBookmarks:]):
Call _collapseSelectionToSingleRow after removing selected items.

(-[BookmarksController _toggleEdit:]):
New method, turns edit mode on or off for the selected item.

(-[BookmarksController _findParentRowOfRow:]):
New helper routine for finding the row index that's the parent of
a given row.

(-[BookmarksController _newItemWithTitle:image:URLString:isLeaf:]):
Bottleneck for new-item-creating methods, finds appropriate place to
insert new item based on current selection, inserts it, selects it,
and puts its name into edit mode.

(-[BookmarksController _newSeparator:]):
New method, placeholder for now.

(-[BookmarksController _newFolder:]):
(-[BookmarksController _newBookmark:]):
Implement by calling _newItemWithTitle:

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
If new value after trimming whitespace is empty, ignore it.

(-[BookmarksController outlineView:shouldEditTableColumn:item:]):
Don't allow address cell of folder rows to be edited.

(-[BookmarksController toolbarAllowedItemIdentifiers:]):
New set of buttons is: New Bookmark, New Folder, Modify, Remove

(-[BookmarksController validateUserInterfaceItem:]):
Disable Modify when nothing is selected.

• English.lproj/Bookmarks.nib: I don't remember what I changed here, possibly nothing real.

• IFErrorAdditions.h: Added.
• IFErrorAdditions.m: Added. (-[IFError errorSummary]): New category on IFError, implements just this one method, which returns a string of the form "<error description> (<error code>)" and handles the case where there's no description.

• FrameProgressEntry.m: (-[FrameProgressEntry statusString]): use errorSummary.
• ResourceProgressEntry.m: (-[ResourceProgressEntry statusString]): use errorSummary.

• GlobalHistory.m: (-[GlobalHistory showWindow:]): Changed an NSLog to a WEBKITDEBUG

• WebBrowser.pbproj/project.pbxproj: Updated for new files.

12:42 PM Changeset in webkit [1122]

• 1 copy
  34 deletes in tags/WebFoundation-5

This commit was manufactured by cvs2svn to create tag
'WebFoundation-5'.

12:42 PM Changeset in webkit [1121]

• 1 copy
  34 deletes in tags/WebFoundation-4

This commit was manufactured by cvs2svn to create tag
'WebFoundation-4'.

12:42 PM Changeset in webkit [1120] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Chris Blumenberg

Fix for this bug:

Radar 2922673 (Remove use of private NSData interface in IFURLFileDatabase.m)

• Database.subproj/IFURLFileDatabase.m: (-[IFURLFileReader initWithPath:]): Code now uses new Jaguar public API

12:25 PM Changeset in webkit [1119] by kocienda

• 4 edits in trunk/WebCore

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Fix for this bug:

Radar 2890624 (need to remove workaround for double free of image data from QPixmap)

The appropriate, bug-free AppKit code is now available to us on Jaguar.
Rolling out the workaround.

• kwq/KWQPixmap.mm: (QPixmap::QPixmap)

9:43 AM Changeset in webkit [1118] by kocienda

• 1 edit in trunk/WebKit/Misc.subproj/WebFileDatabase.m

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Tiny little string copying cleanup suggested by Darin.

• Database.subproj/IFURLFileDatabase.m: (-[IFURLFileDatabase open]): small string copying cleanup.

9:35 AM Changeset in webkit [1117] by kocienda

• 4 edits in trunk/WebKit/Misc.subproj

2002-05-09 Kenneth Kocienda <​kocienda@apple.com>

Reviewed by: Darin Adler

Fixes for these two bugs:

Radar 2859001 (Maintain usage calculation for on-disk cache)
Radar 2859009 (On-disk cache must be able to be truncated to a specific size)

Now, the on-disk database keeps track of the amount of data it stores and can enforce
a usage quota. This new system should work quite well as long as there is a one-to-one
mapping between processes and on-disk cache paths.

Further guarantees for synchronous access to a cache from multiple processes will be
offered if (when) we switch over to using the sleepycat Berkeley DB for the disk cache
implementation.

• CacheLoader.subproj/IFURLDiskCache.m: (-[IFURLDiskCache initWithSizeLimit:path:]): Added code that calls into new database methods (-[IFURLDiskCache dealloc]): Added missing call to [super dealloc] (-[IFURLDiskCache setSizeLimit:]): New (-[IFURLDiskCache usage]): New
• Database.subproj/IFDatabase.h:
• Database.subproj/IFDatabase.m: (-[IFDatabase initWithPath:]): Added code to track size limit and usage (-[IFDatabase isOpen]): Added code to track size limit and usage (-[IFDatabase count]): New (-[IFDatabase sizeLimit]): New (-[IFDatabase setSizeLimit:]): New (-[IFDatabase usage]): New
• Database.subproj/IFNDBMDatabase.h: Removed.
• Database.subproj/IFNDBMDatabase.m: Removed.
• Database.subproj/IFURLFileDatabase.h:
• Database.subproj/IFURLFileDatabase.m: (+[IFURLFileDatabase uniqueFilePathForKey:]): Moved to private category (-[IFURLFileDatabase writeSizeFile:]): New (-[IFURLFileDatabase readSizeFile]): New (-[IFURLFileDatabase truncateToSizeLimit:]): New (-[IFURLFileDatabase initWithPath:]): Added code to deal with size reckoning (-[IFURLFileDatabase removeAllObjects]): Added code to deal with size reckoning (-[IFURLFileDatabase performSetObject:forKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase performRemoveObjectForKey:]): Added code to deal with size reckoning (-[IFURLFileDatabase open]): Added code to deal with size reckoning (-[IFURLFileDatabase close]): Added code to deal with size reckoning (-[IFURLFileDatabase sync]): Added code to deal with size reckoning (-[IFURLFileDatabase count]): New (-[IFURLFileDatabase setSizeLimit:]): New
• WebFoundation.pbproj/project.pbxproj: PB has its way again.

9:19 AM Changeset in webkit [1116]

• 8 copies in tags/Alexander-3

This commit was manufactured by cvs2svn to create tag 'Alexander-3'.

9:19 AM Changeset in webkit [1115] by sheridan

• 8 edits in trunk

Alexander-3 versioning

May 8, 2002:

8:05 PM Changeset in webkit [1114] by rjw

• 6 edits in trunk/WebKit

Added optimizations for text rendering.

5:11 PM Changeset in webkit [1113] by darin

• 7 edits in trunk/WebKit

• Misc.subproj/IFCache.h: Add more JavaScript object statistics.
• Misc.subproj/IFCache.mm: (+[IFCache javaScriptInterpretersCount]): New. (+[IFCache javaScriptNoGCAllowedObjectsCount]): New. (+[IFCache javaScriptReferencedObjectsCount]): New.

• WebKit.pbproj/project.pbxproj: Rearranged two files, dunno why.

5:11 PM Changeset in webkit [1112] by darin

• 5 edits in trunk/JavaScriptCore

• kjs/collector.h:
• kjs/collector.cpp: (Collector::numInterpreters): (Collector::numGCNotAllowedObjects): (Collector::numReferencedObjects): Add three new functions so we can see a bit more about leaking JavaScriptCore.

1:22 PM Changeset in webkit [1111] by cblu

• 8 edits in trunk/WebKit

Cleaned up mach-o plug-in support.

Changed the init method in IFPlugin to initWithPath.

• Plugins.subproj/IFPlugin.h:
• Plugins.subproj/IFPlugin.m: (-[IFPlugin initWithPath:]): (-[IFPlugin load]):
• Plugins.subproj/IFPluginDatabase.m: (findPlugins):

11:37 AM Changeset in webkit [1110] by darin

• 2 edits in trunk/WebKit/WebView.subproj

Forgot include.

11:29 AM Changeset in webkit [1109] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setTitle:]): Use _IF_stringByTrimmingWhitespace.