Timeline

May 13, 2002:

11:16 PM Changeset in webkit [1143] by darin

• 4 edits in trunk/WebCore

• kwq/KWQListImpl.mm: (KWQListImpl::~KWQListImpl): Detach all the iterators from the list when the list is destroyed. I thought this was done before, but it seems not.

10:43 PM Changeset in webkit [1142] by cblu

• 16 edits in trunk/WebKit

Added support for setting the content policy on the location change handler
and data source at any time instead of depending on an immediate response.

• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController haveContentPolicy:andPath:forLocationChangeHandler:]):
• WebView.subproj/IFMainURLHandleClient.h:
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient initWithDataSource:part:]): (-[IFMainURLHandleClient dealloc]): (-[IFMainURLHandleClient setContentPolicy:]): (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]): (-[IFMainURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): (-[IFMainURLHandleClient IFURLHandle:didRedirectToURL:]): (-[IFMainURLHandleClient processData:isComplete:]):
• WebView.subproj/IFWebController.h:
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _setContentPolicy:]):
• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame setProvisionalDataSource:]):

7:57 PM Changeset in webkit [1141] by darin

• 13 edits in trunk/WebCore

Fixed bug 2922884 (JavaScript object leak creating Image object from JavaScript).
There was a reference loop created when a document contained a variable that
referenced an image, because images held references to the document; the C++
kind that do not participate in the JavaScript garbage collection.

• khtml/ecma/kjs_html.h: Use a QGuardedPtr to the DocumentImpl instead of using a Document object.
• khtml/ecma/kjs_html.cpp: (Image::tryPut): Change because the "doc" pointer is now a pointer to the DocumentImpl, not the Document. Also check for 0, since it's now a QGuardedPtr that can become 0. (Image::Image): Newly out of line. Changed because the "doc" pointer is now a pointer to the DocumentImpl, not the Document.

Since the solution used QGuardedPtr, I had to implement it.

• kwq/qt/qguardedptr.h: Put the implementation in a new KWQGuardedPtrBase class, with only the bare minimum in a template. This new implementation uses iterators on a QPtrList, which means there's not much code needed.
• kwq/KWQGuardedPtr.mm: (KWQGuardedPtrBase::KWQGuardedPtrBase): Rewrite to use a QPtrListIterator to a dummy list in the QObject. This reuses code nicely, but a custom-coded solution would be a bit more efficient.

• kwq/qt/qobject.h:
• kwq/KWQObject.mm: (QObject::QObject): Create the one-element list that's used by the QGuardedPtr instances.

Since the above code needed to copy a QPtrListIterator, I needed to support that.

• kwq/qt/qlist.h: Move the iterator's copy constructor out of the private part, and implement it. This class was strange in that it has a public assignment operator, but a private unimplemented copy constructor. Implementing it was trivial, though, so this was no obstacle.

7:56 PM Changeset in webkit [1140] by darin

• 4 edits in trunk/JavaScriptCore

• kjs/value.h: Fix comment typos.

7:30 PM Changeset in webkit [1139] by mjs

• 3 edits in trunk/WebKit

• Makefile.am: Make WebCore precompiled headers depend on config.h to fix build breakage from last change.

WebKit:

• WebKitPrefix.h: Gratuitous change to make the prefix file rebuild.

5:27 PM Changeset in webkit [1138] by mjs

• 5 edits
  2 deletes in trunk/WebCore

Removed libjpeg dependency. Turns out we don't need it.

• configure.in: Don't check for libjpeg.
• Updates/update: Don't bother with the libjpeg update.
• Updates/install-libjpeg.sh: Removed.

WebCore:

Removed libjpeg dependency. Turns out we don't need it.

• Makefile.am: Remove -ljpeg from link line.
• khtml/misc/loader_jpeg.cpp: Removed.
• khtml/misc/loader_jpeg.h: Removed.
• khtml/misc/Makefile.am: Remve loader_jpeg from build.

11:22 AM Changeset in webkit [1137] by cblu

• 11 edits in trunk/WebKit

• WebView.subproj/IFBaseWebController.mm: (-[IFBaseWebController URLPolicyForURL:]):

Use [IFURLHandle canInitWithURL] instead of hard-coded URL schemes.

• WebView.subproj/IFBaseWebControllerPrivate.mm: (-[IFBaseWebController _mainReceivedProgress:forResource:fromDataSource:]):
• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFMainURLHandleClient IFURLHandle:resourceDataDidBecomeAvailable:]):
• WebView.subproj/IFWebDataSourcePrivate.h:
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate init]): (-[IFWebDataSource _setDownloadPath:]):

Removed _contentPolicy as contentPolicy is public.

Initialize contentPolicy in [IFWebDataSourcePrivate init].