Timeline

Jun 6, 2002:

9:39 PM Changeset in webkit [1287] by darin

• 9 edits in trunk

• Makefile.am: Update warning flags for compatibility with new C++.
• configure.in: Update warning flags for compatibility with new C++.

• Tools/DiskCachePeek/DiskCachePeek.pbproj/project.pbxproj: Project Builder wants what it wants.

JavaScriptCore:

• JavaScriptCore.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebFoundation:

• WebFoundation.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

WebKit:

• WebKit.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

• WebCoreSupport.subproj/IFTextRenderer.m: (FillStyleWithAttributes): Remove workaround we copied from AppKit, because it's a workaround for a bug that was fixed in Puma.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Update warning flags for compatibility with new C++.

3:58 PM Changeset in webkit [1286] by cblu

• 4 edits in trunk/WebKit

2002-06-06 Chris Blumenberg <​cblu@apple.com>

Added support for key codes and other encodings.
Send activate to make Java happy.

• Plugins.subproj/IFPluginView.mm: (-[IFPluginView keyMessageForEvent:]): added (-[IFPluginView keyUp:]): use above. (-[IFPluginView keyDown:]): use above. (-[IFPluginView windowBecameKey:]): send activate. (-[IFPluginView windowResignedKey:]): send activate.

11:55 AM Changeset in webkit [1285] by sullivan

• 4 edits in trunk/WebKit

Previous commit didn't seem to take for some reason; trying again.

• Bookmarks.subproj/IFBookmarkList.m: (-[IFBookmarkList removeChild:]): Added assert. (-[IFBookmarkList insertChild:atIndex:]): Set the group of the new child, and added assert.

Added Undo in the Bookmarks window for removing items and for changing
the titles and addresses of items. Also changed the image used for
Stop in the Bookmarks window per a conversation with Don and Chris
yesterday.

• fixed 2927231 -- should be able to Undo deleting bookmarks
• fixed 2948496 -- should be able to Undo title & address changes in Bookmarks window

• BookmarksController.m: (-[UndoRemoveInfo initWithBookmark:]), (-[UndoRemoveInfo dealloc]), (+[UndoRemoveInfo infoWithBookmark:]): New little helper class that hangs onto the info needed to put removed bookmarks back in the right places.

(-[BookmarksController _redoRemoveBookmarks:]),
(-[BookmarksController _undoRemoveBookmarks:]): New methods
(-[BookmarksController removeSelectedBookmarks:]): Register for undo.

(-[BookmarksController _undoTitleChange:]),
(-[BookmarksController _changeTitleForBookmark:to:]),
(-[BookmarksController _undoAddressChange:]),
(-[BookmarksController _changeAddressForBookmark:to:]),
New methods used for undo/redo.

(-[BookmarksController outlineView:setObjectValue:forTableColumn:byItem:]):
Register for Undo, but only if the value has actually changed.

(-[BookmarksController windowWillClose:]): Empty undo/redo stack.

• Resources/Images/red_globe.tiff: Added, used by Stop in Downloads window.
• Resources/Images/green_globe.tiff: Added, to be used by Resume in Downloads window.
• Resources/Images/stop.tiff: Removed.

• DownloadMonitor.m: (-[DownloadMonitor toolbar:itemForItemIdentifier:willBeInsertedIntoToolbar:]): Use new Stop image.

• WebBrowser.pbproj/project.pbxproj: Updated for new image files.

8:18 AM Changeset in webkit [1284] by darin

• 9 edits in trunk/WebKit

• MIME.subproj/IFContentHandler.m: (-[IFContentHandler initWithURL:MIMEType:MIMEHandlerType:]): Add call to [super init]. (-[IFContentHandler useTemplate:withGlobal:]): New helper function. Also got rid of <title> from templates, since there's no need for us to provide a fake title if it's just the URL. (-[IFContentHandler HTMLDocument]): Reduce use of copied and pasted code. (-[IFContentHandler dealloc]): Add call to [super dealloc].

• Resources/image_document_template.html: Remove <title>.
• Resources/plugin_document_template.html: Remove <title>.
• Resources/text_document_template.html: Remove <title>.

• WebView.subproj/IFMainURLHandleClient.mm: (-[IFMainURLHandleClient processData:isComplete:allDataReceived:]): Remove some unneeded type casts.

Jun 5, 2002:

5:45 PM Changeset in webkit [1283] by mjs

• 6 edits in trunk/WebKit

Fixed Radar 2936155 - crash in IFAuthenticationPanel

• Panels.subproj/IFAuthenticationPanel.m: (-[IFAuthenticationPanel runAsSheetOnWindow:withRequest:]): Add some assertions.

(-[IFAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
Avoid referencing instance variables after performing a selector
that might release this object. Also, add some assertions.

• Panels.subproj/IFPanelAuthenticationHandler.m: (-[IFPanelAuthenticationHandler startAuthentication:]): Tweak whitespace.

5:33 PM Changeset in webkit [1282] by darin

• 14 edits in trunk/WebCore

Some fixes to speed up the citibank.com page, and other related changes.

• khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty): Only do a layout if it's actually needed. This speeds things up immensely, and I'm pretty sure it's correct.

• kwq/KWQListImpl.h: To speed things up, get rid of the "private part" level of indirection. This is particularly vital for list iterators, which are created and destroyed a lot on the stack. Also made trivial functions be inline.

• kwq/KWQListImpl.mm: (copyList): Now a static function rather than a member of the now-defunct private class. (KWQListImpl::KWQListImpl): Set up all the new members that used to be in the separate private object. (KWQListImpl::~KWQListImpl): Update the iterator-detaching code to do it the new way, with intrusive list. Also, use clear() instead of having our own code to delete the list -- note this is only used after the level above us does a clear() anyway. (KWQListImpl::clear): Use a loop to delete all the nodes rather than making a delete of one node recursively delete the next -- iteration is more efficient, and also easier to understand in this case. Also update all the iterators so they don't point to deleted nodes. (KWQListImpl::containsRef): Update to return the count, rather than just a true or false value, since that's how the class is defined. (KWQListImpl::assign): Delete the items if asked to (fixes a FIXME). Also use a new swap member function since there's more to swap now. (KWQListImpl::addIterator): Rewrite to use an intrusive linked list. (KWQListImpl::removeIterator): Rewrite to use an intrusive linked list; this makes it much faster since it doesn't have to search the list. (KWQListImpl::swap): Implement this private member function used by assign. (KWQListIteratorImpl::KWQListIteratorImpl): Set up the new members that used to be in the separate private object.

• kwq/qt/qlist.h: Re-add the operator= definition. This would cause a storage leak, although I haven't actually observed the leak.

• kwq/qt/qbuffer.h: Initialize opened to false. This was causing a test failure.

• kwq/KWQDictImpl.h:
• kwq/KWQDictImpl.mm: Streamline implementation a bit by getting rid of unneeded copy constructor definition and making trivial constructor for iterator inline.

• kwq/KWQPtrDictImpl.h: Remove unneeded include.

• WebCore-tests.exp: Update for changes in the entry points used by the tests.

4:49 PM Changeset in webkit [1281] by rjw

• 4 edits in trunk/WebKit

Fixed snafu in recursion over frame tree.

4:49 PM Changeset in webkit [1280] by rjw

• 8 edits in trunk/WebCore

Fixed 2938552. This required an implementation of KHTMLPart::frames which
is used by the JS window.frames property.

2:22 PM Changeset in webkit [1279] by darin

• 4 edits in trunk/JavaScriptCore

Fix problem seen as build failure on Jersey.

• Makefile.am: JavaScriptCore-stamp needs to be a dependency, not a source file, because it doesn't have a corresponding object file. Making it a dependency causes things to compile in the right order.

2:14 PM Changeset in webkit [1278] by rjw

• 8 edits in trunk/WebCore

Fixed window.top JS property (2939353). This caused funny recursion problems at www.megapixel.net and other pages that try to pop frames.

1:25 PM Changeset in webkit [1277] by rjw

• 6 edits in trunk/WebCore

Cleaned up call to frameNamed:. Now use frame relative naming.
Fixed various frame related bugs (including www.heinz.com).

1:24 PM Changeset in webkit [1276] by rjw

• 5 edits in trunk/WebKit

i Normalized frame naming. (We still don't support cross

window name lookups.)