⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jun 26, 2002:

9:42 PM Changeset in webkit [1447] by rjw
  • 14 edits in trunk

Many improvements to selection. More Cocoa like,
normalized all text drawing code paths for selected
and unselected cases. Still need to work on
TextSlave::checkSelectionPoint. Fixed redraw region
problems.

khtml redraw the entire visible region when selection changes.
This could be optimzed.

  • khtml/rendering/font.cpp: (Font::drawText): (Font::width):
  • khtml/rendering/render_text.cpp: (TextSlave::printSelection):
  • kwq/KWQPainter.mm: (QPainter::drawText): (QPainter::selectedTextBackgroundColor):
  • kwq/KWQScrollView.mm: (QScrollView::contentsX): (QScrollView::contentsY):
  • kwq/WebCoreTextRenderer.h:
  • kwq/qt/qpainter.h:

Many improvements to selection. More Cocoa like,
normalized all text drawing code paths for selected
and unselected cases.

Still need to work on:

  1. 'slow' drawing cases, i.e. runs with non-base characters

or runs requiring font substitution.

  1. Select All menu item.
  2. Auto scrolling.
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer drawString:atPoint:withColor:]): (-[IFTextRenderer drawGlyphs:numGlyphs:fromGlyphPosition:toGlyphPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer slowDrawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:attemptFontSubstitution:]): (-[IFTextRenderer _drawCharacters:length:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withTextColor:backgroundColor:]): (-[IFTextRenderer drawCharacters:length:atPoint:withTextColor:]): (-[IFTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withTextColor:backgroundColor:]):
3:47 PM Changeset in webkit [1446] by darin
  • 4 edits in trunk/WebKit
  • fixed 2969280 -- if trailing / not specified for site, relative URLs are incorrectly expanded
  • WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge receivedData:withDataSource:]): Update the URL for the case where we've already been redirected before we receive any data.
3:14 PM Changeset in webkit [1445] by mjs
  • 8 edits in trunk/WebCore

Implement KHTMLPart::findFrame() to fix the following Radar bugs:

Radar 2943177 - infinite JavaScript loop sfcu.org online bill paying
Radar 2950580 - Unknown JavaScript properties on the Window object return self instead

of Undefined

  • khtml/khtml_part.cpp: (KHTMLPart::findFrame):
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::findFrame):
  • kwq/KWQKHTMLPartImpl.h:
3:03 PM Changeset in webkit [1444] by darin
  • 10 edits in trunk/WebKit
  • fixed 2971532 -- crash with null KHTMLView at gramicci.com
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView reapplyStyles]): Handle widget == 0 case. (-[IFHTMLView layout]): Handle widget == 0 case.

Fixed a crash I have seen many times where a data source tries
to use its parent to locate the controller after its parent is
deallocated.

  • WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSourcePrivate dealloc]): Use _parentDataSourceWillBeDeallocated instead of _setController:nil.
  • WebView.subproj/IFWebFramePrivate.h: Add _parentDataSourceWillBeDeallocated.
  • WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _parentDataSourceWillBeDeallocated]): Does both a _setController:nil, and a _setParent:nil on both data sources.
1:44 PM Changeset in webkit [1443] by sullivan
  • 5 edits in trunk/WebKit
  • fixed 2971024 -- wrong item is bookmarked

-[IFWebDataSource redirectedURL] was returning the URL of a
sub-page resource.

  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandle:didRedirectToURL:]): Removed evil call to _setFinalURL here. It had no right to live.
12:35 PM Changeset in webkit [1442] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRenderer]): Fix NSBitmapImageRep leak.
12:01 PM Changeset in webkit [1441] by darin
  • 5 edits in trunk/WebCore
  • fixed 2969378 -- "A with hat" characters (Unicode 00C2) showing up at Zingermans.com
  • kwq/KWQCharsets.mm: (buildDictionaries): Put UTF-16 in the dictionary, but pointing at the string encoding for UTF-8. This mimics what Internet Explorer does.
  • kwq/KWQtextcodec.mm: (QTextCodec::fromUnicode): Fix implementation so it will convert the specified encoding instead of always Latin-1.
11:53 AM Changeset in webkit [1440] by cblu
  • 10 edits in trunk/WebKit

WebKit:

  • added "complete" to progress methods to indicate last progress message
  • Plugins.subproj/IFPluginView.mm: (-[IFPluginView setWindow]): added a draw test
  • WebView.subproj/IFWebController.h:
  • WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[IFWebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

WebBrowser:

  • added "complete" to progress methods to indicate last progress message
  • DownloadMonitor.h:
  • DownloadMonitor.m: (-[DownloadMonitor monitorDownload:withProgress:error:dataSource:complete:]):
  • WebController.m: (-[WebController receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController receivedError:forResourceHandle:partialProgress:fromDataSource:]):
10:53 AM Changeset in webkit [1439] by rjw
  • 8 edits in trunk/WebKit

Fixed recursion problems. +[NSFont findFontLike:forString:withRange:inLanguage:]
will alternate between suggested fonts with bogus answers. The work
around involves adding an explicit flag indicating whether or not
font substitution should be attempted.

  • Misc.subproj/IFStringTruncator.m: (+[IFStringTruncator centerTruncateString:toWidth:withFont:]):
  • WebCoreSupport.subproj/IFTextRenderer.h:
  • WebCoreSupport.subproj/IFTextRenderer.m: (-[IFTextRenderer slowDrawCharacters:length:atPoint:withColor:attemptFontSubstitution:]): (-[IFTextRenderer drawCharacters:length:atPoint:withColor:]): (-[IFTextRenderer floatWidthForCharacters:length:applyRounding:attemptFontSubstitution:]): (-[IFTextRenderer widthForCharacters:length:]):
9:40 AM Changeset in webkit [1438] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView validateUserInterfaceItem:]): Switch to this instead of validateMenuItem: so that a Copy toolbar button would work.
9:16 AM Changeset in webkit [1437] by darin
  • 8 edits in trunk/WebCore

Fixed (or at least worked around) a crash I saw where KWQKHTMLPartImpl::end was
making calls after the KHTMLView was gone. This is specific to our APPLE_CHANGES
code; it's handled differently in KDE.

  • khtml/khtml_part.h: Added detachView.
  • khtml/khtml_part.cpp: (KHTMLPart::detachView): Added. Nils out the view pointer.
  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Call m_part->detachView().
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::end): Don't try to make calls to the view if it's nil.

Jun 25, 2002:

7:50 PM Changeset in webkit [1436] by rjw
  • 8 edits in trunk/WebKit

Disable the copy menu item when IFHTMLView is key
and has no selection.

  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView validateMenuItem:]): Disable menu if selection is empty. (-[IFHTMLView copy:]): Factored code that gets the bridge.
  • WebView.subproj/IFHTMLViewPrivate.h: Added _bridge.
  • WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _bridge]): We need to access the bridge from the view to get the part's selection.
7:26 PM Changeset in webkit [1435] by rjw
  • 8 edits in trunk/WebCore

Support for khtml style selection drawing. Ugly,
we'll want to make this more Mac like.

  • khtml/rendering/font.cpp: (Font::drawText):

Enable khtml code path. Removed APPLE_CHANGES

  • kwq/KWQFontMetrics.mm: (QFontMetrics::charWidth):

Implemented in terms of width().

  • kwq/KWQPainter.mm: (QPainter::drawText):

Implemented.

  • kwq/qt/qfontmetrics.h:

Added QFontMetrics::charWidth.

4:32 PM Changeset in webkit [1434] by cblu
  • 4 edits in trunk/WebKit

Remove downloaded file if cancelled.

  • Misc.subproj/IFDownloadHandler.mm: (-[IFDownloadHandler cancel]):
3:16 PM Changeset in webkit [1433] by rjw
  • 16 edits in trunk

Support for rudimentary plain text 'copy'.

  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
  • WebView.subproj/IFHTMLView.mm: (-[IFHTMLView copy:]):
  • WebView.subproj/IFWebViewPrivate.h:
  • WebView.subproj/IFWebViewPrivate.mm: (-[IFWebView _controller]):

Support for rudimentary plain text 'copy'.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedText]):
1:18 PM Changeset in webkit [1432] by rjw
  • 13 edits in trunk

Enabled progressive image loading code.

  • WebCoreSupport.subproj/IFImageRenderer.h:
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): (-[IFImageRenderer incrementalLoadWithBytes:length:complete:]):
  • WebCoreSupport.subproj/IFImageRendererFactory.m: (-[IFImageRendererFactory imageRenderer]):

Enabled progressive image loading code.

  • khtml/misc/loader.cpp: (CachedImage::data):
  • kwq/KWQPixmap.mm: (QPixmap::QPixmap):
11:56 AM Changeset in webkit [1431] by rjw
  • 4 edits in trunk/WebKit

Extended our text measurement rounding work-around for integer-float
mismatch to round on word boundaries as well as spaces.

10:38 AM Changeset in webkit [1430] by darin
  • 8 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFResourceURLHandleClient.m: (-[IFResourceURLHandleClient IFURLHandleResourceDidCancelLoading:]): (-[IFResourceURLHandleClient IFURLHandleResourceDidFinishLoading:data:]): (-[IFResourceURLHandleClient IFURLHandle:resourceDidFailLoadingWithResult:]): Don't remove the URL handle from the data source until we've finished the loading process in KDE code. This may fix 2968527.
  • WebCoreSupport.subproj/IFTextRenderer.m: Keep around commented printfs so I can do the "dump all strings as they are rendered" again.
  • WebKit.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.
10:31 AM Changeset in webkit [1429] by darin
  • 4 edits in trunk/JavaScriptCore
  • JavaScriptCore.pbproj/project.pbxproj: Re-add -Wmissing-format-attribute.
10:30 AM Changeset in webkit [1428] by darin
  • 26 edits in trunk/WebCore

Removed remaining uses of BORROWED defines.
Made some simplifications and formatting fixes. All safe.

  • kwq/KWQArrayImpl.h:
  • kwq/KWQArrayImpl.mm:
  • kwq/KWQChar.mm:
  • kwq/KWQCharsets.mm:
  • kwq/KWQFile.mm:
  • kwq/KWQKCursor.mm:
  • kwq/KWQKHTMLPart.mm:
  • kwq/KWQListImpl.h:
  • kwq/KWQMapImpl.mm:
  • kwq/KWQString.mm:
  • kwq/KWQValueListImpl.mm:
  • kwq/KWQVectorImpl.h:
  • kwq/KWQtextcodec.mm:
  • kwq/make-charset-table.pl:
  • kwq/make-mac-encodings.c:
  • kwq/qt/qfile.h:
  • kwq/qt/qregexp.h:
  • kwq/qt/qtextcodec.h:
  • WebCore-tests.exp: Small change to exports for the array test.
7:30 AM Changeset in webkit [1427] by darin
  • 4 edits in trunk/WebKit
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Remove stray NSLog.
12:33 AM Changeset in webkit [1426] by darin
  • 6 edits in trunk/WebKit
  • fixed 2968298 -- IFImageRenderer crash at download.com
  • WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer initWithSize:]): Override this instead of [init]. This is the designated initializer and all the others call this. (-[IFImageRenderer copyWithZone:]): Override to nil out fields that can't be shared by the copy.

Fix leaks.

  • History.subproj/IFURIEntry.m: (-[IFURIEntry initWithURL:title:image:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry dealloc]): Release _displayTitle. Fixes a leak. (-[IFURIEntry setTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry setDisplayTitle:]): Use copy instead of retain in case we are passed a mutable string. (-[IFURIEntry initFromDictionaryRepresentation:]): Lose the extra retain for _lastVisitedDate. Fixes a leak.
Note: See TracTimeline for information about the timeline view.