Timeline

Jun 29, 2002:

10:31 PM Changeset in webkit [1477] by darin

• 4 edits in trunk/WebKit

• WebCoreSupport.subproj/IFImageRenderer.m: (-[IFImageRenderer tileInRect:fromPoint:]): Fix calculation of oneTileRect. I think this is finally correct now.

4:28 PM Changeset in webkit [1476] by mjs

• 26 edits in trunk

WebCore:

WebCore part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

• kwq/WebCoreBridge.h: Add new calls needed for window size/position/feature getting and setting.
• kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Set properties on window after creating it using new bridge calls; make it visible.
• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): Support scrollbars feature too.
• kwq/kparts/browserextension.h: Include scrollbar setting stuff.

WebKit:

WebKit part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

Also, renamed IFScriptContextHandler protocol to IFWindowContext,
and made it a settable handler like the others rather than
something implemented by the controller, so it can be used w/o
subclassing.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge openNewWindowWithURL:]): Forward to the WindowContext. (-[IFWebCoreBridge areToolbarsVisisble]): Likewise. (-[IFWebCoreBridge setToolbarsVisible:]): Likewise. (-[IFWebCoreBridge areScrollbarsVisible]): Likewise. (-[IFWebCoreBridge setScrollbarsVisible:]): Likewise. (-[IFWebCoreBridge isStatusBarVisisble]): Likewise. (-[IFWebCoreBridge setStatusBarVisible:]): Likewise. (-[IFWebCoreBridge setWindowFrame:]): Likewise. (-[IFWebCoreBridge window]): Likewise.
• WebView.subproj/IFWebController.h:
• WebView.subproj/IFWebController.mm: (-[IFWebController setWindowContext:]): Setter for new WindowContext handler (-[IFWebController windowContext]): Likewise.
• WebView.subproj/IFWebControllerPrivate.h:
• WebView.subproj/IFWebControllerPrivate.mm: (-[IFWebControllerPrivate dealloc]): Release window context.
• WebView.subproj/IFWebFrame.mm: (-[IFWebFrame frameNamed:]): Open new windows via WindowContext.

WebBrowser:

WebBrowser part of fix for:

Radar 2942074 - JavaScript size, positioning and feature
parameters to window.open are ignored

• BrowserDocument.m: (-[BrowserDocument init]): Set the WebController as it's own WindowContext too.
• BrowserWindow.h:
• BrowserWindow.m: (-[BrowserWindow _saveFrameIfAllowed]): Don't save the frame if the last (-[BrowserWindow setFrameWithoutAutosaving:]): Change window size and position but without saving the frame; if this is a size change and not just a move, avoid saving the frame until the next user resize. (-[BrowserWindow windowDidResize:]): More stuff for the above. (-[BrowserWindow isFavoritesBarVisible]): Implemented. (-[BrowserWindow setFavoritesBarVisible:]): Implemented. (-[BrowserWindow isStatusBarVisible]): Implemented. (-[BrowserWindow setStatusBarVisible:]): Implemented. (-[BrowserWindow isToolbarVisible]): Implemented. (-[BrowserWindow setToolbarVisible:]): Implemented.
• WebController.h:
• WebController.m: (-[BrowserWebController openNewWindowWithURL:]): Don't initially show the window even if no URL is set, so initial parameters can be set properly. (-[BrowserWebController areToolbarsVisible]): Implemented. (-[BrowserWebController setToolbarsVisible:]): Implemented. (-[BrowserWebController isStatusBarVisible]): Implemented. (-[BrowserWebController setStatusBarVisible:]): Implemented. (-[BrowserWebController window]): Implemented. (-[BrowserWebController setFrame:]): Implemented.