Timeline

Jul 14, 2002:

11:51 PM Changeset in webkit [1557] by darin

• 5 edits in trunk/WebCore

WebCore:

• kwq/WebCoreFrame.mm: (-[WebCoreFrame dealloc]): Fix NULL-dereferencing problem that was hidden by the "leak the world" bug in WebBrowser.

WebBrowser:

Fix "leak the world" bug.

• BrowserDocument.m: (-[BrowserDocument close]): Having the web controller as its own window context creates a reference cycle. As with the other similar cases here, break the cycle by explicitly setting it to nil.

10:55 PM Changeset in webkit [1556] by mjs

• 5 edits in trunk/WebCore

Assign getView() results to variable of appropriate type to work
around apparent ObjC++ compiler bug. I wonder why other people
aren't running into this (and why I haven't run into it before).

• kwq/KWQButton.mm: (QButton::setText): (QButton::text):
• kwq/KWQLineEdit.mm: (QLineEdit::setEchoMode): (QLineEdit::setText): (QLineEdit::text): (QLineEdit::setMaxLength): (QLineEdit::isReadOnly): (QLineEdit::setReadOnly): (QLineEdit::maxLength): (QLineEdit::selectAll): (QLineEdit::edited): (QLineEdit::setEdited):

10:08 PM Changeset in webkit [1555] by darin

• 5 edits in trunk/WebCore

• WebCore-tests.exp: Tests needed access to QPoint, QString, and KURL symbols that were formerly exported for the benefit of WebKit.

• kwq/KWQPixmap.mm: I needed to touch something since .exp files don't cause a rebuild, so I fixed a comment in here.

4:49 PM Changeset in webkit [1554] by darin

• 61 edits
  4 adds
  1 delete in trunk

WebCore:

Changes to WebCore that allow WebKit to work through Objective C without going
straight to the KHTML headers. Also remove a bunch of unused stuff, especially
in QPainter.

• WebCore.exp: Export the new classes WebCoreCache and WebCoreJavaScript. Don't export any C++ symbols at all.

• WebCore.pbproj/project.pbxproj: Remove KWQWMatrix.mm, add WebCoreCache.* and WebCoreJavaScript.*.

• khtml/khtml_part.cpp: Put more unused code inside ifndef APPLE_CHANGES.
• khtml/khtmlview.cpp: Put unused code inside #ifndef APPLE_CHANGES
• khtml/khtmlview.h: Put unused virtual functions inside #ifndef APPLE_CHANGES.
• khtml/misc/loader.cpp: (CachedImage::tiled_pixmap): Change this so it always returns pixmap(). Handling it at this level is better than changing all the callers for now.
• khtml/rendering/render_box.cpp: (RenderBox::printBackground): Took out the APPLE_CHANGES now that tiled_pixmap() always just returns pixmap().
• khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): Put some unused code inside APPLE_CHANGES.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPartImpl::requestFrame): Made it get the view using the bridge, since we don't have a [widget] method on the frame any more. (KWQKHTMLPartImpl::findFrame): Used committedBridge instead of bridge, since I changed bridge to return the provisional if available. (KWQKHTMLPartImpl::frames): Used committedBridge instead of bridge, since I changed bridge to return the provisional if available.

• kwq/qt/qpixmap.h: Put an empty version of QWMatrix in here. We don't actually ever need a real matrix, just a class to let us compile.

• kwq/qt/qpainter.h: Moved QWMatrix into qpixmap.h. Removed constructors that take QPixmap and QWidget. Removed unused variants of drawText. Removed unused setClipping, setClipRect, hasClipping, translate, scale, begin, end, and device functions.
• kwq/KWQPainter.mm: (QPainter::QPainter): Remove the constructors that take a paint device, widget, or pixmap. We can get away without them. (QPainter::save): Simplify. Also remove the optimization for painters without stacks, since having an empty stack is very inexpensive. (QPainter::restore): Simplify. (QPainter::_drawPoints): Move paintingDisabled check in here. (QPainter::drawText): Removed many unused drawText variants.

• kwq/KWQView.h: Tweaked.
• kwq/KWQView.mm: Removed [KWQView drawRect:].

• kwq/KWQWMatrix.mm: Removed.

• kwq/qt/qwidget.h: Removed paint() virtual function.
• kwq/KWQWidget.mm: Removed QWidget::paint().

• kwq/WebCoreBridge.h: Added new methods installInFrame:, removeFromFrame, mouseDown:, mouseUp:, mouseMoved:, mouseDragged:, copyDOMTree:, and copyRenderTree:.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Call removeFromFrame. (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Don't return the view any more, also set bridgeOwnsKHTMLView to YES. (-[WebCoreBridge copyDOMNode:DOM::copier:]): Added helper method for copyDOMTree. (-[WebCoreBridge copyDOMTree:]): Added method to be used by IFDOMNode to get at DOM tree without using C++. (-[WebCoreBridge copyRenderNode:khtml::copier:]): Added helper method for copyRenderTree. (-[WebCoreBridge copyRenderTree:]): Added method to be used by IFRenderNode to get at render tree without using C++. (-[WebCoreBridge removeFromFrame]): Added. Deletes the view if we own it. We don't want to wait for dealloc time to do this, since a lingering view might be visible. (-[WebCoreBridge installInFrame:]): Added. Does a set of things we need to do at the time we commit a provisional data source. (-[WebCoreBridge addModifiers:toState:]): Moved here from IFHTMLView. (-[WebCoreBridge mouseUp:]): Added. Used to get a mouse up event to the KHTMLView. (-[WebCoreBridge mouseDown:]): Added. Used to get a mouse down event to the KHTMLView. (-[WebCoreBridge mouseMoved:]): Added. Used to get a mouse moved event to the KHTMLView. (-[WebCoreBridge mouseDragged:]): Added. Used to get a mouse moved event to the KHTMLView in the case where we are dragging -- perhaps could be merged with mouseMoved.

• kwq/WebCoreCache.h: Added. Allows control of the WebCore cache; previously done directly in IFCache in WebKit.
• kwq/WebCoreCache.mm: Added.

• kwq/WebCoreFrame.h: Remove widget method. Change semantics of bridge method to return provisional bridge if available, which corresponds to what the widget method did before. Added a committedBridge method that has the semantics that bridge did before.

• kwq/WebCoreJavaScript.h: Added. Returns statistics about the state of JavaScript objects; previously done directly in IFCache in WebKit.
• kwq/WebCoreJavaScript.mm: Added.

WebKit:

Wean WebKit completely from getting at the C++ parts of WebCore.
We probably don't need to use C++ at all for WebKit any more.

• WebKit.pbproj/project.pbxproj: Remove all the header search paths; we don't need any special ones now.

• WebKitPrefix.h: Remove <config.h>; we don't need it any more.

• Misc.subproj/IFCache.h: Rename getStatistics to statistics.
• Misc.subproj/IFCache.mm: (+[IFCache statistics]): (+[IFCache empty]): (+[IFCache setDisabled:]): Call through WebCoreCache instead of going directly to khtml::Cache. (+[IFCache javaScriptObjectsCount]): (+[IFCache javaScriptInterpretersCount]): (+[IFCache javaScriptNoGCAllowedObjectsCount]): (+[IFCache javaScriptReferencedObjectsCount]): (+[IFCache garbageCollectJavaScriptObjects]): Call through WebCoreJavaScript instead of going directly to kjs::Collector.

• WebCoreSupport.subproj/IFWebCoreFrame.m: (-[IFWebCoreFrame bridge]): Change to return bridge from the provisional data source if it exists. (-[IFWebCoreFrame committedBridge]): Do what [bridge] used to do, always returning the bridge from the committed data source and never the provisional one.

• WebView.subproj/IFHTMLView.mm: (-[IFHTMLView provisionalDataSourceChanged:]): Don't store the provisional widget. It's stored in the bridge for the provisional data source. (-[IFHTMLView provisionalDataSourceCommitted:]): Use the bridge method installInFrame: to do most of the work that used to be here. The rest is don in removeFromFrame which is called elsewhere. (-[IFHTMLView mouseUp:]): Use the bridge's mouseUp method. (-[IFHTMLView mouseDown:]): Use the bridge's mouseDown method. (-[IFHTMLView mouseMovedNotification:]): Use the bridge's mouseMoved method. (-[IFHTMLView mouseDragged:]): Use the bridge's mouseDragged method.

• WebView.subproj/IFHTMLViewPrivate.h: Remove the widget, widgetOwned, and provisionalWidget instance variables, and the _widget and _provisionalWidget methods.
• WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _reset]): Remove the code that deleted the widget and the provisional widget. This is now handled elsewhere.

• WebView.subproj/IFDOMNode.mm: Redo to use the copyDOMTree feature of the bridge.
• WebView.subproj/IFRenderNode.mm: Redo to use the copyRenderTree feature of the bridge.

• WebView.subproj/IFRenderNode.h: Use an NSRect instead of four integers (the switch to floating point is OK).

• WebView.subproj/IFWebDataSourcePrivate.h: Add private _removeFromFrame method.
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _removeFromFrame]): Set the controller and location change handler references to nil, and also call [WebCoreBridge removeFromFrame].
• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFramePrivate setDataSource:]): Use _removeFromFrame where we formerly would set the controller and location change handler references to nil.

• WebCoreSupport.subproj/IFWebCoreBridge.h: Tweak.

WebBrowser:

• Debug/CacheController.m: (-[CacheController refreshWebCoreStatisticsMatrix]): Change name of method from getStatistics to statistics.

Jul 13, 2002:

9:33 PM Changeset in webkit [1553] by darin

• 6 edits in trunk/WebKit

WebFoundation:

• AuthenticationManager.subproj/IFAuthenticationManager.m: (-[IFAuthenticationManager dealloc]): Fix leak by adding call to [super dealloc].

WebKit:

• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView dealloc]):
• WebView.subproj/IFImageRepresentation.m: (-[IFImageRepresentation dealloc]): Fix leaks by adding calls to [super dealloc].

WebBrowser:

• Debug/DOMTree.m: (-[DOMTreeDataSource dealloc]):
• Debug/DebugUtilities.m: (-[DebugUtilities dealloc]):
• Debug/RenderTree.m: (-[RenderTreeDataSource dealloc]):
• Debug/ViewTree.m: (-[ViewTreeDataSource dealloc]):
• ListView.m: (-[ListView dealloc]): Fix leaks by adding calls to [super dealloc].

9:27 PM Changeset in webkit [1552] by darin

• 23 edits
  2 deletes in trunk

top level:

• Site/Internal/Design/IFRenamings.txt: Update with new proposals.

WebFoundation:

• AuthenticationManager.subproj/IFAuthenticationManagerCallback.h:
• AuthenticationManager.subproj/IFAuthenticationManagerPrivate.h:
• Misc.subproj/IFCFRunLoopExtensions.m: Changed to use #import instead of #include.

• Database.subproj/IFURLFileDatabase.m: Renamed private struct IFFileAccessTime to FileAccessTime (PointerEqual): Renamed from IFPtrEqual. (FileAccessTimeRelease): Renamed from IFFileAccessTimeRelease.

• Misc.subproj/IFNSThreadExtensions.m: Renamed IFNSJoinableThreadContext to IFJoinableThreadContext for clarity, since there is no NSJoinableThread. (InitJoinableThreads):

WebCore:

• WebCore.pbproj/project.pbxproj: Add a few files that are sources although they should not be compiled for any target.

• kwq/qt/qpushbutton.h: Simplified.
• kwq/KWQPushButton.mm: (QPushButton::QPushButton): Implemented text parameter.

WebKit:

• Misc.subproj/IFNSEventExtras.h: Removed.
• Misc.subproj/IFNSEventExtras.m: Removed.
• WebKit.pbproj/project.pbxproj: Removed IFNSEventExtras.*.

• WebCoreSupport.subproj/IFWebCoreBridge.mm:
• WebView.subproj/IFWebFrame.mm:
• WebView.subproj/IFWebFramePrivate.h:
• WebView.subproj/IFWebFramePrivate.mm: Renamed all bridgeFrame to frameBridge for greater clarity.

• WebView.subproj/IFHTMLView.mm: Updated comments and commented-out code.

• WebView.subproj/IFWebDataSource.h: Fix comment that mentioned IFDefaultWebController.

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _transitionProvisionalToCommitted]): Fix exception string that cited the wrong state name.

8:55 PM Changeset in webkit [1551] by darin

• 71 edits
  130 adds
  1 delete in trunk

top level:

• embed.am: Removed.

Tools:

• Scripts/embed-in-alex: Added. Replaces the rules in embed.am as the way to make our frameworks embed themselves in Alex so we can rebuild a framework and re-run Alex with the changes without building Alex too.

• Scripts/create-forwarding-header: Added. Mainly useful for the one-time job of making forwarding headers for WebCore, but saving for possible use in the future.

• Scripts/commit-log-editor: Make Tools log show up after top level, but before things like JavaScriptCore.

JavaScriptCore:

• Makefile.am: Don't use embed.am any more.
• JavaScriptCore.pbproj/project.pbxproj: Use embed-into-alex instead of make embed.

WebFoundation:

• Makefile.am: Remove include of embed.am.

• WebFoundation.pbproj/project.pbxproj: Remove unneeded ApplicationServices framework search path. Use embed-into-alex instead of make embed.

WebCore:

• ForwardingHeaders/*: Added. New approach to headers to try to make Project Builder's header dependency support work even for includes like #include <render/render_object.h>.
• kwq/kjs/*: Removed. Now part of ForwardingHeaders.

• Makefile.am: Remove embed.am support.

• WebCore.pbproj/project.pbxproj: Remove other search paths, and add ForwardingHeaders directory as a search path. Add qucomextra_p.h.

• khtml/ecma/kjs_navigator.cpp: Made gratuitous changes to touch this file to make things build without requiring clean rebuild.

• khtml/rendering/render_form.cpp: Removed many unneeded QObject:: qualifiers from inside APPLE_CHANGES to touch this file to make things build without requiring clean rebuild.

• kwq/KWQButton.mm: (QButton::setText), (QButton::text):
• kwq/KWQColor.mm: (QColor::setNamedColor):
• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/KWQKHTMLSettings.mm: (KHTMLSettings::stdFontName), (KHTMLSettings::fixedFontName): (KHTMLSettings::serifFontName), (KHTMLSettings::sansSerifFontName), (KHTMLSettings::cursiveFontName), (KHTMLSettings::fantasyFontName), (KHTMLSettings::encoding):
• kwq/KWQKLocale.mm: (i18n):
• kwq/KWQKMessageBox.mm: (KMessageBox::error), (KMessageBox::warningYesNo): (KMessageBox::questionYesNo), (KMessageBox::sorry):
• kwq/KWQListBox.mm: (-[KWQBrowserDelegate browser:willDisplayCell:atRow:column:]):
• kwq/WebCoreBridge.mm: (-[WebCoreBridge selectedText]): Wean from QSTRING_TO_NSSTRING and NSSTRING_TO_QSTRING.

• kwq/KWQComboBox.mm: (QComboBox::insertItem): Wean from QSTRING_TO_NSSTRING. Note that this now stores a copy of the string in the array. The old version was unsafe if anyone later modified the QString that was passed in.

• kwq/KWQFontMetrics.mm: (QFontMetrics::width):
• kwq/KWQPainter.mm: (QPainter::drawUnderlineForText), (QPainter::drawText): Wean from QSTRING_TO_NSSTRING_LENGTH and _FAST_QSTRING_TO_NSSTRING. We still have speed as high as before, in the "length" case slightly faster.

• kwq/qt/qstring.h: Remove QSTRING_TO_NSSTRING family of macros.

• kwq/KWQInvisibleButton.mm:
• kwq/KWQKHTMLPart.mm:
• kwq/KWQKHTMLPartBrowserExtension.mm:
• kwq/KWQKJavaAppletWidget.mm:
• kwq/KWQKloader.mm:
• kwq/KWQView.mm:
• kwq/KWQsignals.mm:
• kwq/WebCoreBridge.mm:
• kwq/kdecore/kconfig.h:
• kwq/kdecore/klibloader.h:
• kwq/kdecore/klocale.h:
• kwq/khtml/khtml_ext.h:
• kwq/khtml/khtml_factory.h:
• kwq/kio/kmimetype.h: Remove subdirectory prefix from imports to match Project Builder include scheme.

• kwq/KWQKCursor.mm: (+[NSCursor _WebCore_linkCursor]):
• kwq/KWQKLocale.mm: (i18n):
• kwq/KWQKstddirs.mm: (locate): Use bundleForClass instead of bundleWithIdentifier to avoid any potential problems with multiple versions of the framework installed on the same system.

• kwq/KWQKLineEdit.mm: (KLineEdit::completionBox): Remove _logNotYetImplemented, since this is implemented well enough for our needs now, and if we need to implement it later, it will become clear from the application behavior. This should be the destiny of most of these.

• kwq/kdecore/kglobal.h: Simplify.
• kwq/KWQKGlobal.mm: Simplify.
• kwq/qt/qlineedit.h: Simplify.
• kwq/KWQLineEdit.mm: Simplify.

• kwq/KWQPaintDeviceMetrics.mm: Remove unneeded import.
• kwq/qt/qbutton.h: Remove unneeded destructor.

WebKit:

• History.subproj/IFURIEntry.m: (-[IFURIEntry image]): Use [IFURIEntry class] instead of [self class] so we get the icon from the WebKit bundle even if someone subclasses IFURIEntry.
• Plugins.subproj/IFNullPluginView.mm: (-[IFNullPluginView initWithFrame:mimeType:arguments:]): Use bundleForClass instead of bundleWithIdentifier so things work even if we have two copies of WebKit installed on the same machine.

• Makefile.am: Remove include of embed.am.

• WebKit.pbproj/project.pbxproj: Use embed-into-alex instead of make embed. Also change bundle identifier to com.apple.WebKit instead of com.apple.webkit to match standard used by our other frameworks. (Checked that we no longer have any hard-coding of the bundle identifier anywhere in our code.)

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Remove unneeded build phase.

3:01 PM Changeset in webkit [1550] by rjw

• 24 edits in trunk

Fixed 2981849 - frames don't always draw correctly.

• WebCoreSupport.subproj/IFWebCoreBridge.mm: (-[IFWebCoreBridge childFrameNamed:]): Check provisional data source first.

• WebView.subproj/IFHTMLViewPrivate.h:
• WebView.subproj/IFHTMLViewPrivate.mm: (-[IFHTMLView _adjustFrames]): Added method to adjust frame geometry.

• WebView.subproj/IFWebDataSourcePrivate.h:
• WebView.subproj/IFWebDataSourcePrivate.mm: (-[IFWebDataSource _layoutChildren]): Added method to adjust child frame geometries.

• WebView.subproj/IFWebFramePrivate.mm: (-[IFWebFrame _isLoadComplete]): Removed unnecessary drawing now that frame geometry is calculated directly.

• kwq/KWQPainter.mm: Added disable drawing mode. (QPainter::drawRect): (QPainter::drawLine): (QPainter::drawEllipse): (QPainter::drawArc): (QPainter::drawLineSegments): (QPainter::drawPolyline): (QPainter::drawPolygon): (QPainter::drawConvexPolygon): (QPainter::drawPixmap): (QPainter::drawTiledPixmap): (QPainter::drawText): (QPainter::drawUnderlineForText): (QPainter::fillRect): (QPainter::setPaintingDisabled):

• kwq/KWQWidget.mm: (QWidget::frameGeometry): Use the IFWebView's geometry.

• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge _drawRect:withPainter:]): (-[WebCoreBridge drawRect:]): (-[WebCoreBridge adjustFrames:]): Added adjustFrames:. Factored some code.

• kwq/qt/qpainter.h: Added setPaintingDisabled.

• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::attach): (HTMLIFrameElementImpl::attach): Removed uniqueness check. Need to revisit vis-a-vis provisional ds.