Timeline

Jul 18, 2002:

10:10 PM Changeset in webkit [1594] by mjs

• 6 edits in trunk/WebKit

More refactoring: Simplify a bit more by moving more logic into
the data source.

• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _gotFirstByte]): Removed. (-[WebDataSource _setGotFirstByte]): Removed. (-[WebDataSource _isReadyForData]): Removed. (-[WebDataSource _receivedData:]): Commit if appropriate, and pass data to representation and documentView.
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]): Change the check back to policy != None, because the first chunk will trigger a commit in the policy == Show case, so there is no need to worry about it.

9:37 PM Changeset in webkit [1593] by mjs

• 7 edits in trunk/WebKit

Rename some methods for clarity. These two methods are defined by
the end state, not the start state (in fact,
transitionToLayoutAcceptable does most of it's work when it starts
in the cimmitted state, not provisional).

• WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Renamed from _transitionProvisionalToLayoutAcceptable. (-[WebFrame _transitionToCommitted]): Renamed from _transitionProvisionalToLayoutAcceptable.

And adjust all the calls to them:

• WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedProgress:forResourceHandle:fromDataSource:complete:]): (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]):

9:13 PM Changeset in webkit [1592] by mjs

• 18 edits in trunk/WebKit

Even more exciting refactoring. Change the rules for committing
the data source and creating the representation so that both
happen when the first byte has been received _and_ the content
policy has been set to show. Previously these actions happened at
different times. Now we maintain the invariant that the data
source has a representation if and only if it is committed.

• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Simplify further by putting more of the work in WebDataSource.
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedProgress:forResourceHandle:fromDataSource:complete:]):

• WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: Move makeRepresentation method to private file.
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setContentPolicy:]): If the policy is set to show, commit if we have already gotten the first byte. (-[WebDataSource _commitIfReady]): Create representation and commit if we have the first byte and have a policy of show. (-[WebDataSource _gotFirstByte]): Method to check if this data source has gotten the first byte yet. Commit here if ready. (-[WebDataSource _setGotFirstByte]): Method to report that some data has been received. (-[WebDataSource _makeRepresentation]): Make and set up teh document view too. (-[WebDataSource _isReadyForData]): Return TRUE if policy is set (and if the policy is Show, if we have also received the first byte.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Don't call the datasource (it now calls us)
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient WebResourceHandle:resourceDataDidBecomeAvailable:]):

• WebView.subproj/WebView.h, WebView.subproj/WebView.m: move makeDocumentViewForDataSource...
• WebView.subproj/WebViewPrivate.h, WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]): To here.

5:06 PM Changeset in webkit [1591] by hyatt

• 4 edits in trunk/WebCore

• khtml/css/css_valueimpl.cpp: Changed the QRegExps used for font family matching to statics. Helped out one page on the base tests a fair bit. Overall (spread over all 40 pages) it's not that big though.

12:05 PM Changeset in webkit [1590] by mjs

• 3 edits in trunk/WebKit

Avoid throwing an exception while stopping animations. Image
renders were getting into the array multiple times, which means
the code that iterated over the array backwards could throw an
exception, because callling removeObject: on the array would remove
all instances of the object.

This probably fixes the following crashers, and a bunch of huge leaks:

Radar 2999853 - Uninitialized memory access in plugins on theonion.com
Radar 2999892 - Crash disconnecting view from next view chain on theonion.com
Radar 2999911 - Infinite loop in [WebHTMLView dealloc], resulting in crash

• WebCoreSupport.subproj/WebImageRenderer.m: (-[WebImageRenderer scheduleFrame]): Move adding to array of image renderers from here... (-[WebImageRenderer beginAnimationInRect:fromRect:]): To here.

11:22 AM Changeset in webkit [1589] by hyatt

• 4 edits in trunk/WebCore

Small change that gives us 25% speedup (uncached) on the cvs-base suite.

• khtml/css/cssstyleselector.cpp: Optimized CLASS style comparison to avoid allocing QStrings when the CLASS attribute only contains one entry (as opposed to a list of entries).

9:35 AM Changeset in webkit [1588]

• 3 copies in tags/Alexander-13

This commit was manufactured by cvs2svn to create tag 'Alexander-13'.

9:35 AM Changeset in webkit [1587] by sheridan

• 8 edits in trunk

markers & version for Alex-13

1:46 AM Changeset in webkit [1586] by mjs

• 7 edits in trunk/WebKit

Yet still more refactoring in preparation for the KHTMLPart
change. This is preparing things to change the commit rule to
require receiving at least one byte of data, and having the
content policy set to Show.

• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Remove more code since makeRepresentation now does most of the work.
• WebView.subproj/WebDataSource.m: (-[WebDataSource makeRepresentation]): Tell the WebView (if any) to create the documentView now too.
• WebView.subproj/WebView.h:
• WebView.subproj/WebView.m: (-[WebView makeDocumentViewForDataSource:]): Hook document view up to data source.

12:47 AM Changeset in webkit [1585] by mjs

• 5 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Bail early if not loading. (-[WebDataSource _commit]): Method to mark when the data source is committed (it now knows whether it's committed or provisional). This will be useful for adding assertions later on about what operations may happen only when committed, and which can only happen when provisional.

• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionProvisionalToCommitted]): Call data source's _commit method.

Jul 17, 2002:

8:55 PM Changeset in webkit [1584] by rjw

• 1 edit in trunk/WebKit/WebKit.pbproj/project.pbxproj

Made WebDocument.h public.

8:13 PM Changeset in webkit [1583] by rjw

• 3 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: Removed unnecessary (and incorrect) lockFocus.

3:24 PM Changeset in webkit [1582] by mjs

• 14 edits in trunk/WebKit

Some refactoring in preparation for the KHTMLPart change.

• WebView.subproj/WebController.m: (-[WebController haveContentPolicy:andPath:forDataSource:]): Move more of the work of creating and setting the representation and document view into WebDataSource and WebView.

• WebView.subproj/WebDataSource.h, WebView.subproj/WebDataSource.m: (+[(id <WebDocumentRepresentation>) createRepresentationForMIMEType:]): Removed. (-[WebDataSource makeRepresentation]): A method to build the right kind of representation for the content type.

• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _representationClass]): Method to get the right representation class for the current content type. (-[WebDataSource _bridge]): Move here from WebBridge.[mh], so we can later add an assertion that the data source is not provisional.

• WebView.subproj/WebHTMLViewPrivate.m: #import WebDataSourcePrivate.h
• WebView.subproj/WebView.h, WebView.subproj/WebView.m: (+[(id <WebDocumentRepresentation>) createDocumentViewForMIMEType:]): Removed. (-[WebView makeDocumentViewForMIMEType:]): Method to build the right kind of document view for the specified MIME type.

3:02 PM Changeset in webkit [1581] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Take out bogus check for nil path -- a URL with a nil path is OK, for example "about:blank". Also improved log message.