Timeline

Jul 22, 2002:

10:26 PM Changeset in webkit [1633] by darin

• 13 edits
  2 adds in trunk/WebCore

• khtml/rendering/render_text.cpp: (TextSlave::printSelection): Add comments to APPLE_CHANGES. (TextSlave::printDecoration): Add comments to APPLE_CHANGES. (TextSlave::checkSelectionPoint): Add comments to APPLE_CHANGES.

• khtml/xml/dom_stringimpl.cpp: Add comments to APPLE_CHANGES.

• khtml/xml/xml_tokenizer.cpp: (XMLTokenizer::end): Remove APPLE_CHANGES.
• kwq/KWQsignals.mm: Add a new signal dummy function.

• kwq/WebCoreJavaScript.h: Fix header.
• kwq/WebCoreJavaScript.mm: Fix header.

• kwq/WebCoreSettings.h: Added. Not used yet.
• kwq/WebCoreSettings.m: Added. Not used yet.
• WebCore.pbproj/project.pbxproj: Added WebCoreSettings.h and .m.

• English.lproj/InfoPlist.strings: Fixed a spelling error.

• kwq/WebCoreTextRendererFactory.h: Tweak.

10:04 PM Changeset in webkit [1632] by mjs

• 6 edits in trunk/WebCore

Fixed Radar 3004897 - assert at mapquest

• khtml/html/html_baseimpl.cpp: (HTMLIFrameElementImpl::attach): Put back frame name uniqueness check. Lack of this check was causing duplicate frames to be left floating in space.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestFrame): Add an assertion that no frame of the requested name already exists.

6:05 PM Changeset in webkit [1631] by hyatt

• 6 edits in trunk/WebCore

Fix for bug 3004889, plugin content on stylesheet pages not
showing up. The rendering tree needed to perform an update
when all children had arrived, and this was being handled by
the parser. With async rendering construction, I had to store
this in the content node instead, so it could do the update
once the render object was built at a later date.

• khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::HTMLObjectElementImpl): (HTMLObjectElementImpl::attach):
• khtml/html/html_objectimpl.h:
• khtml/html/htmlparser.cpp: (KHTMLParser::processCloseTag):

3:30 PM Changeset in webkit [1630] by hyatt

• 11 edits in trunk/WebCore

This checkin adds support for querying the selected style set,
for querying the preferred style set, and for changing the
selected style set dynamically. With this checkin, a Web page
in Alexander now has the capability to present its own alternate
stylesheet UI in the page and to toggle between sets using script.

• khtml/dom/css_stylesheet.cpp: (DocumentStyle::preferredStylesheetSet): (DocumentStyle::setSelectedStylesheetSet): (DocumentStyle::selectedStylesheetSet):
• khtml/dom/css_stylesheet.h: Added new methods to the DocumentStyle interface as per Hixie's proposed spec.

• khtml/dom/dom_doc.cpp:
• khtml/dom/dom_doc.h:
• khtml/ecma/kjs_dom.cpp: (DOMDocument::getValueProperty): (DOMDocument::tryPut): (DOMDocument::putValue):
• khtml/ecma/kjs_dom.h: Implement the JS binding glue for the new properties.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::processHttpEquiv): (DocumentImpl::preferredStylesheetSet): (DocumentImpl::selectedStylesheetSet): (DocumentImpl::setSelectedStylesheetSet): (DocumentImpl::recalcStyleSelector):
• khtml/xml/dom_docimpl.h: The implementation of the new properties. Also fixed a bug caused by the 3.02 merge in the stylesheet filtering code in recalcStyleSelector.

1:19 PM Changeset in webkit [1629] by rjw

• 10 edits in trunk/WebKit

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• WebView.subproj/WebController.h:
• WebView.subproj/WebController.m: (-[WebController backForwardList]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): (-[WebControllerPrivate dealloc]):

Moved back/forward list from Alex's document to WebController. First step
to address a series of back/forward related issues.

• BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument dealloc]): (-[BrowserDocument goToURL:]): (-[BrowserDocument _backForwardList]): (-[BrowserDocument canGoBack]): (-[BrowserDocument canGoForward]): (-[BrowserDocument goBack:]): (-[BrowserDocument goForward:]):

10:44 AM Changeset in webkit [1628] by cblu

• 3 edits in trunk/WebKit

WebKit:

Strip white space before and after URL string 2998696

• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_bestURLForDraggingInfo:]):

WebBrowser:

Added document icon.

• WebBrowser.pbproj/project.pbxproj:
• document.icns: Added.

7:59 AM Changeset in webkit [1627] by kocienda

• 3 edits in trunk/WebKit

• WebView.subproj/WebHTMLView.m: import of removed WebFrame bridge header was left in, causing a build break.

7:01 AM Changeset in webkit [1626] by mjs

• 17 edits
  4 deletes in trunk

WebCore:

Merged WebCoreBridge and WebCoreFrameBridge.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::urlSelected): Use bridge, not frameBridge. (KWQKHTMLPartImpl::submitForm): Use bridge, not frameBridge. (KWQKHTMLPartImpl::findFrame): Use bridge, not frameBridge. (KWQKHTMLPartImpl::frames): Use bridge, not frameBridge.
• kwq/WebCoreBridge.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge dealloc]): Free RenderPart if set. (-[WebCoreBridge renderPart]): Moved here from WebFrameBridge. (-[WebCoreBridge setRenderPart:]): Moved here from WebFrameBridge. (-[WebCoreBridge copyRenderNode:khtml::copier:]): No more need to get render part from frame bridge. (-[WebCoreBridge installInFrame:]): No more need to get render part from frame bridge.
• kwq/WebCoreFrameBridge.h: Removed.
• kwq/WebCoreFrameBridge.mm: Removed.
• WebCore.exp: Removed WebCoreFrameBridge.
• WebCore.pbproj/project.pbxproj: Removed WebCoreFrameBridge.

WebKit:

Merged WebBridge and WebFrameBridge.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge childFrames]): Return bridges, not frameBridges. (-[WebBridge descendantFrameNamed:]): Return bridge, not frameBridge. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Return a bridge, not a frameBridge. (-[WebBridge mainFrame]): Return a bridge, not a frameBridge. (-[WebBridge frameNamed:]):Return a bridge, not a frameBridge. (-[WebBridge loadURL:attributes:flags:withParent:]): Moved from WebFrameBridge. (-[WebBridge loadURL:]): Moved from WebFrameBridge. (-[WebBridge postWithURL:data:]): Moved from WebFrameBridge.
• WebCoreSupport.subproj/WebFrameBridge.h: Removed.
• WebCoreSupport.subproj/WebFrameBridge.m: Removed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Don't create a WebFrameBridge.
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): No longer dealloc frameBridge, since we don't have one. (-[WebFrame _transitionToCommitted]): Pass along the frame's render part, if any. (-[WebFrame _frameBridge]): Removed.
• WebKit.pbproj/project.pbxproj: Removed deleted files.

4:45 AM Changeset in webkit [1625] by mjs

• 8 edits in trunk/WebKit

Change WebBridge to hold on to a WebFrame instead of a
WebDataSource. Since we will no longer ever have a bridge for a
provisional data source, we'll just bind the bridge to a
frame. Which means we can merge the bridge and the frame bridge
next.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: Changed below methods to work with direct knowledge of the frame but not the bridge (mostly a simplification). (-[WebBridge frame]): (-[WebBridge parent]): (-[WebBridge childFrames]): (-[WebBridge descendantFrameNamed:]): (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge openNewWindowWithURL:]): (-[WebBridge areToolbarsVisible]): (-[WebBridge setToolbarsVisible:]): (-[WebBridge areScrollbarsVisible]): (-[WebBridge setScrollbarsVisible:]): (-[WebBridge isStatusBarVisible]): (-[WebBridge setStatusBarVisible:]): (-[WebBridge setWindowFrame:]): (-[WebBridge window]): (-[WebBridge setStatusText:]): (-[WebBridge mainFrame]): (-[WebBridge frameNamed:]): (-[WebBridge receivedData:withDataSource:]): (-[WebBridge objectLoadedFromCache:size:]): (-[WebBridge setFrame:]): (-[WebBridge dataSourceChanged]): (-[WebBridge dataSource]): (-[WebBridge openedByScript]): (-[WebBridge setOpenedByScript:]):

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _commitIfReady]): Set bridge's frame and notify that the data source changed.
• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Set bridge's frame.
• WebView.subproj/WebFramePrivate.h, WebView.subproj/WebFramePrivate.m: (-[WebFrame _bridge]): Method to get the bridge.

1:32 AM Changeset in webkit [1624] by mjs

• 11 edits in trunk

WebCore:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• kwq/KWQScrollView.mm: Remove mention of provisional widget from comment.
• kwq/WebCoreFrameBridge.h: Remove commitedBridge method, and remove comment about provisionality from bridge method.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write): Remove bogus comment about provisional/committed transition. (KWQKHTMLPartImpl::findFrame): Call bridge, not committedBridge. (KWQKHTMLPartImpl::frames): Likewise.

WebKit:

Removed provisional/committed distinction from WebCore and the
WebCore SPI. WebCore will never see a provisional data source or
provisional anything, any more.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge descendantFrameNamed:]): Don't bother with the provisional bridge - no such thing. (-[WebBridge setDataSource:]): Assert the data source is committed.
• WebCoreSupport.subproj/WebFrameBridge.m: (-[WebFrameBridge bridge]): Return committed bridge always, and remove committed bridge method.

Jul 21, 2002:

10:38 PM Changeset in webkit [1623] by darin

• 109 edits
  1 add in trunk

JavaScriptCore:

• kjs/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

WebCore:

• khtml/*: Roll KDE 3.0.2 changes in. Also switch to not using APPLE_CHANGES for some of the changes that we definitely want to contribute upstream.

• WebCore.pbproj/project.pbxproj: Add KWQStyle.mm, remove KWQStyle.h, moving contents into qstyle.h.

• kwq/KWQApplication.mm: (QApplication::globalStrut): Remove _logNotYetImplemented().

• kwq/KWQButton.mm: (QButton::QButton): Use plain release, not autorelease.
• kwq/KWQComboBox.mm: (QComboBox::init): Use plain release, not autorelease.
• kwq/KWQListBox.mm: (QListBox::QListBox): Use plain release, not autorelease.
• kwq/KWQPainter.mm: (QPainter::drawArc): Use plain release, not autorelease.

• kwq/KWQKHTMLPartBrowserExtension.mm: Remove import of KWQKHTMLPartImpl.h, now that it's always part of khtml_part.h.
• kwq/KWQKHTMLPartImpl.cpp: Simplify.
• kwq/KWQKHTMLPartImpl.h: Add wrapper to allow multiple inclusion. Don't include khtml_part.h any more, since that file now includes this one to minimize changes to KDE code that needs to get to functions in here.
• kwq/KWQKHTMLPartImpl.mm: (KHTMLPart::onURL), (KHTMLPart::nodeActivated), (KHTMLPart::setStatusBarText): Moved here from khtml_part.cpp.
• kwq/KWQLoaderImpl.mm: Include khtml_part.h instead of KWQKHTMLPartImpl.h.

• kwq/KWQPushButton.mm: (buttonFontMetrics), (QPushButton::fontMetrics): Added. Used by the form code to size buttons.
• kwq/KWQStyle.mm: Added. (QStyle::sizeFromContents): Added. Used by the form code to size buttons.

• kwq/KWQStyle.h: Removed.
• kwq/qt/qstyle.h: Moved contents of KWQStyle.h in here.
• kwq/qt/qwidget.h: Include <qstyle.h> rather than KWQStyle.h.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge isFrameSet]): Call straight to impl.

• kwq/kdeui/klineedit.h: Add KLineEdit::frameWidth().
• kwq/qt/qnamespace.h: Remove GUIStyle, MacStyle, and WindowsStyle.
• kwq/qt/qpaintdevice.h: Add QInternal, QInternal::Printer, and QPaintDevice::devType().
• kwq/qt/qpainter.h: Add QPainter::device().
• kwq/qt/qpushbutton.h: Add QPushButton::fontMetrics().

6:59 PM Changeset in webkit [1622] by mjs

• 14 edits in trunk

WebCore:

Fix a recent regression that made JavaScript window closing
crash. Window closing was counting on delayed dealloc/destruction
of things associated with the window, but now that we have made
deallocs more synchronous, we need to add an explicit delay in
this case.

Also, change some fprintf diagnostics of things that should never
happen into assertions, since I actually ran into one.

• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::end): Change fprintf diagnostic to assertion, remove comment that the diagnostic should be removed. (KWQKHTMLPartImpl::scheduleClose): Renamed from close, changed to schedule window closing from the run loop rather than doing it immediately.
• khtml/ecma/kjs_window.cpp: (Window::scheduleClose): Adjusted for above rename.

WebKit:

Fix a regression in my recent refactoring that broke JavaScript
window opening, by doing some trickery to make a frame's initial
dummy data source committed.

• WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Create dummy data source as committed, not provisional.
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Allow the documentView to be nil if there is no webView either; this is temporarily needed to handle the special initial dummy data source, which will be going away soon.
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _receivedData:]): Add temporary special case to avoid sending empty NSData to the representation, to avoid triggering WebCore assertions.
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:]): Get the committed data source, not the provisional one.

6:55 PM Changeset in webkit [1621] by hyatt

• 5 edits in trunk/WebCore

Alternate stylesheet support. Fixed numerous bugs in the handling of alternate sheets and implemented the ability to select alternate sheets per 14.3.2 of the HTML4 spec.

2:23 PM Changeset in webkit [1620] by cblu

• 6 edits in trunk/WebKit

WebKit:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file) in 3 places where we accept drags.

• Misc.subproj/WebNSViewExtras.h:
• Misc.subproj/WebNSViewExtras.m: (-[NSView _web_parentWebView]): no changes (-[NSView _web_acceptableDragTypes]): added (-[NSView _web_bestURLForDraggingInfo:]): added (-[NSView _web_dragOperationForDraggingInfo:]): added
• WebKit.pbproj/project.pbxproj: made WebNSViewExtras.h public
• WebView.subproj/WebView.m: (-[WebView initWithFrame:]): calls _web_acceptableDragTypes (-[WebView draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[WebView concludeDragOperation:]): calls _web_bestURLForDraggingInfo

WebBrowser:

Used darin-inspired code factoring to fix 3000801 (alex doesn't accept drag of webloc file)
in 3 places where we accept drags.

• BrowserNSViewExtras.h:
• BrowserNSViewExtras.m: removed locationField specific drag methods
• LocationFieldEditor.m: (-[LocationFieldEditor acceptableDragTypes]): calls _web_acceptableDragTypes (-[LocationFieldEditor draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationFieldEditor concludeDragOperation:]): calls _web_bestURLForDraggingInfo
• LocationTextField.m: (-[LocationTextField awakeFromNib]): calls _web_acceptableDragTypes (-[LocationTextField draggingEntered:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField draggingUpdated:]): calls _web_dragOperationForDraggingInfo (-[LocationTextField concludeDragOperation:]): calls _web_bestURLForDraggingInfo

10:54 AM Changeset in webkit [1619] by cblu

• 4 edits in trunk/WebKit

WebKit:

• We were loading icons when page loads ended in error. Fixed.
• Special-case file URLs once instead of twice by moving NSWorkspace call out of WebIconLoader

• Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading]): removed file URL special-case
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): check for document error, send file

WebBrowser:

• Comparison between a float and int was causing download history to be erased
• Set the dock mini window to display # of active downloads

• DownloadMonitor.h: renamed _hourlyTimer to _removeExpiredTimer
• DownloadMonitor.m: (-[DownloadMonitor dealloc]): (-[DownloadMonitor updateProgressUI]): set mini dock title (-[DownloadMonitor windowDidLoad]):

4:00 AM Changeset in webkit [1618] by mjs

• 11 edits in trunk

top level:

• Tests/ObjcUnit/Makefile.am: Remove products from symroots on `make clean'.
• Tests/TestPlugin/Makefile.am: Remove products from symroots on `make clean'.
• Tests/WebFoundation-CacheLoader/Makefile.am: Remove products from symroots on `make clean'.

Tools:

• CommitLogEditor/Makefile.am: Remove products from symroots on `make clean'.
• HotSpotFinder/Makefile.am: Remove products from symroots on `make clean'.

JavaScriptCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebFoundation:

• Makefile.am: Remove products from symroots on `make clean'.

WebCore:

• Makefile.am: Remove products from symroots on `make clean'.

WebKit:

• Makefile.am: Remove products from symroots on `make clean'.

WebBrowser:

• Makefile.am: Remove products from symroots on `make clean'.

3:21 AM Changeset in webkit [1617] by mjs

• 4 edits in trunk/WebCore

• WebCore.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:37 AM Changeset in webkit [1616] by mjs

• 3 edits in trunk/WebKit

• WebKit.pbproj/project.pbxproj: Set directories for the group folders, so that creating new files in them will put them in the right directory by default.

2:11 AM Changeset in webkit [1615] by mjs

• 6 edits in trunk/WebKit

More refactoring. Change bridge to get the data source via a
method instead of straight from the ivar, and in the method,
assert that the data source is not nil and is not
provisional. Turns out no one was using it while provisional,
which is great. This means we can eliminate the provisional
concept from the bridge interface as the next step.

• WebCoreSupport.subproj/WebBridge.h:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSource]): New method to get data source - assert it is not nil, and committed. (-[WebBridge frame]): Get data source from method. (-[WebBridge childFrames]): Likewise. (-[WebBridge descendantFrameNamed:]): Likewise. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Likewise. (-[WebBridge openNewWindowWithURL:]): Likewise. (-[WebBridge areToolbarsVisible]): Likewise. (-[WebBridge setToolbarsVisible:]): Likewise. (-[WebBridge areScrollbarsVisible]): Likewise. (-[WebBridge setScrollbarsVisible:]): Likewise. (-[WebBridge isStatusBarVisible]): Likewise. (-[WebBridge setStatusBarVisible:]): Likewise. (-[WebBridge setWindowFrame:]): Likewise. (-[WebBridge window]): Likewise. (-[WebBridge setTitle:]): Likewise. (-[WebBridge setStatusText:]): Likewise. (-[WebBridge mainFrame]): Likewise. (-[WebBridge frameNamed:]): Likewise. (-[WebBridge receivedData:withDataSource:]): Likewise. (-[WebBridge startLoadingResource:withURL:]): Likewise. (-[WebBridge objectLoadedFromCache:size:]): Likewise. (-[WebBridge setDataSource:]): Likewise. (-[WebBridge openedByScript]): Likewise. (-[WebBridge setOpenedByScript:]): Likewise. (-[WebBridge setIconURL:]): Likewise. (-[WebBridge setIconURL:withType:]): Likewise.
• WebView.subproj/WebDataSourcePrivate.h, WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _isCommitted]): New private method to check if a data source is committed, for the benefit of WebBridge assertions.

12:46 AM Changeset in webkit [1614] by hyatt

• 6 edits in trunk/WebCore

Apologies for the lack of the changelog info. I need help setting that up on my laptop. I did edit the changelog, and you can see it there. This is a fix to speed up list boxes.