⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Jul 24, 2002:

6:38 PM Changeset in webkit [1666] by cblu
  • 4 edits in trunk/WebKit

tiny change

  • WebView.subproj/WebDefaultContextMenuHandler.m:
6:34 PM Changeset in webkit [1665] by cblu
  • 9 edits in trunk/WebKit

Added implmentations for a few context menu items.

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebDefaultContextMenuHandler.h:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): (-[WebDefaultContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[WebDefaultContextMenuHandler validateUserInterfaceItem:]): (-[WebDefaultContextMenuHandler openNewWindowWithURL:]): (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): (-[WebDefaultContextMenuHandler copyLinkToClipboard:]): (-[WebDefaultContextMenuHandler openImageInNewWindow:]): (-[WebDefaultContextMenuHandler copyImageToClipboard:]): (-[WebDefaultContextMenuHandler reloadImage:]): (-[WebDefaultContextMenuHandler openFrameInNewWindow:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
4:11 PM Changeset in webkit [1664] by rjw
  • 4 edits in trunk/WebKit

Removed vestigal locationChangeHandler ivar.

  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):
3:59 PM Changeset in webkit [1663] by hyatt
  • 4 edits in trunk/WebCore

Fix for bug 2953423, viamichelin.com lays out incorrectly.
Remove a completely bogus optimization in the KHTML code that
attempted to bail when the specified width was 0. This was
a very basic problem, and it should fix other pages that were
laying out incorrectly as well.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layout):
3:54 PM Changeset in webkit [1662] by cblu
  • 3 edits in trunk/WebKit

Call [self _locationChangeHandler] instead of _private-locationChangeHandler

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource receivedPageIcon:]):
3:41 PM Changeset in webkit [1661] by rjw
  • 3 edits in trunk/WebKit

Implemented find for text views.

3:36 PM Changeset in webkit [1660] by cblu
  • 7 edits in trunk/WebKit

Implemented initial contextual menus. All disabled right now.

  • WebView.subproj/WebDefaultContextMenuHandler.h:
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler dealloc]): added (-[WebDefaultContextMenuHandler addMenuItemWithTitle:action:toArray:]): added (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): create menu items
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
2:22 PM Changeset in webkit [1659] by darin
  • 4 edits in trunk/WebCore
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Remove code that reset m_frameNameId, to complete Maciej's change to fix bug 3006354.
2:14 PM Changeset in webkit [1658] by cblu
  • 8 edits in trunk/WebKit

More renaming for WebDefaultPolicyHandler.

  • WebView.subproj/WebController.m: (-[WebController policyHandler]):
  • WebView.subproj/WebDefaultPolicyHandler.h:
  • WebView.subproj/WebDefaultPolicyHandler.m:
2:07 PM Changeset in webkit [1657] by cblu
  • 3 edits
    4 adds
    2 deletes in trunk/WebKit

Renamed WebDefaultControllerPolicyHandler to WebDefaultPolicyHandler.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebDefaultControllerPolicyHandler.h: Removed.
  • WebView.subproj/WebDefaultControllerPolicyHandler.m: Removed.
  • WebView.subproj/WebDefaultPolicyHandler.h: Added.
  • WebView.subproj/WebDefaultPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):
1:55 PM Changeset in webkit [1656] by cblu
  • 14 edits
    4 adds in trunk/WebKit

More plumbing for contextual menu support.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setContextMenuHandler:]): added (-[WebController contextMenuHandler]): added
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): alloc WebDefaultContextMenuHandler (-[WebControllerPrivate dealloc]): dealloc WebDefaultContextMenuHandler (-[WebController _defaultContextMenuHandler]):
  • WebView.subproj/WebDefaultContextMenuHandler.h: Added.
  • WebView.subproj/WebDefaultContextMenuHandler.m: Added. (-[WebDefaultContextMenuHandler contextMenuItemsForElementInfo:defaultMenuItems:]): new
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): call contextMenuHandlers
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _setController:]): added comment (-[WebHTMLView _controller]): added
1:37 PM Changeset in webkit [1655] by darin
  • 25 edits in trunk

top level:

  • Site/Internal/Quality/fontsizes.html: Added test cases for "+/-" and "0".

WebCore:

  • fixed 2906567 -- Font size calculations should use 96 dpi instead of 72 dpi
  • fixed 3005932 -- fonts specified in 'ex' units rendered waaaaaaay too large
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Use a default font size that's the same as small, rather than a "medium font size". Don't multiply the values from settings by the scaling factor. (CSSStyleSelector::applyRule): Make the default font size here for nodes with no parents be small (m_fontSizes[2]) rather than medium (m_fontSizes[3]).
  • khtml/html/html_inlineimpl.cpp: (parseFontSizeNumber): Added. Tolerant of non-numeric characters after the numeric size. Also distinguishes a size like "0" from something that's not a numeric size at all. (HTMLFontElementImpl::parseAttribute): Use parseFontSizeNumber, but also make size 3 be the same as CSS_VAL_SMALL, not CSS_VAL_MEDIUM. This mistake (using CSS_VAL_MEDIUM) led to all kinds of strangeness in the KHTML code, including mishandling of 0 and the need to create CSS_VALKONQ_XXX_LARGE. Also change code so that 0 is treated as CSS_VAL_SMALL (same as 3) rather than CSS_VAL_XX_SMALL. This makes 0 between -1 and +1.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Make default font size be small (fontSizes()[2]) rather than medium (fontSizes()[3]).
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::HTMLTableElementImpl): Make default font size be CSS_VAL_SMALL, not CSS_VAL_MEDIUM.
  • kwq/qt/qfontmetrics.h:
  • kwq/KWQFontMetrics.mm: (QFontMetrics::xHeight): Added.
  • kwq/WebCoreTextRenderer.h: Added xHeight.
  • khtml/css/css_valueimpl.cpp: (CSSPrimitiveValueImpl::computeLengthFloat): Use xHeight rather than computing the height of an actual letter 'x'.
  • khtml/rendering/render_object.cpp: (RenderObject::getVerticalPosition): Use xHeight rather than computing the height of an actual letter 'x'.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]): Fixed backwards if that prevented font changes from being reflected in the browser window.
  • kwq/khtml/khtml_settings.h:
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::defaultFontSize):
  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.m: (-[WebCoreSettings setDefaultFontSize:]): (-[WebCoreSettings defaultFontSize]): Replace mediumFontSize with defaultFontSize.
  • WebCore.pbproj/project.pbxproj: Rearrange some of the files.

WebKit:

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer xHeight]): Added. Calls [NSFont xHeight].
  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): (-[WebPreferences defaultFontSize]): (-[WebPreferences setDefaultFontSize:]): Renamed minimumFont to defaultFont, and changed it from 11 to 16. Also changed default monospaced font to Courier instead of Monaco.

WebBrowser:

  • Preferences.subproj/TextPreferences.m: (-[TextPreferences defaultFontSize]), (-[TextPreferences setDefaultFontSize:]): Change to use new WebPreferences mediumFontSize (since default is the same as small, not medium).
  • BrowserDocument.m: (-[BrowserDocument reapplyStyles:]): Use setNeedsDisplay: instead of display. It's impolite and unnecessary to do an explicit display.
  • WebBrowser.pbproj/project.pbxproj: Small name tweak.
1:14 PM Changeset in webkit [1654] by rjw
  • 12 edits in trunk

Support for find in HTML, find in text view coming soon.

  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView searchFor:direction:caseSensitive:]):
  • WebView.subproj/WebTextView.h:
  • WebView.subproj/WebTextView.m: (-[WebTextView searchFor:direction:caseSensitive:]):

Support for find in HTML.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge searchFor:direction:caseSensitive:]):
10:31 AM Changeset in webkit [1653] by darin
  • 19 edits in trunk/WebCore
  • fixed 2949235 -- checkboxes in wrong place until you scroll away and back

The problem here was that we put views in when we print, but we never removed them.
I added code to keep track of existing views, and remove them if they are not re-added.

  • kwq/KWQKHTMLPartImpl.h: Add paint, addedWidget, buildViewsNotAddedSet, and viewsNotYetAdded. It might be nice to find a different place to hang this that is not included by the KHTML code. But I think that having this on the bridge would be worse.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::paint): Added. Removes any views that are not explicitly added by RenderWidget during the print process. (KWQKHTMLPartImpl::addedWidget): Added. Called by KWQScrollView to tell us a view was added. (KWQKHTMLPartImpl::buildViewsNotYetAddedSet): Added. Used to build the initial set of views.
  • kwq/KWQScrollView.mm: (QScrollView::addChild): Added call to KWQKHTMLPartImpl::addedWidget.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]): Calls KWQKHTMLPartImpl::paint.
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::frameGeometry), (KWQWindowWidget::mapToGlobal), (KWQWindowWidget::mapFromGlobal), (KWQWindowWidget::internalSetGeometry): Fixed logic to work properly for windows not on main screen.
  • khtml/khtml_part.cpp: Moved the boundary of an existing ifndef APPLE_CHANGES so that KHTMLPart::show() and hide() are not compiled, mainly for clarity.
  • khtml/rendering/render_replaced.cpp: (RenderWidget::detach): Removed unneeded APPLE_CHANGES.
  • kwq/KWQWindowWidget.h: Removed some unneeded virtual functions.
  • kwq/qt/qscrollview.h: Removed some unneeded virtual functions, made others non-virtual.
  • kwq/qt/qwidget.h: Removed some unneeded virtual functions, made others non-virtual.
  • kwq/KWQWidget.mm: Removed a lot of unused and unneeded stuff.
  • force-clean-timestamp: Needed to do this because I changed header files.
8:26 AM Changeset in webkit [1652] by darin
  • 4 edits in trunk/WebCore

top level:

  • Tests/kde/kurl-test.cpp: (main): Added a test case for a relative URL with a leading space in it.
  • Tests/kde/kurl-test.chk: Added the expected result.

WebCore:

  • fixed 3006329 - space should be stripped from beginning of relative url
  • kwq/KWQKURL.mm: (KURL::normalizeRelativeURLString): Added a call to stripWhiteSpace.
2:37 AM Changeset in webkit [1651] by mjs
  • 5 edits in trunk/WebCore

Made frame names globally unique, not just unique per parent frame

  • this is needed to avoid triggering the assertion in 3006354 (Assertion failure on salon.com). Clearing my cache made the assertion go away by itself, but it seems good to avoid the possibility of triggering it in the future.
  • khtml/khtmlpart_p.h: Make m_partNameId static.
  • khtml/khtml_part.cpp: Initialize it here.
12:19 AM Changeset in webkit [1650] by darin
  • 5 edits in trunk/WebCore
  • 3006336 -- crash in _NSDescriptionWithLocaleFunc
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Don't use the result of getNSString() on a C++ temporary object. We could also fix this by doing retain autorelease in getNSString().

Jul 23, 2002:

11:58 PM Changeset in webkit [1649] by cblu
  • 14 edits in trunk

WebCore:

More plumbing for contextual menu support.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge completeURLForDOMString:]): renamed (-[WebCoreBridge elementInfoAtPoint:]): renamed
  • kwq/qt/qpixmap.h: added an accessor to the WebCoreImageRenderer

WebKit:

More plumbing for contextual menu support.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]):
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _elementInfoAtPoint:]): added
9:01 PM Changeset in webkit [1648] by darin
  • 10 edits in trunk

WebFoundation:

  • WebFoundation.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebCore:

  • WebCore.pbproj/project.pbxproj: Fix file reference types to be more consistent.
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag): Changed indenting to use spaces, makes our diff with KDE smaller. (HTMLTokenizer::end): Remove unneeded APPLE_CHANGES.
  • kwq/KWQDOMNode.cpp: Tweak.
  • kwq/KWQDOMNode.h: Tweak.

WebKit:

  • WebKit.pbproj/project.pbxproj: Fix file reference types to be more consistent.

WebBrowser:

  • WebBrowser.pbproj/project.pbxproj: Fix file reference types to be more consistent.
7:46 PM Changeset in webkit [1647] by hyatt
  • 4 edits in trunk/WebCore

Fix bug 2803155 - images not displayed on ​http://bscw.gmd.de.
My fix is to use our newfound quirks mode to implement a comment
parsing quirk (this is how Mozilla handles this same issue).
Only in quirks mode, the tokenizer will treat <!--> atomically as
a complete comment.

This is bug 34302 on bugs.kde.org, for those who are curious.

  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseTag):
6:33 PM Changeset in webkit [1646] by cblu
  • 13 edits
    2 adds in trunk

WebCore:

Initial plumbing for contextual menu support.

  • WebCore.pbproj/project.pbxproj:
  • kwq/KWQDOMNode.cpp: Added. (isImage):
  • kwq/KWQDOMNode.h: Added.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge _URLForDOMString:]): added (-[WebCoreBridge _elementInfoForMouseEvent:]): added

WebKit:

Initial plumbing for contextual menu support.

  • WebCoreSupport.subproj/WebBridge.h:
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge elementInfoForMouseEvent:]): added
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView menuForEvent:]): added
6:22 PM Changeset in webkit [1645] by rjw
  • 4 edits in trunk/WebCore

Turn on find related code in part in preparation for
implementing find in WebKit.

  • khtml/khtml_part.cpp: (KHTMLPart::init): (KHTMLPart::clear): (KHTMLPart::findTextNext):
5:55 PM Changeset in webkit [1644] by darin
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Fix paths for newly added files.
5:53 PM Changeset in webkit [1643] by hyatt
  • 6 edits in trunk/WebCore

Fixing two bugs here. The first is bug with @import sheets not inheriting strict parsing mode from their parent sheet.
This means all @import sheets are being treated as strict mode!

The second bug is in KWQ. We were never calling determineParseMode, so we always defaulted to strict mode, and therefore
were highly intolerant of unitless numbers on absolutely positioned blocks. This fixes many problems, notably www.netscape.com
and ZDNet.com on the cvs-base tests.

  • khtml/css/cssparser.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::write):
5:19 PM Changeset in webkit [1642] by rjw
  • 16 edits
    2 adds in trunk/WebKit

Use one LocationChangeHandler.
Cleaned up (a little) fallback URL code. This code
is still a convoluted and could be further untaggled.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument init]): (-[BrowserDocument _goToURL:withFrameLoadType:fallbackURLs:]): (-[BrowserDocument tryMultipleURLs:]): (-[BrowserDocument _goToNextFallbackURL]):
  • BrowserDocumentPrivate.h:
  • BrowserWebController.h:
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): (-[BrowserWindowController frameLoadRedirected:]): (-[BrowserWindowController frameLoadTryingFallback]):
  • LocationChangeHandler.h:
  • LocationChangeHandler.m: (-[LocationChangeHandler initWithBrowserDocument:]): (-[LocationChangeHandler dealloc]): (-[LocationChangeHandler locationChangeCommittedForDataSource:]): (-[LocationChangeHandler locationChangeDone:forDataSource:]): (-[LocationChangeHandler serverRedirectTo:forDataSource:]):

Cleaned up LocationChangeHandler. We now have one per controller.

  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController policyHandler]): (-[WebController setLocationChangeHandler:]): (-[WebController locationChangeHandler]):
  • WebView.subproj/WebControllerPolicyHandler.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]):

(-[WebDataSource _setIsDummy:)
(-[WebDataSource _isDummy]):
Hack on hack. MJS will remove when the dummy data source hack is removed.

(-[WebDataSource _locationChangeHandler]):
(-[WebDataSource _removeFromFrame]):
(-[WebFrame initWithName:webView:provisionalDataSource:controller:]):
(-[WebFrame setProvisionalDataSource:]):

  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]):

Added default policy handler. This is used if no policy handler is
set on the controller.

  • WebView.subproj/WebDefaultControllerPolicyHandler.h: Added.
  • WebView.subproj/WebDefaultControllerPolicyHandler.m: Added. (-[WebDefaultControllerPolicyHandler initWithWebController:]): (-[WebDefaultControllerPolicyHandler URLPolicyForURL:]): (-[WebDefaultControllerPolicyHandler fileURLPolicyForMIMEType:dataSource:isDirectory:]): (-[WebDefaultControllerPolicyHandler unableToImplementFileURLPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler requestContentPolicyForMIMEType:dataSource:]): (-[WebDefaultControllerPolicyHandler unableToImplementURLPolicyForURL:error:]): (-[WebDefaultControllerPolicyHandler unableToImplementContentPolicy:forDataSource:]): (-[WebDefaultControllerPolicyHandler pluginNotFoundForMIMEType:pluginPageURL:]):
  • WebView.subproj/WebFrame.m:
4:24 PM Changeset in webkit [1641] by darin
  • 4 edits in trunk/WebCore

top level:

  • Tests/kde/kurl-test.chk: Updated test results to match what real web browsers need to do rather than what the RFC says for paths beginning with "../" or "./".
  • Tests/kde/kurl-test.cpp: (main): Add comments for tests where the results are not matching the RFC.

WebCore:

  • fixed 3004818 -- relative urls are assembled incorrectly at ticketmaster
  • fixed 2999279 -- Invalid URI in request at subpage of swatch.com

The issue here is URLs with paths that start with "/../". RFC 2396 says one
thing, and that's what CFURL does. But real web browsers do another thing.

  • kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::KWQKURLPrivate): Clean up a bit by removing unneeded init(). (escapeQString): Don't make a copy of the passed-in QString. (pathEndsWithSlash): Don't make a copy of the passed-in QString. (copyEscapedPath): Make this a static function instead of extern. (KURL::KWQKURLPrivate::decompose): Add the new "../" and "./" logic.
4:09 PM Changeset in webkit [1640] by hyatt
  • 5 edits in trunk/WebCore
  • khtml/rendering/font.cpp: Fix deployment build bustage by including <algorithm>.
  • khtml/rendering/render_frames.cpp: (RenderPartObject::calcReplacedWidth): Fix a bug with ​http://www.moveabletype.com's top portion not showing up (bug 2986714). A hack was being improperly applied to fixed width plugins, when it should have only been applied to variable width plugins.
11:48 AM Changeset in webkit [1639] by darin
  • 7 edits in trunk

WebCore:

  • Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.

WebKit:

  • Makefile.am: Clean based on all, not all-am, so it happens before subdirs if any.
11:45 AM Changeset in webkit [1638] by darin
  • 33 edits
    1 add in trunk

top level:

  • Tests/kde/kurl-test.cpp: (main): Add a lot of new tests. One of them demonstrates the issue underlying bug 3004818. The others are taken straight from the URI RFC (2396).
  • Tests/kde/kurl-test.chk: Expected results for new tests.
  • autogen.sh: Add the new WebCore timestamp file.

WebCore:

Changes require a make clean because of the Project Builder bug.
So I added the "make clean timestamp" hackery.

  • .cvsignore: Ignore the new clean timestamp.
  • force-clean-timestamp: Added.
  • Makefile.am: Add rules for making clean happen.
  • khtml/html/html_formimpl.cpp: (HTMLGenericFormElementImpl::defaultEventHandler): Fix NULL dereference bug in here that I ran into. Code later down in the same function has the check for NULL, so clearly this is just a bug.
  • khtml/rendering/font.cpp: (Font::drawText): Simplify by using new drawText that takes a QChar array, no need to make a QConstString.
  • khtml/rendering/render_text.cpp: (TextSlave::printDecoration): Simplify by using new drawUnderlineForText that takes a QChar array, no need to make a QConstString.
  • kwq/WebCoreTextRenderer.h: Change underline-drawing to use a UniChar array.
  • kwq/qt/qpainter.h:
  • kwq/KWQPainter.mm: (QPainter::drawText): Change to take QChar array instead of a QString, but also discovered a bizarre overloading thing that was happening before and dealt with that by adding a new drawText that still does take a QString. (QPainter::drawUnderlineForText): Change to take QChar array.
  • kwq/qt/qcolor.h: Mark constructor explicit, so we don't get subtle strangess like where the string to draw was being converted to a QColor.
  • khtml/css/cssstyleselector.cpp: No need for APPLE_CHANGES for this change any more.
  • kwq/kdecore/kcharsets.h:
  • kwq/KWQKCharsets.mm: Remove unused functions.
  • kwq/khtml/khtml_settings.h:
  • kwq/KWQKHTMLSettings.mm: Remove unused functions.
  • kwq/qt/qfont.h:
  • kwq/KWQFont.mm: Simplify.
  • kwq/KWQPaintDeviceMetrics.mm: Simplify.
  • kwq/qt/qtextcodec.h:
  • kwq/KWQtextcodec.mm: (QTextCodec::codecForName): Remove unused parameter.

WebKit:

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawUnderlineForCharacters:stringLength:atPoint:withColor:]): Change API to take character array instead of a string.
  • WebKit.pbproj/project.pbxproj: Took "subproj" off the names of some groups.
10:54 AM Changeset in webkit [1637] by hyatt
  • 5 edits in trunk/WebCore

The STYLE element was ignoring both the media and type
attributes (unlike its cousin, the LINK element). This
patch implements support for media and type and further
stops us from loading stylesheets that we should have no
business parsing.

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::process): (HTMLStyleElementImpl::parseAttribute): (HTMLStyleElementImpl::insertedIntoDocument): (HTMLStyleElementImpl::removedFromDocument): (HTMLStyleElementImpl::childrenChanged): (HTMLStyleElementImpl::sheetLoaded):
  • khtml/html/html_headimpl.h:
9:34 AM Changeset in webkit [1636]
  • 3 copies in tags/Alexander-14

This commit was manufactured by cvs2svn to create tag 'Alexander-14'.

9:34 AM Changeset in webkit [1635] by sheridan
  • 8 edits in trunk

Alex-14 versioning

12:34 AM Changeset in webkit [1634] by hyatt
  • 4 edits in trunk/WebCore
  • khtml/html/html_objectimpl.cpp: (HTMLObjectElementImpl::attach): Oops. I accidentally removed the call to an ancestor class attach function. What made this subtle is that it deliberately skipped over a couple of base classes and called the one three superclasses up. When I went to put it back in, I messed up and called the base class instead of the distant ancestor.

Silly me. marvel.com and matadorrecords.com should be ok now.

Note: See TracTimeline for information about the timeline view.