⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 5, 2002:

11:04 PM Changeset in webkit [1746] by mjs
  • 9 edits in trunk

WebCore:

Fixed crashers and leaks that come up when changing the view
associated with a part.

  • khtml/khtmlview.cpp: (KHTMLView::~KHTMLView): Don't zero out the part's view, because that will mess up setting a new one.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:width:height:marginWidth:marginHeight:]): Destroy the old view if we own it.

WebKit:

fixed 2974993 - window.open does not return the right window object
fixed 3017140 - WebKit creates a new KHTMLPart per page; should
reuse it like KHTML does

  • WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation setDataSource:]): Don't swap the part at this point. Now it gets reused.
10:23 PM Changeset in webkit [1745] by mjs
  • 3 edits in trunk/WebKit
  • WebKit.pbproj/project.pbxproj: Fix tyops that broke Development build.
9:54 PM Changeset in webkit [1744] by darin
  • 9 edits in trunk

WebCore:

  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURLInFrame): (KWQKHTMLPartImpl::urlSelected): (KWQKHTMLPartImpl::requestFrame): (KWQKHTMLPartImpl::requestObject): Add some nil checks before making calls with nil NSURL objects. But we also have to figure out how to report some kind of error in these cases, because the current behavior is not so good.

WebKit:

  • .cvsignore: Ignore WebCore-combined.exp.
9:35 PM Changeset in webkit [1743] by mjs
  • 13 edits
    1 add in trunk

JavaScriptCore:

  • fixed 3007072 - need to be able to build fat

WebFoundation:

  • fixed 3007072 - need to be able to build fat
  • WebFoundation.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebCore:

  • fixed 3007072 - need to be able to build fat
  • WebCore.pbproj/project.pbxproj: Fixed DeploymentFat build.

WebKit:

  • fixed 3007072 - need to be able to build fat
  • WebKit.pbproj/project.pbxproj: Fixed DeploymentFat build.
  • Makefile.am: Build WebCore-combined.exp for Development and Mixed build.
  • WebKit-tests.exp: Added.
  • WebKit.exp: Remove test-only function.

WebBrowser:

  • fixed 3007072 - need to be able to build fat
  • WebBrowser.pbproj/project.pbxproj: Fixed DeploymetFat build.
9:21 PM Changeset in webkit [1742] by darin
  • 23 edits in trunk

WebCore:

  • fixed 3016374 -- Change font default from small back to medium
  • khtml/css/cssstyleselector.cpp: (CSSStyleSelector::computeFontSizes): Change back to basing everything on mediumFontSize() as opposed to a defaultFontSize that was the same as "small". (CSSStyleSelector::applyRule): Default is m_fontSizes[3] again.
  • khtml/html/html_inlineimpl.cpp: (HTMLFontElementImpl::parseAttribute): Shift all the sizes up one, so 3 is now medium. It's important that 3 be the same as the default.
  • khtml/html/html_tableimpl.cpp: (HTMLTableElementImpl::attach): Change the default back to medium.
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::recalcStyle): Change the default back to [3].
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFontSize): Change name back.
  • kwq/khtml/khtml_settings.h: Change name back to medium.

Do a little bit of wiring for the "text size multiplier" feature.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setTextSizeMultiplier:]): Added.

WebKit:

Do the wiring for the "text size multiplier" feature. The rest of the work will probably be done
at the WebCore level.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setFrame:]): Set the text size multiplier.
  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setTextSizeMultiplier:]): Added. Calls _textSizeMultiplierChanged on the main frame. (-[WebController textSizeMultiplier]): Added.
  • WebView.subproj/WebControllerPrivate.h: Added textSizeMultiplier instance variable.
  • WebView.subproj/WebFramePrivate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _textSizeMultiplierChanged]): Added. Calls setTextSizeMultiplier: on the bridge, and _textSizeMultiplierChanged on all the child frames.
9:15 PM Changeset in webkit [1741] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Renamed icon loader delegate method to include the icon loader.

  • Misc.subproj/WebIconLoader.h:
  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader WebResourceHandleDidFinishLoading:data:]):
  • WebView.subproj/WebDataSourcePrivate.m:

WebBrowser:

Rendezvous changes:
Properly get host's IP address.
Load and display host's favicon.

  • English.lproj/Rendezvous.nib:
  • RendezvousController.m: (-[RendezvousController windowDidLoad]): (-[RendezvousController _attributedStringWithImage:]): (-[RendezvousController goToHostDoubleAction:]): (-[RendezvousController tableView:objectValueForTableColumn:row:]): (-[RendezvousController netServiceBrowser:didFindService:moreComing:]): (-[RendezvousController netServiceBrowser:didRemoveService:moreComing:]): (+[RendezvousController _URLForNetService:]): (-[RendezvousController netServiceDidResolveAddress:]): (-[RendezvousController iconLoader:receivedPageIcon:]):
7:38 PM Changeset in webkit [1740] by rjw
  • 1 edit in trunk/WebKit/WebCoreSupport.subproj/WebTextRendererFactory.m

Added a comment.

7:35 PM Changeset in webkit [1739] by rjw
  • 3 edits in trunk/WebKit

Added additional check to find appropriate fonts with available
weight, rather than always using a weight of 5.

Regarding "kCGErrorFailure : can't find name id 4 for font id 8395" errors:
CG appears to be lying to us about some fonts, Verdana in particular.
It claims to have an available Verdana font w/ the correct traits, but spits errors
when we request that font. Further, the Font Panel behaves oddly when you request
Verdana. The panel displays the font but if you select the font it doesn't
'stick'. A mystery.

  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory fontWithFamily:traits:size:]):
6:23 PM Changeset in webkit [1738] by darin
  • 7 edits in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsstringextensions-test.chk:
  • Tests/WebFoundation-Misc/ifnsstringextensions-test.m: (main): Added test cases for _web_stringByCollapsingNonPrintingCharacters.

WebFoundation:

  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_stringByCollapsingNonPrintingCharacters]): Added. Collapses any non-printing characters into single spaces, and trims them from the ends too.

WebCore:

  • fixed 3009321 -- bookmark and history menus show black square for (tm)
  • khtml/html/htmltokenizer.cpp: (HTMLTokenizer::parseSpecial): Call fixUpChar. (HTMLTokenizer::parseText): Call fixUpChar. (HTMLTokenizer::parseTag): Call fixUpChar.

WebKit:

  • fixed 2986567 -- suppress return characters from title in title bar, status bar, menu items
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setTitle:]): Call _web_stringByCollapsingNonPrintingCharacters.
5:23 PM Changeset in webkit [1737] by rjw
  • 3 edits
    1 add in trunk/WebKit

Added exported symbols file.

  • WebKit.exp: Added.
  • WebKit.pbproj/project.pbxproj:
4:19 PM Changeset in webkit [1736] by darin
  • 4 edits in trunk/WebCore
  • kwq/make-charset-table.pl: Added a hack that makes us treat for iso-8859-8-e and iso-8859-8-i the same as iso-8859-8; may not be exactly right, but it's probably OK modulo the actual bidi support.
3:47 PM Changeset in webkit [1735] by darin
  • 8 edits in trunk/WebKit

WebFoundation:

  • fixed 3015360 -- google.com, click on images link, stop icon spins forever
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle contentLengthReceived]): Fixed race condition where sizes of objects would jump down to 0 by returning the length of resourceData here instead of the mark. (-[WebResourceHandle _setLoad:]): Added. (-[WebResourceHandle _load]): Added. (-[WebResourceHandle _notifyClientsDidCancelLoading]): Do the WebResourceHandleDidBeginLoading calls outside the lock/unlock also.
  • CacheLoader.subproj/WebResourceHandlePrivate.h: Added _setLoad: and _load.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad handleCount]): Add call to checkForNewHandles. (-[WebResourceLoad _submittedAttributes]): Added. (-[WebResourceLoad cleanup]): Pass the load to loadDidFinish, rather than passing a handle.
  • CacheLoader.subproj/WebResourceLoadManager.m: (-[WebResourceLoadManagerInstanceVariables init]): (-[WebResourceLoadManagerInstanceVariables dealloc]): (-[WebResourceLoadManager invalidateURL:]): (-[WebResourceLoadManager addLoad:forHandle:]): (-[WebResourceLoadManager requestWithURLHandle:]): (-[WebResourceLoadManager cancelRequestWithURLHandle:]): (-[WebResourceLoadManager loadDidFinish:]):
  • CacheLoader.subproj/WebResourceLoadManager.m: Added new WebResourceLoadKey class, rather than trying to trick handles themselves into acting as keys. This works better for the case where a single load is shared by two handles. There's no telling which will be cancelled first, so there's no obvious choice for which to use as the key. (-[WebResourceLoadManager requestWithURLHandle:]): Rewrote for new scheme. I think it's a little less tricky than before, but it's also more terse. (-[WebResourceLoadManager cancelRequestWithURLHandle:]): Rewrote this too. (-[WebResourceLoadManager loadDidFinish:]): This too.
  • CacheLoader.subproj/WebResourceLoadManagerPrivate.h: Change parameter type of loadDidFinish to WebResourceLoad. Removed unused cancelAllRequestsWithURL and cancelAllRequestsInGroup.
  • CacheLoader.subproj/WebResourceLoadPrivate.h: Removed unused removeAllHandles, cancelIfServingOneHandle, and added _submittedAttributes.
  • CacheLoader.subproj/WebResourceLoad.h: Removed canonicalURL.
  • CacheLoader.subproj/WebFileProtocolHandler.m:
  • CacheLoader.subproj/WebHTTPProtocolHandlerPrivate.m:
  • CacheLoader.subproj/WebHTTPResourceLoader.m:
  • CacheLoader.subproj/WebResourceLoadQueue.m: [WebResourceLoad url] now always returns a canonical URL. Got rid of [WebResourceLoad canonicalURL] and updated callers.
  • CacheLoader.subproj/WebResourceLoadManager.h: Tweak.
  • Misc.subproj/WebNSDictionaryExtras.m: Fix definitions to match header.

WebKit:

  • fixed 3014122 -- spinner never stops spinning when iframe has URL with bad path
  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Initialize the state in WebFramePrivate init instead.
  • WebView.subproj/WebFramePrivate.h: Remove WebFrameStateUninitialized.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate init]): Set initial state to WebFrameStateComplete. (-[WebFrame _transitionToLayoutAcceptable]): Remove WebFrameStateUninitialized case. (-[WebFrame _transitionToCommitted]): Remove WebFrameStateUninitialized case. (-[WebFrame _isLoadComplete]): Remove WebFrameStateUninitialized case.
  • WebView.subproj/WebDataSource.h: Tweak.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource stopLoading]): Move downloadHandler logic from here into _stopLoading. (-[WebDataSource isLoading]): Rewrite for simplicity.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _stopLoading]): Move downloadHandler logic here from stopLoading. Also make this work even if handles are removed from the list during the stop process. (-[WebDataSource _recursiveStopLoading]): Simplify a lot by using WebFrame's stopLoading. (-[WebDataSource _setTitle:]): Use the committed boolean rather than the state to check if the title change should be sent to the location change handler.
9:07 AM Changeset in webkit [1734] by mjs
  • 3 edits in trunk/WebKit
  • Misc.subproj/WebKitDebug.h: Put WEBKIT_ASSERT_NOT_REACHED() inside the appropriate #ifdef, and remove the various _log macros, which are onsolete in WebKit.
4:30 AM Changeset in webkit [1733] by mjs
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Simplified a bit.
4:08 AM Changeset in webkit [1732] by mjs
  • 15 edits in trunk

WebCore:

Merged KHTMLPart::end method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::end): Remove call to impl. Use original version, but clear KURL cache and call slotFinishedParsing as well.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::end): Removed. (KWQKHTMLPartImpl::gotoBaseAnchor): Removed. No longer needed.
  • kwq/KWQKURL.mm: (KURL::encodedHtmlRef): Implemented. (KURL::htmlRef): Implemented.
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge scrollToBaseAnchor]): Removed. No longer needed.

WebKit:

Some changes related to re-merging the KHTMLPart end() method:

  • Misc.subproj/WebKitDebug.h: Added WEBKIT_ASSERT_NOT_REACHED().
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToLayoutAcceptable]): Replace NSException with ASSERT_NOT_REACHED (this is an internal consistency check, not an argument check on a public API, so an assert is more appropriate than an exception). (-[WebFrame _transitionToCommitted]): Likewise. (-[WebFrame _isLoadComplete]): Likewise; also, remove bridge call to scrollToBaseAnchor:, since that will now happen automatically when calling end.
2:07 AM Changeset in webkit [1731] by mjs
  • 8 edits in trunk/WebCore

Merged KHTMLPart::openURL method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::openURL): Don't call the impl version. Leave most of this #ifdef'd, except the parts that look useful.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Removed.
1:13 AM Changeset in webkit [1730] by mjs
  • 11 edits in trunk/WebCore

Merged KHTMLPart::begin method with khtml original.

  • khtml/khtml_part.cpp: (KHTMLPart::begin): Restore this method and don't call the impl version. ifdef out the parts that don't compile.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::begin): Removed.
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::showAnimations): Implemented; always return false. (KHTMLSettings::userStyleSheet): Implemented; always return empty string.
  • kwq/kdecore/kurl.h: Implemented isValid as inline method.

Aug 4, 2002:

4:13 PM Changeset in webkit [1729] by hyatt
  • 4 edits in trunk/WebCore

Fix my bungled CSS for input fields in the user agent style
sheet.

  • khtml/css/html4.css:
Note: See TracTimeline for information about the timeline view.