⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 7, 2002:

11:24 PM Changeset in webkit [1774] by mjs
  • 19 edits in trunk

WebCore:

WebCore work for:

  • fixed 2956008 - Need API for getting/setting text encoding for current page
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::slotData): Handle the possibility of override encoding - one that's not just a hint from the server but should override
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge addData:withEncoding:]): Adjust for slotData interface change. (-[WebCoreBridge addData:withOverrideEncoding:]): New method that allows passing override encoding as a CFStringEncoding. (-[WebCoreBridge textEncoding]): Return the current text encoding.

WebKit:

WebKit work for:

  • fixed 2956008 - Need API for getting/setting text encoding for current page
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge receivedData:withDataSource:]): Handle override encoding, if any.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:attributes:flags:]): Remember the flags and attributes.
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate init]): Initialize overrideEncoding (-[WebDataSourcePrivate dealloc]): Release attributes (-[WebDataSource _setOverrideEncoding:]): Added. (-[WebDataSource _overrideEncoding]): Added. (-[WebDataSource _flags]): Added. (-[WebDataSource _attributes]): Added.
  • WebView.subproj/WebFrame.m: (-[WebFrame startLoading]): Pass proper forceRefresh value to data source based on load type (but the data source will ignore it). (-[WebFrame reload:]): Made this work a bit better. Now instead of crashing, it will actually reload, but it won't force a refresh (and may not handle the back/forward issues properly).
  • WebView.subproj/WebDocument.h: Defined new WebDocumentTextEncoding protocol.
  • WebView.subproj/WebHTMLView.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView textEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setTextEncoding:]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView setDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol. (-[WebHTMLView usingDefaultTextEncoding]): Implemented WebDocumentTextEncoding protocol.

WebBrowser:

  • fixed 2957200 - Text Encoding submenu is not yet implemented
  • AppController.h:
  • AppController.m: (-[AppController applicationDidFinishLaunching:]): Install standard Text Encoding menu items.
  • BrowserWindowController.h:
  • BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): Validate the menu items properly, based on whether the current view can change encodings. (-[BrowserWindowController changeTextEncoding:]): Hook up to new WebKit API.
  • English.lproj/MainMenu.nib: Add Default item to encoding menu, hook it up to AppController.
  • TextEncodingMenu.h: Added. Stolen from Mail.
  • TextEncodingMenu.m: Added. Stolen from Mail.
  • WebBrowser.pbproj/project.pbxproj: Added new files.
6:19 PM Changeset in webkit [1773] by hyatt
  • 1 edit in trunk/WebCore/khtml/css/cssstyleselector.cpp

Fix build bustage.

6:15 PM Changeset in webkit [1772] by hyatt
  • 12 edits in trunk/WebCore

Adding support for a separate fixed font size to WebCore.
Your fixed font size pref will now be honored when the
generic monospace family is used.

  • khtml/css/cssstyleselector.cpp:
  • khtml/css/cssstyleselector.h:
  • khtml/rendering/font.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::mediumFixedFontSize):
  • kwq/WebCoreSettings.h:
  • kwq/WebCoreSettings.m: (-[WebCoreSettings setFixedFontSize:]): (-[WebCoreSettings fixedFontSize]):
  • kwq/khtml/khtml_settings.h:
1:30 PM Changeset in webkit [1771] by darin
  • 4 edits in trunk/WebCore
  • fixed 3017499 -- One-click crasher at hondamotorcycle.com
  • kwq/KWQKURL.mm: (operator==): Just compare the strings. Faster and safer.
12:33 PM Changeset in webkit [1770] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3017245 -- Shift-Delete should go forward
  • WebView.subproj/WebView.m: (-[WebView keyDown:]): Check for shift-delete.
12:19 PM Changeset in webkit [1769] by rjw
  • 9 edits in trunk

Fixed scrollview related drawing turd problems.
(3000844 and 2896459).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
  • WebView.subproj/WebView.m: (-[WebView setFrame:]):

Removed debug log.

  • kwq/KWQFrame.mm: (QFrame::setFrameStyle):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
12:03 PM Changeset in webkit [1768] by darin
  • 8 edits in trunk

top level:

  • Tests/WebFoundation-Misc/ifnsurlextensions-test.m: New test that tests more of the code in WebNSExtras.
  • Tests/WebFoundation-Misc/ifnsurlextensions-test.chk: New output for new test. Matches the old for canonicalize test cases.

WebFoundation:

  • fixed 3017633 -- IPv6 URL support needed
  • fixed 2876174 -- Some URL functions should be moved to IFNSURLExtensions and have test cases added
  • Misc.subproj/WebNSURLExtras.h: Removed _web_extractHTTPBaseURLString and _web_URLWithScheme:user:password:host:port:path:parameter:query:fragment:, renamed _web_URLWithoutFragment to _web_URLByRemovingFragment.
  • Misc.subproj/WebNSURLExtras.m: (ReleaseIfNotNULL): Added. Used by the component-related functions. (StringByAddingPercentEscapes): Broken out from URLStringByAddingPercentEscapes. (URLStringByAddingPercentEscapes): Add code to handle the IPv6 case but make sure we escape any other bracket characters in the string. (+[NSURL _web_URLWithComponents:]): Added. (-[NSURL _web_URLComponents]): Added. These use the CFURL functions for breaking URLs into components, but makes them easier to use from AppKit by using autoreleased NSString objects and also fixes some anomalies in the CFURL functions. (-[NSURL _web_URLByRemovingFragment]): Simpler implementation, new name. (-[NSURL _web_URLByRemovingUserAndQueryAndFragment]): Added. Replaces WebNSURLRemoveUserAndSubresourceInfo. (-[NSURL _web_URLByRemovingPasswordAndPath]): Added. Replaces WebNSURLCanonicalRoot. (-[NSURL _web_URLByRemovingLastPathComponent]): Added. Replaces WebNSURLGetParent. (-[NSURL _web_canonicalize]): Rewrote to use _web_URLComponents.
  • CacheLoader.subproj/WebFileProtocolHandler.m: (+[WebFileProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.
  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (+[WebHTTPProtocolHandler canonicalizeURL:]): Rewrite to use _web_URLComponents.
  • AuthenticationManager.subproj/WebAuthenticationManager.m: Remove WebNSURLRemoveUserAndSubresourceInfo, WebNSURLCanonicalRoot, and WebNSURLGetParent, and use equivalent functions from WebNSURLExtras.
  • Misc.subproj/WebNSStringExtras.h:
  • Misc.subproj/WebNSStringExtras.m: (-[NSString _web_hasCaseInsensitivePrefix:]): Added.

WebCore:

  • kwq/KWQKURL.mm: (KURL::KWQKURLPrivate::decompose): Use CFURLCopyPath instead calling _NSParseStringToGenericURLComponents.

WebKit:

  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Call _web_URLWithoutFragment by its new name _web_URLByRemovingFragment.
11:03 AM Changeset in webkit [1767] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3018632 - the show javascript files inline bug

  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]): support application/x-javascript
  • WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]): support application/x-javascript
10:43 AM Changeset in webkit [1766] by sullivan
  • 7 edits in trunk/WebKit

WebKit:

  • Misc.subproj/WebNSViewExtras.h:
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_superviewOfClass:]): Changed name from _web_superviewWithName: and made it take a Class object instead of a string.
  • Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView drawRect:]):
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView start]): (-[WebPluginView layout]): Updated callers of _web_superviewWithName:
  • WebKit.pbproj/project.pbxproj: Changed WebNSViewExtras.h from Public to Private

WebBrowser:

  • BrowserNSViewExtras.h,
  • BrowserNSViewExtras.m: Remove superviewOfClass now that it's in WebKit
  • ActivityViewer.m: (-[ActivityViewer bestSizeForWindowContent]): Use _web_superviewOfClass:
9:28 AM Changeset in webkit [1765] by rjw
  • 1 edit in trunk/WebCore/kwq/WebCoreBridge.mm

Fixed compile problem.

9:22 AM Changeset in webkit [1764] by rjw
  • 4 edits in trunk/WebCore

Turned off temporary debugging I accidentally checked in.

  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):

Aug 6, 2002:

10:46 PM Changeset in webkit [1763] by hyatt
  • 6 edits in trunk/WebCore

Make user stylesheet changes dynamic. Web documents will now
update as the user stylesheet is applied and unapplied. Altered
how reapplyStyles works a bit.

  • khtml/khtml_part.cpp: (KHTMLPart::reparseConfiguration):
  • khtml/xml/dom_docimpl.cpp: (DocumentImpl::setUserStyleSheet):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge reapplyStyles]):
9:19 PM Changeset in webkit [1762] by hyatt
  • 5 edits in trunk/WebCore

Enable user stylesheet support. It works from a fresh start but
is not yet completely dynamic.

  • khtml/khtml_part.cpp: (KHTMLPart::setUserStyleSheet):
  • kwq/KWQKHTMLSettings.mm: (KHTMLSettings::userStyleSheet):
9:12 PM Changeset in webkit [1761] by darin
  • 12 edits in trunk

WebCore:

  • fixed 2965321 -- Crash on window close in kthml::Loader::cancelRequests from particular page
  • khtml/misc/loader.cpp: (Loader::servePendingRequests): Look at return value from KWQServeRequest instead of assuming it will always succeed.
  • kwq/KWQLoaderImpl.h: Add return value for KWQServeRequest.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Return false if we fail to make either the NSURL or the WebResourceHandle. Also make sure that we delete the job if necessary.

WebKit:

Fix assert I saw while fixing bug 2965321.

  • WebView.subproj/WebControllerPrivate.m: (-[WebController _receivedError:forResourceHandle:partialProgress:fromDataSource:]): Create a suitable resource identifier from the failing URL in the WebError for cases where we fail before we are able to construct a resource handle.
8:58 PM Changeset in webkit [1760] by sullivan
  • 4 edits in trunk/WebCore
  • force-clean-timestamp: Edited this file to force a make clean in WebCore after discovering that it was necessary the hard way. I'm not sure which earlier checkin made this be required.
8:39 PM Changeset in webkit [1759] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::overURL): Fix crash in overURL, another case just like bug 3006336.
8:29 PM Changeset in webkit [1758] by darin
  • 3 edits in trunk/WebKit
  • fixed 2970516 -- Activate Events don't appear to be coming in to the Java Applet.plugin correctly.
  • Plugins.subproj/WebPluginView.m: (-[WebPluginView sendActivateEvent:]): Use activeFlag to set modifiers, not activMask, which is an event mask.
7:05 PM Changeset in webkit [1757] by rjw
  • 11 edits in trunk/WebCore

Frame resizing related changes. Frames are now resizable
w/ a resize bar. Still need to draw frame borders.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize): (RenderFrame::slotViewCleared):
  • kwq/KWQFrame.mm: (QFrame::setFrameStyle): (QFrame::frameStyle): (QFrame::frameWidth):
  • kwq/KWQWidget.mm: (QWidget::lockDrawingFocus): (QWidget::unlockDrawingFocus): (QWidget::flushDrawing): (QWidget::enableFlushDrawing): (QWidget::disableFlushDrawing): (QWidget::setDrawingAlpha): (QWidget::displayRect):
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge drawRect:withPainter:]):
  • kwq/qt/qframe.h:
  • kwq/qt/qwidget.h:
5:57 PM Changeset in webkit [1756] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

Add mechanism to store userStyleSheet preferences in WebKit in
preparation for Dave wiring up the implementation.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (-[WebPreferences userStyleSheetEnabled]), (-[WebPreferences setUserStyleSheetEnabled:]), (-[WebPreferences userStyleSheetLocation]), (-[WebPreferences setUserStyleSheetLocation:]): New methods, read and write UserDefaults values.

(+[WebPreferences load]): Set initial values for
userStyleSheetEnabled and userStyleSheetLocation

WebBrowser:

Updated to use userStyleSheet preferences from WebKit.

  • Defaults.plist,
  • PreferenceKeys.h: Remove preference keys for ApplyStyleSheet since this is in WebKit now.
  • Preferences.subproj/AppearancePreferences.m: (-[AppearancePreferences setStylesheetPathPreference:]), (-[AppearancePreferences stylesheetPathPreference]), (-[AppearancePreferences updateStylesheetViews]), (-[AppearancePreferences toggleApplyStylesheet:]): Update to use WebKit preferences API; remove local storage.
4:28 PM Changeset in webkit [1755] by mjs
  • 16 edits in trunk

WebCore:

Removed some APPLE_CHANGES no longer needed after the part change.

  • khtml/khtml_part.cpp: (KHTMLPart::openedByJS): Don't call impl version. (KHTMLPart::setOpenedByJS): Don't call impl version.
  • kwq/KWQKHTMLPartImpl.h:
  • kwq/KWQKHTMLPartImpl.mm: Removed openedByJS and setOpenedByJS.
  • kwq/WebCoreBridge.h: Don't prototype setOpenedByScript: and openedByScript methods now that they are not needed.

WebKit:

Removed some APPLE_CHANGES no longer needed after the part change.

  • WebCoreSupport.subproj/WebBridge.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: Remove setOpenedByScript: and openedByScript methods now that they are not needed.
3:37 PM Changeset in webkit [1754] by darin
  • 8 edits in trunk/WebKit

WebKit:

  • fixed 3017761 -- dataSource != nil assertion navigating at yahoo.com
  • WebView.subproj/WebLocationChangeHandler.h:
  • WebView.subproj/WebLocationChangeHandler.m: Change client redirect calls to pass the frame, not the data source. At the time a client redirect is requested, it's not even clear yet which data source will be involved. We may want to make some of the other calls pass frames, also, aside from the "start", "committed", "done", calls, which must specify the data source.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Pass frame, not data source. (-[WebBridge reportClientRedirectCancelled]): Pass frame, not data source.

WebBrowser:

Update for change to client redirect API.

  • LocationChangeHandler.m: (-[LocationChangeHandler clientRedirectTo:delay:fireDate:forFrame:]): (-[LocationChangeHandler clientRedirectCancelledForFrame:]): We get the frame now, not the data source.
1:16 PM Changeset in webkit [1753] by hyatt
  • 7 edits in trunk/WebCore

Make checkboxes and radio buttons use the small control
size. Tweak their baselines to not use font metrics and
to line up properly. (voodooextreme.com nearly renders
the left column correctly now.)

  • khtml/rendering/render_form.cpp: (RenderCheckBox::baselinePosition): (RenderRadioButton::baselinePosition):
  • khtml/rendering/render_form.h:
  • kwq/KWQCheckBox.mm: (QCheckBox::QCheckBox):
  • kwq/KWQRadioButton.mm: (QRadioButton::QRadioButton):
12:54 PM Changeset in webkit [1752] by darin
  • 52 edits in trunk/WebKit

WebFoundation:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebKit:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.

WebBrowser:

  • lots of files: Changed url to URL in many places and renamed URL-related methods.
11:09 AM Changeset in webkit [1751] by sullivan
  • 4 edits in trunk/WebCore

WebCore:

WebCore part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • khtml/khtml_part.cpp: (KHTMLPart::setZoomFactor): inside APPLE_CHANGES, remove use of KHTML limits for zoom factor; this is a client responsibility in our model.

WebBrowser:

WebBrowser part of fix for 2915396 -- implement larger/smaller font
or page zoom functionality

  • BrowserDocument.h:
  • BrowserDocument.m: Define min/max text multiplier values, and ratio (-[BrowserDocument canMakeTextLarger]), (-[BrowserDocument canMakeTextSmaller]): New methods, check that there's a page and that the new size wouldn't be too big/small.

(-[BrowserDocument makeTextLarger:]),
(-[BrowserDocument makeTextSmaller:]):
New methods, set web controller's text multiplier.

(-[BrowserDocument validateUserInterfaceItem:]):
Disable makeTextLarger and makeTextSmaller when appropriate.

11:00 AM Changeset in webkit [1750] by darin
  • 5 edits in trunk/WebCore
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Put in a check for nil that I missed.
10:13 AM Changeset in webkit [1749] by darin
  • 26 edits in trunk

WebCore:

  • fixed 2948805 -- Need WebKit API for larger/smaller font feature
  • khtml/khtml_part.cpp: (KHTMLPart::clear): Head in the direction of using the m_frames and m_objects arrays, by turning some APPLE_CHANGES code on. (KHTMLPart::checkCompleted): More code turned on here. (KHTMLPart::checkEmitLoadEvent): And more code turned on here. (KHTMLPart::parentPart): Remove APPLE_CHANGES version. We can use the original now. (KHTMLPart::setZoomFactor): Remove APPLE_CHANGES. We want this function now.
  • khtml/khtml_part.h: Remove some APPLE_CHANGES to make xmlDocImpl public. No longer needed.
  • khtml/khtmlpart_p.h: Remove a bunch of APPLE_CHANGES.
  • kwq/KWQKHTMLPartImpl.h: Remove parentPart(), add getDocument() and getRenderer().
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Use parentPart() instead of [bridge parent]. (KWQKHTMLPartImpl::requestFrame): Set up a ChildFrame in the m_frames array. (KWQKHTMLPartImpl::layout): Use getRenderer(). (KWQKHTMLPartImpl::getDocument): Added. (KWQKHTMLPartImpl::getRenderer): Added.
  • kwq/WebCoreBridge.h: Add [setParent:], remove [parent].
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setParent:]): Added. (-[WebCoreBridge reapplyStyles]): Use getDocument(). (-[WebCoreBridge forceLayout]): Use getRenderer(). (-[WebCoreBridge drawRect:withPainter:]): Use getRenderer(). (-[WebCoreBridge copyDOMTree:]): Use getDocument(). (-[WebCoreBridge copyRenderTree:]): Use getRenderer(). (-[WebCoreBridge completeURLForDOMString:]): Use getDocument(). (-[WebCoreBridge elementAtPoint:]): Use getRenderer(). (-[WebCoreBridge setTextSizeMultiplier:]):
  • kwq/khtml/khtml_ext.h: Add dummy setEnabled function to make khtml_part.cpp compile.
  • kwq/kparts/part.h: Add real parent() and setParent() implementation.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge dataSourceChanged]): Call setParent:.
  • WebView.subproj/WebControllerPrivate.m: (-[WebControllerPrivate init]): Initialize the text size multiplier to 1.
  • WebView.subproj/WebDataSource.h: Removed [redirectedURL], deprecated [inputURL], added [URL].
  • WebView.subproj/WebDataSource.m: (-[WebDataSource URL]): Added. Returns current URL, without requiring separate logic for the redirected and not-yet-redirected cases.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): Use [WebDataSource URL].
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Use [WebDataSource URL].

WebBrowser:

  • BrowserDocument.m: (-[BrowserDocument currentURL]): Use [WebDataSource URL]. (-[BrowserDocument provisionalURL]): Use [WebDataSource URL].
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:dataSource:]): Use [WebDataSource URL].
  • DownloadMonitor.m: (-[DownloadMonitor receivedProgress:forResourceHandle:fromDataSource:complete:]): Use [WebDataSource URL].
  • FrameProgressEntry.m: (-[FrameProgressEntry URL]): Use [WebDataSource URL].
9:21 AM Changeset in webkit [1748] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

WebKit part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • WebView.subproj/WebPreferences.h:
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Add default value for fixed width size (-[WebPreferences fixedFontSize]), (-[WebPreferences setFixedFontSize:]): New methods.

WebBrowser:

WebBrowser part of fix for 3017539 -- Replace Serif and Sans-serif
font preferences with Default preference; let fixed width font
size be independent.

  • Preferences.subproj/TextPreferences.h:
  • Preferences.subproj/TextPreferences.m: (-[TextPreferences updateFontSampleField:]): (-[TextPreferences updateFontSampleFields]): (-[TextPreferences chooseFont:]): (-[TextPreferences chooseStandardFont:]): (-[TextPreferences changeFont:]): (-[TextPreferences initializeFromDefaults]): Removed serif and sans-serif code, replaced with standard font. Made font sizes independent of each other.
  • Preferences.subproj/English.lproj/TextPreferences.nib: Futzed with Interface Builder.
8:36 AM Changeset in webkit [1747] by darin
  • 3 edits in trunk/WebKit
  • fixed 3017536 -- Change default font to Lucida Grande 14 pt.
  • WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Changed default font and sans serif font family names to Lucida Grande. Changed default font size to 14 point.
Note: See TracTimeline for information about the timeline view.