⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 12, 2002:

11:48 PM Changeset in webkit [2056] by rjw
  • 3 edits in trunk/WebKit

Don't initiate a drag if an autoscroll happened.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):
8:21 PM Changeset in webkit [2055] by rjw
  • 11 edits in trunk

Added "Absolute" position to the render tree view. Useful
to see how kthml LIES!

  • Debug/RenderTree.m: (-[RenderTreeDataSource outlineView:objectValueForTableColumn:byItem:]):
  • Debug/RenderTree.nib:

Added absolute position column to render node for
render tree view.

  • WebView.subproj/WebRenderNode.h:
  • WebView.subproj/WebRenderNode.m: (-[WebRenderNode initWithName:position:rect:view:children:]): (-[WebRenderNode absolutePositionString]): (-[WebKitRenderTreeCopier nodeWithName:position:rect:view:children:]):

Rewrite of khtml selection drawing code. Now does
a delta between old and new selection and only
draw those objects that have changed. Selection
drawing is now MUCH faster.

  • khtml/rendering/render_root.cpp: (enclosingPositionedRect): (RenderRoot::setSelection): (RenderRoot::clearSelection):
  • khtml/rendering/render_root.h:

Added additional absolute position property to render node
stuff for debug render tree view.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge copyRenderNode:copier:]):
6:35 PM Changeset in webkit [2054] by hyatt
  • 4 edits in trunk/WebKit

Add text/xml to our list of MIME types that should use the
Web view. With this fix we now render XML and XHTML
correctly!

  • WebView.subproj/WebDataSourcePrivate.m: (+[WebDataSource _repTypes]):
  • WebView.subproj/WebViewPrivate.m: (+[WebView _viewTypes]):
6:04 PM Changeset in webkit [2053] by hyatt
  • 5 edits in trunk/WebCore

KHTML was butchering the laws of background propagation from
the <body> to the <html>. This fixes the logical flaws and
makes some of the geekiest CSS on the planet render correctly. ;)

  • khtml/rendering/render_body.cpp: (RenderBody::printBoxDecorations):
  • khtml/rendering/render_html.cpp: (RenderHtml::printBoxDecorations):
5:19 PM Changeset in webkit [2052] by hyatt
  • 4 edits in trunk/WebCore

Make fixed positioned elements work when you scroll. We were
just missing the implementation of a QScrollView method.

  • kwq/KWQScrollView.mm: (QScrollView::setStaticBackground):
3:23 PM Changeset in webkit [2051] by hyatt
  • 4 edits in trunk/WebCore

Fix a bug in KHTML that leads it to claim cached @imported stylesheets
are not loaded (when in fact they are).

This fixes the W3C CSS page.

  • khtml/css/css_ruleimpl.cpp: (CSSImportRuleImpl::init):
2:51 PM Changeset in webkit [2050] by kocienda
  • 12 edits in trunk/WebKit

WebFoundation:

Removed load flags as a design concept. Replaced with new "caching policy" concept
which are set on a WebResourceRequest. These policies determine how a load will
be processed with regards to the cache.

  • CacheLoader.subproj/IFURLHandleC.h: Removed obsolete IFURLHandleGetFlags function
  • CacheLoader.subproj/IFURLHandleC.m: Ditto.
  • CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]): Temporary hack until new redirect API is available.
  • CacheLoader.subproj/WebCacheLoaderConstants.h: Removed all load flags.
  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Removed calls to load flags and replaced with calls to new request policies. (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Ditto.
  • CacheLoader.subproj/WebResourceHandle.m: Removed flags accessor, and removed calls to load flags and replaced with calls to new request policies. (-[WebResourceHandle description]): Removed calls to load flags and replaced with calls to new request policies.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad _beginLoad]): Ditto. (-[WebResourceLoad description]): Ditto.
  • CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Ditto. (+[WebResourceLoadKey keyWithLoad:]): Ditto. (-[WebResourceLoadKey isEqual:]): Ditto. (-[WebResourceLoadKey hash]): Ditto. (-[WebResourceLoadManager requestWithURLHandle:]): Ditto. (-[WebResourceLoadManager loadDidFinish:]): Ditto.
  • CacheLoader.subproj/WebResourceRequest.h: Added new WebRequestCachePolicy and WebResponseCachePolicy enums, and accessor methods to set these values on a request.
  • CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): Ditto. (-[WebResourceRequest requestCachePolicy]): Added. (-[WebResourceRequest setRequestCachePolicy:]): Added. (-[WebResourceRequest responseCachePolicy]): Added. (-[WebResourceRequest setResponseCachePolicy:]): Added (-[WebResourceRequest copyWithZone:]): Removed calls to load flags and replaced with calls to new request policies.
  • CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (WebSimpleHTTPProtocolHandlerInit): Added some initial support for the notion of "specially-handled" headers. This work is not done yet. (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Fixed case where we appended nil if there was no user-agent set. (-[WebSimpleHTTPProtocolHandler _examineHeaders]): Removed calls to load flags and replaced with calls to new request policies.
  • Misc.subproj/WebFoundation.h:
  • WebFoundation.exp: Removed obsolete _IFURLHandleGetFlags symbol.

WebKit:

Removed load flags as a design concept. Replaced with new "caching policy" concept
which are set on a WebResourceRequest. These policies determine how a load will
be processed with regards to the cache.

  • WebCoreSupport.subproj/WebBridge.h: Removed flags from loadURL method.
  • WebCoreSupport.subproj/WebBridge.m: Removed calls to load flags and replaced with calls to new request policies. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge isReloading]): Ditto. (-[WebBridge loadURL:referrer:]): Ditto. (-[WebBridge loadURL:withParent:]): Removed flags from loadURL method. (-[WebBridge postWithURL:referrer:data:]): Removed calls to load flags and replaced with calls to new request policies.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Ditto.
  • WebView.subproj/WebDataSource.h: Removed flags from init method.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): Ditto. (-[WebDataSource initWithRequest:]): Ditto.
  • WebView.subproj/WebDataSourcePrivate.h: Removed flags ivar, and dangling attributes ivar.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Removed calls to load flags and replaced with calls to new request policies.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Ditto.
1:25 PM Changeset in webkit [2049] by cblu
  • 4 edits in trunk/WebCore

Fixed livepage crash on Marklar. It is naughty to divide by 0 on marklar so we now check before doing that.

  • khtml/rendering/render_box.cpp: (RenderBox::printBackground):
12:15 PM Changeset in webkit [2048] by hyatt
  • 4 edits in trunk/WebCore

Fix crash on trekweb.com. My simplified FOUC code was a little
bit too simple. ;)

  • khtml/html/html_headimpl.cpp: (HTMLLinkElementImpl::setStyleSheet): (HTMLStyleElementImpl::childrenChanged):
12:05 PM Changeset in webkit [2047] by hyatt
  • 8 edits in trunk/WebCore

Fix the Warcraft 3 page on blizzard.com so that the relative
positioned blocks inside centered tables inside enclosing tables
with percentage widths work correctly.

This fix also causes the textfields on mrskin.com to show up
again.

  • khtml/rendering/render_box.cpp: (RenderBox::RenderBox): (RenderBox::setPos):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::addChild):
  • khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
  • khtml/rendering/render_object.h:
8:53 AM Changeset in webkit [2046]
  • 3 copies in tags/Alexander-23

This commit was manufactured by cvs2svn to create tag 'Alexander-23'.

8:53 AM Changeset in webkit [2045] by cblu
  • 5 edits in trunk/WebKit

WebKit:

Make WebTextView private and exported.

  • WebKit.exp:
  • WebKit.pbproj/project.pbxproj:
  • WebView.subproj/WebTextView.h:

WebBrowser:

Show HTML source in Alex.

  • BrowserDocument.h:
  • BrowserDocument.m: (-[BrowserDocument viewSource:]): create new HTMLSourceDocument
  • BrowserDocumentController.h:
  • BrowserDocumentController.m: (-[BrowserDocumentController openHTMLSourceDocumentWithDataSource:]): added
  • ContextMenuHandler.m: (-[ContextMenuHandler viewSource:]): create new HTMLSourceDocument
  • English.lproj/HTMLSource.nib: Added.
  • HTMLSourceController.h: Added.
  • HTMLSourceController.m: Added. (-[HTMLSourceController windowDidLoad]): (-[HTMLSourceController setString:]): (-[HTMLSourceController targetForSearch]):
  • HTMLSourceDocument.h: Added.
  • HTMLSourceDocument.m: Added. (-[HTMLSourceDocument initWithDataSource:]): (-[HTMLSourceDocument dealloc]): (-[HTMLSourceDocument makeWindowControllers]): (-[HTMLSourceDocument dataRepresentationOfType:]): (-[HTMLSourceDocument saveDocumentTo:]): (-[HTMLSourceDocument fileName]): (-[HTMLSourceDocument fileType]): (-[HTMLSourceDocument displayName]):
  • WebBrowser.pbproj/project.pbxproj:

Sep 11, 2002:

11:53 PM Changeset in webkit [2044] by mjs
  • 4 edits in trunk/WebCore

WebCore:

Don't show the window here any more, now that WebBrowser will set
it up to be shown properly itself.

  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow):

WebBrowser:

Changed new window opening to happen right away instead of waiting
until the content policy is known. This avoids the horrible lack
of feedback and feeling of slowness on new window opening, but
re-introduces the problem that command-clicking on a link that
downloads leaves around an empty window (Radar 3049296).

While I was at it, I made goToInitialURL get called right away
instead of deferring it, since the problems that arose from
calling it right away before no longer apply.

  • fixed Radar 3017596 - Cmd click on link doesn't display new window fast enough
  • fixed Radar 3049291 - Deferring goToInitialURL can cause problems
  • BrowserDocument.h:
  • BrowserDocument.m: Remove methods and code related to awaiting the content policy, since we no longer wait for it.
  • BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Show the window next time through the event loop. (-[BrowserDocumentController _createEmptyBrowserDocumentAndDisplay:]): Show the window next time through the event loop.
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForMIMEType:URL:inFrame:]): No more need to show or close window when content policy is determined.
  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Go to initial URL immediately, not after delay.
6:59 PM Changeset in webkit [2043] by hyatt
  • 4 edits in trunk/WebCore

Fix horizontal scrolling. The HTML render object lies. It lies,
I tell you.

  • khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
6:01 PM Changeset in webkit [2042] by hyatt
  • 11 edits in trunk/WebCore

Fix clipping to work with layers. This fixes the marquee
(once again) on livepage.apple.com.

  • khtml/rendering/render_box.cpp: (RenderBox::getClipRect):
  • khtml/rendering/render_box.h:
  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::removeChildNode):
  • khtml/rendering/render_flow.cpp: (RenderFlow::setStyle): (RenderFlow::printObject):
  • khtml/rendering/render_layer.cpp: (RenderLayer::enclosingPositionedAncestor): (RenderLayer::convertToLayerCoords): (RenderLayer::paint): (RenderLayer::constructZTree):
  • khtml/rendering/render_layer.h:
  • khtml/rendering/render_object.h:
  • khtml/rendering/render_replaced.cpp: (RenderReplaced::print):
4:23 PM Changeset in webkit [2041] by darin
  • 4 edits in trunk/WebCore

WebFoundation:

  • Misc.subproj/WebAssertions.h: Changed assertions to use a different technique for varargs, which seems to work better on Claudius. Sorry about the nearly-full build.
  • CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest setMethod:]): Store a copy so we don't end up retaining a mutable string that the caller then modifies. (-[WebResourceRequest setHeaders:]): Allow nil for theHeaders, and make an empty dictionary in that case. (-[WebResourceRequest setHeader:forKey:]): Store a copy so we don't end up putting a reference to a mutable string in our dictionary. (-[WebResourceRequest addHeader:forKey:]): Ditto. (-[WebResourceRequest setExtraCookies:]): Ditto, same applies for NSArray. (-[WebResourceRequest setData:]): Ditto, same for NSData.

WebCore:

  • kwq/KWQAssertions.h: Updated copy of the assertions macros (made by script).
4:10 PM Changeset in webkit [2040] by mjs
  • 8 edits in trunk/WebKit

Combined provisionalDataSourceChanged: and
provisionalDataSourceCommitted: methods into a single
setDataSource:, since they are always called one immediately after
the other.

  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]): (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]):
  • WebView.subproj/WebDocument.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView setDataSource:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView setDataSource:]):
  • WebView.subproj/WebTextView.m: (-[WebTextView setDataSource:]):
  • WebView.subproj/WebViewPrivate.m: (-[WebView _makeDocumentViewForDataSource:]):
3:43 PM Changeset in webkit [2039] by rjw
  • 3 edits in trunk/WebKit

i Better fix for previous problem.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):
2:05 PM Changeset in webkit [2038] by darin
  • 4 edits in trunk/WebCore
  • fixed 3047552 -- crash using CFNotification calls on an NSNotification
  • kwq/KWQWindowWidget.mm: (KWQWindowWidget::KWQWindowWidget): Create a KWQWindowWidgetDeleter, and hook it up to the notification. (KWQWindowWidget::~KWQWindowWidget): Disconnect the KWQWindowWidgetDeleter and release it. (-[KWQWindowWidgetDeleter initWithWindowWidget:]): Store a pointer. (-[KWQWindowWidgetDeleter deleteWindowWidget]): Do a delete.
1:33 PM Changeset in webkit [2037] by rjw
  • 3 edits in trunk/WebKit

Remove ceiling of text width at end of fragment. This was screwing up
intra fragment text measurements.

Selection of justified text is still screwed up. This is a fundamental problem
in khtml and will require a rewrite of their justification code. Konq has the
same problems selecting justified text. The drawing of code applies the justification
factor, but checking the selection doesn't add the justification factor, so selection
will be incorrect by the justification amount.

  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:applyRounding:attemptFontSubstitution:]):
12:26 PM Changeset in webkit [2036] by darin
  • 3 edits in trunk/WebKit
  • WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Use the current URL, not the original URL, when doing a reload. This prevents the URL from changing back and forth when you reload on a page that involved a redirect.
11:56 AM Changeset in webkit [2035] by darin
  • 10 edits
    1 add
    1 delete in trunk/WebCore
  • fixed 3021137 -- changing font prefs doesn't redraw frames other than the main frame
  • kwq/WebCoreSettings.m: Renamed to WebCoreSettings.mm.
  • kwq/WebCoreSettings.mm: Renamed from WebCoreSettings.m so I could use C++. (-[WebCoreSettings _updateAllViews]): Iterate over all KWQKHTMLPartImpl instances, calling setNeedsReapplyStyles on each one.
  • WebCore.pbproj/project.pbxproj: Updated for name change.
  • kwq/KWQKHTMLPartImpl.h: Add instances() and mutableInstances(). Get rid of frameExists(), findFrame(), and frames().
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::KWQKHTMLPartImpl): Add to instance list. (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Remove from instance list. (KWQKHTMLPartImpl::requestFrame): Update to not use frameExists(). (KWQKHTMLPartImpl::overURL): Update to not use frameExists, and improve handling of various cases. (KWQKHTMLPartImpl::mutableInstances): Create and return instance list.
  • kwq/WebCoreBridge.h: Add setNeedsReapplyStyles; already implemented in WebKit.
  • khtml/khtml_part.cpp: (KHTMLPart::findFrame): Remove APPLE_CHANGES. (KHTMLPart::frameExists): Remove APPLE_CHANGES. (KHTMLPart::frames): Remove APPLE_CHANGES.
11:52 AM Changeset in webkit [2034] by darin
  • 4 edits in trunk/WebKit

Add machinery needed for fix to 3021137, changing font prefs
doesn't redraw frames other than the main frame.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsReapplyStyles]): Added. Lets the web views know that they need to reapply styles. If we did this over on the WebCore side, we'd have to do it right away. Maybe that would be OK; we can move that that later.
  • WebView.subproj/WebTextView.m: (-[WebTextView setFixedWidthFont]): Use the fixed-width size, rather than using the other size with the fixed-width family.
11:14 AM Changeset in webkit [2033] by kocienda
  • 17 edits in trunk/WebKit

WebFoundation:

Major change to the API and design of WebFoundation.

Attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

  • CacheLoader.subproj/IFHTTPURLHandleC.m: (IFHTTPURLHandleGetRequestMethod): Removed attribute usage. Replace with calls to new API. (IFHTTPURLHandleGetRequestHeaders): Ditto.
  • CacheLoader.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addUnconditionalUserRequestHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addAcceptHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler addCookieHeaders:]): Ditto. (-[WebCFNetworkHTTPProtocolHandler hasConditionalCustomHeaders]): Ditto.
  • CacheLoader.subproj/WebCacheLoaderConstants.h: Removed newly obsoleted attributes.
  • CacheLoader.subproj/WebCacheLoaderConstants.m: Ditto.
  • CacheLoader.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler shouldAttemptOriginLoad]): Removed attribute usage. Replace with calls to new API. (-[WebHTTPProtocolHandler shouldCacheResourceData]): Ditto. (-[WebHTTPProtocolHandler requestMethod]): Ditto. (-[WebHTTPProtocolHandler requestData]): Ditto. (-[WebHTTPProtocolHandler retryWithRedirectedURLAndResultCode:]): Ditto. (-[WebHTTPProtocolHandler testAndSetCacheObjectState:]): Ditto.
  • CacheLoader.subproj/WebResourceHandle.h: Removed attributeForKey method.
  • CacheLoader.subproj/WebResourceHandle.m: (-[WebResourceHandle description]): Removed attribute usage. Replace with calls to new API. (-[WebResourceHandle initWithRequest:client:]): WebResourceRequest no longer requires explicit validation.
  • CacheLoader.subproj/WebResourceHandleInternal.h: Removed processedAttributes.
  • CacheLoader.subproj/WebResourceHandleInternal.m: (-[WebResourceHandleInstanceVariables dealloc]): Ditto.
  • CacheLoader.subproj/WebResourceHandlePrivate.h: Removed _setAttribute method.
  • CacheLoader.subproj/WebResourceHandlePrivate.m: Ditto.
  • CacheLoader.subproj/WebResourceLoad.h: Removed processedAttributes ivar. Removed attributeForKey and setAttribute:forKey: methods.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad initWithRequest:]): Ditto. (-[WebResourceLoad description]): Ditto. (-[WebResourceLoad dealloc]): Ditto.
  • CacheLoader.subproj/WebResourceLoadManager.m: (+[WebResourceLoadKey keyWithHandle:]): Removed attributes from cache key. Need to put back some request info soon. (+[WebResourceLoadKey keyWithLoad:]): Ditto.
  • CacheLoader.subproj/WebResourceRequest.h: Removed attributes ivar. Added method, headers, extraCookies and data ivars. Added getter and setter methods for each of the new ivars.
  • CacheLoader.subproj/WebResourceRequest.m: (-[WebResourceRequest initWithURL:]): API and implementation rejiggering to deal with removing attributes from the init methods. (-[WebResourceRequest initWithURL:flags:]): Ditto. (-[WebResourceRequest initWithURL:userAgent:flags:]): Ditto. (-[WebResourceRequest method]): Added. (-[WebResourceRequest setMethod:]): Added. (-[WebResourceRequest headers]): Added. (-[WebResourceRequest setHeaders:]): Added. (-[WebResourceRequest referrer]): Added. (-[WebResourceRequest setReferrer:]): Added. (-[WebResourceRequest extraCookies]): Added. (-[WebResourceRequest setExtraCookies:]): Added. (-[WebResourceRequest data]): Added. (-[WebResourceRequest setData:]): Added. (-[WebResourceRequest flags]): Just moved method in the file. No changes. (-[WebResourceRequest protocolHandlerClass]): Ditto. (-[WebResourceRequest copyWithZone:]): Made sure new ivars get copied. (-[WebResourceRequest dealloc]): Added new ivars.
  • CacheLoader.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler createHTTPRequest]): Removed attribute usage. Replace with calls to new API.
  • WebFoundation.exp: Removed attribute key exports.

WebKit:

Major change to the API and design of WebFoundation. WebKit has been modified
to use the new API.

WebFoundation attributes, as a design concept, are now completely gone. The old usages of
attributes have been replaced with new API on the WebResourceRequest
and WebResourceResponse classes.

  • Plugins.subproj/WebPluginStream.h: Removed attribute usage in init API. No need for replacement.
  • Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:]): Removed attribute usage in init API. (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Ditto. (-[WebNetscapePluginStream dealloc]): Remove attribute release. (-[WebNetscapePluginStream startLoad]): Removed attribute usage. Replace with calls to new API. (-[WebNetscapePluginStream receivedData:withHandle:]): Ditto.
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView pluginURLFromCString:]): Added this helper method. (-[WebNetscapePluginView loadRequest:inTarget:withNotifyData:]): Added. (-[WebNetscapePluginView getURLNotify:target:notifyData:]): Modified to call new loadRequest:inTarget:withNotifyData: method. (-[WebNetscapePluginView getURL:target:]): Ditto. (-[WebNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): Ditto.
  • WebCoreSupport.subproj/WebBridge.h: Removed attribute usage in loadURL API. No need for replacement.
  • WebCoreSupport.subproj/WebBridge.m: Added loadRequest:withParent: (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): (-[WebBridge startLoadingResource:withURL:referrer:]): Removed attribute usage. Replace with calls to new API. (-[WebBridge isReloading]): Ditto. (-[WebBridge loadRequest:withParent:]): Added. (-[WebBridge loadURL:]): Modified to use new loadRequest:withParent: API (-[WebBridge loadURL:referrer:]): Ditto. (-[WebBridge loadURL:flags:withParent:]): Ditto. (-[WebBridge postWithURL:data:]): Ditto.
  • WebCoreSupport.subproj/WebSubresourceClient.h: Changed API to use an NSString referrer instead of an attributes dictionary.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Removed attribute usage. Replace with calls to new API.
  • WebView.subproj/WebDataSource.h: Added initWithRequest: method.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithURL:]): Removed attribute usage in init API. (-[WebDataSource initWithURL:flags:]): Ditto. (-[WebDataSource initWithRequest:]): Added. (-[WebDataSource request]): Added.
  • WebView.subproj/WebDataSourcePrivate.h: Added WebResourceRequest ivar.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Added WebResourceRequest ivar. (-[WebDataSource _startLoading:]): Removed attribute usage. Replace with calls to new API.
  • WebView.subproj/WebFrame.m: (-[WebFrame reload:]): Removed attribute usage. Replace with calls to new API.
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _goToItem:withFrameLoadType:]): Use new WebDataSource init API.

WebBrowser:

Updated to use new referrer ivar and accessor methods on WebResourceRequest, instead
of using attributes.

  • BrowserDocument.m: (-[BrowserDocument _goToURL:referrer:withFallbackURLs:])
9:37 AM Changeset in webkit [2032] by darin
  • 36 edits in trunk

WebCore:

WebCore part of support for the "Referer" header.

  • khtml/khtml_part.cpp: (KHTMLPart::urlSelected): Use much more of this function. (KHTMLPart::submitForm): Use much more of this function.
  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Parse the referrer out of the URLArgs and pass it along.
  • kwq/KWQKHTMLPartImpl.h: Change parameters to urlSelected and submitForm to allow KHTML to do more of the work. Add referrer helper function.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Pass referrer of nil when opening a blank window. (KWQKHTMLPartImpl::referrer): Extract referrer from metadata. (KWQKHTMLPartImpl::openURLRequest): Pass referrer from args through the bridge. (KWQKHTMLPartImpl::urlSelected): Remove code that duplicates what's in KHTMLPart. Also pass referrer from args through the bridge as above. (KWQKHTMLPartImpl::submitForm): Ditto.
  • kwq/kdeui/kmessagebox.h: Add information member function.
  • kwq/KWQKMessageBox.mm: (KMessageBox::information): Implement.
  • kwq/kdecore/kurl.h: Add encode_string member function.
  • kwq/KWQKURL.mm: (KURL::KURL): Fix buffer overflow bug, and add an assert so we will notice these overflows even when using the static buffer. (KURL::parse): Added a similar assert, even though I didn't fix any overflow bug here. (KURL::encode_string): Implemented this, but didn't test it.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Pass referrer through the bridge.
  • kwq/WebCoreBridge.h: Add referrer parameters to loadURL, postWithURL, openNewWindowWithURL, and startLoadingResource.
  • kwq/kparts/browserextension.h: Implement setDoPost, setContentType, const version of metaData().
  • kwq/qt/qstring.h: Implement fromLatin1(const char *, int).
  • WebCore-tests.exp: Not sure why, but I needed to remove isMalformed, and the tests seem to still work with it removed.

WebKit:

WebKit part of support for the "Referer" header.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge openNewWindowWithURL:referrer:frameName:]): Add referrer parameter, and pass it on to the window context method. (-[WebBridge addAttributeForReferrer:toDictionary:]): Added. (-[WebBridge attributesForReferrer:]): Added. (-[WebBridge startLoadingResource:withURL:referrer:]): Put the referrer into an attributes dictionary and pass it to the WebSubresourceClient method. (-[WebBridge loadURL:referrer:]): Put the referrer into an attributes dictionary and pass it along. (-[WebBridge postWithURL:referrer:data:]): Put the referrer into an attributes dictionary and pass it along.
  • WebCoreSupport.subproj/WebSubresourceClient.h: Add an attributes parameter to the method that starts loading.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:attributes:forDataSource:]): Put the attributes into the WebResourceRequest.
  • WebView.subproj/WebController.h: Add a referrer parameter to the WebWindowContext openNewWindowWithURL method.
  • WebView.subproj/WebDefaultContextMenuHandler.m: (-[WebDefaultContextMenuHandler openNewWindowWithURL:referrer:]): Pass the referrer on to the window context. (-[WebDefaultContextMenuHandler openLinkInNewWindow:]): Pass nil for the referrer for now. Not sure if this is best. (-[WebDefaultContextMenuHandler openImageInNewWindow:]): Ditto. (-[WebDefaultContextMenuHandler openFrameInNewWindow:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFrame frameNamed:]): Pass nil for the referrer here where we are creating a new empty window.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Pass nil for the referrer here in the WebClickPolicyOpenNewWindow. The policy API doesn't provide a way for the policy handler to specify the referrer; we might want to change that later.
  • Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView loadURL:inTarget:withNotifyData:andHandleAttributes:]): Pass nil for the referrer here. But it seems wrong that this function discards the handle attributes that are passed in for the case where it opens a new window.

WebBrowser:

WebBrowser part of support for the "Referer" header.

  • BrowserWebController.m: (-[BrowserWebController openNewWindowWithURL:referrer:]): Add referrer parameter, and pass it through to the document controller. (-[BrowserWebController pluginNotFoundSheetEnded:returnCode:contextInfo:]): Pass nil for referrer.
  • BrowserDocumentController.h: Add referrer parameter to the long version of goToURL.
  • BrowserDocumentController.m: (-[BrowserDocumentController openDocumentWithContentsOfURL:referrer:display:]): Change to not all makeDocumentWithContentsOfURL and instead create the document here, because we need to pass the referrer through. (-[BrowserDocumentController openDocumentWithContentsOfURL:display:]): Just call the version above that has a referrer, passing a referrer of nil. (-[BrowserDocumentController _goToEachURL:referrer:forceNewWindow:orderFront:]): Pas referrer to goToURL and to openDocumentWithContentsOfURL. (-[BrowserDocumentController goToEachURL:]): Pass nil for referrer. (-[BrowserDocumentController goToURL:referrer:forceNewWindow:orderFront:]): Add referrer parameter, and pass through to _goToEachURL.
  • BrowserDocument.h: Add _openWithReferrer field, initWithContentsOfURL method that takes a referrer, and goToURL method that takes a referrer.
  • BrowserDocument.m: (-[BrowserDocument initWithContentsOfURL:referrer:]): Set _openWithReferrer. (-[BrowserDocument dealloc]): Release _openWithReferrer. (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]): Add referrer parameter. Set up attributes dictionary with referrer in it. (-[BrowserDocument goToURL:]): Call through to goToURL:referrer:. (-[BrowserDocument goToURL:referrer:]): Added. Passes referrer on. (-[BrowserDocument goToInitialURL:]): Pass _openWithReferrer. (-[BrowserDocument tryMultipleURLs:]): Pass nil for referrer.
  • ActivityViewer.m: (-[ActivityViewer _goToClickedItem:]): Pass nil for referrer.
  • AppController.m: (-[AppController application:openFile:]): Ditto. (-[AppController handleGURLEvent:withReplyEvent:]): Ditto.
  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToForceNewWindow:]): Ditto.
  • Test/PageLoadTestRunner.m: (-[PageLoadTestRunner goToPage]): Ditto.
8:41 AM Changeset in webkit [2031] by cblu
  • 4 edits in trunk/WebKit

Fixed: 3048158 - Crash at google in _destroyInitializingClassList

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient didCancelWithHandle:]):
3:36 AM Changeset in webkit [2030] by hyatt
  • 8 edits in trunk/WebCore

This patch fixes a slew of bugs. It is an implementation
of the IE extensions offsetLeft, offsetTop, and offsetParent.
Konqueror actually had implementations for these properties
that were totally wrong, leading any DHTML that would use
these properties (like the DHTML on brainjar.com or livepage.apple.com)
to misposition child elements.

With these properties now implemented, the menus on brainjar.com
position correctly, and the marquee on livepage.apple.com once
again shows up (and now you can see how I've regressed clipping
by not shoving it into the layer system as well).

Next up will be fixing the clipping bug on livepage.apple.com.

  • khtml/ecma/kjs_dom.cpp: (DOMNode::getValueProperty):
  • khtml/rendering/render_flow.cpp: (RenderFlow::offsetHeight): (RenderFlow::offsetLeft): (RenderFlow::offsetTop):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.cpp: (RenderObject::offsetLeft): (RenderObject::offsetTop): (RenderObject::offsetParent):
  • khtml/rendering/render_object.h:
Note: See TracTimeline for information about the timeline view.