Timeline

Sep 28, 2002:

4:57 PM Changeset in webkit [2201] by darin

• 6 edits in trunk/WebCore

Turn -Werror back on. There must have been some miscommunication
about the fat build; this was supposed to have been on.

• WebCore.pbproj/project.pbxproj: Add -Werror back.

• kwq/WebCoreHistory.h: Add missing method to fix warning.
• kwq/KWQKHistoryProvider.mm: Tweak.

1:38 PM Changeset in webkit [2200] by darin

• 6 edits in trunk/WebCore

Give the next fat build a better chance of working with the
new gcc without turning warnings off.

• khtml/css/cssparser.cpp: Use a macro to disable inlining.
• khtml/html/htmltokenizer.cpp: Ditto.
• khtml/misc/htmlhashes.cpp: Ditto.

12:49 PM Changeset in webkit [2199] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Catch a request that we can't use here instead of failing later.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Added an assert so the failure was less confusing; good idea to leave it in.

12:35 PM Changeset in webkit [2198] by cblu

• 4 edits in trunk/WebKit

Support for latest Flash plug-in. It requests a javascript URL for every plug-in instance. Until javascript URLs work, we return an error to the plug-in.

Fixed: 3035582 - flash animations don't work after upgrading flash
Fixed: 3021936 - links in flash at foggypetronasracing.com doesn't work

• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): Make the request here and return nil if we can't create a handle with it. (-[WebNetscapePluginStream dealloc]): release the request (-[WebNetscapePluginStream startLoad]): use the request when creating the handle

1:06 AM Changeset in webkit [2197] by darin

• 4 edits in trunk/WebCore

• fixed 3022441 -- scroll bar is missing in window created with window.open

• khtml/ecma/kjs_window.cpp: (WindowFunc::tryCall): The checks for extra parameters to window.open were using isNull, which checks for a null ValueImp pointer, not an "Undefined".

12:39 AM Changeset in webkit [2196] by darin

• 15 edits in trunk

WebCore:

• fixed 2886111 -- changing font or size preference causes open windows to redraw incorrectly

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fix logic about when a recalc of the minWidth and maxWidth is needed.

Fixed bug where changing the text size multiplier would cause the
window to redraw twice -- once with the text size changed, and then
later with the layout changed.

• khtml/khtmlview.h: Added unscheduleRelayout.
• khtml/khtmlview.cpp: (KHTMLView::unscheduleRelayout): Added.

• kwq/KWQKHTMLPartImpl.h: Added forceLayout.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::forceLayout): Call both layout and unscheduleRelayout.

• kwq/WebCoreBridge.h: Add setNeedsLayout.
• kwq/WebCoreBridge.mm: (-[WebCoreBridge forceLayout]): Call KWQKHTMLPartImpl::forceLayout. (-[WebCoreBridge setTextSizeMultiplier:]): Call forceLayout.

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge setNeedsLayout]): Added.

Sep 27, 2002:

9:22 PM Changeset in webkit [2195] by cblu

• 4 edits in trunk/WebKit

Fixed KJS crasher caused by nil plug-in returned from WebPlugin.
Got the RealPlayer plug-in loaded, nothing playing yet.

• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin getPluginInfo]): check for nil plug-in names/descriptions (-[WebNetscapePlugin stringByResolvingSymlinksAndAliasesInPath:]): new, resolves old-style aliases (-[WebNetscapePlugin initWithPath:]): call stringByResolvingSymlinksAndAliasesInPath

5:45 PM Changeset in webkit [2194] by darin

• 4 edits in trunk/WebCore

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo): Fixed a > that should have been a < that prevented tables from changing sizes when table minimum widths changed.

5:16 PM Changeset in webkit [2193] by darin

• 2 edits in trunk/WebKit/WebView.subproj

• LocationChangeError.m: (-[LocationChangeHandler displayLocationChangeError:]): Add back the WebErrorCodeCancelled case.

4:44 PM Changeset in webkit [2192] by rjw

• 4 edits in trunk/WebKit

i Fix 3058315: crash in WebHTMLRepresentation receivedData:withDataSource

​http://www.u2.com/lite/ does some whacky things with its framset's onLoad
handler. The fix ensures that data isn't sent to the bridge once
the bridge has been dealloced.

• WebKit.pbproj/project.pbxproj: Nothing changed. PB dorkiness.
• WebView.subproj/WebHTMLRepresentation.m: (-[WebHTMLRepresentation receivedData:withDataSource:]):

Fix related to 3058315.

• LoadProgressMonitor.m: (-[LoadProgressMonitor receivedUpdateForKey:URLString:bytesLoaded:bytesExpected:error:dataSource:isComplete:]):

2:34 PM Changeset in webkit [2191] by darin

• 9 edits in trunk/WebCore

• fixed 2937198 -- Checkboxes and radiobuttons don't align with title control in forms

• kwq/qt/qcheckbox.h: Add baselinePosition override.
• kwq/KWQCheckBox.mm: Tweak the size constants. (QCheckBox::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.

• kwq/qt/qradiobutton.h: Add baselinePosition override.
• kwq/KWQRadioButton.mm: Tweak the size constants. (QRadioButton::baselinePosition): Implement this. Line up baseline two pixels above the bottom, not at the bottom.

2:31 PM Changeset in webkit [2190] by cblu

• 14 edits in trunk

WebCore:

WebPlugin clean up.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/WebCoreViewFactory.h:

WebKit:

Fixed: 3056559 - QT plugin doesn't load (claudius)
Fixed: 3042850 - Enable Java by default

Cleaned up WebPlugin and WebPluginDatabase.

• Plugins.subproj/WebPlugin.h:
• Plugins.subproj/WebPlugin.m: (-[WebNetscapePlugin openResourceFile]): (-[WebNetscapePlugin closeResourceFile:]): (-[WebNetscapePlugin stringForStringListID:andIndex:]): (-[WebNetscapePlugin getPluginInfo]): (-[WebNetscapePlugin initWithPath:]): (-[WebNetscapePlugin load]): (-[WebNetscapePlugin unload]): (-[WebNetscapePlugin MIMEToExtensionsDictionary]): (-[WebNetscapePlugin extensionToMIMEDictionary]): (-[WebNetscapePlugin MIMEToDescriptionDictionary]): (-[WebNetscapePlugin description]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase pluginForMIMEType:]): (-[WebNetscapePluginDatabase pluginForExtension:]): (-[WebNetscapePluginDatabase pluginForFilename:]): (-[WebNetscapePluginDatabase MIMETypes]): (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView setDataSource:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebView.subproj/WebPreferences.m: (+[WebPreferences load]): Enable Java by default

1:50 PM Changeset in webkit [2189] by rjw

• 21 edits in trunk

WebBrowser no longer responsible for setting page title in history.

• LocationChangeHandler.m: (-[LocationChangeHandler receivedPageTitle:forDataSource:]):

Fixed 3060158: REGRESSION: iframes added to session history
Also moved setting title in history to WebKit.

• History.subproj/WebHistory.h:
• History.subproj/WebHistory.m: (+[WebHistory sharedHistory]): (+[WebHistory webHistoryWithFile:]): (-[WebHistory addEntryForURL:]): (-[WebHistory addEntries:]):
• History.subproj/WebHistoryPrivate.h:
• History.subproj/WebHistoryPrivate.m:
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]):
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseDragged:]):

Fixed 3059237: Visited links do not appear in a different color on yahoo.com
Fixed 3051288: visited links are not colored in local files
Fixed 3060158: REGRESSION: iframes added to session history
Always use the canonical originally requested URL as the URL entered in history.

• khtml/khtml_part.cpp: (KHTMLPart::begin):
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::requestedURLString):
• kwq/KWQKHistoryProvider.mm:
• kwq/WebCoreBridge.h:
• kwq/WebCoreHistory.h:

12:40 PM Changeset in webkit [2188] by hyatt

• 4 edits in trunk/WebCore

Fix for 3058119, doctype of HTML docs should be null.

• khtml/dom/dom_doc.cpp:

12:27 PM Changeset in webkit [2187] by hyatt

• 4 edits in trunk/WebCore

DOM compliance. Fix for 3058100, hasFeature of HTML returns
false. Oops.

• khtml/xml/dom_docimpl.cpp: (DOMImplementationImpl::hasFeature):

11:35 AM Changeset in webkit [2186] by darin

• 4 edits in trunk/WebCore

• fixed 3060487 -- error connecting member slot to signal (KWQObject)

• kwq/KWQObject.mm: (QObject::connect): Add slotShowDocument to the list of slots that we don't care about hooking up.

10:32 AM Changeset in webkit [2185] by cblu

• 5 edits in trunk/WebKit

WebKit:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

• Misc.subproj/WebNSPasteboardExtras.h:
• Misc.subproj/WebNSPasteboardExtras.m: (+[NSPasteboard initialize]): set WebURLPboardType and WebURLNamePboardType (-[NSPasteboard _web_writeURL:andTitle:withOwner:]): use WebURLPboardType and WebURLNamePboardType
• WebKit.exp: export WebURLPboardType and WebURLNamePboardType

WebBrowser:

Added support for dragging links the the dock.
Created new pasteboard types WebURLPboardType WebURLNamePboardType that the dock requires.

• BrowserWebBookmarkExtras.m: (+[WebBookmark writeBookmarks:toPasteboard:withOwner:]): use WebURLPboardType and WebURLNamePboardType

10:27 AM Changeset in webkit [2184] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3033969 -- repro crash (infinite recursion in JavaScript) clicking on "screens" option at fsv.sf.net

• kjs/object.h: Change recursion limit to 100 levels rather than 1000.

8:25 AM Changeset in webkit [2183] by cblu

• 1 edit in trunk/WebKit/Misc.subproj/WebNSPasteboardExtras.m

* empty log message *

4:30 AM Changeset in webkit [2182] by mjs

• 5 edits in trunk/WebKit

WebFoundation:

Put in place all the API changes needed for the "remember
password" feature and examining stored passwords. The actual
storing of passwords in Keychain is not implemented yet - that's
the next step.

• AuthenticationManager.subproj/WebAuthenticatingResource.h: Added.
• AuthenticationManager.subproj/WebAuthenticatingResource.m: Added. New class that's the data holder part of WebAuthenticationRequest, the part that describes the resource needing authentication. (-[WebAuthenticatingResourcePrivate dealloc]): (-[WebAuthenticatingResource initWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (+[WebAuthenticatingResource resourceWithURL:realm:username:receivesCredentialSecurely:proxyHost:proxyType:]): (-[WebAuthenticatingResource init]): (-[WebAuthenticatingResource dealloc]): (-[WebAuthenticatingResource URL]): (-[WebAuthenticatingResource realm]): (-[WebAuthenticatingResource username]): (-[WebAuthenticatingResource receivesCredentialSecurely]): (-[WebAuthenticatingResource isProxy]): (-[WebAuthenticatingResource proxyHost]): (-[WebAuthenticatingResource proxyType]): (-[WebAuthenticatingResource copyWithZone:]):
• AuthenticationManager.subproj/WebAuthenticationHandler.h:
• AuthenticationManager.subproj/WebAuthenticationHandlerDispatcher.m: (-[WebAuthenticationDispatchState dealloc]): (-[WebAuthenticationHandlerDispatcher _dispatchStartAuthentication:]): (-[WebAuthenticationHandlerDispatcher WebAuthenticationRequest:useCredential:]): (-[WebAuthenticationHandlerDispatcher _dispatchAuthenticationDone:]): (-[WebAuthenticationHandlerDispatcher startAuthentication:]):
• AuthenticationManager.subproj/WebAuthenticationManager.h:
• AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager removeCredentialForResource:]): (-[WebAuthenticationManager resourceCredentials]): (-[WebAuthenticationManager _invokeHandlersWithURL:realm:forRequest:withCallback:context:]): (-[WebAuthenticationManager _invokeHandlersWithURL:proxy:forRequest:withCallback:context:]): (-[WebAuthenticationManager _tryRequest:]): (-[WebAuthenticationManager WebAuthenticationRequest:useCredential:]):
• AuthenticationManager.subproj/WebAuthenticationRequest.h:
• AuthenticationManager.subproj/WebAuthenticationRequest.m: (-[WebAuthenticationRequestPrivate initWithResource:previousFailureCount:delegate:]): (-[WebAuthenticationRequestPrivate dealloc]): (-[WebAuthenticationRequest _initWithResource:previousFailureCount:delegate:]): Change to init with a WebAuthenticatingResource rather than passing all the data. (-[WebAuthenticationRequest _authenticationHandlerBusy]): (-[WebAuthenticationRequest resource]): New method (-[WebAuthenticationRequest previousFailureCount]): Renamed from previousFailures (-[WebAuthenticationRequest useCredential:]): Renamed from authenticationDone: (-[WebAuthenticationRequest cancel]): Removed to fix in-band signalling
• AuthenticationManager.subproj/WebAuthenticationRequestPrivate.h:
• AuthenticationManager.subproj/WebAuthenticationResult.m: Removed.
• AuthenticationManager.subproj/WebCredential.h: Added.
• AuthenticationManager.subproj/WebCredential.m: Added. Renamed from WebAuthenticationResult. (-[WebCredentialPrivate dealloc]): (-[WebCredential initWithUsername:password:remembered:]): Add remembered: parameter (+[WebCredential credentialWithUsername:password:remembered:]): Likewise (-[WebCredential dealloc]): (-[WebCredential username]): (-[WebCredential password]): (-[WebCredential remembered]): New method (-[WebCredential copyWithZone:]):
• Misc.subproj/WebFoundation.h:
• WebFoundation.exp: Fix exports.
• WebFoundation.pbproj/project.pbxproj: Add new files, remove removed ones.

Mechanical fixes to get C glue to compile:

• AuthenticationManager.subproj/IFAuthenticationHandlerC.m: (-[IFCallBackAuthenticationHandler isReadyToStartAuthentication:]):
• AuthenticationManager.subproj/IFAuthenticationRequestC.m: (IFAuthenticationRequestCopyURL): (IFAuthenticationRequestCopyRealm): (IFAuthenticationRequestCopyUsername): (IFAuthenticationRequestWillPasswordBeSentInClear): (IFAuthenticationRequestGetPreviousFailures): (IFAuthenticationRequestIsForProxy): (IFAuthenticationRequestCopyProxyHost): (IFAuthenticationRequestCopyProxyType): (IFAuthenticationRequestDone):
• AuthenticationManager.subproj/IFAuthenticationResultC.m: (IFAuthenticationResultCreate): (IFAuthenticationResultCopyUsername): (IFAuthenticationResultCopyPassword):

WebKit:

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): (-[WebAuthenticationPanel runAsModalDialogWithRequest:]): (-[WebAuthenticationPanel sheetDidEnd:returnCode:contextInfo:]):
• Panels.subproj/WebPanelAuthenticationHandler.h:
• Panels.subproj/WebPanelAuthenticationHandler.m: (-[WebPanelAuthenticationHandler isReadyToStartAuthentication:]): (-[WebPanelAuthenticationHandler startAuthentication:]): (-[WebPanelAuthenticationHandler _authenticationDoneWithRequest:result:]):