Timeline

Sep 30, 2002:

10:30 PM Changeset in webkit [2212] by cblu

• 11 edits
  7 adds
  3 deletes in trunk/WebKit

A ton o' plugin view clean-up and arch changes. Turned WebPluginView into WebBaseNetscapePluginView. New classes WebNetscapePluginEmbeddedView and WebNetscapePluginDocumentView are subclasses of WebBaseNetscapePluginView. WebNetscapePluginDocumentView handles non-HTML plug-in content and WebNetscapePluginEmbeddedView is the WebHTMLView subview.

Found that we leak the world on complex pages with plug-ins such as macromedia.com and marvel.com when closing the window. Still need to figure this out.

• Plugins.subproj/WebBaseNetscapePluginView.h: Added.
• Plugins.subproj/WebBaseNetscapePluginView.m: Added. (+[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:]): (-[WebBaseNetscapePluginView modifiersForEvent:]): (-[WebBaseNetscapePluginView getCarbonEvent:withEvent:]): (-[WebBaseNetscapePluginView keyMessageForEvent:]): (-[WebBaseNetscapePluginView sendEvent:]): (-[WebBaseNetscapePluginView sendActivateEvent:]): (-[WebBaseNetscapePluginView sendUpdateEvent]): (-[WebBaseNetscapePluginView acceptsFirstResponder]): (-[WebBaseNetscapePluginView becomeFirstResponder]): (-[WebBaseNetscapePluginView resignFirstResponder]): (-[WebBaseNetscapePluginView mouseDown:]): (-[WebBaseNetscapePluginView mouseUp:]): (-[WebBaseNetscapePluginView mouseEntered:]): (-[WebBaseNetscapePluginView mouseExited:]): (-[WebBaseNetscapePluginView keyUp:]): (-[WebBaseNetscapePluginView keyDown:]): (-[WebBaseNetscapePluginView isInResponderChain]): (-[WebBaseNetscapePluginView performKeyEquivalent:]): (-[WebBaseNetscapePluginView menuForEvent:]): (-[WebBaseNetscapePluginView setUpWindowAndPort]): (-[WebBaseNetscapePluginView setWindow]): (-[WebBaseNetscapePluginView removeTrackingRect]): (-[WebBaseNetscapePluginView resetTrackingRect]): (-[WebBaseNetscapePluginView start]): (-[WebBaseNetscapePluginView stop]): (-[WebBaseNetscapePluginView dataSource]): (-[WebBaseNetscapePluginView webFrame]): (-[WebBaseNetscapePluginView controller]): (-[WebBaseNetscapePluginView plugin]): (-[WebBaseNetscapePluginView setMIMEType:]): (-[WebBaseNetscapePluginView setBaseURL:]): (-[WebBaseNetscapePluginView setArguments:]): (-[WebBaseNetscapePluginView setMode:]): (-[WebBaseNetscapePluginView initWithFrame:]): (-[WebBaseNetscapePluginView dealloc]): (-[WebBaseNetscapePluginView drawRect:]): (-[WebBaseNetscapePluginView isFlipped]): (-[WebBaseNetscapePluginView viewWillMoveToWindow:]): (-[WebBaseNetscapePluginView viewDidMoveToWindow]): (-[WebBaseNetscapePluginView viewHasMoved:]): (-[WebBaseNetscapePluginView windowWillClose:]): (-[WebBaseNetscapePluginView windowBecameKey:]): (-[WebBaseNetscapePluginView windowResignedKey:]): (-[WebBaseNetscapePluginView defaultsHaveChanged:]): (-[WebBaseNetscapePluginView frameStateChanged:]): (-[WebBaseNetscapePluginView pluginInstance]): (-[WebBaseNetscapePluginView pluginURLFromCString:]): (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): (-[WebBaseNetscapePluginView getURLNotify:target:notifyData:]): (-[WebBaseNetscapePluginView getURL:target:]): (-[WebBaseNetscapePluginView postURLNotify:target:len:buf:file:notifyData:]): (-[WebBaseNetscapePluginView postURL:target:len:buf:file:]): (-[WebBaseNetscapePluginView newStream:target:stream:]): (-[WebBaseNetscapePluginView write:len:buffer:]): (-[WebBaseNetscapePluginView destroyStream:reason:]): (-[WebBaseNetscapePluginView status:]): (-[WebBaseNetscapePluginView invalidateRect:]): (-[WebBaseNetscapePluginView invalidateRegion:]): (-[WebBaseNetscapePluginView forceRedraw]):
• Plugins.subproj/WebBaseNetscapePluginViewPrivate.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.h: Added.
• Plugins.subproj/WebNetscapePluginDocumentView.m: Added. (-[WebNetscapePluginDocumentView initWithFrame:]): (-[WebNetscapePluginDocumentView dealloc]): (-[WebNetscapePluginDocumentView drawRect:]): (-[WebNetscapePluginDocumentView dataSource]): (-[WebNetscapePluginDocumentView setDataSource:]): (-[WebNetscapePluginDocumentView dataSourceUpdated:]): (-[WebNetscapePluginDocumentView setNeedsLayout:]): (-[WebNetscapePluginDocumentView layout]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h: Added.
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: Added. (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:arguments:]): (-[WebNetscapePluginEmbeddedView dealloc]): (-[WebNetscapePluginEmbeddedView viewDidMoveToWindow]): (-[WebNetscapePluginEmbeddedView start]): (-[WebNetscapePluginEmbeddedView dataSource]):
• Plugins.subproj/WebNetscapePluginViewPrivate.h: Removed.
• Plugins.subproj/WebPluginDatabase.m: (-[WebNetscapePluginDatabase init]):
• Plugins.subproj/WebPluginNullEventSender.h:
• Plugins.subproj/WebPluginNullEventSender.m: (-[WebNetscapePluginNullEventSender initWithPluginView:]): (-[WebNetscapePluginNullEventSender sendNullEvents]):
• Plugins.subproj/WebPluginStream.h:
• Plugins.subproj/WebPluginStream.m: (-[WebNetscapePluginStream getFunctionPointersFromPluginView:]): (-[WebNetscapePluginStream initWithURL:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream startLoad]): (-[WebNetscapePluginStream receivedData:withDataSource:]): (-[WebNetscapePluginStream handleWillUseUserAgent:forURL:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream cancel]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]): (-[WebNetscapePluginStream handleDidRedirect:toURL:]):
• Plugins.subproj/WebPluginView.h: Removed.
• Plugins.subproj/WebPluginView.m: Removed.
• Plugins.subproj/npapi.m: (NPN_GetURLNotify): (NPN_GetURL): (NPN_PostURLNotify): (NPN_PostURL): (NPN_NewStream): (NPN_Write): (NPN_DestroyStream): (NPN_Status): (NPN_InvalidateRect): (NPN_InvalidateRegion): (NPN_ForceRedraw):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebViewFactory viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebKit.pbproj/project.pbxproj:
• WebView.subproj/WebHTMLViewPrivate.m: (-[NSView _web_stopIfPluginView]):

2:39 PM Changeset in webkit [2211] by hyatt

• 4 edits in trunk/WebCore

Fix the case sensitivity problem with attribute names
in HTML. They are now lower-cased when being queried
from the DOM. Bug 3058145.

• khtml/xml/dom_docimpl.cpp: (DocumentImpl::attrName):

1:25 PM Changeset in webkit [2210] by hyatt

• 4 edits in trunk/WebCore

Make sure to keep the fix checked in for 1.18. That fix is
good.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

1:03 PM Changeset in webkit [2209] by hyatt

• 4 edits in trunk/WebCore

Backing out change to render_table.cpp. The original logic
(in version 1.16) is correct.

• khtml/rendering/render_table.cpp: (RenderTable::addColInfo):

11:09 AM Changeset in webkit [2208] by darin

• 4 edits in trunk/WebKit

• WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Remove the ill-advised "don't even create a WebDataSource if WebResourceHandle can't handle this request" code.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _startLoading]): Rearrange checks so we won't get confused if we can't create a handle.

10:52 AM Changeset in webkit [2207] by darin

• 13 edits in trunk/WebCore

• kwq/qt/qobject.h: Add the destroyed signal.
• kwq/KWQObject.mm: (QObject::connect): Remove names of parentDestroyed and slotWidgetDestructed from the list of "slots OK to fail to connect without complaining". (QObject::QObject): Initialize the destroyed signal.

• kwq/qt/qguardedptr.h:
• kwq/KWQGuardedPtr.mm:
• kwq/KWQSignal.h:
• kwq/KWQSlot.h: Rearrange includes so qobject.h can include KWQSignal.h.

• kwq/KWQSignal.mm: Tweak.

• kwq/KWQSlot.mm: Added support for the parentDestroyed slot in KJS::WindowQObject and the slotWidgetDestructed slot in khtml::RenderWidget.

10:08 AM Changeset in webkit [2206] by darin

• 2 edits
  1 add in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Added.

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Added.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Added.

9:26 AM Changeset in webkit [2205] by darin

• 3 edits in trunk/WebKit

• fixed crashing part of 3063517 -- crash loading .png in separate window

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView start]): Don't try to start if the NPP_New is 0. This indicates the the plugin hasn't been loaded.

8:49 AM Changeset in webkit [2204] by darin

• 3 edits in trunk/WebKit

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setLoading:]): Remove extra quotes in use of ASSERT_ARG.

Sep 29, 2002:

10:03 PM Changeset in webkit [2203] by darin

• 11 edits in trunk/WebKit

WebKit:

• Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase _iconForFileURL:withSize:]): Don't be case sensitive about filename extensions.

• Misc.subproj/WebDownloadHandler.m:
• Misc.subproj/WebIconLoader.m:
• Plugins.subproj/WebPluginStream.m:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDefaultContextMenuDelegate.m:
• WebView.subproj/WebFrame.m:
• WebView.subproj/WebFramePrivate.m:
• WebView.subproj/WebView.m: Don't use WebFoundation.h -- faster building to just import what we really use.

WebBrowser:

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): Don't be case sensitive about filename extensions.

• Preferences.subproj/SecurityPreferences.m: Don't use WebFoundation.h -- faster building to just import what we really use.

10:04 AM Changeset in webkit [2202] by cblu

• 5 edits in trunk/WebKit

WebKit:

Fixed: 2978258 - quake3arena.com sends me to the flash=false site
The page has a flash plugin that once loaded, requests the flash=true page. If the plugin doesn't load, the meta refresh tag to the flash=false page fires after 3 seconds. This is how this site's flash detection works.

The reason this doesn't work for us is because the flash movie is at the bottom of the page. Plugins don't start until the initial drawRect. Since the movie is at the bottom of the page and out of site, the plugin never gets the drawRect and thus, never starts. We now start plug-ins when they are added to the window.

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Fixed click then click and drag causes crash.

• Plugins.subproj/WebPluginView.m: (-[WebNetscapePluginView drawRect:]): don't start plug-in here (-[WebNetscapePluginView viewDidMoveToWindow]): start it here
• WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate contextMenuItemsForElement:defaultMenuItems:]): don't provide "Download Link To Disk" and "Open Link In New Window" items for URLs we cant handle.
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): clean-up (-[WebHTMLView mouseDragged:]): Don't allow drag if the frame has a provisional data source because this view may be released and the drag callbacks might reference this released view.

WebBrowser:

Fixed: 3062224 - context menu includes "Download Item to Disk" for mailto links

• Added "Open With QuickTime Player" context menu for URLs ending with .mov.
• Only show "Open With*" items for http URLs.

• ContextMenuHandler.m: (-[ContextMenuHandler contextMenuItemsForElement:defaultMenuItems:]): (-[ContextMenuHandler openWithiTunes:]): (-[ContextMenuHandler openWithQuickTime:]):