⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 16, 2002:

10:43 PM Changeset in webkit [2350] by darin
  • 5 edits in trunk/WebCore
  • fixed 3061103 -- Line-breaks lost when submitting after pasting text from MSIE into Alexander textarea
  • kwq/KWQLineEdit.mm: (QLineEdit::text):
  • kwq/KWQTextEdit.mm: (QTextEdit::text): Turn \r\n sequences and standalone \r characters into \n characters on the way out of AppKit land and into KHTML land. I didn't try to make this efficient for the common case because these are not time-critical functions.
6:08 PM Changeset in webkit [2349] by rjw
  • 13 edits in trunk

i Fixed a few regressions in drawing of frame resize handle

in preparation for drawing frame borders and completing
2982466.

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
  • kwq/KWQPainter.mm: (QPainter::drawRect):
  • kwq/qt/qscrollview.h:
  • kwq/KWQScrollView.mm: (QScrollView::updateContents):
  • kwq/KWQWidget.mm: (QWidget::enableFlushDrawing):

Use static_cast everywhere DOM::NodeImpl is cast to
subclass.

  • kwq/WebCoreDOMNode.mm: (-[WebCoreDOMNode DOM::]): (-[WebCoreDOMNodeList DOM::]): (-[WebCoreDOMNamedNodeMap DOM::]): (-[WebCoreDOMAttr DOM::]):

Added some drawing debug code (ifdef excluded).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]):
5:37 PM Changeset in webkit [2348] by hyatt
  • 7 edits in trunk/WebCore

Fix crash on pages with bulleted lists. Making sure the list
item marker doesn't get a layer (which means it has to be
painted by hand now by the list item object).

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_list.cpp: (RenderListItem::printObject):
  • khtml/rendering/render_list.h:
  • khtml/rendering/render_object.h:
5:01 PM Changeset in webkit [2347] by darin
  • 4 edits in trunk/WebCore
  • fixed 3072542 -- double "&" in submit button
  • khtml/rendering/render_form.cpp: (RenderSubmitButton::rawText): Don't double the "&" character, not needed for KWQ.
4:49 PM Changeset in webkit [2346] by darin
  • 3 edits in trunk/WebKit

Fixed anomalies with plugin positioning caused by my switch to
NSViewFocusDidChangeNotification. Turns out that is not sent during
live resize, but we need things to work during live resize.

  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView start]): Register for changes in the bounds and frame of all superviews again, instead of using NSViewFocusDidChangeNotification.
4:28 PM Changeset in webkit [2345] by hyatt
  • 5 edits in trunk/WebCore

When render objects were being dynamically wrapped in anonymous
blocks, the layer parenting connection was being broken without
being reconnected when the wrapping finished. This patch
shifts the layer connection into the functions that are also
called in the dynamic case.

With this fix, all objects on mrskin finally show up. Yeehah.
brainjar.com's brain is back too.

This patch also stops treating images as inline if they are
using abs/fixed positioning, since according to the CSS spec,
abs/fixed positioned elements should be treated as block-level
content.

  • khtml/rendering/render_container.cpp: (RenderContainer::addChild): (RenderContainer::appendChildNode): (RenderContainer::insertChildNode):
  • khtml/rendering/render_image.cpp: (RenderImage::setStyle):
4:24 PM Changeset in webkit [2344] by darin
  • 9 edits in trunk/WebCore
  • fixed 3045570 -- can't select a printer at inkfinder.com
  • khtml/khtml_part.cpp: (KHTMLPart::processObjectRequest): Call the new openURL for the case where we are reusing a part. We do this backwards from how KHTML does, so it's twisted.
  • kwq/KWQKHTMLPartImpl.h: Add openURL.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::openURL): Tell the bridge to load the URL.
  • kwq/mac-encodings.txt: Tweak Korean encoding names.
3:41 PM Changeset in webkit [2343] by rjw
  • 3 edits in trunk/WebKit

Fixed 2969367. Ensure layout happens before doing check
to determine if scrollbars are needed. Ahhh, dynamic
scrollbars work so much better now.

  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):
3:01 PM Changeset in webkit [2342] by darin
  • 3 edits in trunk/WebKit

Fixed the problem where we would leave white bits when making the window larger.

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView drawRect:]): During live resize, use the visible rectangle after doing layout, not before.
2:55 PM Changeset in webkit [2341] by hyatt
  • 9 edits in trunk/WebCore

A very substantial change. Absolute/fixed positioned elements that
are NOT renderflows were not getting layers constructed for them.
They do now.

Also, floats now have layers constructed for them. This allows
printSpecialObjects to be completely eliminated, enables smarter
damge rect intersection testing for faster painting, and fixes
regressions on sites like www.demian5.com.

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_flow.cpp: (RenderFlow::printObject): (RenderFlow::addOverHangingFloats): (RenderFlow::printTree):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_layer.cpp: (RenderLayer::constructZTree):
  • khtml/rendering/render_root.cpp: (RenderRoot::printObject):
  • khtml/rendering/render_table.cpp: (RenderTable::print):
1:40 PM Changeset in webkit [2340] by rjw
  • 10 edits in trunk

Fixed 3059237, which was fixed, but regressed.

Fixed regression in visited links due to change is semantics of
[dataSource request], added [dataSource _originalRequest]. Items
always need to be added to history with the original request.

  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _defersCallbacksChanged]): (-[WebDataSource _originalRequest]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]):

Removed bogus code.

  • kwq/KWQKHistoryProvider.mm:
10:03 AM Changeset in webkit [2339] by darin
  • 11 edits in trunk/WebKit

WebKit:

  • fixed 3017152 -- intra-page anchors not updating page address field
  • WebView.subproj/WebLocationChangeDelegate.h: Rearrange methods so they are in the order they are delivered. Add locationChangedWithinPageForDataSource method. Renamed the redirect methods to match the verb tenses used in the others. Removed the URL parameter from the server redirect method.
  • WebView.subproj/WebLocationChangeDelegate.m: Update the class to match the changes to the protocol.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportClientRedirectTo:delay:fireDate:]): Update for change to clientWillRedirectTo method name. (-[WebBridge loadURL:]): Call locationChangedWithinPageForDataSource:.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]): Update for change to serverRedirectedForDataSource method name.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView mouseMovedNotification:]): Remove overzealous assert that was firing for me.
  • WebCoreSupport.subproj/WebSubresourceClient.m: Update comment.
  • WebView.subproj/WebDataSource.h: Fix comment.

WebBrowser:

WebBrowser changes to handle location changes within a page (clicks on anchors).

  • BrowserWindowController.h: Added mainFrameLocationChangedWithinPage.
  • BrowserWindowController.m: (-[BrowserWindowController mainFrameLocationChangedWithinPage]): Calls setLocationFieldTextToCurrentURL.
  • LocationChangeHandler.m: (-[LocationChangeHandler serverRedirectedForDataSource:]): Updated name to track change in WebKit. Also removed unnecessary calls to titleChangedForFrame and to _currentURLHasChanged, since both are only needed if the data source is committed, and server redirects always come before it is committed. (-[LocationChangeHandler locationChangedWithinPageForDataSource:]): Added. Has much of what used to be in serverRedirectedForDataSource, and also calls the new mainFrameLocationChangedWithinPage. (-[LocationChangeHandler clientWillRedirectTo:delay:fireDate:forFrame:]): Updated name to track change in WebKit.

Oct 15, 2002:

6:42 PM Changeset in webkit [2338] by rjw
  • 6 edits in trunk/WebCore
  • kwq/WebCoreBridge.mm: (attributedString): Don't convert element unless it has a renderer.
  • kwq/WebCoreDOMNode.mm: (-[WebCoreDOMAttr DOM::]): (-[WebCoreDOMAttr name]): (-[WebCoreDOMAttr specified]): (-[WebCoreDOMAttr value]): (-[WebCoreDOMAttr ownerElement]): (-[WebCoreDOMElement tagName]): (-[WebCoreDOMElement setAttribute::]): (-[WebCoreDOMElement removeAttribute:]): (-[WebCoreDOMElement getAttributeNode:]): (-[WebCoreDOMElement removeAttributeNode:]): (-[WebCoreDOMElement getElementsByTagName:]): (-[WebCoreDOMElement getAttributeNS::]): (-[WebCoreDOMElement setAttributeNS:::]): (-[WebCoreDOMCharacterData data]): (-[WebCoreDOMCharacterData setData:]): (-[WebCoreDOMCharacterData length]): (-[WebCoreDOMCharacterData substringData::]): (-[WebCoreDOMCharacterData appendData:]): (-[WebCoreDOMCharacterData insertData::]): (-[WebCoreDOMCharacterData deleteData::]): (-[WebCoreDOMText splitText:]): (-[WebCoreDOMProcessingInstruction data]): (-[WebCoreDOMProcessingInstruction setData:]):
  • kwq/WebCoreDOMPrivate.h: API cleanup.
5:39 PM Changeset in webkit [2337] by hyatt
  • 4 edits in trunk/WebCore

More work on making blocks correctly compute their maximal
positive and negative margins. Adding code to ensure
that floats and absolute/fixed positioned elements know
not to collapse with children or with themselves. Also adding
code to teach empty blocks that they can collapse their own
margins together.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
5:15 PM Changeset in webkit [2336] by darin
  • 18 edits in trunk

WebCore:

WebCore support for using referrer even in loads that are not initiated
by WebCore itself.

  • kwq/KWQKHTMLPartBrowserExtension.mm: (KHTMLPartBrowserExtension::createNewWindow): Don't pass a referrer. We get the referrer from the part.
  • kwq/KWQKHTMLPartImpl.h: Add a new referrer method that works on the part, and remove the old one that got it from the URL arguments.
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::bridgeForFrameName): Don't pass a referrer when creating a new window. (KWQKHTMLPartImpl::openURLRequest): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::urlSelected): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::createPart): Don't pass a referrer when creating a child frame for this window. (KWQKHTMLPartImpl::submitForm): Don't pass a referrer when doing a load. (KWQKHTMLPartImpl::referrer): Added.
  • kwq/KWQLoaderImpl.mm: (KWQServeRequest): Don't pass a referrer when starting a load.
  • kwq/WebCoreBridge.h: Add referrer method. Remove referrer parameter from many other methods.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge referrer]): Added.

WebKit:

  • fixed 3062393 -- need to send proper referrer for "open in new window" menu items and keyboard shortcuts
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Don't take a referrer parameter any more. Get the referrer by calling to the other side of the bridge, instead. (-[WebBridge startLoadingResource:withURL:]): Ditto. (-[WebBridge loadURL:]): Ditto. (-[WebBridge postWithURL:data:contentType:]): Ditto. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Ditto.
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]): Don't take a referrer parameter, which was always nil anyway. Instead, get the referrer from the bridge. (-[WebDefaultContextMenuDelegate openLinkInNewWindow:]): Don't pass nil for referrer. (-[WebDefaultContextMenuDelegate openImageInNewWindow:]): Ditto. (-[WebDefaultContextMenuDelegate openFrameInNewWindow:]): Ditto.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _continueAfterClickPolicyForEvent:]): Pass a referrer from the bridge, rather than nil, for both WebClickPolicyOpenNewWindow and WebClickPolicyOpenNewWindowBehind.
  • Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:]): Add a FIXME.
4:48 PM Changeset in webkit [2335] by darin
  • 4 edits in trunk/WebKit
  • WebView.subproj/WebDataSourcePrivate.h: Remove unused stuff.
  • WebView.subproj/WebDataSourcePrivate.m: Ditto.
4:35 PM Changeset in webkit [2334] by darin
  • 4 edits in trunk/WebCore
  • fixed 3021713 -- text selection background obliterates descenders (in www.theregister.co.uk articles)
  • fixed 3038207 -- Selected link text doesn't draw its link underline
  • khtml/rendering/render_text.cpp: (TextSlave::printSelection): Don't draw text at all, just draw a selection background. (RenderText::printObject): Draw in two passes. Draw the selection background in the first pass, and the text in the second pass. That way pieces of the background won't cover any other text or adornments, like underlines.
3:44 PM Changeset in webkit [2333] by darin
  • 16 edits in trunk

WebCore:

  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::urlSelected): Move the special case of a different anchor within the same page into WebKit from here.
  • kwq/kdecore/kurl.h: Mark urlcmp as a friend.
  • kwq/KWQKURL.mm: (urlcmp): Implement the ignoreRef feature, which is needed to make the KHTMLPart::openURL function work right.
  • kwq/WebCoreBridge.h: Removed addBackForwardItemWithURL:anchor: and added URL method.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge URL]): Added.

WebKit:

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:referrer:]): Add a special case for when the URL is the same as the previous URL for the same frame. This relies on some logic in KHTML's openURL method that handles this case too.
  • WebView.subproj/WebDataSource.m: (-[WebDataSource initWithRequest:]): Don't bother keeping an inputURL. (-[WebDataSource URL]): Just return [[self request] URL]. Maybe we can remove this altogether.
  • WebView.subproj/WebDataSourcePrivate.h: Remove inputURL, finalURL.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): No need to release inputURL, finalURL. (-[WebDataSource _setURL:]): Used only by the new code above. Makes a copy of the request, changes the URL, and then drops the old request. (-[WebDataSource _setRequest:]): Changed to no longer call _setURL. Now does much of the work that _setURL used to do.
1:49 PM Changeset in webkit [2332] by darin
  • 13 edits in trunk

WebCore:

The key was to make the name attribute work properly.

  • khtml/ecma/kjs_window.cpp: (Window::get): Enable the "name" attribute. (Window::put): Enable the "name" attribute, but don't do the conversion to an 8-bit string -- leave it as a QString.
  • kwq/WebCoreBridge.h: Add setName/name methods.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge setName:]): Added. Calls part->setName(). (-[WebCoreBridge name]): Added. Calls part->name().
  • kwq/kparts/part.h: Added setName/name to ReadOnlyPart.
  • kwq/KWQKHTMLPartImpl.mm: Remove old bogusish comment.

WebKit:

WebKit part of improved frame name support.

  • WebView.subproj/WebFrame.m: (-[WebFrame initWithName:webView:provisionalDataSource:controller:]): Call setName on the newly created part.
1:01 PM Changeset in webkit [2331] by sullivan
  • 3 edits in trunk/WebKit
  • fixed 3075777 -- hysteresis for dragging links on web pages is still too large
  • WebView.subproj/WebHTMLView.m: changed hysteresis constants; added comment.
12:52 PM Changeset in webkit [2330] by darin
  • 3 edits in trunk/WebKit

Fix problem where timer was lasting after window was closed.

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _detachFromParent]): Add a call to [_private->bridge closeURL].
12:51 PM Changeset in webkit [2329] by rjw
  • 4 edits in trunk/WebCore

Added text color to attributed string conversion.

  • kwq/WebCoreBridge.mm: (attributedString):
12:47 PM Changeset in webkit [2328] by rjw
  • 8 edits in trunk

Added attributed string to pasteboard. Fixes 3006760.
We may want to scale back the content that is included in the
attributed string. Currently all text nodes in the selection
are converted. This include text nodes for non-visible content,
i.e. scripts.
[Note we may also want to put HTML snippet on the pboard. The appkit
does support reading text using htmldisplay today. Of course this should
eventually migrate to use WebView.]

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView copy:]):

Added API to get attributed string from bridge.
Added API to get selection in terms of the DOM API
from the bridge.

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (attributedString): (-[WebCoreBridge selectionStart]): (-[WebCoreBridge selectionStartOffset]): (-[WebCoreBridge selectionEnd]): (-[WebCoreBridge selectionEndOffset]):
11:20 AM Changeset in webkit [2327] by darin
  • 5 edits in trunk/WebCore
  • fixed 3054791 -- crash in WebCoreSettings _updateAllViews changing font
  • kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::~KWQKHTMLPartImpl): Pass in the "this" pointer so that the right instance is removed from the instances list. Before, we would always remove the first instance from the list, leaving the list broken.
11:19 AM Changeset in webkit [2326] by darin
  • 3 edits in trunk/WebKit

Fixed bug where URLs dragged to the content area were not made canonical
the way URLs dragged to the page address field are.

  • Misc.subproj/WebNSPasteboardExtras.m: (-[NSPasteboard _web_bestURL]): Make URLs canonical before returning them.
10:34 AM Changeset in webkit [2325] by cblu
  • 6 edits in trunk/WebKit

If a file is renamed during download because a file of the same name already exists, show this in the UI.

  • Misc.subproj/WebDownloadHandler.h:
  • Misc.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedResponse:]): added, create file here (-[WebDownloadHandler receivedData:]): don't create file here
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handleDidFinishLoading:]): call [dataSource _setPrimaryLoadComplete:YES] for downloads (-[WebMainResourceClient handle:didReceiveResponse:]): call [WebDownloadHandler receivedResponse:] (-[WebMainResourceClient handle:didReceiveData:]): no download error to handle
7:28 AM Changeset in webkit [2324] by kocienda
  • 4 edits in trunk/WebCore

Fixed an "unused variable" build breaker. Note that I just
commented out the code and put a FIXME, as I know this is code
that David has been banging on a lot. This should be either
used for real or removed eventually, but I'll leave that for
Hyatt.

  • khtml/rendering/render_flow.cpp: (RenderFlow::layoutBlockChildren):
Note: See TracTimeline for information about the timeline view.