⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 18, 2002:

5:27 PM Changeset in webkit [2374] by rjw
  • 15 edits in trunk

Fixed khtml to ignore <title> tags after the first tag.

Fixed setting document.title from JavaScript.

  • khtml/dom/html_document.cpp: (HTMLDocument::setTitle):
  • khtml/html/html_headimpl.cpp: (HTMLTitleElementImpl::insertedIntoDocument): (HTMLTitleElementImpl::childrenChanged):

Changed name to setUsesBackForwardList: from
setUseBackForwardList. ditto for useBackForwardList

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController setUsesBackForwardList:]): (-[WebController usesBackForwardList]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _isLoadComplete]):

Fixed history items that have "untitled" title after
redirect. (3078577).

  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setTitle:]):

Made title of snippet window change to match document title, if
present.

  • Debug/SnippetController.h:
  • Debug/SnippetController.m: (-[SnippetController setTitle:]): (-[SnippetLocationChangeDelegate locationChangeDone:forDataSource:]):
3:08 PM Changeset in webkit [2373] by darin
  • 4 edits in trunk/WebCore
  • fixed 3078293 -- Implement evaluateJavaScript on WebController
  • kwq/KWQVariant.mm: (QVariant::asString): Made this return reasonable values for types other than string. Still may be loose ends left, but this takes care of most of it.
3:00 PM Changeset in webkit [2372] by darin
  • 11 edits in trunk

WebCore:

  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebKit:

  • WebView.subproj/WebController.h:
  • WebView.subproj/WebController.m: (-[WebController stringByEvaluatingJavaScriptFromString:]): Changed to return a string and changed name.

WebBrowser:

  • BrowserWebBookmarkExtras.m: (-[WebBookmark _goToWithWindowPolicy:]):
  • BrowserWindowController.m: (-[BrowserWindowController goToToolbarLocation:]): Update to call stringByEvaluatingJavaScriptFromString.
1:49 PM Changeset in webkit [2371] by darin
  • 3 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
  • English.lproj/Localizable.strings: Regenerate after recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

  • LoadProgressMonitor.m: (-[LoadProgressMonitor _busyStatus]): Say "Contacting <host>" instead of "Looking for <host>" to help reduce confusion about whether this shows up just during DNS or not.
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
  • English.lproj/Localizable.strings: Regnerate.
1:26 PM Changeset in webkit [2370] by kocienda
  • 3 edits in trunk/WebKit

Removed unneeded import of WebFoundation/WebResourceLoadManager.h

  • Misc.subproj/WebIconLoader.m
1:20 PM Changeset in webkit [2369] by hyatt
  • 7 edits in trunk/WebCore

The collapsing margin rewrite. Also fixes a bug where
we stay in quirks mode for strict HTML4 dtds when we
shouldn't.

  • khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::determineParseMode):
  • khtml/rendering/render_flow.cpp: (RenderFlow::layout): (RenderFlow::layoutBlockChildren):
  • khtml/rendering/render_flow.h:
  • khtml/rendering/render_object.h:
11:10 AM Changeset in webkit [2368] by darin
  • 7 edits in trunk

WebCore:

  • Makefile.am: Move dependency so clean happens before build.

WebKit:

  • Makefile.am: Move dependency so clean happens before build.
11:01 AM Changeset in webkit [2367] by darin
  • 3 edits in trunk/WebKit
  • force-clean-timestamp: Dependencies don't work well enough, so we need a clean build here after the WebFoundation domain change.
10:13 AM Changeset in webkit [2366] by darin
  • 7 edits
    1 delete in trunk/WebKit

WebFoundation:

WebError cleanup. Change domains to be strings, remove unused codes.

  • AuthenticationManager.subproj/WebAuthenticationManagerPrivate.h:
  • AuthenticationManager.subproj/WebAuthenticationManager.m: (-[WebAuthenticationManager _checkForAuthenticationFailureInHTTPResponse:withURL:]): Don't return an error code. The error code was always vague, and never looked at by our one client or exposed outside WebFoundation. If we later want to report a precise error, we can easily re-add it.
  • CacheLoader.subproj/WebResourceLoad.h: Change domain parameter to an NSString *.
  • CacheLoader.subproj/WebResourceLoad.m: (-[WebResourceLoad failedWithResultCode:inDomain:failingURL:]): Ditto.
  • Misc.subproj/WebError.h: Moved WebErrorDomainWebKit to WebKit. Removed WebErrorDomainFTP. Removed WebErrorCodeNoError, WebErrorCodeHTTPUnknownAuthenticationSchemeError, and WebErrorCodeHTTPBadAuthenticationHeaderError, which were never used. Changed methods to take NSString * for the error domain. Added errorIsInDomain method.
  • Misc.subproj/WebError.m: (-[WebErrorPrivate dealloc]): Release the error domain string. (classInitialize): Remove descriptions for now-unused error codes. (-[WebError initWithErrorCode:inDomain:failingURL:]): Take a domain string. (-[WebError errorDomain]): Return the domain string. (-[WebError errorIsInDomain:]): Added. (-[WebError errorDescription]): Update to look up by string. (+[WebError addErrorsWithCodesAndDescriptions:inDomain:]): Use domain string as key.
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler performHTTPHeaderRead:andCall:]): Get rid of the code that stored the authenticationFailureResult, which was never passed to the user.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.h: Remove authenticationFailureResult.
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler determineErrorAndFail]): Rearrange the code so we don't use WebErrorCodeNoError. Also change the domain so that we don't report the WebErrorCodeCannotConnectToHostError error in the SSL domain any more.
  • WebFoundation.exp: Export the new domain string globals.

WebKit:

Update for WebFoundation error domain changes.

  • Misc.subproj/WebKitErrors.h: Put WebErrorDomainWebKit in here. Also remove WebErrorNoError and the WebErrorCode name for the enum.
  • WebKit.exp: Export the WebErrorDomainWebKit constant.
  • WebView.subproj/WebView.m: Define the WebErrorDomainWebKit.
  • WebKit.pbproj/project.pbxproj: Always use WebKit.exp.
  • Makefile.am: Don't generate WebKit-combined.exp any more.
  • WebKit-tests.exp: Removed.

WebBrowser:

Update for WebFoundation error domain changes.

  • LocationChangeError.m: (-[LocationChangeHandler specializedTitleForError:]): Use the new errorIsInDomain method instead of doing a switch statement, since that works with NSString. (-[LocationChangeHandler specializedMessageForError:]): Ditto.

Oct 17, 2002:

11:41 PM Changeset in webkit [2365] by darin
  • 2 edits in trunk/WebKit
  • fixed 3078644 -- Odd clipping in frame
  • WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
  • WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.
11:40 PM Changeset in webkit [2364] by darin
  • 5 edits in trunk/WebKit

A small change that eliminates a variety of strange clipping problems, including ones that
make large swathes of the page disappear.

  • WebView.subproj/WebClipView.h: Add hasAdditionalClip and additionalClip methods.
  • WebView.subproj/WebClipView.m: (-[WebClipView resetAdditionalClip]): Add an assertion. (-[WebClipView setAdditionalClip:]): Ditto. (-[WebClipView hasAdditionalClip]): Added. (-[WebClipView additionalClip]): Added.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView visibleRect]): Turn off the additional clip while computing our visibleRect. This way, the additional clip only affects people who ask for the clip view's visibleRect directly, which basically means just the focus rectangle drawing code we are trying to influence.
5:30 PM Changeset in webkit [2363] by rjw
  • 11 edits in trunk

Support for drawing frame borders and frame resizing. (fixes 2982466).

  • khtml/rendering/render_frames.cpp: (RenderFrameSet::userResize):
  • kwq/WebCoreBridge.h:
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge frameBorderStyle]):
  • kwq/qt/qframe.h:

Support for drawing frame borders (fixes 2982466).

  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _drawBorder:]): (-[WebHTMLView drawRect:]):
5:18 PM Changeset in webkit [2362] by darin
  • 8 edits in trunk/WebCore
  • fixed 2807340 -- Alex is case sensitive for anchors, but should not be in quirks mode (other browsers aren't)
  • khtml/dom/html_misc.cpp: Touched this file to prevent us from requiring a full build. Damned header dependencies still don't work right.
  • khtml/html/html_miscimpl.h: Add caseSensitive parameters.
  • khtml/html/html_miscimpl.cpp: (HTMLCollectionImpl::getNamedItem): Add caseSensitive parameter, and compare by converting both to lower case if it's false and pass it on when recursing. (HTMLCollectionImpl::namedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedItem): Pass along a caseSensitive parameter. (HTMLFormCollectionImpl::getNamedFormItem): Pass along, and handle, it. (HTMLFormCollectionImpl::getNamedImgItem): Ditto. (HTMLFormCollectionImpl::nextNamedItemInternal): Pass true for caseSensitive.
  • khtml/khtml_part.cpp: (KHTMLPart::gotoAnchor): Pass false for the new caseSensitive parameter to namedItem when the document mode is not strict.
  • kwq/KWQListBox.mm: (QListBox::sizeForNumberOfLines): Removed a stray NSLog that I left in by accident.
4:04 PM Changeset in webkit [2361] by darin
  • 6 edits in trunk/WebCore
  • fixed 3052547 -- <select> doesn't size properly (size > 1)
  • khtml/rendering/render_form.cpp: (RenderLineEdit::slotReturnPressed): #if !APPLE_CHANGES around some unused code in here. (RenderSelect::updateFromElement): Fix bug where it was using Multi here, but Extended elsewhere for the selection mode. (RenderSelect::layout): Change code so that QListBox handles the sizing.
  • kwq/KWQListBox.h: Removed a lot of unused stuff, made other things use inlines.
  • kwq/KWQListBox.mm: Rewrote most of the file contents. Made a new QListBox::sizeForNumberOfLines method. We will have to port this to NSTableView rather than NSBrowser.
2:05 PM Changeset in webkit [2360] by darin
  • 4 edits in trunk/WebCore
  • fixed 3078245 -- REGRESSION: lightgrey displays as black, used to display as white, should display light gray
  • kwq/KWQColor.mm: (getNamedColors): For every color with the name "gray" in it, also include the version spelled "grey" as other browsers seem to.
1:14 PM Changeset in webkit [2359] by sullivan
  • 8 edits in trunk/WebKit

WebKit:

  • added support for bookmark identifiers, to be used for marking bookmark proxies uniquely (independent of localized title). This is not the old unique-identifier scheme; now identifiers are optional, and initially nil, but the client can use them for its own purposes.
  • Bookmarks.subproj/WebBookmark.h:
  • Bookmarks.subproj/WebBookmark.m: (-[WebBookmark dealloc]): release identifier (-[WebBookmark identifier]): return identifier (-[WebBookmark setIdentifier:]): set identifier
  • Bookmarks.subproj/WebBookmarkLeaf.m: (-[WebBookmarkLeaf initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkLeaf dictionaryRepresentation]): save identifier (-[WebBookmarkLeaf copyWithZone:]): copy identifier
  • Bookmarks.subproj/WebBookmarkList.m: (-[WebBookmarkList initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkList dictionaryRepresentation]): save identifier (-[WebBookmarkList copyWithZone:]): copy identifier
  • Bookmarks.subproj/WebBookmarkPrivate.h:
  • Bookmarks.subproj/WebBookmarkProxy.m: (-[WebBookmarkProxy initFromDictionaryRepresentation:withGroup:]): restore identifier (-[WebBookmarkProxy dictionaryRepresentation]): save identifier (-[WebBookmarkProxy copyWithZone:]): copy identifier

WebBrowser:

  • a bunch of work in the direction of getting the special "bookmark sources" to work in the bookmarks view. The Address Book contents now appear in the Bookmarks view, but Rendezvous and History don't yet.
  • BookmarkSource.h: Added. Defines protocol to be used by special bookmark sources.
  • BookmarksController.h: define identifier constants used for special bookmark sources.
  • BookmarksController.m: (-[BookmarksController _blessOrCreateSpecialFolders]): set identifiers on bookmark proxies representing special bookmark sources
  • BookmarksViewController.m: (-[BookmarksViewController undoRemoveBookmarks:]): (-[BookmarksViewController selectedContentItems]): (-[BookmarksViewController deleteContentItems:]): (-[BookmarksViewController deleteSelectedContentItems]): (-[BookmarksViewController doubleClick:]): (-[BookmarksViewController newBookmarkFolder:]): (-[BookmarksViewController bookmarkSourceForProxyIdentifier:]): (-[BookmarksViewController refreshContents]): (-[BookmarksViewController bookmarksFromContentItems:]): (-[BookmarksViewController bookmarkFromContentItem:]): (-[BookmarksViewController canAddToBookmarkSource:]): (-[BookmarksViewController canAddToSelectedBookmarkSource]): (-[BookmarksViewController canDeleteFromSelectedBookmarkSource]): (-[BookmarksViewController child:ofContentItem:]): (-[BookmarksViewController isContentItemExpandable:]): (-[BookmarksViewController numberOfChildrenOfContentItem:]): (-[BookmarksViewController titleStringForContentItem:]): (-[BookmarksViewController addressStringForContentItem:]): (-[BookmarksViewController imageForContentItem:]): (-[BookmarksViewController shouldEditTableColumn:forContentItem:]): (-[BookmarksViewController tableView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController cleanUpAfterDraggingBookmarksWithOperation:]): (-[BookmarksViewController prepareForDraggingBookmarks:fromSourceColumn:]): (-[BookmarksViewController tableView:validateDrop:proposedRow:proposedDropOperation:]): (-[BookmarksViewController handleKeyDown:inSourceColumn:]): (-[BookmarksViewController tableViewSelectionDidChange:]): (-[BookmarksViewController outlineView:child:ofItem:]): (-[BookmarksViewController outlineView:isItemExpandable:]): (-[BookmarksViewController outlineView:numberOfChildrenOfItem:]): (-[BookmarksViewController outlineView:objectValueForTableColumn:byItem:]): (-[BookmarksViewController outlineView:draggingSourceOperationMaskForLocal:]): (-[BookmarksViewController outlineView:writeItems:toPasteboard:]): (-[BookmarksViewController outlineView:willDisplayCell:forTableColumn:item:]): (-[BookmarksViewController outlineView:shouldEditTableColumn:item:]): (-[BookmarksViewController copy:]): (-[BookmarksViewController delete:]): My brain gets sore thinking about writing individual comments here. Basically I generalized methods that were dealing explicitly with bookmarks to deal with opaque "content items" instead, then delegate to the appropriate BookmarkSource in the bottleneck methods. Only Address Book is hooked up so far. This also fixed lots of trouble you could get into if you played with the "not implemented yet" items too much.
  • ABHomePagesController.h:
  • ABHomePagesController.m: (-[ABHomePagesController refreshContents]): (-[ABHomePagesController canDeleteContents]): (-[ABHomePagesController deleteContentItems:]): (-[ABHomePagesController isContentItemExpandable:]): (-[ABHomePagesController child:ofContentItem:]): (-[ABHomePagesController numberOfChildrenOfContentItem:]): (-[ABHomePagesController bookmarkFromContentItem:]): (-[ABHomePagesController bookmarksFromContentItems:]): (-[ABHomePagesController addressStringForContentItem:]): (-[ABHomePagesController titleStringForContentItem:]): (-[ABHomePagesController imageForContentItem:]): Implement BookmarkSource protocol; I haven't deleted all the similar code that drives the Address Book window yet.
  • English.lproj/MainMenu.nib: changed "Last Search Results" to "SnapBack to Search" under protest.
  • WebBrowser.pbproj/project.pbxproj: updated for new file
12:06 PM Changeset in webkit [2358] by hyatt
  • 4 edits in trunk/WebCore

Make navigator.product dynamic based off user agent (i.e.,
make it participate in spoofing too).

  • khtml/ecma/kjs_navigator.cpp: (Navigator::getValueProperty):
11:10 AM Changeset in webkit [2357]
  • 3 copies in tags/Alexander-28

This commit was manufactured by cvs2svn to create tag 'Alexander-28'.

11:10 AM Changeset in webkit [2356] by sheridan
  • 8 edits in trunk

Alex-28

10:12 AM Changeset in webkit [2355] by darin
  • 5 edits in trunk/WebCore
  • fixed 3077856 -- REGRESSION: scroll to fragment doesn't work (except when Alex started from command line)
  • kwq/kparts/browserextension.h: Initialize reload to false. It was uninitialized, and when true was preventing anchor navigation from working.
9:48 AM Changeset in webkit [2354] by darin
  • 4 edits in trunk/WebKit
  • fixed 3062613 -- too many redirects at nytimes.com and apple

Our cookie policy was rejecting the cookies from nytimes.com -- the policy base
URL was still the news.com URL from before the redirect.

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): Update the cookie policy URL when a redirect changes the data source's URL.
9:17 AM Changeset in webkit [2353] by darin
  • 3 edits in trunk/WebKit
  • fixed 3077910 -- REGRESSION: download window open at startup time -> no scrollbars
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]): Check for WebDocumentView protocol before making the layout method call. Prevents exception when WebDynamicScrollBarsView is used with a document that is not a WebDocumentView.
1:05 AM Changeset in webkit [2352] by darin
  • 4 edits in trunk/WebCore
  • khtml/rendering/render_flow.cpp: (RenderFlow::lowestPosition): Don't recurse on the same child twice. (RenderFlow::rightmostPosition): Ditto.
1:03 AM Changeset in webkit [2351] by hyatt
  • 4 edits in trunk/WebCore

Fix bayarea.com. My implementation of offsetParent was
flawed. And to think I was blaming Gecko... ;)

  • khtml/rendering/render_object.cpp: (RenderObject::offsetParent):
Note: See TracTimeline for information about the timeline view.