Timeline

Oct 24, 2002:

9:54 PM Changeset in webkit [2462] by rjw

• 9 edits in trunk

Fixed many font substitution related bugs, at least including:
3006966, 3026675, 3071106, and more... (each of these bugs
has a list of related bugs).

Needs little more cleanup to correctly deal with non base characters.

• WebCoreSupport.subproj/WebTextRenderer.h:
• WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:]): (-[WebTextRenderer floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Against Darin's better judgement prevent extra layout when not in live resize. If
this introduces any regressions I owe darin a good bottle of wine.

• WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView updateScrollers]):

Updated to reflect new calling parameter semantic of floatCharacterWidths(),
which now returns the entire array of widths up the last character requested.

• khtml/rendering/render_text.cpp: (TextSlave::checkSelectionPoint):

4:35 PM Changeset in webkit [2461] by cblu

• 4 edits in trunk/WebKit

New Java plug-in works! Much faster to load and no spinny cursor! Unfortunately, it very unstable.

• Plugins.subproj/WebPluginController.m: cleaned-up the logging messages. (-[WebPluginController addPluginView:]): (-[WebPluginController didAddPluginView:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController destroyAllPlugins]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): make height and width an attribute.

4:12 PM Changeset in webkit [2460] by hyatt

• 4 edits in trunk/WebCore

<pre>, <xmp> and <plaintext> should all have a top margin of 1em.
Fixes a bunch of sites that use <pre>.

• khtml/css/html4.css:

3:34 PM Changeset in webkit [2459] by cblu

• 18 edits in trunk

WebCore:

Removed didAddSubview calls because that can easily be done in WebKit. Duh!

• khtml/rendering/render_frames.cpp: (RenderPart::setWidget):
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm:
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
• kwq/WebCoreBridge.h:

WebKit:

Some clean-up and bug fixes for new plug-in support.

• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): need a colon after windowWillClose (-[WebPluginController addPluginView:]): added logging (-[WebPluginController didAddPluginView:]): added logging (-[WebPluginController startAllPlugins]): added logging (-[WebPluginController stopAllPlugins]): added logging (-[WebPluginController destroyAllPlugins]): added logging
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage getMIMEInformation]): use correct dict key for getting MIME descriptions
• WebCoreSupport.subproj/WebBridge.m: no more didAddSubview
• WebView.subproj/WebFramePrivate.h: no more didAddSubview
• WebView.subproj/WebFramePrivate.m: no more didAddSubview
• WebView.subproj/WebHTMLView.m: (-[WebHTMLView addSubview:]): call didAddPluginView on WebPluginController

3:08 PM Changeset in webkit [2458] by sullivan

• 3 edits in trunk/WebKit

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge objectLoadedFromCache:response:size:]): added ASSERT(response != nil), leftover from debugging session on Tuesday, seems worth leaving in.

WebBrowser:

• fixed 3083271 -- Change Show/Hide menu items in View menu to use check marks

• English.lproj/MainMenu.nib: changed menu items to not include "Show" or "Hide" and to be indented by two spaces so they look like they belong to the dimmed "Show" item at the top of the menu. This is a yucky UI hack but is (A) probably better than the old huge list of items starting with "Show" or "Hide", and (B) what SJ wants.

• BrowserWindowController.m: (-[BrowserWindowController validateMenuItem:]): validate by updating check mark rather than changing title

1:28 PM Changeset in webkit [2457] by darin

• 5 edits
  29 adds
  26 deletes in trunk/WebCore

A step in the direction of making KWQ headers much nicer.
Move all empty headers out of kwq, and into ForwardingHeaders.

• ForwardingHeaders/kcmdlineargs.h: Added.
• ForwardingHeaders/kdatastream.h: Added.
• ForwardingHeaders/khtml_iface.h: Added.
• ForwardingHeaders/khtml_printsettings.h: Added.
• ForwardingHeaders/khtml_run.h: Added.
• ForwardingHeaders/kio/kprinter.h: Added.
• ForwardingHeaders/kio/kprotocolmanager.h:
• ForwardingHeaders/kio/ktrader.h: Added.
• ForwardingHeaders/kio/scheduler.h: Added.
• ForwardingHeaders/kmultipledrag.h: Added.
• ForwardingHeaders/kprinter.h: Added.
• ForwardingHeaders/kprotocolmanager.h: Added.
• ForwardingHeaders/ksslcertchain.h: Added.
• ForwardingHeaders/ksslinfodlg.h: Added.
• ForwardingHeaders/kstdaction.h: Added.
• ForwardingHeaders/ktempfile.h: Added.
• ForwardingHeaders/ktrader.h: Added.
• ForwardingHeaders/kurldrag.h: Added.
• ForwardingHeaders/kxmlguifactory.h: Added.
• ForwardingHeaders/qasyncimageio.h: Added.
• ForwardingHeaders/qbitmap.h: Added.
• ForwardingHeaders/qclipboard.h: Added.
• ForwardingHeaders/qfontdatabase.h: Added.
• ForwardingHeaders/qglobal.h: Added.
• ForwardingHeaders/qhbox.h: Added.
• ForwardingHeaders/qintcache.h: Added.
• ForwardingHeaders/qintdict.h: Added.
• ForwardingHeaders/qmetaobject.h: Added.
• ForwardingHeaders/qobjectlist.h: Added.
• ForwardingHeaders/scheduler.h: Added.

• kwq/dcop/kdatastream.h: Removed.
• kwq/kdecore/kcmdlineargs.h: Removed.
• kwq/kdecore/kmultipledrag.h: Removed.
• kwq/kdecore/ktempfile.h: Removed.
• kwq/kdecore/kurldrag.h: Removed.
• kwq/kdeui/kstdaction.h: Removed.
• kwq/kdeui/kxmlguifactory.h: Removed.
• kwq/khtml/khtml_iface.h: Removed.
• kwq/khtml/khtml_printsettings.h: Removed.
• kwq/khtml/khtml_run.h: Removed.
• kwq/kio/kprinter.h: Removed.
• kwq/kio/kprotocolmanager.h: Removed.
• kwq/kio/kssl/ksslcertchain.h: Removed.
• kwq/kio/kssl/ksslinfodlg.h: Removed.
• kwq/kio/ktrader.h: Removed.
• kwq/kio/scheduler.h: Removed.
• kwq/qt/qasyncimageio.h: Removed.
• kwq/qt/qbitmap.h: Removed.
• kwq/qt/qclipboard.h: Removed.
• kwq/qt/qfontdatabase.h: Removed.
• kwq/qt/qglobal.h: Removed.
• kwq/qt/qhbox.h: Removed.
• kwq/qt/qintcache.h: Removed.
• kwq/qt/qintdict.h: Removed.
• kwq/qt/qmetaobject.h: Removed.
• kwq/qt/qobjectlist.h: Removed.

• WebCore.pbproj/project.pbxproj: Removed all the above headers from the project.

12:47 PM Changeset in webkit [2456] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.

WebBrowser:

• WebBrowser.pbproj/project.pbxproj: Move the new pltsuite into the Test group.

12:23 PM Changeset in webkit [2455] by darin

• 4 edits
  1 delete in trunk/WebCore

• ForwardingHeaders/private/qucomextra_p.h: Emptied this out.
• kwq/qt/private/qucomextra_p.h: Removed.

12:15 PM Changeset in webkit [2454] by hyatt

• 4 edits in trunk/WebCore

Make sure that KHTML's initial layout happens after KHTML
fires the onload. This means that in the case where we
beat the timer, we will now fire the onload before both
the initial layout and the initial paint.

• khtml/html/html_documentimpl.cpp: (HTMLDocumentImpl::close):

11:35 AM Changeset in webkit [2453] by cblu

• 5 edits in trunk/WebKit

WebKit:

Changed some method names in WebPluginController.

• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController didAddPluginView:]): (-[WebPluginController startAllPlugins]): (-[WebPluginController stopAllPlugins]): (-[WebPluginController destroyAllPlugins]): (-[WebPluginController windowWillClose:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): (-[WebFrame _didAddSubview:]):

WebBrowser:

Fixed: 2961256 - vend an open URL service

• AppController.m: (-[AppController applicationDidFinishLaunching:]): register the services
• ServicesProvider.h: Added.
• ServicesProvider.m: Added. (-[ServicesProvider openURL:userData:error:]): the service
• WebBrowser.pbproj/project.pbxproj:

10:04 AM Changeset in webkit [2452]

• 3 copies in tags/Alexander-29

This commit was manufactured by cvs2svn to create tag 'Alexander-29'.

10:04 AM Changeset in webkit [2451] by sheridan

• 8 edits in trunk

Alex-29 version stamp

9:28 AM Changeset in webkit [2450] by rjw

• 4 edits in trunk/WebKit

Don't leak request.

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

9:18 AM Changeset in webkit [2449] by rjw

• 5 edits in trunk/WebKit

Always copy request, we can't count on it being immutable.
This was the cause of the ASSERT from last night's checkin.

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate handle:willSendRequest:]):

Only send serverRedirectedForDataSource: if URL changed.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):

8:38 AM Changeset in webkit [2448] by cblu

• 17 edits in trunk

WebCore:

Use "MIMEType" instead of "serviceType".

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart):
• kwq/WebCoreBridge.h:

WebKit:

• Use "MIMEType" instead of "serviceType".

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage load]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage filename]): (-[WebBasePluginPackage setPath:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:MIMEType:attributes:]):
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getMIMEInformation]): changed name. (-[WebNetscapePluginPackage initWithPath:]):
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:MIMEType:attributes:]): (-[WebNullPluginView dealloc]): (-[WebNullPluginView viewDidMoveToWindow]): send missing plug-ins notification here
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage getMIMEInformation]): new, gets MIME info from plist (-[WebPluginPackage initWithPath:]): (-[WebPluginPackage dealloc]): (-[WebPluginPackage viewFactory]): (-[WebPluginPackage load]): (-[WebPluginPackage unload]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:MIMEType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

2:02 AM Changeset in webkit [2447] by rjw

• 3 edits in trunk/WebKit

Flag error instead of ASSERTing as a result of fix to 3083013.
Not clear why this condition occurs, but better than ASSERTing
for Alex 29.

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setRequest:]):

12:35 AM Changeset in webkit [2446] by darin

• 5 edits in trunk/WebCore

• kwq/KWQKLocale.mm: (i18n): Make it obvious when non-localized strings from WebCore show up in the UI, but putting the string "not localized: " in front.

• kwq/KWQKMessageBox.mm: (KMessageBox::error): Fix use of NSRunAlertPanel so that we won't accidentally try to interpret % sequences in the messages we are displaying. (KMessageBox::warningYesNo): Ditto. (KMessageBox::questionYesNo): Ditto. (KMessageBox::sorry): Ditto. (KMessageBox::information): Ditto.

12:20 AM Changeset in webkit [2445] by darin

• 7 edits in trunk/WebKit

• fixed a crash I ran into in the new delegate code

• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate _releaseResources]): Retain self across this deallocation to avoid reentering and being deallocated midstream. This happens because the handle holds the only reference to us, and we may be releasing the last reference to it. (-[WebBaseResourceHandleDelegate dealloc]): Add call to [super dealloc].

• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage dealloc]): Add call to [super dealloc].

• WebView.subproj/WebMainResourceClient.m: Tweak.

Oct 23, 2002:

11:50 PM Changeset in webkit [2444] by darin

• 4 edits in trunk/WebKit

• fixed 3083013 -- REGRESSION: Cookie refused at ​http://directory/ even on reload

Restore a bit of the cruft.

• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]): We need to change the request on the data source when a redirect happens, because the data source goes on to ultimately communicate this to WebCore. Restored the code that did that, with some changes to fit into the new regime.

10:16 PM Changeset in webkit [2443] by rjw

• 30 edits in trunk/WebKit

Cleaned up months of accumulated cruft.
Added base class to the three WebResourceHandleDelegate implementors.
Removed superfluous handle references to controller callbacks.
More can still be done.
All in the name of fixing 3076050.

• Misc.subproj/WebKitErrors.h:
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]):
• Plugins.subproj/WebNetscapePluginRepresentation.m: (-[WebNetscapePluginRepresentation receivedData:withDataSource:]): (-[WebNetscapePluginRepresentation receivedError:withDataSource:]): (-[WebNetscapePluginRepresentation finishedLoadingWithDataSource:]):
• Plugins.subproj/WebNetscapePluginStream.h:
• Plugins.subproj/WebNetscapePluginStream.m: (-[WebNetscapePluginStream initWithRequest:pluginPointer:notifyData:]): (-[WebNetscapePluginStream dealloc]): (-[WebNetscapePluginStream start]): (-[WebNetscapePluginStream stop]): (-[WebNetscapePluginStream handle:willSendRequest:]): (-[WebNetscapePluginStream handle:didReceiveResponse:]): (-[WebNetscapePluginStream handle:didReceiveData:]): (-[WebNetscapePluginStream handleDidFinishLoading:]): (-[WebNetscapePluginStream handle:didFailLoadingWithError:]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge reportBadURL:]):
• WebCoreSupport.subproj/WebSubresourceClient.h:
• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient initWithLoader:dataSource:]): (-[WebSubresourceClient dealloc]): (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): (-[WebSubresourceClient receivedError:]): (-[WebSubresourceClient handle:willSendRequest:]): (-[WebSubresourceClient handle:didReceiveResponse:]): (-[WebSubresourceClient handle:didReceiveData:]): (-[WebSubresourceClient handleDidFinishLoading:]): (-[WebSubresourceClient handle:didFailLoadingWithError:]): (-[WebSubresourceClient cancel]):
• WebView.subproj/WebBaseResourceHandleDelegate.h:
• WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate init]): (-[WebBaseResourceHandleDelegate _releaseResources]): (-[WebBaseResourceHandleDelegate dealloc]): (-[WebBaseResourceHandleDelegate setDataSource:]): (-[WebBaseResourceHandleDelegate dataSource]): (-[WebBaseResourceHandleDelegate resourceLoadDelegate]): (-[WebBaseResourceHandleDelegate downloadDelegate]): (-[WebBaseResourceHandleDelegate setIsDownload:]): (-[WebBaseResourceHandleDelegate isDownload]): (-[WebBaseResourceHandleDelegate handle:willSendRequest:]): (-[WebBaseResourceHandleDelegate handle:didReceiveResponse:]): (-[WebBaseResourceHandleDelegate handle:didReceiveData:]): (-[WebBaseResourceHandleDelegate handleDidFinishLoading:]): (-[WebBaseResourceHandleDelegate handle:didFailLoadingWithError:]): (-[WebBaseResourceHandleDelegate cancel]): (-[WebBaseResourceHandleDelegate handle]):
• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _mainReceivedBytesSoFar:fromDataSource:complete:]): (-[WebController _receivedError:fromDataSource:]): (-[WebController _mainReceivedError:fromDataSource:]):
• WebView.subproj/WebDataSource.h:
• WebView.subproj/WebDataSource.m:
• WebView.subproj/WebDataSourcePrivate.h:
• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _startLoading]): (-[WebDataSource _stopLoading]): (-[WebDataSource _clearErrors]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _isLoadComplete]):
• WebView.subproj/WebMainResourceClient.h:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient initWithDataSource:]): (-[WebMainResourceClient dealloc]): (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient cancel]): (-[WebMainResourceClient handle:willSendRequest:]): (-[WebMainResourceClient _notifyDelegatesOfInterruptionByPolicyChange]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handle:didReceiveData:]): (-[WebMainResourceClient handleDidFinishLoading:]): (-[WebMainResourceClient handle:didFailLoadingWithError:]):
• WebView.subproj/WebResourceLoadDelegate.h:

6:30 PM Changeset in webkit [2442] by cblu

• 13 edits in trunk

WebCore:

WebKit now gets called when render_frame subviews are added.

• khtml/rendering/render_frames.cpp: (RenderPart::setWidget): call didAddWidget on the part
• kwq/KWQKHTMLPartImpl.h:
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::didAddWidget): added, calls didAddSubview on the bridge

WebKit:

Support for new plug-in API. This is about as much as I can do without the new java plug-in and java root.

• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): observe window close changes (-[WebPluginController dealloc]): remove observer, assert if we're still tracking plug-ins (-[WebPluginController didAddSubview:]): start the plug-in (-[WebPluginController stopAllPlugins]): stop and destroy all plug-ins. (-[WebPluginController windowWillClose:]): call stopAllPlugins if the window in question is closing
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): call stopAllPlugins on WebPluginController

5:44 PM Changeset in webkit [2441] by cblu

• 19 edits in trunk

WebCore:

Change for plug-in package API changes.

• kwq/KWQKConfigBase.mm: (KConfig::readEntry):
• kwq/WebCoreBridge.h: added didAddSubview, called when a render_frame's view is added as a subview of the main view.
• kwq/WebCoreViewFactory.h: added didAddSubview

WebKit:

Changed the plug-in package API to return key enumerators instead dictionaries.

• Plugins.subproj/WebBasePluginPackage.h:
• Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage initWithPath:]): (-[WebBasePluginPackage load]): (-[WebBasePluginPackage unload]): (-[WebBasePluginPackage dealloc]): (-[WebBasePluginPackage extensionEnumerator]): (-[WebBasePluginPackage MIMETypeEnumerator]): (-[WebBasePluginPackage descriptionForMIMEType:]): (-[WebBasePluginPackage MIMETypeForExtension:]): (-[WebBasePluginPackage extensionsForMIMEType:]): (-[WebBasePluginPackage setName:]): (-[WebBasePluginPackage setPath:]): (-[WebBasePluginPackage setFilename:]): (-[WebBasePluginPackage setPluginDescription:]): (-[WebBasePluginPackage setMIMEToDescriptionDictionary:]): (-[WebBasePluginPackage setMIMEToExtensionsDictionary:]):
• Plugins.subproj/WebNetscapePluginPackage.h:
• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage getPluginInfo]): (-[WebNetscapePluginPackage pathByResolvingSymlinksAndAliasesInPath:]): (-[WebNetscapePluginPackage initWithPath:]): (-[WebNetscapePluginPackage executableType]):
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController didAddSubview:]):
• Plugins.subproj/WebPluginDatabase.h:
• Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase pluginForKey:withEnumeratorSelector:]): (-[WebPluginDatabase pluginForMIMEType:]): (-[WebPluginDatabase pluginForExtension:]): (-[WebPluginDatabase MIMETypes]): (-[WebPluginDatabase init]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]): (-[WebBridge didAddSubview:]): new
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _didAddSubview:]): new

4:17 PM Changeset in webkit [2440] by darin

• 16 edits in trunk

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt:

WebCore:

• finished up the job of moving the file button to WebKit

I did this mainly for localization reasons.

• kwq/KWQFileButton.h: Remove filename(), add filenameChanged(), make KWQFileButton be a QWidget subclass, not a QPushButton one. Remove clicked() and paint() virtual functions, _filename, _icon, and _label data members.
• kwq/KWQFileButton.mm: (KWQFileButton::KWQFileButton): Just make a WebCoreFileButton. (KWQFileButton::~KWQFileButton): Less to do here now. (KWQFileButton::setFilename): Call the button to do the work. (KWQFileButton::sizeHint): Ditto. (KWQFileButton::frameGeometry): Ditto. (KWQFileButton::setFrameGeometry): Ditto. (KWQFileButton::baselinePosition): Ditto. (KWQFileButton::filenameChanged): Added. Sends message. (-[KWQFileButtonAdapter initWithKWQFileButton:]): Observe the "filename changed notification". (-[KWQFileButtonAdapter dealloc]): Stop observing. (-[KWQFileButtonAdapter filenameChanged:]): Send a signal when the notification comes in, so KHTML finds out.

• kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Remove handling for RenderFileButton slotReturnPressed. (KWQSlot::call): Ditto.

• kwq/WebCoreViewFactory.h: Remove bestSize. Add setVisualFrame, visualFrame, and bestVisualFrameSize.

• kwq/KWQInputDialog.mm: Tweaked includes. Long-term we want to use "", not <>.
• kwq/KWQKConfigBase.mm: Ditto.
• kwq/KWQKHTMLPartImpl.mm: Ditto.

WebKit:

• finished up the job of moving the file button here from WebCore.

I did this mainly for localization reasons.

• WebCoreSupport.subproj/WebFileButton.m: (-[WebFileButton initWithFrame:]): Set up button control size, font, bezel style, target, and action. Also add it as a subview. (-[WebFileButton drawRect:]): Center icon in the "visual frame" part of the view, not the entire bounds. (-[WebFileButton setFilename:]): Don't show any icon when the filename is empty. (-[WebFileButton bestVisualFrameSize]): Implemented this. (-[WebFileButton visualFrame]): Ditto. (-[WebFileButton setVisualFrame:]): Ditto. (-[WebFileButton baseline]): Ditto. (-[WebFileButton beginSheet]): Added. Shared between button presses and other clicks. (-[WebFileButton chooseButtonPressed:]): Call beginSheet. (-[WebFileButton mouseDown:]): Ditto. (-[WebFileButton openPanelDidEnd:returnCode:contextInfo:]): Send the notification, WebCoreFileButtonFilenameChanged, when the filename is changed.

• WebView.subproj/WebController.m: (-[WebController policyDelegate]): Add a FIXME about the leak I found here.

1:49 PM Changeset in webkit [2439] by cblu

• 20 edits in trunk

WebCore:

Call the arguments for plug-ins "attributes" everywhere.

• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart):
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::showApplet):
• kwq/WebCoreBridge.h:

WebKit:

Call the arguments for plug-ins "attributes" everywhere.

• Plugins.subproj/WebBaseNetscapePluginView.h:
• Plugins.subproj/WebBaseNetscapePluginView.m: (-[WebBaseNetscapePluginView setAttributes:]):
• Plugins.subproj/WebNetscapePluginEmbeddedView.h:
• Plugins.subproj/WebNetscapePluginEmbeddedView.m: (-[WebNetscapePluginEmbeddedView initWithFrame:plugin:URL:baseURL:mime:attributes:]):
• Plugins.subproj/WebNullPluginView.h:
• Plugins.subproj/WebNullPluginView.m: (-[WebNullPluginView initWithFrame:mimeType:attributes:]): (-[WebNullPluginView drawRect:]):
• Plugins.subproj/WebPluginController.h:
• Plugins.subproj/WebPluginController.m: (-[WebPluginController initWithWebFrame:]): (-[WebPluginController dealloc]): (-[WebPluginController addPluginView:]):
• Plugins.subproj/WebPluginPackage.h:
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage viewFactory]):
• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributes:baseURL:]): (-[WebBridge viewForPluginWithURL:attributes:baseURL:serviceType:]): (-[WebBridge viewForJavaAppletWithFrame:attributes:baseURL:]):

11:52 AM Changeset in webkit [2438] by cblu

• 17 edits in trunk

WebCore:

For the new plug-in API, we need to pass a WebPluginContainer to the plug-in view upon creation. The is owned by the WebFrame. To make this all work, I had to move the WebCore plug-in and java view constructors to WebBridge from WebViewFactory since WebBridge has the frame.

• khtml/khtml_part.cpp: (KHTMLPart::createJavaContext): New APPLE_CHANGES around the java context constructor so we pass the part.
• kwq/KWQKHTMLPartImpl.mm: (KWQKHTMLPartImpl::createPart): call the bridge to create the view
• kwq/KWQKJavaAppletWidget.mm: (KJavaAppletWidget::KJavaAppletWidget): save the context (KJavaAppletWidget::showApplet): call the bridge to create the view
• kwq/WebCoreBridge.h:
• kwq/WebCoreViewFactory.h:
• kwq/khtml/java/kjavaappletcontext.h: made constructor take the part
• kwq/khtml/java/kjavaappletwidget.h: ivar for the context

WebKit:

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge requestedURL]): (-[WebBridge viewForPluginWithURL:serviceType:arguments:baseURL:]): (-[WebBridge viewForJavaAppletWithFrame:baseURL:parameters:]):
• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): (-[WebViewFactory pluginsInfo]):

10:49 AM Changeset in webkit [2437] by darin

• 6 edits in trunk/WebKit

• fix bug where plugins crashed closing a stream that was never opened

• Plugins.subproj/WebBaseNetscapePluginStream.h: Change type for parameter of receivedError: to NPReason. It's not NPError.
• Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream dealloc]): Assert that stream is destroyed by checking stream.ndata. (-[WebBaseNetscapePluginStream setResponse:]): Set stream.ndata to nil if the stream is not successfully created by NPP_NewStream. (-[WebBaseNetscapePluginStream destroyStreamWithReason:]): Added. Destroys the stream, but only if it's present. Also set stream.ndata to nil. This was the bug fix. (-[WebBaseNetscapePluginStream receivedError:]): Call destroyStreamWithReason:. (-[WebBaseNetscapePluginStream finishedLoadingWithData:]): Call destroyStreamWithReason:.

• English.lproj/Localizable.strings: Update.
• English.lproj/StringsNotToBeLocalized.txt: Update.

10:38 AM Changeset in webkit [2436] by cblu

• 3 edits in trunk/WebKit

Forgot to add WebPluginController back to the project after I had a project conflict.

• WebKit.pbproj/project.pbxproj:

10:27 AM Changeset in webkit [2435] by cblu

• 4 edits
  2 adds in trunk/WebKit

Added WebPluginController which controls and reacts to plug-in requests. Its owned by the WebFrame.

• Plugins.subproj/WebPluginController.h: Added.
• Plugins.subproj/WebPluginController.m: Added. (-[WebPluginController initWithWebFrame:]): (-[WebPluginController showURL:inFrame:]): (-[WebPluginController showStatus:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): (-[WebFrame pluginController]):

9:57 AM Changeset in webkit [2434] by darin

• 19 edits
  2 adds in trunk

WebCore:

• fixed 3080478 -- reproducible incomplete load on apple.com

• kwq/KWQLoaderImpl.mm: (-[WebCoreResourceLoader receivedResponse:]): Add an assert. (-[WebCoreResourceLoader cancel]): Don't finish here, just disconnect the handle from the job, and disconnect the job from the WebCoreResourceLoader, and let the KHTML code finish the cleanup later. This is the bug fix. (KWQCheckCacheObjectStatus): Add an assertion.

• kwq/KWQKjobclasses.mm: (TransferJob::~TransferJob): Don't call kill(); do the work here instead. (TransferJob::kill): Self-destruct. Need this to avoid a storage leak.

• khtml/misc/loader.cpp: (CachedObject::~CachedObject): Put some Apple-specific code inside APPLE_CHANGES. (CachedObject::setResponse): Streamlined this function. (Loader::receivedResponse): Added assertions.

• kwq/qt/qxml.h: Add more stubs.
• kwq/KWQxml.mm: Ditto.

• kwq/WebCoreViewFactory.h: Add [WebCoreViewFactory fileButton], the WebCoreFileButton protocol, and WebCoreFileButtonFilenameChanged.
• kwq/WebCoreViewFactory.m: Add WebCoreFileButtonFilenameChanged.
• WebCore.exp: Export _WebCoreFileButtonFilenameChanged.

WebKit:

Add WebFileButton, to be used by WebCore soon. It's about 1/2
done right now. Compiles but not used yet.

• WebCoreSupport.subproj/WebViewFactory.m: (-[WebViewFactory fileButton]): Added.

• WebCoreSupport.subproj/WebFileButton.h: Added.
• WebCoreSupport.subproj/WebFileButton.m: Added.
• WebKit.pbproj/project.pbxproj: Added WebFileButton files.

• WebCoreSupport.subproj/WebSubresourceClient.m: (-[WebSubresourceClient handle:didReceiveResponse:]): Add an assertion.

5:40 AM Changeset in webkit [2433] by mjs

• 5 edits in trunk/WebKit

• fixed 2876448 - The authentication panel should give a note when the user tried to log in and failed

Also, made the message different (and more helpful) when the
authentication is for a proxy server.

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use different messages depending on proxy and previous failure count.

Updated localized strings:

• English.lproj/Localizable.strings:
• English.lproj/StringsNotToBeLocalized.txt:

2:29 AM Changeset in webkit [2432] by mjs

• 7 edits in trunk/WebKit

• fixed 2876446 - The label in the authentication panel needs to adjust its height depending on content

Also improved [NSControl sizeToFitAndAdjustWindowHeight] method.

• Panels.subproj/English.lproj/WebAuthenticationPanel.nib: Adjusted springs.
• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Use sizeToFitAndAdjustWindowHeight on main label.

• Misc.subproj/WebNSControlExtras.m: (-[NSControl sizeToFitAndAdjustWindowHeight]): Improved the logic so the best height is picked while leaving the width alone. Before, the label would always come out to be a very wide single line.