Timeline

Oct 30, 2002:

9:26 PM Changeset in webkit [2518] by mjs

• 1 edit in trunk/WebCore/khtml/rendering/render_form.cpp

Revert accidentally committed change.

9:20 PM Changeset in webkit [2517] by mjs

• 5 edits in trunk/WebCore

• fixed 3049853 - Javascript: setInterval incorrectly acts as single shot

• kwq/KWQObject.mm: (QObject::startTimer): Set a recurring timer instead of single-shot, to match QObject semantics.

6:42 PM Changeset in webkit [2516] by rjw

• 1 edit in trunk/WebKit/Misc.subproj/WebUnicode.m

Fixed stupid compile problem.

6:23 PM Changeset in webkit [2515] by rjw

• 12 edits
  5 adds in trunk

More work on bidi and contextual forms.
Table lookup code for unicode characters attributes.

• Misc.subproj/WebUnicode.h: Added.
• Misc.subproj/WebUnicode.m: Added. (_unicodeDigitValue): (_unicodeCategory): (_unicodeDirection): (_unicodeJoining): (_unicodeDecompositionTag): (_unicodeMirrored): (_unicodeMirroredChar): (_unicodeCombiningClass): (_unicodeLower): (_unicodeUpper): (WebKitInitializeUnicode):
• Misc.subproj/WebUnicodeTables.m: Added.
• WebKit.pbproj/project.pbxproj:

Additional logging parameter.

• Misc.subproj/WebKitLogging.h:
• Misc.subproj/WebKitLogging.m:

More work on bidi and contextual forms.
Table lookup code is up in WebKit. Function
pointers are used to isolate WebCore from private
implementation in WebKit. Needs to be fast, so
the usual ObjC abstraction won't work.

• WebCore.exp:
• WebCore.pbproj/project.pbxproj:
• kwq/KWQChar.mm: (QChar::direction):
• kwq/KWQString.h:
• kwq/WebCoreUnicode.cpp: Added.
• kwq/WebCoreUnicode.h: Added.

6:15 PM Changeset in webkit [2514] by mjs

• 7 edits in trunk/WebKit

WebKit:

Pass WebResourceRequest rather than just NSURL to URL policy
delegate method.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (+[WebDefaultPolicyDelegate defaultURLPolicyForRequest:]): (-[WebDefaultPolicyDelegate URLPolicyForRequest:inFrame:]):
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]):

WebBrowser:

Adjust for WebKit API change.

• BrowserDocument.m: (-[BrowserDocument _goToURL:referrer:withFallbackURLs:]):
• BrowserWebController.m: (-[BrowserWebController URLPolicyForRequest:inFrame:]):

2:50 PM Changeset in webkit [2513] by darin

• 4 edits in trunk/WebCore

• fixed crash when you open an empty window and just hit tab, tab, tab

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::nextKeyViewInFrame): Check for nil.

2:19 PM Changeset in webkit [2512] by darin

• 3 edits in trunk/WebKit

WebFoundation:

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebBrowser:

• English.lproj/Localizable.strings: Regenerated this file.

12:15 PM Changeset in webkit [2511] by darin

• 4 edits in trunk/JavaScriptCore

• fixed 3073230 -- Alex is doing file I/O when executing JavaScript by asking for localtime

I fixed this by using Core Foundation time functions instead.

• kjs/date_object.cpp: (tmUsingCF): Function that uses Core Foundation to get the time and then puts it into a tm struct. (gmtimeUsingCF): Function used instead of gmtime (used a macro to make the substitution). (localtimeUsingCF): Function used instead of localtime (used a macro to make the substitution).

11:34 AM Changeset in webkit [2510] by cblu

• 3 edits in trunk/WebKit

Fixed: 3088122 - Assertion failure/crash closing window with QuickTime streaming in

• WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setMainDocumentError:]): call receivedError on the representation.

11:17 AM Changeset in webkit [2509] by darin

• 4 edits in trunk/WebKit

• fixed memory leaks in plugin package creation code

• Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage initWithPath:]): Rearrange this code, and make sure that it does a [self release] if it's going to return nil instead of self. (-[WebNetscapePluginPackage unload]): Set bundle to 0 when we release it. (-[WebNetscapePluginPackage dealloc]): Release the bundle if it's not 0.

• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): Rearrange this code, and make sure that it does a [self release] if it's going to return nil instead of self.

9:51 AM Changeset in webkit [2508] by darin

• 7 edits
  2 adds in trunk/WebCore

• fixed 3083982 -- Logging into AOL gives null view, crash

I fixed the crash part. Not the "gives null view" part.
The key was to disentangle the references and lifetimes of the transfer job class,
and the resource loader object that KWQ uses to connect it with WebKit.

• kwq/KWQKJobClasses.h: Change the job to keep a loader reference, not a handle reference. The job needs to inform the loader when it's being deallocated.
• kwq/KWQKJobClasses.mm: Use jobWillBeDeallocated instead of cancel when the job is deallocated.

• kwq/KWQLoader.mm: (KWQServeRequest): Use KWQResourceLoader, now with a home in a separate file.

• kwq/KWQResourceLoader.h: Added.
• kwq/KWQResourceLoader.mm: Added.
• WebCore.pbproj/project.pbxproj: Added KWQResourceLoader files.

8:19 AM Changeset in webkit [2507] by darin

• 15 edits in trunk

WebCore:

• fixed 3086564 -- REGRESSION: meta-refresh to the same page doesn't refresh

The key is to get args.reload passed through to the bridge.

• kwq/WebCoreBridge.h: Add reload parameter to loadURL:.

• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURL): Pass NO for reload. (KWQKHTMLPart::openURLRequest): Pass args.reload for reload. (KWQKHTMLPart::urlSelected): Pass args.reload for reload. (KWQKHTMLPart::submitForm): Pass args.reload for reload.

• fixed a memory problem with the use of NSBrowser in KWQListBox
• fixed 2863040 -- multiple default items in select list not selected

Switched to use NSTableView instead of NSBrowser. This should also create
a measurable speedup due to other changes to this class.

• kwq/KWQListBox.h: Remove firstItem(), the insertItem() that takes a QListBoxItem parameter, and deleteItems(). Add _items, _width, and _widthGood. Removed _head. Removed the QListBoxItem and QListBoxText classes.
• kwq/KWQListBox.mm: (QListBox::QListBox): Create a KWQListBoxScrollView and put an NSTableView inside it. Also create an NSMutableArray to hold the items. (QListBox::~QListBox): Disconnect the table view from the delegate before releasing it. Also release the items array. (QListBox::count): Return the array count. (QListBox::clear): Do a reloadData here instead of loadColumnZero. (QListBox::setSelectionMode): Update for table view. (QListBox::insertItem): Update for table view. (QListBox::insertGroupLabel): Just calls insertItem for now. (QListBox::endBatchInsert): Update for table view. (QListBox::setSelected): Update for table view, including support for multiple selection. (QListBox::isSelected): Update for table view. (QListBox::sizeForNumberOfLines): Use the table view cell for width, and cache it so we don't have to measure all the strings over and over again. (-[KWQListBoxScrollView setFrameSize:]): Resize the table view column whenever the entire scroll view is resized. (-[KWQListBoxTableViewDelegate initWithListBox:]): Store box pointer and pointer to items array. (-[KWQListBoxTableViewDelegate numberOfRowsInTableView:]): Return count. (-[KWQListBoxTableViewDelegate tableView:objectValueForTableColumn:row:]): Get the data from the items array. (-[KWQListBoxTableViewDelegate tableViewSelectionDidChange:]): Call both the selection-changed signal and the clicked signal.

• khtml/rendering/render_form.cpp: (RenderSelect::updateFromElement): Get rid of the one place here that gets at a list box item by calling a KWQ function insertGroupLabel instead of making a QListBoxText. Also call beginBatchInsert() before clear() for a slight additional speed boost.

• fixed 3067572 -- javascript: URLs typed into page address field or bookmarks don't work in empty window

We needed a document for DOM, so we make a dummy one. This works for an empty
window, and also for a window with non-HTML content.

• kwq/KWQKHTMLPart.h: Added createDummyDocument().
• kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::createDummyDocument): Create an empty DOM document if there isn't one already.

• kwq/WebCoreBridge.mm: (-[WebCoreBridge stringByEvaluatingJavaScriptFromString:]): Call the new createDummyDocument() instead of checking and doing nothing if there is no document present when this is called.

• other stuff

• kwq/WebCoreBridge.mm: (-[WebCoreBridge DOMDocument]): Removed a stray printf.

• kwq/KWQTextArea.mm: Tweaked code a little.

WebKit:

• fixed 3086564 -- REGRESSION: meta-refresh to the same page doesn't refresh

The key is to respect the new reload: parameter from the bridge.

• WebCoreSupport.subproj/WebBridge.m: (-[WebBridge loadURL:reload:]): Don't ever treat a reload as a redirect. Set the cache policy to WebRequestCachePolicyLoadFromOrigin if it's a reload.

• fixed 3087214 -- REGRESSION: <WebKit/WebKit.h> contains #import of non-existent header

• Misc.subproj/WebKit.h: Removed import of WebControllerSets.h, which is private.

1:43 AM Changeset in webkit [2506] by mjs

• 10 edits in trunk/WebKit

WebKit:

Another step towards the policy API change - add request argument
to file URL policy and remove isDirectory argument.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate fileURLPolicyForMIMEType:andRequest:inFrame:]):
• WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]):
• WebView.subproj/WebFramePrivate.h:
• WebView.subproj/WebFramePrivate.m: (-[WebFrame _shouldShowRequest:]):
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:willSendRequest:]):

WebBrowser:

Adjust for API change.

• BrowserWebController.m: (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]):

Oct 29, 2002:

11:58 PM Changeset in webkit [2505] by mjs

• 7 edits in trunk/WebKit

WebKit:

First step towards policy API change. Pass request instead of URL
to content policy delegate method.

• WebView.subproj/WebControllerPolicyDelegate.h:
• WebView.subproj/WebDefaultPolicyDelegate.m:
• WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

First step towards policy API change. Pass request instead of URL
to content policy delegate method.

• BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):

11:55 PM Changeset in webkit [2504] by mjs

• 6 edits in trunk/WebKit

• fixed 3087548 - REGRESSION: two windows open for netflix confirmation

• WebView.subproj/WebControllerPrivate.h:
• WebView.subproj/WebControllerPrivate.m: (-[WebController _findFrameInThisWindowNamed:]): Added this function back, and added check for top-level frame name. (-[WebController _findFrameNamed:]): Use _findFrameInThisWindowNamed: to make sure top-level frame names get checked.

8:50 PM Changeset in webkit [2503] by cblu

• 3 edits
  6 adds
  2 deletes in trunk/WebKit

Created Downloads.subproj to hold the to-be-implemented download decoders.

• Downloads.subproj/WebDownloadDecoder.h: Added.
• Downloads.subproj/WebDownloadHandler.h: Added.
• Downloads.subproj/WebDownloadHandler.m: Added. (-[WebDownloadHandler initWithDataSource:]): (-[WebDownloadHandler dealloc]): (-[WebDownloadHandler errorWithCode:]): (-[WebDownloadHandler receivedResponse:]): (-[WebDownloadHandler receivedData:]): (-[WebDownloadHandler finishedLoading]): (-[WebDownloadHandler cancel]):
• Misc.subproj/WebDownloadHandler.h: Removed.
• Misc.subproj/WebDownloadHandler.m: Removed.
• WebKit.pbproj/project.pbxproj: