Timeline

Nov 3, 2002:

11:49 PM Changeset in webkit [2547] by darin

• 4 edits in trunk/WebKit

WebKit:

• Plugins.subproj/WebPluginError.h:
• Plugins.subproj/WebPluginError.m: Not MyCompanyName, but rather Apple Computer.

WebBrowser:

• DownloadProgressEntry.m:
• DownloadRow.h:
• DownloadRow.m:
• DownloadViewController.h:
• DownloadViewController.m:
• DownloadWindowController.h:
• DownloadWindowController.m:
• ServicesProvider.h:
• ServicesProvider.m: Not MyCompanyName, but rather Apple Computer.

11:05 PM Changeset in webkit [2546] by darin

• 5 edits in trunk/WebKit

WebFoundation:

• AuthenticationManager.subproj/WebKeychainCredential.m: (-[WebKeychainCredentialPrivate dealloc]): Check for NULL before calling CFRelease, since our dealloc function can be called even before our init function runs if a base class decides to do the "[self release]; return nil;" thing in its init function.

• CookieManager.subproj/WebCookieStorageServer.m: (-[WebCookieStorageServerPrivate dealloc]): Remove call to invalidate, since, as Trey reminded us, it's pointless to invalidate a timer that retains us in our dealloc function.

WebKit:

• Plugins.subproj/WebPlugin.h: Fix comment.

• Plugins.subproj/WebPluginError.m: (-[WebPluginErrorPrivate dealloc]): Fix leak by calling [super dealloc].

• WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Remove the timer invalidate since, as Trey pointed out, it's pointless to invalidate a timer in dealloc if it's retaining this object while valid.

WebBrowser:

• DiskCopyPuppetStrings.h: Remove bogus Log section. Fix header guard that was broken.

• DownloadRow.m: (-[DownloadRow dealloc]): Fix leak by calling [super dealloc].
• DownloadViewController.m: (-[DownloadViewController dealloc]): Ditto.

1:18 PM Changeset in webkit [2545] by cblu

• 4 edits
  4 adds in trunk/WebKit

WebKit:

• Added MacBinary decoding code. Not yet used.

• Downloads.subproj/WebMacBinaryDecoder.h: Added.
• Downloads.subproj/WebMacBinaryDecoder.m: Added. (+[WebMacBinaryDecoder canDecodeHeaderData:]): (-[WebMacBinaryDecoder init]): (-[WebMacBinaryDecoder dealloc]): (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): (-[WebMacBinaryDecoder finishDecoding]): (-[WebMacBinaryDecoder fileAttributes]):
• Downloads.subproj/crc16.h: Added.
• Downloads.subproj/crc16.m: Added. (CRC16):
• Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage isLoaded]):
• WebKit.pbproj/project.pbxproj:

WebBrowser:

• Added DiskCopy interaction code. Not yet used.
• Added Chuck's table view hacks to get NSViews in a TableView. Not yet used.

• DiskCopyPuppetStrings.h: Added.
• DownloadMonitor.h:
• DownloadMonitor.m: (-[DownloadMonitor init]): (-[DownloadMonitor removeEntry:]): (-[DownloadMonitor _removeExpiredEntries]): (-[DownloadMonitor resource:didFinishLoadingFromDataSource:]): (-[DownloadMonitor resource:didFailLoadingWithError:fromDataSource:]):
• ViewCell.h: Added.
• ViewCell.m: Added. (RectCenteredInRect): (+[ViewCell needsToRemainInViewHierarchy]): (-[ViewCell init]): (-[ViewCell copyWithZone:]): (-[ViewCell dealloc]): (-[ViewCell instantiateView]): (-[ViewCell setObjectValue:]): (-[ViewCell objectValue]): (-[ViewCell removeViewFromSuperview]): (-[ViewCell setView:]): (-[ViewCell view]): (-[ViewCell setViewFrame:inCellFrame:inView:]): (-[ViewCell drawWithFrame:inView:]): (-[ViewCell trackMouse:inRect:ofView:]): (-[ViewCell editWithFrame:inView:editor:delegate:event:]):
• ViewCellTableView.h: Added.
• ViewCellTableView.m: Added. (+[ViewCellTableColumn newViewCell]): (-[ViewCellTableColumn initWithIdentifier:]): (-[ViewCellTableColumn initWithCoder:]): (-[ViewCellTableColumn dealloc]): (-[ViewCellTableColumn cells]): (-[ViewCellTableColumn dataCellForRow:]): (-[ViewCellTableColumn removeRows:]): (-[ViewCellTableColumn appendRows:]): (-[ViewCellTableColumn noteNumberOfTableRowsChanged:]): (-[ViewCellTableColumn willRemoveFromTableView:]): (-[NSTableColumn noteNumberOfTableRowsChanged:]): (-[NSTableColumn willRemoveFromTableView:]): (-[ViewCellTableView replaceHeaderView]): (-[ViewCellTableView workaroundReorderResizeProblem]): (-[ViewCellTableView didReorderOrResizeNotification:]): (-[ViewCellTableView initWithFrame:]): (-[ViewCellTableView initWithCoder:]): (-[ViewCellTableView dealloc]): (-[ViewCellTableView noteNumberOfRowsChanged]): (-[ViewCellTableView reloadData]): (-[ViewCellTableView removeTableColumn:]): (-[ViewCellTableView acceptsFirstResponder]): (-[ViewCellTableView needsPanelToBecomeKey]):
• WebBrowser.pbproj/project.pbxproj:

12:50 PM Changeset in webkit [2544] by darin

• 3 edits in trunk/WebKit

Tools:

• Scripts/extract-localizable-strings: Add printf to the list of functions to ignore when finding localizable strings.

WebKit:

• English.lproj/StringsNotToBeLocalized.txt: Update for recent changes both to the code here and to the extract script.

WebBrowser:

• English.lproj/StringsNotToBeLocalized.txt: Remove some now-unneeded exceptions for strings that don't appear in our code any more.

• English.lproj/Localizable.strings: Re-generated. It appears that John removed two more localizable strings after he generated it. (I had to check because last time I did this I clobbered John's change, and I didn't want to do that again.)

12:41 PM Changeset in webkit [2543] by darin

• 9 edits in trunk

WebCore:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• kwq/WebCoreResourceLoader.h: Add reportError, distinct from cancel and finish.
• kwq/KWQResourceLoader.mm: (-[KWQResourceLoader reportError]): Set the error boolean on the job and then call through to [finish].

WebKit:

• fixed 3091300 -- "prelighting" on local page is still slow, despite recent bug fix

Turns out all updating would be slow if any resources on the page failed to load.

• WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:referrer:forDataSource:]): Call the new reportError instead of cancel. (-[WebSubresourceClient handle:didFailLoadingWithError:]): Ditto.

12:20 PM Changeset in webkit [2542] by darin

• 4 edits in trunk/WebCore

• fixed 3091275 -- can't type into Answer field in RealOne Player order form

• khtml/rendering/render_form.cpp: (RenderLineEdit::updateFromElement): Treat 0 as max (1024) as other browsers do. (RenderFileButton::updateFromElement): Ditto, although this is in !APPLE_CHANGES code that we don't use in WebCore.

Nov 2, 2002:

2:00 PM Changeset in webkit [2541] by darin

• 3 edits in trunk/WebKit

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Do the previous fix one better by using _web_hostWithPort.

1:55 PM Changeset in webkit [2540] by darin

• 3 edits in trunk/WebKit

• fixed bug where the address of an NSNumber object would be used for the port number

• Panels.subproj/WebAuthenticationPanel.m: (-[WebAuthenticationPanel setUpForRequest:]): Call intValue on the object returned from [NSURL port].