⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 7, 2002:

11:53 PM Changeset in webkit [2598] by darin
  • 4 edits in trunk/WebKit
  • History.subproj/WebHistoryItem.h: Replace _URL with _URLString.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _retainIconInDatabase:]): Get the URL with [self URL]. (-[WebHistoryItem initWithURL:target:parent:title:]): Set up _URLString. (-[WebHistoryItem dealloc]): Release _URLString. (-[WebHistoryItem URL]): Make a URL from _URLString. (-[WebHistoryItem icon]): Use [self URL] instead of _URL. (-[WebHistoryItem setURL:]): Store a URL string. (-[WebHistoryItem hash]): Use the URL string's hash. (-[WebHistoryItem isEqual:]): Compare the URL strings. (-[WebHistoryItem description]): Use _URLString. (-[WebHistoryItem dictionaryRepresentation]): Use _URLString. (-[WebHistoryItem initFromDictionaryRepresentation:]): Call through to the other init functions so we have only one designated initializer. Leave the date as nil if there's no date in the dictionary instead of setting the date to 0.
11:47 PM Changeset in webkit [2597] by darin
  • 4 edits in trunk/WebCore
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::slotData): Add an assert in the hopes of catching bug 3084704 a little earlier.
11:43 PM Changeset in webkit [2596] by darin
  • 4 edits in trunk/JavaScriptCore
  • kjs/date_object.cpp: (mktimeUsingCF): Fix storage leak.
9:29 PM Changeset in webkit [2595] by mjs
  • 9 edits in trunk/WebKit

WebKit:

Removed SaveAndOpenExternally policy.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler finishedLoading]):
  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handleDidFinishLoading:]):

WebBrowser:

Removed all uses of SaveAndOpenExternally policy.

  • BrowserDocument.m: (-[BrowserDocument _stopNonDownloadingDataSource:]):
  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]):
9:15 PM Changeset in webkit [2594] by cblu
  • 3 edits in trunk/WebKit

WebKit:

  • WebKit.pbproj/project.pbxproj:

WebBrowser:

Made Alexander responsible for opening downloads.

  • BrowserWebController.m: (-[BrowserWebController fileURLPolicyForMIMEType:andRequest:inFrame:]): call +[WBPreferences shouldOpenFileWithMIMEType:] (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]): no open policy
  • Defaults.plist:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry isDiskCopyFile]): (-[DownloadProgressEntry startDiskCopyInteraction]): (-[DownloadProgressEntry openFile]): (-[DownloadProgressEntry setCompleted]):
  • Preferences.subproj/WBPreferences.h:
  • Preferences.subproj/WBPreferences.m: (+[WBPreferences shouldOpenFileWithMIMEType:]): moved this method here from BrowserWebController as this is now called in 2 different places
7:10 PM Changeset in webkit [2593] by mjs
  • 4 edits in trunk/JavaScriptCore
  • partial fix to 3073230 - JavaScript time calls do I/O by lastat()ing /etc/localtime
  • kjs/date_object.cpp: (mktimeUsingCF): Implementation of mktime using CF.
6:49 PM Changeset in webkit [2592] by rjw
  • 2 edits in trunk/WebKit

Commit changelog.

5:29 PM Changeset in webkit [2591] by mjs
  • 3 edits in trunk/WebKit
  • fixed 3095628 - REGRESSION: exception when clicking on link to load content into iframe
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _actionInformationForNavigationType:event:]): Get the element info from the HTML view where the click originally happened, not the current document view. Add some asserts to make sure this is working.
5:14 PM Changeset in webkit [2590] by rjw
  • 4 edits in trunk/WebCore

Don't stop animating unless we're the last referee. (3083281)

  • kwq/KWQPixmap.mm: (QPixmap::~QPixmap):
3:50 PM Changeset in webkit [2589] by rjw
  • 3 edits in trunk/WebKit

Fixed updating of status bar and activity window when
loading plugin content as main document. (3084311)

  • LoadProgressMonitor.m: (-[LoadProgressMonitor resource:didReceiveContentLength:fromDataSource:]):
11:29 AM Changeset in webkit [2588]
  • 3 copies in tags/Alexander-31

This commit was manufactured by cvs2svn to create tag 'Alexander-31'.

11:29 AM Changeset in webkit [2587] by sheridan
  • 8 edits in trunk

Alex-31 stamp

7:47 AM Changeset in webkit [2586] by mjs
  • 3 edits in trunk/WebKit
  • fixed 3094778 - REGRESSION: Assert on logout from schwab.com

(probably fixed it anyway - I'm flying blind on this one)

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]): Use a nil request if the URL was nil, instead of making a request that contains a nil URL.
6:33 AM Changeset in webkit [2585] by mjs
  • 14 edits in trunk/WebKit

WebKit:

Changed things so that creating a window takes a request rather
than a URL and referrer.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge createWindowWithURL:frameName:]):
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _openNewWindowWithRequest:behind:]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _setTriggeringEvent:]): (-[WebDataSource _triggeringEvent]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate openNewWindowWithURL:]):
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): (-[WebFrame findOrCreateFramedNamed:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
  • WebView.subproj/WebWindowOperationsDelegate.h:

WebBrowser:

Changed things so that creating a window takes a request rather
than a URL and referrer.

  • BrowserWebController.m: (-[BrowserWebController createWindowWithRequest:]):

Nov 6, 2002:

10:43 PM Changeset in webkit [2584] by darin
  • 4 edits in trunk/WebKit
  • fixed problem where files small enough to fit entirely in the buffer (8K or less) would not be decoded
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler decodeData:]): Added. Moved most of the code from receivedData into here. (-[WebDownloadHandler receivedData:]): Changed to call decodeData. (-[WebDownloadHandler finishedLoading]): Call decodeData on any remaining bytes rather than writing them straight out to the data fork.
5:21 PM Changeset in webkit [2583] by rjw
  • 8 edits in trunk

More work on rendering scripts. Now most complex scripts render correctly.
Working new features include:
bidi, diacriticals, cursive forms, and arabic ligatures.
Selection of text rendered in these scripts, is however, not working.
Also, line height is incorrect when renderering combined below glyphs.
ajami is, sadly, horrendously broken.

  • Misc.subproj/WebUnicode.m: (glyphVariantLogical): (shapedString):
  • WebCoreSupport.subproj/WebTextRenderer.m: (-[WebTextRenderer drawCharacters:stringLength:fromCharacterPosition:toCharacterPosition:atPoint:withPadding:withTextColor:backgroundColor:rightToLeft:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:]):

Use our notion of unicode whitespace from lookup tables
and isspace for latin1. This is more correct than CF.
Fixed issues Dave ran into with whitespace calculations.

  • kwq/KWQChar.mm: (QChar::isSpace):
5:10 PM Changeset in webkit [2582] by sullivan
  • 3 edits in trunk/WebKit

WebKit:

  • Bookmarks.subproj/WebBookmark.m: (+[WebBookmark bookmarkOfType:]): made this handle WebBookmarkTypeProxy

WebBrowser:

  • fixed 3092708 -- allow option for Bookmarks Toolbar as submenu of Bookmarks menu

The wording and possibly layout in Preferences will change soon, but the
behavior is now implemented as SJ specified.

  • Defaults.plist:
  • PreferenceKeys.h: New preference keys for the new options
  • Preferences.subproj/English.lproj/BookmarkPreferences.nib: rejigger everything in the bookmarks preferences panel
  • Preferences.subproj/BookmarkPreferences.h:
  • Preferences.subproj/BookmarkPreferences.m: (-[BookmarkPreferences updateBookmarksViews]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesAddressBook:]): (-[BookmarkPreferences toggleBookmarksToolbarIncludesRendezvous:]): (-[BookmarkPreferences toggleBookmarksMenuAndToolbarAreSame:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesBookmarksToolbar:]): (-[BookmarkPreferences toggleBookmarksMenuIncludesRendezvous:]): (-[BookmarkPreferences initializeFromDefaults]): reworked all the code to handle the new options, including the way some options change when others are checked
  • BookmarksController.h: made addressBookProxyTitle and rendezvousProxyTitle public
  • BookmarksController.m: (-[BookmarksController addChildrenOfBookmark:toMenu:]): new method, generalized from code elsewhere (handles keyboard equivalents for toolbar items) (-[BookmarksController addMenuItemForBookmark:toMenu:]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController addFavoritesSubmenu]): new method, calls addChildrenOfBookmark:toMenu: (-[BookmarksController addSpecialBookmarkSourcesToMenu]): now handles toolbar as submenu, plus fancier logic to match new preferences (-[BookmarksController _addBookmarksToMenu]): now calls addChildrenOfBookmark:toMenu: (-[BookmarksController receivedBrowserPreferenceValueChangedNotification:]): now checks for new preferences also
  • FavoriteButton.m: (-[FavoriteButton setBookmark:]): now handles WebBookmarkTypeProxy -- like folder in appearance, but not a drag target (-[FavoriteButton menu]): now handles WebBookmarkTypeProxy (by returning nil for the context menu) (-[FavoriteButton hasContentsMenu]): new method, just checks bookmark type (-[FavoriteButton _contentsMenu]): now handles WebBookmarkTypeProxy by using BookmarkSource protocol to extract contents (-[FavoriteButton mouseDown:]): check hasContentMenu instead of assuming which types have menus
  • FavoritesBar.m: (-[FavoritesBar addButtonForBookmark:withLeftEdge:]): new method, extracted from _refreshButtons (-[FavoritesBar includeRendezvous]), (-[FavoritesBar includeAddressBook]): new methods, check with NSUserDefaults (-[FavoritesBar _refreshButtons]): take includeRendezvous and includeAddressBook into account; now calls addButtonForBookmark:withLeftEdge: (-[FavoritesBar refreshButtonsSoon]): new method, extracted from _favoritesChanged (-[FavoritesBar preferenceValueChanged:]): new method, call refreshButtons if the right prefs have changed (-[FavoritesBar _favoritesChanged:]): now calls refreshButtonsSoon (-[FavoritesBar initWithView:]): register for preferences value changed notifications (-[FavoritesBar dropIndexFromDraggingInfo:]): take includeRendezvous and includeAddressBook into account (-[FavoritesBar performDragOperation:]): take includeRendezvous and includeAddressBook into account
4:16 PM Changeset in webkit [2581] by darin
  • 5 edits in trunk/WebKit
  • fixed bug that affected BinHex-encoded files with no resource fork
  • Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeData:dataForkData:resourceForkData:]): Don't decode the resource fork unless done with the data fork.
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler receivedData:]): Set the forks to nil before calling through.
3:47 PM Changeset in webkit [2580] by darin
  • 4 edits in trunk/WebKit
  • Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Fix == 129 check that was supposed to be <= 129.
  • English.lproj/StringsNotToBeLocalized.txt: Update for recent changes.
3:44 PM Changeset in webkit [2579] by cblu
  • 2 edits in trunk/WebKit/Downloads.subproj

WebFoundation:

Added _web_infoDictionaryForBundleAtPath. Gets info dictionary without using NSBundle.

  • Misc.subproj/WebNSDictionaryExtras.h:
  • Misc.subproj/WebNSDictionaryExtras.m: (+[NSDictionary _web_infoDictionaryForBundleAtPath:]):

WebBrowser:

Preliminary work for disk copy interaction.

  • AppController.m: (-[AppController awakeFromNib]): tweak to GURL event call, no actual change
  • Defaults.plist: don't have WebKit open disk images for us anymore, since Alex will do this.
  • DiskCopyPuppetStrings.h:
  • DownloadMonitor.m: (-[DownloadMonitor init]): set handlers for disk copy events (-[DownloadMonitor handleDiskCopyEvent:withReplyEvent:]): added, does nothing right now
  • DownloadProgressEntry.h:
  • DownloadProgressEntry.m: (-[DownloadProgressEntry diskCopyStage]): new (-[DownloadProgressEntry setDiskCopyStage:]): new (-[DownloadProgressEntry startDiskCopyInteraction]): new, check version of disk copy, open disk image (-[DownloadProgressEntry setCompleted]): call startDiskCopyInteraction
3:31 PM Changeset in webkit [2578] by darin
  • 4 edits in trunk/WebKit
  • Downloads.subproj/WebBinHexDecoder.m: (-[WebBinHexDecoder decodeIntoBuffer:size:]): Fix an off-by-one error handling repeat counts.
  • WebKit.pbproj/project.pbxproj: Fix group name I accidentally mangled.
3:11 PM Changeset in webkit [2577] by darin
  • 8 edits
    2 adds in trunk/WebKit
  • added a BinHex decoder and did a little work on the MacBinary decoder

I'm not supposed to be working on this, but I didn't feel like doing "real" work.

  • Downloads.subproj/WebBinHexDecoder.h: Added.
  • Downloads.subproj/WebBinHexDecoder.m: Added.
  • WebKit.pbproj/project.pbxproj: Added WebBinHexDecoder.
  • Downloads.subproj/WebDownloadDecoder.h: Added WEB_DOWNLOAD_DECODER_MINIMUM_HEADER_LENGTH.
  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler closeFile]): Check to be sure we don't close the same file twice.
  • Downloads.subproj/WebMacBinaryDecoder.h: Added _scriptCode.
  • Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]): Added check of MacBinary version field. (-[WebMacBinaryDecoder decodeData:dataForkData:resourceForkData:]): Added MacBinary III part that gets the script code. (-[WebMacBinaryDecoder filename]): Use the script code.
2:37 PM Changeset in webkit [2576] by mjs
  • 8 edits in trunk/WebKit

WebKit:

Took URL field out of click policy - open in new window policy
will always open the request URL.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyPrivate dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:andPath:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):

WebBrowser:

Updated for WebKit changes.

  • BrowserWebController.m: (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
11:26 AM Changeset in webkit [2575] by cblu
  • 3 edits in trunk/WebKit

Support MacBinary I by checking that bytes 99-127 are 0. Also check byte 82 for all formats.

  • Downloads.subproj/WebMacBinaryDecoder.m: (+[WebMacBinaryDecoder canDecodeHeaderData:]):
9:25 AM Changeset in webkit [2574] by kocienda
  • 3 edits in trunk/WebKit

WebFoundation:

Fix for this bug:

Radar 3004422 (Loader should cache misses)

I added a code to support caching HTTP 404 responses. These objects
will now get cached just like other responses, and they are subject
to the same revalidation rules as other cache objects.

To support caching the 404 for a specified period of time, I have
added an extra method to WebHTTPResourceRequest.

  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler willCacheObject:]): (-[WebHTTPProtocolHandler shouldCacheResponse:]):
  • ProtocolHandlers.subproj/WebHTTPResourceRequest.h:
  • ProtocolHandlers.subproj/WebHTTPResourceRequest.m: (-[WebResourceRequest pageNotFoundCacheLifetime]): (-[WebResourceRequest setPageNotFoundCacheLifetime:]): (-[WebHTTPResourceRequestParameters copyWithZone:]): (-[WebHTTPResourceRequestParameters isEqual:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _examineHeaders]):

WebKit:

Call new WebHTTPResourceRequest method to set the amount of time
to cache a 404 response when trying to fetch a favicon.

This change helps to fix this bug:

Radar 3004422 (Loader should cache misses)

  • Misc.subproj/WebIconLoader.m: (-[WebIconLoader startLoading])
Note: See TracTimeline for information about the timeline view.