⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 11, 2002:

11:17 PM Changeset in webkit [2630] by mjs
  • 19 edits in trunk/WebKit

WebKit:

Remove contentPolicy parameter from _downloadURL, and remove
remaining traces of path from policy object.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebControllerPolicyDelegate.m: (-[WebPolicyPrivate dealloc]): (+[WebURLPolicy webPolicyWithURLAction:]): (+[WebFileURLPolicy webPolicyWithFileAction:]): (+[WebContentPolicy webPolicyWithContentAction:]): (+[WebClickPolicy webPolicyWithClickAction:]):
  • WebView.subproj/WebControllerPolicyDelegatePrivate.h:
  • WebView.subproj/WebControllerPrivate.h:
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:]):
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultContextMenuDelegate downloadURL:]):
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate clickPolicyForAction:andRequest:inFrame:]):
  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _continueAfterClickPolicyForEvent:request:]):
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView namesOfPromisedFilesDroppedAtDestination:]):
  • WebView.subproj/WebImageView.m: (-[WebImageView namesOfPromisedFilesDroppedAtDestination:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Don't pass path when making policy objects.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]): (-[BrowserWebController clickPolicyForAction:andRequest:inFrame:]):
10:33 PM Changeset in webkit [2629] by darin
  • 8 edits in trunk

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Update.

WebCore:

  • kwq/KWQWidget.mm: (QWidget::setCursor): Remove printf I left in by accident.

WebKit:

  • Plugins.subproj/WebNetscapePluginPackage.m: (-[WebNetscapePluginPackage load]): Use fileSystemRepresentationWithPath, not cString, to turn a path into something to pass to FSPathMakeRef.
  • English.lproj/StringsNotToBeLocalized.txt: Update.

WebBrowser:

  • BrowserNSStringExtras.m: (-[NSString compareVersionString:]): Use lossyCString so we don't get an exception if a string is bad.
  • English.lproj/StringsNotToBeLocalized.txt: Update.
6:06 PM Changeset in webkit [2628] by darin
  • 11 edits in trunk

WebCore:

  • tighten up cursor handling a bit more
  • kwq/KWQWidget.mm: (QWidget::setCursor): Use setDocumentCursor: instead of our own protocol. (QWidget::cursor): Use documentCursor instead of storing our own cursor.
  • kwq/WebCoreFrameView.h: Remove setCursor: method.

WebKit:

  • tighten up cursor handling a bit more
  • WebView.subproj/WebDynamicScrollBarsView.m:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView addMouseMovedObserver]): Call _frameOrBoundsChanged so we emit a mouse moved event right away. (-[WebHTMLView viewWillMoveToSuperview:]): Remove the colon since I removed the parameter from _frameOrBoundsChanged.
  • WebView.subproj/WebHTMLViewPrivate.h: Declare _frameOrBoundsChanged.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged]): Remove parameter.
5:47 PM Changeset in webkit [2627] by darin
  • 7 edits in trunk/WebCore
  • fixed 3084704 -- crash in HTMLTokenizer on page with JavaScript HTMLDocument::Close inside a <script>

I think it's going to work this time. The key was to hook up the
KHTML submitFormAgain machinery.

  • khtml/khtml_part.cpp: (KHTMLPart::submitForm): Take out the APPLE_CHANGES ifdef that was disabling the submitFormAgain logic.
  • kwq/KWQKHTMLPart.h: Remove submitForm(), because openURLRequest() handles it fine.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::openURLRequest): Move the logic for handling POST here from submitForm() and remove submitForm().
  • kwq/KWQSlot.mm: (KWQSlot::KWQSlot): Add support for the submitFormAgain slot. (KWQSlot::call): Ditto.
11:27 AM Changeset in webkit [2626] by trey
  • 3 edits in trunk/WebKit

Fixed 3015884 - Reloading a page should remember the scroll position

  • WebView.subproj/WebFramePrivate.m: (-[WebFrame _transitionToCommitted]): Save scroll position on reload (-[WebFrame _isLoadComplete]): Restore position on reload
11:04 AM Changeset in webkit [2625] by darin
  • 8 edits
    2 adds in trunk/WebCore
  • fixed 3092421 -- javascript: URL that opens window crashes Alex if typed into empty window
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::KWQKHTMLPart): Set _ownsView to false. (KWQKHTMLPart::~KWQKHTMLPart): Delete the view if we own it. Also release _currentEvent to fix a leak. (KWQKHTMLPart::setView): Delete the old view if we own it. Also, set the _ownsView flag. (KWQKHTMLPart::createDummyDocument): Create a dummy view too.
  • kwq/KWQDummyView.h: Added.
  • kwq/KWQDummyView.m: Added.
  • WebCore.pbproj/project.pbxproj: Added KWQDummyView.
  • kwq/WebCoreBridge.h: Remove bridgeOwnsKHTMLView and currentEvent.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge createKHTMLViewWithNSView:marginWidth:marginHeight:]): Pass true to setView instead of setting bridgeOwnsKHTMLView. (-[WebCoreBridge removeFromFrame]): Just call setView on the part. It knows how to handle ownership now. (-[WebCoreBridge installInFrame:]): Call setOwnsView instead of setting bridgeOwnsKHTMLView.
10:33 AM Changeset in webkit [2624] by trey
  • 21 edits in trunk

First checkin of making frames work with the back forward list, restoring scroll position and form state. Fixing:

3014555 Lose frameset context going back/forward
3078151 History inconsistency after loading frame content
3089551 REGRESSION: www.bmwusa.com frames don't load in alex-30
3095878 refresh doesn't preserve frame state

WebCore:

  • khtml/khtml_part.cpp: (KHTMLPart::requestFrameName): Call through bridge to get generated frame name.
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::generateFrameName): New call that just forwards through the bridge.
  • kwq/WebCoreBridge.h:

WebKit:

  • History.subproj/WebBackForwardList.m: (-[WebBackForwardList addEntry:]): Yank code to avoid adding a duplicate entry, to catch the refresh case. That's dealt with in WebFramePrivate now. (-[WebBackForwardList description]): Enhanced to print more info.
  • History.subproj/WebHistoryItem.h: History items now hold an array of subitems to mirror the frame tree. One item in the tree is designated the target of the navigation.
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem dealloc]): Release new ivars. (-[WebHistoryItem isTargetItem]): (-[WebHistoryItem setIsTargetItem:]): New setter and setter. (-[WebHistoryItem _recurseToFindTargetItem]): (-[WebHistoryItem targetItem]): Search the tree to find the target item. (-[WebHistoryItem children]): (-[WebHistoryItem addChildItem:]): (-[WebHistoryItem childItemWithName:]): Maintain and search new child item list. (-[WebHistoryItem description]): Enhanced to print out the tree of items. (-[WebHistoryItem dictionaryRepresentation]): (-[WebHistoryItem initFromDictionaryRepresentation:]): Save and load the new state.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge generateFrameName]): New call from KWQ, just forwards to Frame. (-[WebBridge createChildFrameNamed:withURL:renderPart:allowsScrolling:marginWidth:marginHeight:]): Call new frame method dedicated to this case. (-[WebBridge saveDocumentState:]): (-[WebBridge documentState]): Call frame methods to get the right item to save/restore to/from.
  • WebView.subproj/WebController.m: (-[WebController _goToItem:withLoadType:]): Stop any current loading before going to a new item. (-[WebController goBack]): (-[WebController goForward]): (-[WebController goBackOrForwardToItem:]): Name change of private method (for consistency)
  • WebView.subproj/WebDataSourcePrivate.h: ProvisionalItem and PreviousItem are moved back up to WebFrame, where we know more about the state transitions that happen during loading.
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): Don't release removed ivars. (-[WebDataSource _commitIfReady]): Make the view representations -after- the transition to committed. This allows us to save away the scroll location successfully, since making the view was resetting it.
  • WebView.subproj/WebFrame.h:
  • WebView.subproj/WebFrame.m: (-[WebFrame setProvisionalDataSource:]): Saving the scroll location has moved elsewhere to handle frames. (-[WebFrame stopLoading]): Skip all the work if we're already state=complete.
  • WebView.subproj/WebFramePrivate.h: The frame now holds a ref to the current, previous and provisional back-forward items.
  • WebView.subproj/WebFramePrivate.m: (-[WebFramePrivate dealloc]): Release new state. (-[WebFramePrivate setProvisionalItem:]): (-[WebFramePrivate setPreviousItem:]): (-[WebFramePrivate setCurrentItem:]): New setters (1 line getters were missed by script) (-[WebFrame _addBackForwardItemClippedAtTarget:]): Adds a BF item to the top of the BF list. (-[WebFrame _createItem]): Create a single BF item. (-[WebFrame _createItemTreeWithTargetFrame:clippedAtTarget:]): Create a tree of BF items, which mirror the frame tree. (-[WebFrame _immediateChildFrameNamed:]): New frame search utility (doesn't recurse) (-[WebFrame _detachFromParent]): Save the scroll position when detaching a frame. (-[WebFrame _transitionToCommitted]): Maintain new item ivars. Save scroll position when appropriate. Hook up items for child frames to their parent, as they are created. (-[WebFrame _setState:]): Clear previousItem whenever we reach committed. (-[WebFrame _isLoadComplete]): Clear previousItem if we are committed. (-[WebFrame _childFramesMatchItem:]): Does the frame's frame tree match the one held by the item? (-[WebFrame _loadItem:fromItem:withLoadType:]): Only do simple anchor navigation if the frame has no children (fixes oddball corner case with a frame reloading itself). Set provisional item. (-[WebFrame _recursiveGoToItem:fromItem:withLoadType:]): Heart of returning to an item that had frames. We either find that the existing content is good, or initiate a load. (-[WebFrame _goToItem:withLoadType:]): Adjust the BF list cursor, and recurse to do the work. (-[WebFrame _loadURL:loadType:clientRedirect:triggeringEvent:]): Only do anchor-style nav if the destination URL has a fragment. Save scroll position. (-[WebFrame _loadURL:intoChild:]): If returning to an item with frames, possibly replace the new content with the stuff that was there at the time, substituting the URL. (-[WebFrame _saveScrollPositionToItem:]): Don't croak on nil item or view. (-[WebFrame _restoreScrollPosition]): Do croak (ASSERT) on nil item. (-[WebFrame _scrollToTop]): Nit cleanup. (-[WebFrame _addFramePathToString:]): Add a component for our frame to the frame name we're generating. (-[WebFrame _generateFrameName]): Generate a frame name that is repeatable. (-[WebFrame _itemForSavingDocState]): Returns correct item to use for formstate save. (-[WebFrame _itemForRestoringDocState]): Returns correct item to use for formstate restore

WebBrowser:

  • BrowserDocument.m: (-[BrowserDocument _addItem:toMenu:]): For a back-forward item that's a tree because its for a frameset, use the right item of the tree to generate the menu contents.
7:01 AM Changeset in webkit [2623] by mjs
  • 12 edits in trunk/WebKit

WebKit:

Store path and the fact that we're downloading in the data source,
instead of storing the content policy.

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler cleanUpAfterFailure]): (-[WebDownloadHandler createFileIfNecessary]): (-[WebDownloadHandler finishedLoading]):
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _downloadURL:withContentPolicy:]):
  • WebView.subproj/WebDataSource.h:
  • WebView.subproj/WebDataSource.m: (+[WebDataSource registerRepresentationClass:forMIMEType:]): (-[WebDataSource isDownloading]): (-[WebDataSource downloadPath]):
  • WebView.subproj/WebDataSourcePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSourcePrivate dealloc]): (-[WebDataSource _commitIfReady]): (-[WebDataSource _setIsDownloading:]): (-[WebDataSource _setDownloadPath:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): (-[WebMainResourceClient handle:didReceiveResponse:]): (-[WebMainResourceClient handleDidFinishLoading:]):

WebBrowser:

Adjusted for WebKit API changes.

  • DownloadProgressEntry.m: (+[DownloadProgressEntry entryWithDataSource:]): (-[DownloadProgressEntry path]):
4:49 AM Changeset in webkit [2622] by mjs
  • 8 edits in trunk/WebKit

WebKit:

Don't ask for the content policy any more if the previous policies
said to save - in effect this means to ask only if the previous
policies said to use the content policy. Also, remove now-useless
previous content policy parameter from content policy delegate.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _setContentPolicy:]): Retain new policy before releasing the old one.
  • WebView.subproj/WebDefaultPolicyDelegate.m:
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]): Don't ask for content policy if the delegate already decided to save.

WebBrowser:

Adjusted for WebKit API change.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:]):
1:29 AM Changeset in webkit [2621] by mjs
  • 7 edits in trunk/WebKit

WebKit:

Added new policy delegate callback to get the filename - this
won't be up to the content policy any more.

  • WebView.subproj/WebControllerPolicyDelegate.h:
  • WebView.subproj/WebDefaultPolicyDelegate.m: (-[WebDefaultPolicyDelegate saveFilenameForResponse:andRequest:]):
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient handle:didReceiveResponse:]):

WebBrowser:

Added new policy delegate callback to get the filename - this
won't be up to the content policy any more.

  • BrowserWebController.m: (-[BrowserWebController contentPolicyForResponse:andRequest:inFrame:withContentPolicy:]): (-[BrowserWebController saveFilenameForResponse:andRequest:]):
12:46 AM Changeset in webkit [2620] by darin
  • 4 edits in trunk/WebCore
  • fixed 3097253 -- text tagged <small> inside <h1> is too small
  • khtml/css/html4.css: Change BIG to use "font-size: larger" rather than "font-size: large" and SMALL to use "font-size: smaller" rather than "font-size: small".
12:31 AM Changeset in webkit [2619] by darin
  • 15 edits in trunk

WebCore:

  • kwq/WebCoreBridge.h: Remove unused modifierTrackingEnabled method.

WebKit:

  • made some improvements to cursor setting for greater speed and correctness
  • WebView.subproj/WebDynamicScrollBarsView.m: (-[WebDynamicScrollBarsView setCursor:]): Just use setDocumentCursor: instead of our own logic. This allows us to remove code and may fix some bugs or anomalies as well. (-[WebDynamicScrollBarsView dealloc]): Release the cursor. I think we were leaking before.
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView viewWillMoveToSuperview:]): Use _frameOrBoundsChanged: method now, which has been moved into the private file. (-[WebHTMLView dragImage:at:offset:event:pasteboard:source:slideBack:]): Don't bother finding topmost WebHTMLView to call _updateMouseoverWithEvent: on; now it works fine no matter which level it's called at.
  • WebView.subproj/WebHTMLViewPrivate.m: (-[WebHTMLView _frameOrBoundsChanged:]): Moved the code here that was formerly in the _setNeedsLayoutIfSizeChanged method, also added code that does _updateMouseoverWithEvent: so that we get properly updated cursor when we scroll. (-[WebHTMLView _updateMouseoverWithEvent:]): Remove unneeded assert. This method works equally well no matter which WebHTMLView calls it; everything is done at the window and controller level.
  • WebView.subproj/WebControllerPrivate.h: Added lastElementWasNotNil field and _mouseDidMoveOverElement:modifierFlags: method.
  • WebView.subproj/WebControllerPrivate.m: (-[WebController _mouseDidMoveOverElement:modifierFlags:]): Call through to the delegate, but don't do multiple calls if they are all nil.
  • WebCoreSupport.subproj/WebBridge.m: Remove unused modifierTrackingEnabled method.
  • WebView.subproj/WebHTMLViewPrivate.h: Remove unused _setModifierTrackingEnabled and _modifierTrackingEnabled methods.

WebBrowser:

  • AppController.m: (-[AppController awakeFromNib]): Remove unneeded call to set unused modifierTrackingEnabled flag. The code that used to care about this flag is now in WebBrowser and there's no need to inform WebCore and WebKit about whether we are passing in flags-changed events.

Nov 10, 2002:

10:36 PM Changeset in webkit [2618] by darin
  • 3 edits in trunk/WebKit

WebFoundation:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebKit:

  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

WebBrowser:

  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Add call to _setAutoreleaseDuringLiveResize: so we can live with a smaller footprint when running under SUJagGreen or newer.
  • Preferences.subproj/DefaultBrowserController.m: (keyValuesMatch): Fix comparison of nils. (-[DefaultBrowserController handleApplicationPopUp:withSheetDidEndSelector:]): Fix typo in localization comment.
  • English.lproj/Localizable.strings: Update.
  • English.lproj/StringsNotToBeLocalized.txt: Update.
  • TextFieldWithControls.m: (-[TextFieldWithControls selectText:]): Add a comment explaining Chris's bug fix.
2:33 PM Changeset in webkit [2617] by cblu
  • 5 edits in trunk/WebKit

WebFoundation:

Made WebCacheObject and WebResourceResponse methods that refer to specific dates set and return NSDates rather than NSTimeIntervals. Our public methods now only use NSTimeIntervals when referring to differences in time. Made the methods that use NSTimeIntervals when referring to specific dates private.

  • CacheLoader.subproj/WebCacheObject.h:
  • CacheLoader.subproj/WebCacheObject.m: (-[WebCacheObject createdDate]): (-[WebCacheObject setCreatedDate:]): (-[WebCacheObject expiresDate]): (-[WebCacheObject setExpiresDate:]): (-[WebCacheObject lastModifiedDate]): (-[WebCacheObject setLastModifiedDate:]): (-[WebCacheObject maxAgeValue]): (-[WebCacheObject isExpired]): (-[WebCacheObject age]): (-[WebCacheObject freshnessLifetime]): (-[WebCacheObject dealloc]): (-[WebCacheObject _createdTime]): (-[WebCacheObject _setCreatedTime:]): (-[WebCacheObject _expiresTime]): (-[WebCacheObject _setExpiresTime:]): (-[WebCacheObject _lastModifiedTime]): (-[WebCacheObject _setLastModifiedTime:]):
  • CacheLoader.subproj/WebCacheObjectPrivate.h: Added.
  • CacheLoader.subproj/WebResourceResponse.h:
  • CacheLoader.subproj/WebResourceResponse.m: (-[WebResourceResponse createdDate]): (-[WebResourceResponse lastModifiedDate]): (-[WebResourceResponse _createdTime]): (-[WebResourceResponse _lastModifiedTime]): (-[WebResourceResponse _takePersistentValuesFrom:]):
  • CacheLoader.subproj/WebResourceResponsePrivate.h:
  • ProtocolHandlers.subproj/WebCFNetworkHTTPProtocolHandler.m: (-[WebCFNetworkHTTPProtocolHandler addIfModifiedSinceHeader:]): (-[WebCFNetworkHTTPProtocolHandler continueHeaderReadAfter3xxResponseAndCall:]):
  • ProtocolHandlers.subproj/WebHTTPProtocolHandler.m: (-[WebHTTPProtocolHandler willCacheObject:]):
  • ProtocolHandlers.subproj/WebSimpleHTTPProtocolHandler.m: (-[WebSimpleHTTPProtocolHandler _createHTTPRequest]): (-[WebSimpleHTTPProtocolHandler _examineHeaders]):
  • WebFoundation.pbproj/project.pbxproj:

WebKit:

Fixed: 3021681 - downloaded files' creation and modification dates are not set

  • Downloads.subproj/WebDownloadHandler.m: (-[WebDownloadHandler createFileIfNecessary]): call [response creationDate] and [response lastModifiedDate] when setting file attributes.
  • Plugins.subproj/WebBaseNetscapePluginStream.m: (-[WebBaseNetscapePluginStream setResponse:]): call [response lastModifiedDate] when giving content to plug-ins.

WebBrowser:

Possible fix for: 3096071 - Button under "Proxy settings" in preferences window needs implementation

With the new Network Pref root, the proxy button seems to work %50 of the time. 3096071 may be fixed if the current problem is just a bug in the network pref.

  • Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences _launchNetworkPrefs]): code from Robert Ulrich (-[GeneralPreferences openProxyPreferences:]): call _launchNetworkPrefs
9:07 AM Changeset in webkit [2616] by darin
  • 3 edits in trunk/WebKit
  • English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.
Note: See TracTimeline for information about the timeline view.