⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Nov 23, 2002:

11:49 PM Changeset in webkit [2846] by mjs
  • 13 edits in trunk/JavaScriptCore
  • completed Darin's mostly-fix for 3037795 - Resource use increases when accessing very high index value in array

The two missing pieces were handling sparse properties when
shrinking the array, and when sorting. Thse are now both taken
care of.

  • kjs/array_instance.h:
  • kjs/array_object.cpp: (ArrayInstanceImp::put): (ArrayInstanceImp::deleteProperty): (ArrayInstanceImp::resizeStorage): (ArrayInstanceImp::setLength): (ArrayInstanceImp::sort): (ArrayInstanceImp::pushUndefinedObjectsToEnd):
  • kjs/identifier.h:
  • kjs/object.h:
  • kjs/property_map.cpp:
  • kjs/property_map.h:
  • kjs/reference_list.cpp: (ReferenceList::append): (ReferenceList::length):
  • kjs/reference_list.h:
  • kjs/ustring.cpp: (UString::toUInt32):
  • kjs/ustring.h:
4:04 PM Changeset in webkit [2845] by mjs
  • 8 edits in trunk/JavaScriptCore

Numerous collector changes for a net gain of 3% on JS ibench:

  • Replaced per-block bitmap with free list.
  • Increased number of empty blocks kept around to 2.
  • Doubled block size.
  • When scanning heap in collector, skip scanning the rest of a block as soon as we see as many live cells as the the number of used cells it had originally.

Also the following collector changes unrelated to performance:

  • Made constants const int' instead of static const int'.
  • Miscellaneous code cleanup.
  • kjs/collector.cpp:
  • Added debugging mode enabled by defining DEBUG_GC which asserts when a destroyed ValueImp
  • kjs/internal.cpp: (ContextImp::mark):
  • kjs/value.cpp: (Value::Value):
  • kjs/value.h:
  • kjs/config.h:
1:17 PM Changeset in webkit [2844] by cblu
  • 9 edits in trunk/WebKit

Fixed: 3109835 - Download errors aren't communicated to client

Cleaned-up WebMainResourceClient and WebBaseResourceHandleDelegate a little.

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase defaultIconWithSize:]): tweak (-[WebIconDatabase releaseIconForSiteURL:]): don't retain site URL here (-[WebIconDatabase _setIcon:forIconURL:]): tweak (-[WebIconDatabase _setIconURL:forSiteURL:]): tweak (-[WebIconDatabase _releaseIconForIconURLString:]): retain site URL here (-[WebIconDatabase _releaseFutureIconForSiteURL:]): tweak (-[WebIconDatabase _sendNotificationForSiteURL:]): tweak
  • WebView.subproj/WebBaseResourceHandleDelegate.h:
  • WebView.subproj/WebBaseResourceHandleDelegate.m: (-[WebBaseResourceHandleDelegate cancelWithError:]): made public (-[WebBaseResourceHandleDelegate cancel]): cancel downloads too, call cancelWithError (-[WebBaseResourceHandleDelegate cancelQuietly]): call cancelWithError (-[WebBaseResourceHandleDelegate cancelledError]): tweak (-[WebBaseResourceHandleDelegate notifyDelegatesOfInterruptionByPolicyChange]): tweak
  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient receivedError:]): stop downloadHandler if downloading, else notify controller (-[WebMainResourceClient cancel]): call receivedError (-[WebMainResourceClient checkContentPolicyForResponse:andCallSelector:]): tweak (-[WebMainResourceClient handle:didReceiveData:]): stop load for download errors, report error (-[WebMainResourceClient handleDidFinishLoading:]): call didFailLoadingWithError is download error (-[WebMainResourceClient handle:didFailLoadingWithError:]): call receivedError

Nov 22, 2002:

11:49 PM Changeset in webkit [2843] by darin
  • 19 edits in trunk

JavaScriptCore:

  • replaced List class with a vector rather than a linked list, changed it to use a pool of instances instead of all the nodes allocated off of the heap; gives 10% gain on iBench
  • kjs/list.h: Complete rewrite.
  • kjs/list.cpp: Ditto.
  • kjs/array_object.cpp: (compareWithCompareFunctionForQSort): Go back to doing a clear and two appends here. Fast with the new list implementation.
  • kjs/collector.h: Remove _COLLECTOR hack and just make rootObjectClasses return a const void *.
  • kjs/collector.cpp: Remove _COLLECTOR hack, and various other minor tweaks.

WebCore:

  • khtml/ecma/kjs_window.cpp: Remove _COLLECTOR hack.
  • kwq/WebCoreJavaScript.h:
  • kwq/WebCoreJavaScript.mm: (+[WebCoreJavaScript rootObjectClasses]): Update for name change -- root object classes, not all live object classes.
  • force-js-clean-timestamp: Make sure we don't have more build problems.

WebKit:

  • Misc.subproj/WebCoreStatistics.h:
  • Misc.subproj/WebCoreStatistics.m: (+[WebCoreStatistics javaScriptRootObjectClasses]): Update for name change -- root object classes, not all live object classes.

WebBrowser:

  • Debug/CacheController.m: (-[CacheController refreshJavaScriptStatisticsMatrix]): Update for name change -- root object classes, not all live object classes.
9:24 PM Changeset in webkit [2842] by cblu
  • 4 edits in trunk/WebKit

WebFoundation:

Fixed: 3026574 - .text is probably text too

  • types.plist: "text" is another extension for text/plain

WebKit:

Fixed assertion while loading local files.

  • Misc.subproj/WebIconDatabase.m: we don't have icon URLs for files
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]): Only try loading favicon as the root of server if scheme is http or https. This isn't really a feature of other protocols.
8:33 PM Changeset in webkit [2841] by hyatt
  • 5 edits in trunk/WebCore

Fix for 3107658, text doubling problem caused by layers being
constructed for <td>s. Just disallow positioning of <td>.

  • khtml/rendering/render_box.cpp: (RenderBox::setStyle):
  • khtml/rendering/render_flow.cpp: (RenderFlow::setStyle):
7:53 PM Changeset in webkit [2840] by hyatt
  • 4 edits in trunk/WebCore

Oops. I meant to do that for <input type=button> and not
<button>. Just do it for <select>s for now.

  • khtml/rendering/render_box.cpp: (RenderBox::calcReplacedWidth):
7:43 PM Changeset in webkit [2839] by hyatt
  • 4 edits in trunk/WebCore

Make <select>s and <button>s ignore a CSS-specified width if that
width is smaller than their intrinsic width.

Fixes the <select> at the top of livepage.apple.com.

  • khtml/rendering/render_box.cpp: (RenderBox::calcReplacedWidth):
7:43 PM Changeset in webkit [2838] by cblu
  • 4 edits in trunk/WebKit

WebKit:

2002-11-22 Chris Blumenberg <​cblu@apple.com>

  • WebView.subproj/WebMainResourceClient.m: (-[WebMainResourceClient continueAfterContentPolicy:response:]): Added a FIXME around saveFilenameForResponse:andRequest: because the API expects a path but is asking for a filename.

WebBrowser:

Fixed: 3049735 - no default location for downloads

InternetConfig was giving an empty string for the download path. Now, when this happens, we set the download directory in InternetConfig to the Desktop.

  • BrowserWebController.m: (-[BrowserWebController saveFilenameForResponse:andRequest:]): Added a FIXME because the API expects a path but is asking for a filename.
  • Preferences.subproj/WBPreferences.m: (+[WBPreferences downloadPath]): Handle nil and "" case. Set download directory to Desktop.
6:50 PM Changeset in webkit [2837] by cblu
  • 3 edits in trunk/WebKit

Fixed: 3104693 - QT movie doesn't show video while still downloading

The initial size of plug-in should be 0,0 instead of 1,1 or else we don't get the layout

  • Plugins.subproj/WebNetscapePluginDocumentView.m: (-[WebNetscapePluginDocumentView initWithFrame:]):
6:18 PM Changeset in webkit [2836] by vicki
  • 1 edit in trunk/WebKit/Misc.subproj/WebIconDatabase.m

fixed tiny deployment build breakage; removed unused variables duration and start

5:27 PM Changeset in webkit [2835] by cblu
  • 5 edits in trunk/WebKit

Fixed: 3078737 - Crash in -[WebHistoryItem dealloc] after closing last window

  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase releaseIconForSiteURL:]): retain the site URL string because it may get released from beneath (-[WebIconDatabase _updateFileDatabase]): tweak (-[WebIconDatabase _iconsForIconURLString:]): disable timings for deployment build (-[WebIconDatabase _setIconURL:forSiteURL:]): tweak (-[WebIconDatabase _releaseIconForIconURLString:]): tweak (-[WebIconDatabase _scaleIcon:toSize:]): disable timings for deployment build
  • Misc.subproj/WebIconDatabasePrivate.h:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _updateIconDatabaseWithURL:]): new, does the db binding (-[WebDataSource _loadIcon]): call _updateIconDatabaseWithURL
3:20 PM Changeset in webkit [2834] by darin
  • 8 edits
    2 adds
    1 delete in trunk/JavaScriptCore
  • prepare to reimplement KJS::List; move to its own file, add statistics
  • kjs/function_object.cpp: (FunctionProtoFuncImp::call): Use new copyTail() function rather than copy() and removeFirst().
  • kjs/identifier.cpp: Add statistics, off by default.
  • kjs/property_map.cpp: Add statistics, off by default.
  • kjs/list.cpp: Added. Moved code here. To be rewritten.
  • kjs/list.h: Added. Moved interface here. To be rewritten.
  • kjs/types.cpp: Removed.
  • kjs/types.h: Now just an empty header that includes other headers.
3:05 PM Changeset in webkit [2833] by cblu
  • 7 edits in trunk/WebKit

WebKit:

Attempt to fix: 3078737 - Crash in -[WebHistoryItem dealloc] after closing last window
I haven't found anything that would cause the crash. I did some clean-up, added asserts and error messages in hopes that this help me track this down.

  • Misc.subproj/WebIconDatabase.h:
  • Misc.subproj/WebIconDatabase.m: (-[WebIconDatabase init]): (-[WebIconDatabase iconForSiteURL:withSize:cache:]): (-[WebIconDatabase iconForSiteURL:withSize:]): (-[WebIconDatabase retainIconForSiteURL:]): (-[WebIconDatabase releaseIconForSiteURL:]): (-[WebIconDatabase delayDatabaseCleanup]): (-[WebIconDatabase allowDatabaseCleanup]): (-[WebIconDatabase _iconDictionariesAreGood]): (-[WebIconDatabase _loadIconDictionaries]): (-[WebIconDatabase _updateFileDatabase]): (-[WebIconDatabase _hasIconForSiteURL:]): (-[WebIconDatabase _iconsForIconURLString:]): (-[WebIconDatabase _iconForFileURL:withSize:]): (-[WebIconDatabase _setIcon:forIconURL:]): (-[WebIconDatabase _setIconURL:forSiteURL:]): (-[WebIconDatabase _retainIconForIconURLString:]): (-[WebIconDatabase _releaseIconForIconURLString:]): (-[WebIconDatabase _retainFutureIconForSiteURL:]): (-[WebIconDatabase _releaseFutureIconForSiteURL:]): (-[WebIconDatabase _releaseOriginalIconsOnDisk]): (-[WebIconDatabase _sendNotificationForSiteURL:]): (-[WebIconDatabase _addObject:toSetForKey:inDictionary:]): (-[WebIconDatabase _largestIconFromDictionary:]): (-[WebIconDatabase _iconsBySplittingRepresentationsOfIcon:]): (-[WebIconDatabase _iconFromDictionary:forSize:cache:]): (-[WebIconDatabase _scaleIcon:toSize:]):
  • Misc.subproj/WebIconDatabasePrivate.h:
  • WebKit.exp:
  • WebView.subproj/WebDataSourcePrivate.m: (-[WebDataSource _loadIcon]):

WebBrowser:

  • Removed old scripting code.
  • Removed code that installed built-in icons.
  • AppController.m: (-[AppController awakeFromNib]):
  • Scripting.subproj/Scripting.h: Removed.
  • Scripting.subproj/Scripting.m: Removed.
  • WebBrowser.pbproj/project.pbxproj:
2:19 PM Changeset in webkit [2832] by rjw
  • 6 edits in trunk/WebKit

Fixed rendering issues associated with 3100120.
We now correctly map surrogate pairs in UTF-16. khtml still has
issues dealing with characters outside BMP. These are tracked
with 3109251 and 3109258.

Surrogate pairs are treated as exceptions and have their own character
to glyph map.

  • Misc.subproj/WebUnicode.h:
  • Misc.subproj/WebUnicode.m: (shapedString):
  • WebCoreSupport.subproj/WebTextRenderer.h:
  • WebCoreSupport.subproj/WebTextRenderer.m: (glyphForUnicodeCharacter): (findLengthOfCharacterCluster): (-[WebTextRenderer substituteFontForString:]): (-[WebTextRenderer convertUnicodeCharacters:length:toGlyphs:]): (-[WebTextRenderer _floatWidthForCharacters:stringLength:fromCharacterPosition:numberOfCharacters:withPadding:applyRounding:attemptFontSubstitution:widths:fonts:glyphs:numGlyphs:letterSpacing:wordSpacing:]): (-[WebTextRenderer extendUnicodeCharacterToGlyphMapToInclude:]): (-[WebTextRenderer extendCharacterToGlyphMapToInclude:]):
1:28 PM Changeset in webkit [2831] by darin
  • 15 edits
    20 adds in trunk/WebCore
  • started checking in all our generated source files for the benefit of B&I
  • .cvsignore:
  • WebCore-combined.exp: Added.
  • khtml/css/.cvsignore:
  • khtml/css/cssproperties.c: Added.
  • khtml/css/cssproperties.h: Added.
  • khtml/css/cssvalues.c: Added.
  • khtml/css/cssvalues.h: Added.
  • khtml/ecma/.cvsignore:
  • khtml/ecma/kjs_css.lut.h: Added.
  • khtml/ecma/kjs_dom.lut.h: Added.
  • khtml/ecma/kjs_events.lut.h: Added.
  • khtml/ecma/kjs_html.lut.h: Added.
  • khtml/ecma/kjs_navigator.lut.h: Added.
  • khtml/ecma/kjs_range.lut.h: Added.
  • khtml/ecma/kjs_traversal.lut.h: Added.
  • khtml/ecma/kjs_views.lut.h: Added.
  • khtml/ecma/kjs_window.lut.h: Added.
  • khtml/html/.cvsignore:
  • khtml/html/kentities.c: Added.
  • khtml/misc/.cvsignore:
  • khtml/misc/htmlattrs.c: Added.
  • khtml/misc/htmlattrs.h: Added.
  • khtml/misc/htmltags.c: Added.
  • khtml/misc/htmltags.h: Added.
  • kwq/.cvsignore:
  • kwq/KWQCharsetData.c: Added.
1:13 PM Changeset in webkit [2830] by sullivan
  • 4 edits in trunk/WebKit

WebKit:

  • Resources/url_icon.tiff: new generic URL icon -- little blue globe, pretty nice
  • WebKit.exp: removed symbol for WebTextRendererFactory which was in here to support an obsolete SPI hack

WebBrowser:

  • fixed 3104765 -- Use plain metal for bookmarks toolbar
  • fixed 3104766 -- Implement new highlighting for bookmarks toolbar
  • fixed 3108323 -- Dragging a toolbar bookmark can cause others to flash their mouseover highlight
  • new preference icons
  • BrowserNSStringExtras.h:
  • BrowserNSStringExtras.m: (-[NSString drawDoubledInRect:withTopColor:bottomColor:font:centered:flipped:]): new method that encapsulates the double-text-draw used by the status bar. Now it's needed for FavoriteButtons too.
  • EtchedStringView.m: (-[EtchedStringView drawRect:]): Now uses -[NSString drawDoubledInRect:etc]
  • FavoriteButton.h:
  • FavoriteButton.m: (-[FavoriteButton setBookmark:]): (-[FavoriteButton drawRolloverBackgroundImage]): (-[FavoriteButton drawPressedBackgroundImage]): (-[FavoriteButton drawDragBackgroundImage]): (-[FavoriteButton drawRect:]): (-[FavoriteButton drawForDraggingImageInRect:]): (-[FavoriteButton mouseDown:]): (-[FavoriteButton setIsMouseOver:]): reworked all the drawing code to draw background with _NSDrawThreePartImage instead of filled circles and rectangles, to match the new design from HI. Also, don't do rollover drawing if mouse is down (fixes 3108323)
  • FavoriteButtonCell.h:
  • FavoriteButtonCell.m: (+[FavoriteButtonCell bottomColorForDarkText]): (+[FavoriteButtonCell topColorForDarkText]): (+[FavoriteButtonCell bottomColorForLightText]): (+[FavoriteButtonCell topColorForLightText]): (-[FavoriteButtonCell drawInteriorWithFrame:inView:]): (-[FavoriteButtonCell setDrawsLightText:]): (-[FavoriteButtonCell drawsLightText]): reworked all the drawing code to use -[NSString drawDoubledInRect:etc], to match the new design from HI
  • FavoritesBarView.h:
  • FavoritesBarView.m: (-[FavoritesBarView awakeFromNib]): removed code to use a special background pattern
  • Preferences.subproj/AppearancePreferences.tiff:
  • Preferences.subproj/BookmarkPreferences.tiff:
  • Preferences.subproj/SecurityPreferences.tiff: new icons (GeneralPreferences.tiff is unchanged)
  • Preferences.subproj/English.lproj/GeneralPreferences.nib: final (ha!) set of tweaks from HI
  • Preferences.subproj/GeneralPreferences.m: (-[GeneralPreferences moduleWasInstalled]): tweaked; removed obsolete comment
  • Resources/Images/FavoriteDrag_Caps.tif: Added.
  • Resources/Images/FavoriteDrag_Middle.tif: Added.
  • Resources/Images/FavoritePressed_Caps.tif: Added.
  • Resources/Images/FavoritePressed_Middle.tif: Added.
  • Resources/Images/FavoriteRollover_Caps.tif: Added.
  • Resources/Images/FavoriteRollover_Middle.tif: Added.
  • Resources/Images/FavoritesBarClipIndicator.tiff:
  • Resources/Images/FavoritesFolderArrow.tif:
  • Resources/Images/FavoritesFolderArrowWhite.tif: Added.
  • WebBrowser.pbproj/project.pbxproj: updated for new files
11:35 AM Changeset in webkit [2829] by trey
  • 6 edits in trunk/WebKit

WebKit:

Added more detailed notifications on history changes.
All changes below are just posting the new notes at the right time.

  • English.lproj/StringsNotToBeLocalized.txt:
  • History.subproj/WebHistory.h:
  • History.subproj/WebHistory.m: (-[WebHistory _sendNotification:entries:]): (-[WebHistory addEntry:]): (-[WebHistory removeEntry:]): (-[WebHistory removeEntries:]): (-[WebHistory removeAllEntries]): (-[WebHistory addEntries:]): (-[WebHistory loadHistory]):
  • WebKit.exp:

WebBrowser:

Autocomplete is working with a decent DB behind it. We use a Patricia tree with the added
capability of enumerating forward from a cursor.

Things that work at this point:

  • Anything in your history or bookmarks (except from AB or Rendezvous) is findable
  • autocomplete DB tracks changes to history
  • results are ordered lexographically (not fancy, but at least the shortest things are first)

Here's what's getting fixed next:

  • Matching doesn't work if you type ​http:// or www. as part of your partial string (we only match ignoring the boilerplate).
  • Changes to bookmarks are not reflected in the autocomplete DB
  • Results will be ranked so the one you want is always the first one selected, like it's reading your mind.
  • Reduce conversions from NString to NSURL to NSString to NSURL to...
  • BrowserWindowController.m: (-[BrowserWindowController windowDidLoad]): Re-enable feature.
  • CompletionController.m: (leftPointsUpward): Patricia utility function. (rightPointsUpward): Patricia utility function. (leftmostChild): Patricia utility function. (+[CompletionController _tree_create]): Initialize the root node. (destroyTree): recursively free up the tree (+[CompletionController _tree_destroy]): Free the tree. (_bitOfString): Patricia utility function. (_leftmostBitOfUnichar): Patricia utility function. (_leftmostDiffBit): Patricia utility function. (_stringFromKey): Extract the string we index from an item we put in the db (calls _cookedURLString) (_findInsertionPoint): Search the tree for place we would insert a node. (_findPotentialNode): Search for a match in the tree. (+[CompletionController _tree_addItem:]): Add an item. (+[CompletionController _tree_deleteItem:]): Delete an item. (+[CompletionController _tree_findItem:cursor:]): Find and item, setting cursor. (+[CompletionController _tree_nextItemUsingCursor:]): Get next item. (+[CompletionController _tree_setCursorAtStart:]): Set cursor (only for debug now) (DumpAutoCompleteTree): Debugding dump. (_cookedURLString): Strips off boilerplate like "​http://www." from a URL (+[CompletionController _addBookmarkTree:]): Recursively adds bookmarks to the tree. (+[CompletionController _loadDB]): Adds bookmarks and history to the tree. (-[CompletionController _executeQuery]): Looks up a result set given a user's partial string. (+[CompletionController _registerForNotifications]): Listen for history changes. (+[CompletionController _historyAdded:]): Update db on history change. (+[CompletionController _historyRemoved:]): Update db on history change. (+[CompletionController _reloadDB:]): Update db on history change. (-[CompletionController _buildUI]): Make popdown window slightly transparent. (-[CompletionController _reflectSelectedRow]): Properly add completion text to user's partial text. ("​http://www." no longer hardwired) (-[CompletionController tableView:objectValueForTableColumn:row:]): Handle bookmarks as well as WebHistoyItems.
  • GlobalHistory.m: (-[GlobalHistory _registerForHistoryNotifications]): Register for new WebHistory notifications.
11:03 AM Changeset in webkit [2828] by hyatt
  • 7 edits in trunk/WebCore

Fix for the table/form regressions. Also landing beginnings
of the block/inline work.

  • khtml/html/html_tableimpl.cpp: (HTMLTableSectionElementImpl::addChild):
  • khtml/html/html_tableimpl.h:
  • khtml/rendering/render_flow.cpp: (RenderFlow::RenderFlow):
  • khtml/rendering/render_flow.h:
11:00 AM Changeset in webkit [2827] by rjw
  • 4 edits in trunk/WebKit

Changed NSString category methods to include _web_ prefix.

  • Misc.subproj/WebKitNSStringExtras.h:
  • Misc.subproj/WebKitNSStringExtras.m: (-[NSString _web_widthForString:font:]):

Changed NSString category methods to include _web_ prefix.

  • EtchedStringView.m: (-[EtchedStringView drawRect:]):
10:48 AM Changeset in webkit [2826] by rjw
  • 3 edits
    2 adds in trunk/WebKit

Changed to use simplified SPI. Drawing and measuring using
WebKit's text renderer are provided as category methods
on NSString.

  • EtchedStringView.m: (-[EtchedStringView drawRect:]):

Simplified drawing and measuring SPI for use by Alex.

  • Misc.subproj/WebKitNSStringExtras.h: Added.
  • Misc.subproj/WebKitNSStringExtras.m: Added. (-[NSString widthForString:font:]):
  • WebKit.pbproj/project.pbxproj:
1:47 AM Changeset in webkit [2825] by mjs
  • 4 edits in trunk/JavaScriptCore
  • reduce cell size to 56 bytes from 64, now that nearly all objects fit in that size. .5% speed gain and probably some footprint gain.
  • kjs/collector.cpp: Change CELL_SIZE from 64 to 56.
1:04 AM Changeset in webkit [2824] by darin
  • 21 edits in trunk

JavaScriptCore:

  • change ScopeChain to be a singly linked list shares tails, gives 11% gain on iBench
  • kjs/context.h: (ContextImp::pushScope): Make inline, use push instead of prepend, and pass imp pointer. (ContextImp::popScope): Make inline, use pop instead of removeFirst.
  • kjs/function.cpp: (DeclaredFunctionImp::DeclaredFunctionImp): No need to copy.
  • kjs/function_object.cpp: (FunctionObjectImp::construct): Use push instead of prepend, and pass imp pointer.
  • kjs/internal.cpp: (ContextImp::ContextImp): Use clear, push instead of prepend, and pass imp pointers.
  • kjs/nodes.cpp: (ResolveNode::evaluateReference): Use isEmpty, pop, and top instead of ScopeChainIterator.
  • kjs/object.h: Change _scope to be a NoRefScopeChain.
  • kjs/object.cpp: No need to initialize _scope any more, since it's not a NoRefScopeChain.
  • kjs/scope_chain.h: Rewrite, different implementation and interface.
  • kjs/scope_chain.cpp: More of the same.

WebCore:

  • khtml/ecma/kjs_dom.cpp: (DOMNode::pushEventHandlerScope): Change to push handlers on an existing scope chain rather than returning one. Name change too.
  • khtml/ecma/kjs_dom.h: More of the same.
  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::pushEventHandlerScope): And here.
  • khtml/ecma/kjs_html.h: And here.
  • khtml/ecma/kjs_events.cpp: (JSEventListener::handleEvent): Use the pushEventHandlerScope function, and also don't worry about optimizing the "no change" case, because that already works pretty efficiently.
12:48 AM Changeset in webkit [2823] by hyatt
  • 7 edits in trunk/WebCore

Fix for the weather.com, slate and espn malformations that
could occur. Also reverting an earlier change for handling
font tags like other inlines. Both FONT and A need to be
given special treatment until I can implement a strategy that
will allow them to be handled just like the other inlines.

  • khtml/html/dtd.cpp: (DOM::checkChild):
  • khtml/html/html_elementimpl.cpp: (HTMLElementImpl::isInline):
  • khtml/html/html_elementimpl.h:
  • khtml/xml/dom_nodeimpl.h:
12:13 AM Changeset in webkit [2822] by mjs
  • 4 edits in trunk/JavaScriptCore
  • a simple change for .4% gain on ibench - instead of unmarking all objects at the start of collection, instead unmark as part of the sweep phase
  • kjs/collector.cpp: (Collector::collect): Remove separate unmarking pass and instead unmark the objects that don't get collected during the sweep phase.
Note: See TracTimeline for information about the timeline view.