Timeline

Aug 27, 2004:

5:31 PM Changeset in webkit [7396] by mjs

• 6 edits
  7 adds in trunk

Reviewed by Chris.

• fixed <rdar://problem/3778043> REGRESSION: innerHTML is broken, breaks automated iBench testing
• also fixed outerHTML, which would spill over past the node for whch it was supposed to get HTML

• khtml/html/html_elementimpl.cpp: (HTMLElementImpl::outerHTML):
• khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML):
• khtml/xml/dom_nodeimpl.cpp: (NodeImpl::toHTML): (NodeImpl::recursive_toString): (NodeImpl::recursive_toHTML):
• khtml/xml/dom_nodeimpl.h:
• kwq/WebCoreBridge.mm: (-[WebCoreBridge markupStringFromNode:nodes:]):

• added new layout tests to cover the problems I fixed

• layout-tests/fast/innerHTML/001-expected.txt: Added.
• layout-tests/fast/innerHTML/001.html: Added.
• layout-tests/fast/innerHTML/002-expected.txt: Added.
• layout-tests/fast/innerHTML/002.html: Added.
• layout-tests/fast/innerHTML/003-expected.txt: Added.
• layout-tests/fast/innerHTML/003.html: Added.

5:07 PM Changeset in webkit [7395] by hyatt

• 1 edit in trunk/WebCore/khtml/css/css_computedstyle.cpp

* empty log message *

5:06 PM Changeset in webkit [7394] by hyatt

• 3 edits in trunk/WebCore

Fix for 3739239, getComputedStyle of top not being implemented broke a site that checked for it.

Reviewed by kocienda

• khtml/css/css_computedstyle.cpp: (DOM::valueForLength): (DOM::CSSComputedStyleDeclarationImpl::getPositionOffsetValue): (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue):
• khtml/css/css_computedstyle.h:

3:39 PM Changeset in webkit [7393] by sullivan

• 2 edits in trunk/WebCore

Reviewed by Ken.

Tweaked option-tab handling to match good suggestion from Tim Omernick of OmniWeb

• kwq/KWQTextArea.mm: removed override of textDidChange: (-[KWQTextAreaTextView keyDown:]): moved option-tab handling that was in textDidChange to here. Rearranged existing code a little for clarity.

3:03 PM Changeset in webkit [7392] by adele

• 2 adds in trunk/LayoutTests/fast/frames

Adding layout test for contentWindow for iframe

2:52 PM Changeset in webkit [7391] by adele

• 6 edits in trunk/WebCore

Reviewed by Darin.

Fix for:
<rdar://problem/3689949> Provide contentWindow access on an iframe

• khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getValueProperty): added cases for contentWindow for frames and iframes
• khtml/ecma/kjs_html.h: added contentWindow to the list of properties for frames and iframes
• khtml/ecma/kjs_html.lut.h: regenerated file
• khtml/html/html_baseimpl.cpp: (HTMLFrameElementImpl::contentPart): factored out old contentDocument code to return KHTMLPart for frame (HTMLFrameElementImpl::contentDocument): now just gets the contentDocument from contentPart
• khtml/html/html_baseimpl.h: added declaration for contentPart

12:07 PM Changeset in webkit [7390] by kocienda

• 2 edits in trunk/WebKit

Reviewed by Chris

Fix for this bug:

<rdar://problem/3756997> WebKit aggressive in making pasted text into a URL, even when it's not much like a URL

• WebView.subproj/WebHTMLView.m: (-[WebHTMLView _documentFragmentFromPasteboard:allowPlainText:]): Don't try so hard to coerce data on the pasteboard into a URL, and do not make an anchor with an href for any URLs that are explicitly present on the pasteboard. Also, move URL pasteboard type check beneath the RTF checks.

11:59 AM Changeset in webkit [7389] by vicki

• 3 edits in trunk

back to 2.0, v162u for tip of tree

11:49 AM Changeset in webkit [7388]

• 3 copies in tags/Safari-161

This commit was manufactured by cvs2svn to create tag 'Safari-161'.

11:49 AM Changeset in webkit [7387] by vicki

• 6 edits in trunk

Safari-161 stamp

10:26 AM Changeset in webkit [7386] by kocienda

• 2 edits in trunk/WebCore

Reviewed by Darin

Fix for this bug:

<rdar://problem/3778059> Odd behaviour when editing between blockquote elements

• khtml/editing/htmlediting_impl.cpp: (khtml::CompositeEditCommandImpl::deleteUnrenderedText): This function should not move the selection out of the current block, ever. This is exactly what the bug reported. What was I thinking? Now, the code looks at the passed-in position and then the equivalent upstream and downstream positions to see if the selection can be placed there after the delete, and settles on the block containing the passed-in position as a fallback.
• layout-tests/editing/inserting/insert-3778059-fix-expected.txt: Added.
• layout-tests/editing/inserting/insert-3778059-fix.html: Added.