⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Aug 30, 2004:

5:49 PM Changeset in webkit [7409] by darin
  • 10 edits
    1 delete in trunk

WebCore:

Reviewed by John.

  • fixed <rdar://problem/3637519> REGRESSION (125-128): unrepro crash in QListBox::sizeForNumberOfLines at istweb.apple.com
  • kwq/KWQListBox.h: Added a clearCachedTextRenderers function.
  • kwq/KWQListBox.mm: (itemTextRenderer): Change to use globals that are outside the function, and added retain calls. (groupLabelTextRenderer): Ditto. (QListBox::clearCachedTextRenderers): Release global text renderers and nil out the globals.
  • kwq/WebCoreBridge.h: Removed updateAllViews; not needed any more.
  • kwq/WebCoreBridge.mm: Ditto.
  • kwq/WebCoreTextRendererFactory.h: Added a clearCaches method.
  • kwq/WebCoreTextRendererFactory.mm: (-[WebCoreTextRendererFactory clearCaches]): Added. Tells all the views to repaint after clearing the cached text renderers from KWQListBox. To be more elegant, we could generalize the KWQListBox trick, but for now why bother?
  • kwq/WebCoreTextRendererFactory.m: Removed. I needed to put some C++ code in here, so changed the extension to .mm.
  • WebCore.pbproj/project.pbxproj: Removed WebCoreTextRendererFactory.m, and added WebCoreTextRendererFactory.mm.

WebKit:

Reviewed by John.

  • part of fix for <rdar://problem/3637519> REGRESSION (125-128): unrepro crash in QListBox::sizeForNumberOfLines at istweb.apple.com
  • WebCoreSupport.subproj/WebTextRendererFactory.m: (-[WebTextRendererFactory clearCaches]): Call [super clearCaches].
3:58 PM Changeset in webkit [7408] by darin
  • 2 edits in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3528538> can paste a Return character into the Search field at amazon.com, other browsers won't
  • kwq/KWQTextField.mm: (-[KWQTextFieldController controlTextDidChange:]): Truncate text before the first line break.
3:44 PM Changeset in webkit [7407] by darin
  • 2 edits in trunk/WebCore
  • kwq/KWQTextCodec.mm: (KWQTextDecoder::convertOneChunkUsingTEC): Added some more assertions I used to track down what looks like a TEC bug.
3:36 PM Changeset in webkit [7406] by darin
  • 3 edits in trunk/WebCore

Reviewed by Ken.

  • fixed <rdar://problem/3779122> No accesskey support on LABEL element
  • khtml/html/html_formimpl.h: Change type of m_currValue to DOMString. Should have been done as part of my form data check-in, but harmless to do now. Add accessKeyAction function for HTMLLabelElementImpl.
  • khtml/html/html_formimpl.cpp: (DOM::HTMLButtonElementImpl::parseHTMLAttribute): Remove conversion of DOMString to QString for m_currValue. (DOM::HTMLLabelElementImpl::formElement): If there's no "for" attribute, search children for the first control. (DOM::HTMLLabelElementImpl::accessKeyAction): Forward the accesskey action to the formElement.
2:50 PM Changeset in webkit [7405] by darin
  • 3 edits in trunk/WebCore

Reviewed by Dave.

  • fixed <rdar://problem/3303968> final newline character omitted from <textarea> when parsing a new page
  • khtml/html/htmltokenizer.cpp: (khtml::HTMLTokenizer::processListing): Handle newline pending cases as well as space and tab pending spaces at the end of this function. This seems right for both scripts and text areas; it's not clear why omittiing the LF is ever needed. Tested by running all the layout tests; no regressions.
  • fixed <rdar://problem/3552736> word wrapped text fields that blur/focus when you type move the insertion point strangely (vtext.com)
  • khtml/rendering/render_form.cpp: (RenderTextArea::updateFromElement): Call text() instead of calling widget->text() directly. This prevents this function from running in cases where the text didn't really change for text areas in wrap mode.
2:28 PM Changeset in webkit [7404] by darin
  • 2 edits in trunk/WebCore

Reviewed by Dave.

  • got rid of ERROR message when running layout tests by implementing text-transform in computed style
  • khtml/css/css_computedstyle.cpp: (DOM::numberAsString): Added. Helper that returns "1" rather then "1.0" for integer values. (DOM::CSSComputedStyleDeclarationImpl::getPropertyCSSValue): Fixed use of tabs instead of spaces. Fixed switch statements so they don't use default so we get errors if we leave a case out. Changed callers to use numberAsString instead of QString::number. Added implementation of CSS_PROP_TEXT_TRANSFORM. Added code to prevent falling through to next property when no item in a switch statement matches.
1:35 PM Changeset in webkit [7403] by darin
  • 31 edits
    7 adds in trunk

WebCore:

Reviewed by Chris.

  • did work to prepare for uploading files incrementally when submitting forms
  • khtml/misc/formdata.h: Added. Class for holding form data inside WebCore.
  • khtml/misc/formdata.cpp: Added.
  • khtml/html/html_formimpl.h: Added the FormDataList type, changed the formData function parameters and made it private, renamed the encoding method to appendFormData and changed the parameters around.
  • khtml/html/html_formimpl.cpp: (DOM::FormDataList): Added. Class that replaces the old use of QValueList<QCString> for form data. Later we'll change it to accomodate filenames too. (DOM::HTMLFormElementImpl::formData): Changed code to use FormDataList intsead of the old encodingList. Also changed to return the "OK" result as the function result and put the form data into something passed as an "out" parameter; the old way was the other way around. (DOM::HTMLFormElementImpl::submit): Change to use FormData rather than a QByteArray when getting the form data to submit. (DOM::HTMLButtonElementImpl::appendFormData): Rename from encoding, and use the new appendData function instead of the old way of doing += to put data on the list. (DOM::HTMLInputElementImpl::appendFormData): Ditto. (DOM::HTMLSelectElementImpl::appendFormData): Ditto. (DOM::HTMLKeygenElementImpl::appendFormData): Ditto. (DOM::HTMLTextAreaElementImpl::appendFormData): Ditto. (DOM::FormDataList::FormDataList): Added. (DOM::FormDataList::appendString): Added. (DOM::FormDataList::begin): Added. (DOM::FormDataList::end): Added.
  • khtml/khtml_part.h: Changed the type of the submitForm parameter to FormData instead of QByteArray.
  • khtml/khtmlpart_p.h: Changed the type of the submitFormData data member to FormData instead of QByteArray.
  • khtml/khtml_part.cpp: (KHTMLPart::submitForm): Called the new flattenToString function in all the code that handles mailto forms. Called the new flatten function in the non-Apple code path.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Pass NSArray for form data instead of NSData.
  • kwq/KWQKJob.h: Use FormData instead of QByteArray. A couple other small cleanups.
  • kwq/KWQKJobClasses.h: Ditto.
  • kwq/KWQKJobClasses.mm: (KIO::TransferJobPrivate::TransferJobPrivate): Ditto. (KIO::TransferJob::TransferJob): Ditto. (KIO::TransferJob::postData): Ditto.
  • kwq/KWQKPartsBrowserExtension.h: Ditto.
  • kwq/KWQLoader.mm: (KWQServeRequest): Ditto. (KWQServeSynchronousRequest): Ditto.
  • kwq/KWQFormData.h: Added. A function to convert KHTML form data into an NSArray for communication with the WebKit side.
  • kwq/KWQFormData.mm: Added.
  • kwq/WebCoreBridge.h: Pass NSArray instead of NSData for form data.
  • kwq/KWQArrayImpl.h: Added a detach member function. The old version would do unnecessary work when detach was called on an array that had exactly one reference.
  • kwq/KWQArrayImpl.mm: (KWQArrayImpl::detach): Added.
  • kwq/KWQMemArray.h: (QMemArray::detach): Call through to KWQArrayImpl.
  • kwq/KWQValueList.h: (QValueList::first): Added overload for non-const. (QValueList::last): Ditto.
  • ForwardingHeaders/misc/formdata.h: Added.
  • WebCore.pbproj/project.pbxproj: Added formdata.h, formdata.cpp, KWQFormData.h, and KWQFormData.cpp.
  • WebCore-tests.exp: Updated for changes to QValueList, and re-sorted.
  • WebCore-combined.exp: Regenerated.

WebKit:

Reviewed by Chris.

  • did work to prepare for uploading files incrementally when submitting forms
  • History.subproj/WebHistoryItem.m: (-[WebHistoryItem _setFormInfoFromRequest:]): Use NSArray instead of NSData for form data. (-[WebHistoryItem formData]): Ditto.
  • History.subproj/WebHistoryItemPrivate.h: Ditto.
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge startLoadingResource:withURL:customHeaders:postData:]): Ditto. (-[WebBridge syncLoadResourceWithURL:customHeaders:postData:finalURL:responseHeaders:statusCode:]): Ditto. (-[WebBridge postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
  • WebCoreSupport.subproj/WebSubresourceClient.h: Ditto.
  • WebCoreSupport.subproj/WebSubresourceClient.m: (+[WebSubresourceClient startLoadingResource:withURL:customHeaders:postData:referrer:forDataSource:]): Ditto.
  • WebView.subproj/WebFrame.m: (-[WebFrame _loadItem:withLoadType:]): Ditto. (-[WebFrame _postWithURL:referrer:target:data:contentType:triggeringEvent:form:formValues:]): Ditto.
  • WebView.subproj/WebFramePrivate.h: Ditto.
  • WebView.subproj/WebFormDataStream.h: Added.
  • WebView.subproj/WebFormDataStream.m: (-[WebFormDataStream initWithFormDataArray:]): Placeholder; not done yet. (-[WebFormDataStream formDataArray]): Ditto.
  • WebKit.pbproj/project.pbxproj: Added WebFormDataStream files.
11:00 AM Changeset in webkit [7402] by darin
  • 4 edits in trunk/WebCore

Reviewed by Ken.

  • improved multiple submit logic in preparation for making command-click on a form button load a form in another frame
  • kwq/KWQKHTMLPart.h: Added const to a bunch of member functions for cleanup. Added prepareForUserAction member function.
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::submitForm): Simplified logic and removed special case for "http" and "https". (KWQKHTMLPart::renderer): Added const. (KWQKHTMLPart::keyEvent): Added call to prepareForUserAction. (KWQKHTMLPart::lastEventIsMouseUp): Added const. (KWQKHTMLPart::eventMayStartDrag): Added const. (KWQKHTMLPart::mouseDown): Added call to prepareForUserAction. (KWQKHTMLPart::overrideMediaType): Added const. (KWQKHTMLPart::canGoBackOrForward): Added const. (KWQKHTMLPart::prepareForUserAction): Added. Clears _submittedFormURL.
  • kwq/KWQAccObject.mm: (-[KWQAccObject accessibilityPerformAction:]): Added call to prepareForUserAction.
10:43 AM Changeset in webkit [7401] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by John

Fix for this bug:

<rdar://problem/3762231> REGRESSION (Mail): tab key inserts a single space

  • khtml/editing/htmlediting_impl.cpp: (khtml::isTab): New helper. Checks a DOMString to see if it is one character and that character is a tab. (khtml::InputTextCommandImpl::execute): Trap tabs before handling insertion of other kinds of whitespace. Treat a tab like four spaces. Rearrange the code to update the ending position after the text insertion to cover the new tab case where the amount of advance is not the same as the number of character in the passed-in DOMString (i.e. tabs expand to four characters).
10:39 AM Changeset in webkit [7400] by sullivan
  • 4 edits in trunk/WebKit

Reviewed by Ken.

  • WebKit part of fix for <rdar://problem/3607720> myFrame.print() prints the window but should only print the frame
  • WebView.subproj/WebUIDelegatePrivate.h: declare new delegate method that includes which frame to print
  • WebView.subproj/WebDefaultUIDelegate.m: (-[WebDefaultUIDelegate webView:printFrameView:]): implement default (no-op) version of new delegate method
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge print]): call new delegate method if available, otherwise call old delegate method, for backward compatibility.
8:38 AM Changeset in webkit [7399] by kocienda
  • 2 edits in trunk/WebKit

Reviewed by John.
Checked in by Ken

Ken comments: It looks like Maciej forgot to land this when he checked in the
WebCore portion of this change.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canGoBackOrForward:]):
8:13 AM Changeset in webkit [7398] by kocienda
  • 4 edits in trunk/WebCore

Reviewed by Chris

Fix for this bug:

<rdar://problem/3779706> plain text on pasteboard loses indentation when pasted into Blot

  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::documentFragmentWithText): New function that takes over the code from KWQKHTMLPart and improves it to handle converting tabs and spaces for suitable display in HTML.
  • kwq/WebCoreBridge.mm: (-[WebCoreBridge documentFragmentWithText:]): Move smarts from here to KWQKHTMLPart.

Aug 29, 2004:

2:47 PM Changeset in webkit [7397] by mjs
  • 6 edits in trunk/WebCore

Reviewed by John.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

  • khtml/khtml_part.cpp: (KHTMLPart::scheduleHistoryNavigation):
  • kwq/KWQKHTMLPart.h:
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::canGoBackOrForward):
  • kwq/KWQKPartsBrowserInterface.h:
  • kwq/WebCoreBridge.h:
Note: See TracTimeline for information about the timeline view.