⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Sep 1, 2004:

5:58 PM Changeset in webkit [7432] by adele
  • 3 adds in trunk/LayoutTests/fast/frames

Adding layout test for contentWindow for frames

4:49 PM Changeset in webkit [7431] by rjw
  • 2 edits in trunk/JavaScriptCore

Add pid to exception messages (to help debug dashboard clients).

Reviewed by Chris.

  • kjs/interpreter.cpp: (Interpreter::evaluate):
3:53 PM Changeset in webkit [7430] by rjw
  • 2 edits in trunk/WebCore

Fixed panther build glitch.

Reviewed by Ken.

  • khtml/ecma/kjs_html.cpp:
3:17 PM Changeset in webkit [7429] by cblu
  • 2 edits in trunk/WebKit

Fixed deployment build failure.

  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]):
12:38 PM Changeset in webkit [7428] by rjw
  • 4 edits in trunk/WebCore

WebCore:

Finished implementation of gradient support in <canvas>.

Reviewed by John.

  • khtml/ecma/kjs_html.cpp: (KJS::HTMLElementFunction::tryCall): (isGradient): (isImagePattern): (KJS::Context2DFunction::tryCall): (Context2D::putValue): (Context2D::Context2D): (KJS::GradientFunction::tryCall): (gradientCallback): (Gradient::commonInit): (Gradient::Gradient): (Gradient::~Gradient): (Gradient::getShading): (Gradient::addColorStop): (sortStops): (Gradient::colorStops):
  • khtml/ecma/kjs_html.h: (KJS::ColorStop::ColorStop):
  • khtml/ecma/kjs_html.lut.h: (KJS::):

Tests:

Test page for gradients usage in the <canvas>.

Reviewed by John.

  • html/canvas_gradient.html: Added.
  • html/gibson.jpg: Added.
11:22 AM Changeset in webkit [7427] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3784686, hidden links still active. Make sure text nodes exclude themselves from nodeAtPoint checks
when hidden.

  • khtml/rendering/render_text.cpp: (RenderText::nodeAtPoint):
10:29 AM Changeset in webkit [7426] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

Add layout tests.

10:19 AM Changeset in webkit [7425] by hyatt
  • 3 edits in trunk/WebCore

Fixes for 3761411 and 3782201. This patch makes two changes to percentage heights. First it makes sure that
replaced elements always flex inside a cell (unlike blocks and tables, which do so only sometimes under bizarre
conditions that are still being guessed at by me). The second fix is a recognition that empty tables do not
actually honor their heights, and so it is a mistake to try to flex them.

Reviewed by mjs

  • khtml/rendering/render_table.cpp: (RenderTableSection::layoutRows):
  • khtml/rendering/render_table.h: (khtml::RenderTable::hasSections):

Aug 31, 2004:

3:12 PM Changeset in webkit [7424] by cblu
  • 7 edits in trunk/WebKit

Fixed:
<rdar://problem/3699498> Context menu for editable WebViews should provide items like Cut and Paste
<rdar://problem/3781535> REGRESSION (Mail): no context menu after ctrl-clicking a misspelled word

Reviewed by kocienda.

  • English.lproj/Localizable.strings:
  • WebView.subproj/WebDefaultContextMenuDelegate.m: (-[WebDefaultUIDelegate menuItemWithTag:]): updated to handle new menu items (-[WebDefaultUIDelegate contextMenuItemsForElement:]): renamed from webView:contextMenuItemsForElement:defaultMenuItems: (-[WebDefaultUIDelegate editingContextMenuItemsForElement:]): new (-[WebDefaultUIDelegate webView:contextMenuItemsForElement:defaultMenuItems:]): moved, now call contextMenuItemsForElement: or editingContextMenuItemsForElement:
  • WebView.subproj/WebDefaultUIDelegate.h:
  • WebView.subproj/WebHTMLView.m: (-[WebHTMLView _isSelectionMisspelled]): new (-[WebHTMLView _guessesForMisspelledSelection]): new (-[WebHTMLView _changeSpellingFromMenu:]): new (-[WebHTMLView _ignoreSpellingFromMenu:]): new (-[WebHTMLView _learnSpellingFromMenu:]): new
  • WebView.subproj/WebHTMLViewPrivate.h:
  • WebView.subproj/WebUIDelegate.h:
2:58 PM Changeset in webkit [7423] by darin
  • 2 edits in trunk/WebKit
  • fixed B&I build failure
  • WebView.subproj/WebHTMLView.m: (-[WebTextCompleteController _buildUI]): Work around unwanted warning by adding a cast.
2:31 PM Changeset in webkit [7422] by kocienda
  • 2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3781572> can't paste text in replied message view

  • khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::toHTML): Copying text placed in an anonymous block was failing since the code in here depending on the text node's containing block having an element, which it won't. In fact, using containing block is wrong anyway, since positioned elements can have containing blocks far from where they live in the tree. This "move up to block check" should use the more DOM-wise enclosingBlockFlowElement() in NodeImpl.
1:18 PM Changeset in webkit [7421] by mjs
  • 1 edit in trunk/WebKit/ChangeLog

Reviewed by John.

<rdar://problem/3778314> REGRESSION: Can't proceed to survey questions on Lominger's Apple website

Because we will stop parsing when there is a pending redirection,
avoid setting one if no navigation would actually take place
because the number of steps is out of range.

  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge canGoBackOrForward:]):
9:58 AM Changeset in webkit [7420] by hyatt
  • 2 adds in trunk/LayoutTests/fast/table

* empty log message *

9:49 AM Changeset in webkit [7419] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3742585, sony dhtml menus wrong size. The percentage table height algorithm was wrong. This patch
unifies the table percentage height algorithm with the block percentage height algorithm and fixes bugs in
both.

Reviewed by john

  • khtml/rendering/render_box.cpp: (RenderBox::calcPercentageHeight):
  • khtml/rendering/render_table.cpp: (RenderTable::layout):
9:39 AM Changeset in webkit [7418] by kocienda
  • 2 edits
    16 adds in trunk

Reviewed by me

Added more editing layout tests.

  • layout-tests/editing/deleting/delete-tab-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-tab-001.html: Added.
  • layout-tests/editing/deleting/delete-tab-002-expected.txt: Added.
  • layout-tests/editing/deleting/delete-tab-002.html: Added.
  • layout-tests/editing/deleting/delete-tab-003-expected.txt: Added.
  • layout-tests/editing/deleting/delete-tab-003.html: Added.
  • layout-tests/editing/deleting/delete-tab-004-expected.txt: Added.
  • layout-tests/editing/deleting/delete-tab-004.html: Added.
  • layout-tests/editing/editing.js: Fixed a little bug in one of the "delayed" commands.
  • layout-tests/editing/inserting/insert-tab-001-expected.txt: Added.
  • layout-tests/editing/inserting/insert-tab-001.html: Added.
  • layout-tests/editing/inserting/insert-tab-002-expected.txt: Added.
  • layout-tests/editing/inserting/insert-tab-002.html: Added.
  • layout-tests/editing/inserting/insert-tab-003-expected.txt: Added.
  • layout-tests/editing/inserting/insert-tab-003.html: Added.
  • layout-tests/editing/inserting/insert-tab-004-expected.txt: Added.
  • layout-tests/editing/inserting/insert-tab-004.html: Added.
9:29 AM Changeset in webkit [7417] by kocienda
  • 3 edits in trunk

Reviewed by John

Fix for this bug:

<rdar://problem/3782521> Typing newline at start of block does not work

  • khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply): Change handling of case to insert newline at the start of a block.
  • layout-tests/editing/inserting/insert-br-006-expected.txt: Updated layout test with new results.
9:04 AM Changeset in webkit [7416] by kocienda
  • 1 edit in trunk/WebCore/khtml/editing/htmlediting_impl.cpp

Checked this in by mistake, rolling back

8:57 AM Changeset in webkit [7415] by kocienda
  • 2 edits in trunk/WebCore

ChangeLog

8:56 AM Changeset in webkit [7414] by kocienda
  • 3 edits in trunk

Reviewed by NOBODY (OOPS!).

  • khtml/editing/htmlediting_impl.cpp: (khtml::InputNewlineCommandImpl::doApply):
  • layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
  • layout-tests/editing/selection/move-by-line-001-expected.txt:
8:41 AM Changeset in webkit [7413] by kocienda
  • 2 edits
    10 adds in trunk

Reviewed by me

Added more editing layout tests.

  • layout-tests/editing/deleting/collapse-whitespace-3587601-fix-expected.txt: Added.
  • layout-tests/editing/deleting/collapse-whitespace-3587601-fix.html: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-001-expected.txt: Added.
  • layout-tests/editing/deleting/delete-block-merge-contents-001.html: Added.
  • layout-tests/editing/editing.js: Added some more navigation commands.
  • layout-tests/editing/inserting/insert-3778059-fix-expected.txt: Added.
  • layout-tests/editing/inserting/insert-3778059-fix.html: Added.
  • layout-tests/editing/selection/move-by-line-001-expected.txt: Added.
  • layout-tests/editing/selection/move-by-line-001.html: Added.
  • layout-tests/editing/style/typing-style-003-expected.txt: Added.
  • layout-tests/editing/style/typing-style-003.html: Added.
8:27 AM Changeset in webkit [7412] by kocienda
  • 1 edit
    14 adds
    8 deletes in trunk

Reviewed by me

Added more editing layout tests. Renamed some others.

  • layout-tests/editing/inserting/insert-br-001-expected.txt: Added.
  • layout-tests/editing/inserting/insert-br-001.html: Added.
  • layout-tests/editing/inserting/insert-br-002-expected.txt: Added.
  • layout-tests/editing/inserting/insert-br-002.html: Added.
  • layout-tests/editing/inserting/insert-br-003-expected.txt: Added.
  • layout-tests/editing/inserting/insert-br-003.html: Added.
  • layout-tests/editing/inserting/insert-br-004-expected.txt: Added.
  • layout-tests/editing/inserting/insert-br-004.html: Added.
  • layout-tests/editing/inserting/insert-br-005-expected.txt: Added.
  • layout-tests/editing/inserting/insert-br-005.html: Added.
  • layout-tests/editing/inserting/insert-br-006-expected.txt: Added.
  • layout-tests/editing/inserting/insert-br-006.html: Added.
  • layout-tests/editing/inserting/insert-br-case1-expected.txt: Removed.
  • layout-tests/editing/inserting/insert-br-case1.html: Removed.
  • layout-tests/editing/inserting/insert-br-case2-expected.txt: Removed.
  • layout-tests/editing/inserting/insert-br-case2.html: Removed.
  • layout-tests/editing/inserting/insert-br-case3-expected.txt: Removed.
  • layout-tests/editing/inserting/insert-br-case3.html: Removed.
  • layout-tests/editing/inserting/insert-br-case6-expected.txt: Removed.
  • layout-tests/editing/inserting/insert-br-case6.html: Removed.
  • layout-tests/editing/inserting/insert-text-with-newlines-expected.txt: Added.
  • layout-tests/editing/inserting/insert-text-with-newlines.html: Added.
8:14 AM Changeset in webkit [7411] by kocienda
  • 2 edits in trunk

Reviewed by me

  • layout-tests/editing/editing.js: Modified typeCharacterCommand so it can accept a character as an argument.
8:02 AM Changeset in webkit [7410] by kocienda
  • 25 edits in trunk

Reviewed by Hyatt

Fix for these bugs:

<rdar://problem/3777629> REGRESSION (Mail): can't delete blank lines in quoted text in HTML mail replies
<rdar://problem/3780309> REGRESSION (Mail): can't delete past an empty span in a particular test case
<rdar://problem/3780315> REGRESSION (Mail): right arrow works incorrectly in a particular test case with an empty span
<rdar://problem/3780320> REGRESSION (Mail): left arrow works incorrectly in a particular test case with an empty span
<rdar://problem/3780336> REGRESSION (Mail): down arrow fails in a reduction of a Mail reply test case (seems to be inside a span)

  • khtml/xml/dom_position.cpp: (DOM::Position::upstream): If this position's node is a block, use it for the StayInBlock case, not the block's enclosing block. (DOM::Position::downstream): Ditto. (DOM::Position::inRenderedContent): Refine the case for non-text nodes. This was erroneously returning true for any empty element (like <span></span>).
  • khtml/xml/dom_positioniterator.cpp: Change the following four functions to consider all nodes, not just leaves of the DOM tree. This is a step towards making this iteration less cranky and unpredictable, and was necessary to do now to keep the inRenderedContent() change above from breaking editign layout tests. (DOM::PositionIterator::peekPrevious) (DOM::PositionIterator::peekNext) (DOM::PositionIterator::atStart) (DOM::PositionIterator::atEnd)
  • kwq/KWQKHTMLPart.mm: (KWQKHTMLPart::fontForCurrentPosition): Check that the position being checked is an element and that the element is in rendered content. I ran across some null-check failures while I was coding this fix, and the additions seem prudent.

Updated these layout tests with new results.

  • layout-tests/editing/deleting/delete-3608430-fix-expected.txt:
  • layout-tests/editing/deleting/delete-3775172-fix-expected.txt:
  • layout-tests/editing/deleting/delete-block-contents-001-expected.txt:
  • layout-tests/editing/deleting/delete-block-contents-002-expected.txt:
  • layout-tests/editing/deleting/delete-block-contents-003-expected.txt:
  • layout-tests/editing/deleting/delete-image-004-expected.txt:
  • layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
  • layout-tests/editing/editing.js:
  • layout-tests/editing/execCommand/boldSelection-expected.txt:
  • layout-tests/editing/execCommand/italicizeByCharacter-expected.txt:
  • layout-tests/editing/execCommand/modifyForeColorByCharacter-expected.txt:
  • layout-tests/editing/execCommand/print-expected.txt:
  • layout-tests/editing/execCommand/selectAll-expected.txt:
  • layout-tests/editing/selection/extend-by-character-002-expected.txt:
  • layout-tests/editing/selection/extend-by-character-004-expected.txt:
  • layout-tests/editing/selection/extend-by-character-005-expected.txt:
  • layout-tests/editing/selection/extend-by-character-006-expected.txt:
  • layout-tests/editing/selection/select-all-001-expected.txt:
  • layout-tests/editing/selection/select-all-002-expected.txt:
  • layout-tests/editing/selection/select-all-003-expected.txt:
Note: See TracTimeline for information about the timeline view.