⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Timeline



Oct 21, 2004:

6:08 PM Changeset in webkit [7878] by hyatt
  • 2 edits
    2 adds in trunk

Reviewed by darin

Clean up the inline run function so that it doesn't return incorrect answers when making children non-inline.

<rdar://problem/3848724> REGRESSION (166-168u): RenderText::layout called, firing assertion that kills Mail
<rdar://problem/3848357> RenderText::layout called, firing assertion that kills Safari (www.apple.com/downloads/macosx)

  • khtml/rendering/render_block.cpp: (khtml::getInlineRun): (khtml::RenderBlock::makeChildrenNonInline):
5:00 PM Changeset in webkit [7877] by hyatt
  • 2 adds in trunk/LayoutTests/fast/dynamic

Add layout test for dynamic block/inline crash.

4:45 PM Changeset in webkit [7876] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3810389, crash because of continuation() craziness. Revert back to the old behavior of
making sure that all line boxes get deleted and recreated when inlines are split because of a block.

Reviewed darin

  • khtml/rendering/render_inline.cpp: (RenderInline::splitFlow):
2:19 PM Changeset in webkit [7875] by kocienda
  • 27 edits in trunk

Reviewed by Darin

Significant improvement to the way that whitespace is handled during editing.

  • khtml/editing/htmlediting.cpp: (khtml::CompositeEditCommand::deleteInsignificantText): New functions (there are actually two being added with this name) that delete "insignificant" unrendered text. (khtml::CompositeEditCommand::deleteInsignificantTextDownstream): Takes a position, calculates the downstream position to use as the endpoint for the deletion, and then calls deleteInsignificantText with this start and end. (khtml::DeleteSelectionCommand::doApply): Call new deleteInsignificantTextDownstream function. (khtml::InputNewlineCommand::doApply): Ditto. (khtml::InputTextCommand::input): Ditto.
  • khtml/editing/htmlediting.h: Add new declarations.

Modified layout test results:

  • layout-tests/editing/deleting/delete-block-merge-contents-016-expected.txt:
  • layout-tests/editing/deleting/delete-block-merge-contents-017-expected.txt:
  • layout-tests/editing/deleting/delete-contiguous-ws-001-expected.txt:
  • layout-tests/editing/deleting/delete-selection-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-001-expected.txt:
  • layout-tests/editing/deleting/delete-tab-004-expected.txt:
  • layout-tests/editing/deleting/delete-trailing-ws-001-expected.txt:
  • layout-tests/editing/inserting/insert-3659587-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3775316-fix-expected.txt:
  • layout-tests/editing/inserting/insert-3778059-fix-expected.txt:
  • layout-tests/editing/inserting/insert-br-001-expected.txt:
  • layout-tests/editing/inserting/insert-br-004-expected.txt:
  • layout-tests/editing/inserting/insert-br-005-expected.txt:
  • layout-tests/editing/inserting/insert-br-006-expected.txt:
  • layout-tests/editing/inserting/insert-tab-001-expected.txt:
  • layout-tests/editing/inserting/insert-tab-002-expected.txt:
  • layout-tests/editing/inserting/insert-tab-004-expected.txt:
  • layout-tests/editing/inserting/insert-text-with-newlines-expected.txt:
  • layout-tests/editing/inserting/typing-001-expected.txt:
  • layout-tests/editing/inserting/typing-around-br-001-expected.txt:
  • layout-tests/editing/inserting/typing-around-image-001-expected.txt:
  • layout-tests/editing/style/typing-style-003-expected.txt:
  • layout-tests/editing/undo/redo-typing-001-expected.txt:
  • layout-tests/editing/undo/undo-typing-001-expected.txt:
2:12 PM Changeset in webkit [7874] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3847054, assertion failure in RenderText::layout() on news.com page. Fix getInlineRun so that
it no longer breaks early (thus causing some children not to get properly wrapped by anonymous blocks).

Reviewed by darin

  • khtml/rendering/render_block.cpp: (khtml::getInlineRun):
10:04 AM Changeset in webkit [7873] by darin
  • 2 edits in trunk/WebKit

Reviewed by John.

  • fixed <rdar://problem/3847994> REGRESSION: reproducible exception in WebImageRenderer releasePatternColor; afterwards get crash or no more browsing
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage createRendererIfNeeded]): Replaced retainOrCopyIfNeeded with this. This returns nil if a copied renderer isn't needed, and returns a new renderer if a copy is. The old version was sometimes returning a WebInternalImage and other times a WebImageRenderer. (-[WebImageRenderer retainOrCopyIfNeeded]): Returns the result of createRendererIfNeeded or retains self and returns self.

Oct 20, 2004:

5:23 PM Changeset in webkit [7872] by hyatt
  • 16 edits in trunk/LayoutTests/fast

Land updated layout tests with scroll info.

5:20 PM Changeset in webkit [7871] by darin
  • 6 edits in trunk/WebKit

Reviewed by Dave.

  • fixed <rdar://problem/3470715> Pattern cache can get huge with use of css background-image in Safari
  • WebCoreSupport.subproj/WebImageRenderer.h: Change WebImageRenderer to be a subclass of NSObject rather than NSImage and contain a pointer to a WebInternalImage.
  • WebCoreSupport.subproj/WebImageRenderer.m: (-[WebInternalImage releasePatternColor]): Added. Releases patternColor. (-[WebImageRenderer initWithMIMEType:]): Added. Makes WebInternalImage and then self. (-[WebImageRenderer initWithData:MIMEType:]): Ditto. (-[WebImageRenderer initWithContentsOfFile:]): Ditto. (-[WebImageRenderer dealloc]): Added. Calls releasePatternColor and then releases WebInternalImage. (-[WebImageRenderer image]): Added. Returns pointer to image. (-[WebImageRenderer MIMEType]): Added. Calls through to image. (-[WebImageRenderer TIFFRepresentation]): Ditto. (-[WebImageRenderer frameCount]): Ditto. (-[WebImageRenderer setOriginalData:]): Added. Sets image data pointer. (+[WebImageRenderer stopAnimationsInView:]): Added. Calls through to image. (-[WebImageRenderer incrementalLoadWithBytes:length:complete:]): Ditto. (-[WebImageRenderer size]): Ditto. (-[WebImageRenderer resize:]): Ditto. (-[WebImageRenderer drawImageInRect:fromRect:]): Ditto. (-[WebImageRenderer drawImageInRect:fromRect:compositeOperator:context:]): Ditto. (-[WebImageRenderer stopAnimation]): Ditto. (-[WebImageRenderer tileInRect:fromPoint:context:]): Ditto. (-[WebImageRenderer isNull]): Ditto. (-[WebImageRenderer retainOrCopyIfNeeded]): Ditto. (-[WebImageRenderer increaseUseCount]): Ditto. (-[WebImageRenderer decreaseUseCount]): Ditto. (-[WebImageRenderer flushRasterCache]): Ditto. (-[WebImageRenderer imageRef]): Ditto. (-[WebImageRenderer copyWithZone:]): Ditto.
  • Misc.subproj/WebNSViewExtras.m: (-[NSView _web_dragImage:rect:event:pasteboard:source:offset:]): Update for slight changes to WebImageRenderer API.
  • WebCoreSupport.subproj/WebImageRendererFactory.m: (-[WebImageRendererFactory imageRendererWithMIMEType:]): Ditto. (-[WebImageRendererFactory imageRendererWithData:MIMEType:]): Ditto. (-[WebImageRendererFactory imageRendererWithSize:]): Ditto. (-[WebImageRendererFactory imageRendererWithName:]): Ditto.
  • WebView.subproj/WebImageView.m: (-[WebImageView image]): Ditto.
5:20 PM Changeset in webkit [7870] by hyatt
  • 4 edits in trunk/WebCore

Add better dumping of overflow information for scrolling regions.

Fix for 3726524, crash in updateLayerPosition. Make sure anonymous elements properly remove themselves
from the render tree so that layers and so forth are cleaned up.

Reviewed by darin

  • khtml/rendering/render_container.cpp: (RenderContainer::detach):
  • khtml/rendering/render_layer.h: (khtml::RenderLayer::scrollXOffset): (khtml::RenderLayer::scrollYOffset):
  • kwq/KWQRenderTreeDebug.cpp: (write):
2:34 PM Changeset in webkit [7869] by hyatt
  • 3 edits in trunk/WebCore

Fix for 3791146, make sure all lines are checked when computing overflow.

Reviewed by kocienda

  • khtml/rendering/bidi.cpp: (khtml::RenderBlock::computeHorizontalPositionsForLine): (khtml::RenderBlock::layoutInlineChildren): (khtml::RenderBlock::findNextLineBreak): (khtml::RenderBlock::checkLinesForOverflow):
  • khtml/rendering/render_block.h:
2:31 PM Changeset in webkit [7868] by cblu
  • 4 edits in trunk/WebKit

Fixed: <rdar://problem/3846943> REGRESSION: JNLP files are rendered instead of downloaded

Reviewed by john.

  • Plugins.subproj/WebBasePluginPackage.h:
  • Plugins.subproj/WebBasePluginPackage.m: (-[WebBasePluginPackage isJavaPlugIn]): new
  • Plugins.subproj/WebPluginDatabase.m: (-[WebPluginDatabase refresh]): don't register the Java plug-in for a document view since Java file should be downloaded when not embedded.
1:58 PM Changeset in webkit [7867] by hyatt
  • 2 edits in trunk/WebCore

Fix for 3790936, make the unicode-breaking on the layout tests match Panther.

Reviewed by kocienda

  • khtml/rendering/break_lines.cpp: (khtml::isBreakable):
12:01 PM Changeset in webkit [7866] by darin
  • 15 edits
    2 deletes in trunk/WebCore

Reviewed by John.

  • fixed <rdar://problem/3317107> text input fields and text areas don't respect background color and text color CSS properties
  • khtml/rendering/render_form.cpp: (RenderFormElement::updateFromElement): Create a palette with the background and foreground colors in it and set it on the widget.
  • khtml/rendering/render_style.h: (khtml::StyleVisualData::operator==): No palette to compare with APPLE_CHANGES. Removed palette and palette-related function members.
  • khtml/rendering/render_style.cpp: (StyleVisualData::StyleVisualData): No palette to initialize with APPLE_CHANGES. (RenderStyle::diff): No palette to compare.
  • kwq/KWQLineEdit.h: Added setPalette override. Made text function const.
  • kwq/KWQLineEdit.mm: (QLineEdit::setPalette): Added. Sets foreground and background color based on palette. (QLineEdit::text): Made const.
  • kwq/KWQTextEdit.h: Added setPalette override.
  • kwq/KWQTextEdit.mm: (QTextEdit::setPalette): Added. Sets foreground and background color based on palette.
  • kwq/KWQPalette.h: Removed most things, leaving only background and foreground colors per color group, and only a single color group per palette.
  • kwq/KWQColorGroup.mm: Removed.
  • kwq/KWQPalette.mm: Removed.
  • WebCore.pbproj/project.pbxproj: Removed KWQColorGroup.mm and KWQPalette.mm.
  • kwq/KWQApplication.h: Removed unused palette function.
  • kwq/KWQApplication.mm: Ditto.
  • kwq/KWQWidget.h: Removed unsetPalette.
  • kwq/KWQWidget.mm: Ditto.
  • fixed storage leak
  • khtml/html/html_formimpl.cpp: (DOM::HTMLGenericFormElementImpl::~HTMLGenericFormElementImpl): Roll in storage leak fix from KDE guys.
11:21 AM Changeset in webkit [7865] by cblu
  • 5 edits
    1 add in trunk/WebKit

Fixed:
<rdar://problem/3842030> WebKit needs to pass the mode (NP_FULL, NP_EMBED, etc) when calling plugInViewWithArguments
<rdar://problem/3792852> Safari is loading the new QuickTime Cocoa plugin on Panther

Reviewed by darin.

  • Plugins.subproj/WebPluginDocumentView.m: (-[WebPluginDocumentView setDataSource:]): pass "full" as the mode
  • Plugins.subproj/WebPluginPackage.m: (-[WebPluginPackage initWithPath:]): load plug-in with the "webplugin" extension
  • WebCoreSupport.subproj/WebBridge.m: (-[WebBridge pluginViewWithPackage:attributeNames:attributeValues:baseURL:]): pass "embed" as the mode
  • WebKit.pbproj/project.pbxproj:
Note: See TracTimeline for information about the timeline view.