Context Navigation

← Previous Period
Next Period →

Timeline

Oct 22, 2004:

5:19 PM Changeset in webkit [7885] by cblu

2 edits in trunk/WebKit

Fixed: <rdar://problem/3851491> installedPlugins being called for a page without plugins

Reviewed by mjs.

WebView.subproj/WebFrameView.m: (+[WebFrameView _canShowMIMETypeAsHTML:]): call _viewTypesAllowImageTypeOmission instead of using ivar since the ivar is nil until _viewTypesAllowImageTypeOmission is called, this was causing [WebView canShowMIMEType:] to check plug-ins

3:26 PM Changeset in webkit [7884] by kocienda

3 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bug:

<rdar://problem/3844662> REGRESSION (Mail): Style changes can affect adjacent, unselected text

khtml/editing/htmlediting.cpp: (khtml::ApplyStyleCommand::doApply): Move end position downstream to be sure we remove style from everything that could be affected. (khtml::ApplyStyleCommand::removeCSSStyle): Comma in intended function call was outside the braces, making it act as a comma operator, with a zero value as the right value!!! This made an important check always fail!!! It turns out that we do not want the constant at all, since that constant is only needed when checking a computed style, not an inline style as is being done here. (khtml::ApplyStyleCommand::removeStyle): Call nodeFullySelected with new interface. (khtml::ApplyStyleCommand::nodeFullySelected): Change interface and implementation to rely on RangeImpl::compareBoundaryPoints to perform the required check.
khtml/editing/htmlediting.h: Changed nodeFullySelected function interface.

1:07 PM Changeset in webkit [7883] by kocienda

2 edits in trunk/WebCore

Reviewed by Hyatt

Fix for this bugs:

<rdar://problem/3848343> REGRESSION (Mail, 166-168u): Typed text after space at end of line before block quote does not appear
<rdar://problem/3848224> REGRESSION (Mail): space typed at end of line vanishes after typing next character

khtml/rendering/bidi.cpp: (khtml::RenderBlock::findNextLineBreak): When the khtmlLineBreak is in AFTER_WHITE_SPACE mode, as it is when we are editing, add in the space of the current character when calculating the width of committed plus uncommitted characters. If this value exceeds the width of the line, move up the line break object and call skipWhitespace to move past the end of the whitespace.

12:14 PM Changeset in webkit [7882] by vicki